Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217711/?format=api
{ "id": 2217711, "url": "http://patchwork.ozlabs.org/api/patches/2217711/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-12-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330115017.256211-12-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-30T11:50:15", "name": "[PULL,11/12] lsi53c895a: keep SCSIRequest alive during DMA", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69dc8849a7eaaff2aa618f2fa4beb4f4ad3635ba", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-12-pbonzini@redhat.com/mbox/", "series": [ { "id": 498008, "url": "http://patchwork.ozlabs.org/api/series/498008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498008", "date": "2026-03-30T11:50:04", "name": "[PULL,01/12] meson.build: remove i386-softmmu WHPX support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217711/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217711/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KB/VfMbt;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=JUE7o5Sb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkqQK20RFz1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 22:53:29 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7BBG-00061S-0j; Mon, 30 Mar 2026 07:53:20 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8y-0003f8-DR\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:51:03 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8t-0005y7-Mt\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:50:54 -0400", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-479-y289Jhn0Mz-lR5DQiRtV3A-1; Mon, 30 Mar 2026 07:50:49 -0400", "by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-48544725bdeso59210715e9.2\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 04:50:49 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48730688694sm164169325e9.11.2026.03.30.04.50.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 04:50:43 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774871450;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=KB/VfMbtqK6bMrjtJwfH4KpXTuGE4O1K3SnuPN+ABW289q7VLJgVWUhNXybNdj9epy9XnM\n QtN+4z9ZXZOhoNFIJ9OMZ2tDCFY8ER84SvbkdwXmj+endNfUzrQbGNw3cpmNf7tjDf4hw0\n 0tGtPmm7mHZ547pmpwynqjdA6W5q8vM=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774871447; x=1775476247; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=JUE7o5SbsIu0VNykv7x7rUOgOWWLF3LnG+ydd9xFOAtdsXGkro7xxgJr+W/SKjNSL6\n d+EOIf/r5Lsq4UAEzJ+tCF1eJ9s4GO0flNs7jfev5x+hbaoGf63FLuxmBeB89sS3FFy2\n RxmD1laIv5VgXAq5Ndjh7/c/o1NN35x5m0Hkg46PnN0VyG9kQARr9/u1FKpjHKyPNxCp\n fo9vbIxl1a08jpC4DAAaEpYZYKy3CqEAI90j1+e8Rqv9fd4zXYXCDBOv9AqHNzYlaYmj\n D01g8XAjGenUm4cG+EPFZmKI7Tgxr30HJPu2B4wVaF/Afr7817ziUDWWP5F4Ey6+l2op\n KGaQ==" ], "X-MC-Unique": "y289Jhn0Mz-lR5DQiRtV3A-1", "X-Mimecast-MFC-AGG-ID": "y289Jhn0Mz-lR5DQiRtV3A_1774871448", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774871447; x=1775476247;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=GH9FUb/pz+OgWGzH1dj7F+UNoMvhv9kN9wGeOiyDBEo8iV263Ngez8KosMv5hhHvwn\n zVE/4XNekV55/cO3xRv2V2LBz39XZ7cRyTfOb83J10Di4qRQADZtxkWsa1MuLj5d7P55\n zvmwnh4p83oeKMv2dzRaO/Tahqc0LmKWVgMa1EtOOtR0oZMFRCnBnztvPp5tpOYjx8LP\n UfrmGiLRkRCMByIR/GLC6Tu9psfxVKjAqaNnMnWGUrMFv99wgTFjWAL7g2UKRVxUlwZD\n F9DkMW9xGyui0+jhgbkkjn9TNiBaSIS26eerwNy/j3BNRAmoZiwr8EXBsuDg+wGmbggB\n 8UMw==", "X-Gm-Message-State": "AOJu0YxDg+XPxiM543ftOYv5BY8h3D1fcb7tQ42e6AygPB4s7F30+7O2\n W04eBzIvXFp3Kf8jgbVrDQAhzDF/lZXenTrVeOSGefGwt6tQizpJxn2hF/i8m6xLGweBDgACFnZ\n gCZeD/oaebxHZSW3ImltpfI6jYpt8AMWUXXrUKO37GvDFBWtpunebbSiEWJ4Fppn2A3SiPE5VQD\n 7lHCdeGllyRVEZqT9AQgtHN9AAiLN1h/KXKzJF7YIK", "X-Gm-Gg": "ATEYQzyrlPHbmU7bQECfvm1cK+iWPKhH2vHkT7oSZhFlQiArkDNcvI0ORjxXpKu7RwT\n WxZ3iX6xpYb0zF4VpGkYOr3s6ThVk0UdtXzaOHUocmxR5KieW1E5o10CDzlIPPOIv4Sn4j6ooVW\n 4I6f9g/DdqFpBvIdPLT4gBuzomBs55+3rI3wm8m0HOK974xQyEFyFrj9FKI4P+CKX6Gs7gvp8pI\n zj/pRWarOgz584ReyDEkBmeBN3S+zgIhjHDvdEmuKLiqCBWHrZJeP4CXTE+G9Irs3TqZS0xuz5K\n J2zJSzkhLZsI/1Fxsf5Thz6hoM+Amre3fGGAsAiEVEsAfVxfnwWpFBXVMHVH8SA2X6/tkzq+2Ik\n b1zP2YuL/VCv1GT2aSEw3Ir3wL1nIiDDCEh42WKa47a7thJqpFfVJHRpKKyM9K13EWUYiROP5j5\n cFqn17pM3oVErHhOvSBIzcEZ3u", "X-Received": [ "by 2002:a05:600d:8451:b0:485:40db:d40c with SMTP id\n 5b1f17b1804b1-48727d4596dmr178503015e9.3.1774871447242;\n Mon, 30 Mar 2026 04:50:47 -0700 (PDT)", "by 2002:a05:600d:8451:b0:485:40db:d40c with SMTP id\n 5b1f17b1804b1-48727d4596dmr178502605e9.3.1774871446690;\n Mon, 30 Mar 2026 04:50:46 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Jihe Wang <wangjihe.mail@gmail.com>,\n\tqemu-stable@nongnu.org", "Subject": "[PULL 11/12] lsi53c895a: keep SCSIRequest alive during DMA", "Date": "Mon, 30 Mar 2026 13:50:15 +0200", "Message-ID": "<20260330115017.256211-12-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260330115017.256211-1-pbonzini@redhat.com>", "References": "<20260330115017.256211-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-5", "X-Spam_score": "-0.6", "X-Spam_bar": "/", "X-Spam_report": "(-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reentrant MMIO can cause the SCSIRequest to be completed, at which\npoint lsi_request_orphan would drop the last reference. Anything\nthat happens afterwards would access freed data. Keep a reference\nto the SCSIRequest and, through req->hba_private, to the lsi_request*\nfor as long as DMA runs.\n\nReported-by: Jihe Wang <wangjihe.mail@gmail.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex b882fc02276..54123f77579 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -637,7 +637,7 @@ static void lsi_do_dma(LSIState *s, int out)\n }\n \n p = s->current;\n- req = s->current->req;\n+ req = scsi_req_ref(s->current->req);\n dev = req->dev;\n assert(dev);\n \n@@ -667,6 +667,11 @@ static void lsi_do_dma(LSIState *s, int out)\n } else {\n lsi_mem_write(s, addr, p->dma_buf, count);\n }\n+ if (p->orphan) {\n+ scsi_req_unref(req);\n+ return;\n+ }\n+ scsi_req_unref(req);\n \n p->dma_len -= count;\n if (p->dma_len == 0) {\n", "prefixes": [ "PULL", "11/12" ] }