Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217706/?format=api
{ "id": 2217706, "url": "http://patchwork.ozlabs.org/api/patches/2217706/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-10-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330115017.256211-10-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-30T11:50:13", "name": "[PULL,09/12] lsi53c895a: keep lsi_request and SCSIRequest in local variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9e3af0200e840c8717e342fd9adb731488d268cc", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-10-pbonzini@redhat.com/mbox/", "series": [ { "id": 498008, "url": "http://patchwork.ozlabs.org/api/series/498008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498008", "date": "2026-03-30T11:50:04", "name": "[PULL,01/12] meson.build: remove i386-softmmu WHPX support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217706/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217706/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JYPCpkLe;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=EEDH5fnY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkqNm50n6z1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 22:52:08 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7B9w-0004co-2G; Mon, 30 Mar 2026 07:51:57 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8u-0003bo-JW\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:50:59 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8s-0005xa-6j\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:50:52 -0400", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-458-1hVFE3iAMeSmJYX0LXq6FQ-1; Mon, 30 Mar 2026 07:50:44 -0400", "by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-4836abfc742so38080855e9.0\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 04:50:44 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21e265fsm19206909f8f.1.2026.03.30.04.50.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 04:50:40 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774871445;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=JYPCpkLeDJ9w/M0NuivMnP5f3F5pD+fHTA1GrbIxIeelUoATeSiZmrLk2my4Kadmxv+AxO\n f2sfA/0gpI8XXiFv6P8zX/s8LQwFhBpNzINmUutUudCar3UAHCeLetZ+l7VKY8tuWtFFyJ\n +uXsIVEqxfWCgiqpY2ulpc6VPHoeXLs=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774871442; x=1775476242; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=EEDH5fnYG5aH41Ge5O8sjrkQVjXP7aM32BI04hBX2vfEUJAo2ueE2Ii217XDK3X/p/\n Eb4t3AIUAYNvvQ8oA71O4l6U7GZq+s4kvD3uEV7XgrUQV7+SMSW7EWHh0lBCM9Am7AVy\n 163N9tD8ZSjaUUaojMQIjkJJuBZ4FD9sQMOTQ8JLZDETq2kJcfBsWnIBKGoCywXf7mwx\n DOCpUVT60RZM2Sl9saISGYtO8PjTT8H4/bKYpbUxM6WNe09R/VVxtMo6yDLH4/b0SUeP\n Etp9o+yZrFUaXm9vCN/zc/6pkOHq/x8YB56NTFgRQviHGc0rqlAlHFbIkIfZbY3Pysh/\n GCfw==" ], "X-MC-Unique": "1hVFE3iAMeSmJYX0LXq6FQ-1", "X-Mimecast-MFC-AGG-ID": "1hVFE3iAMeSmJYX0LXq6FQ_1774871443", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774871442; x=1775476242;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=nhc9xAEUvL0xlwKx25LnS3r/1t6QKyHIseofrWEVoeoy6yeMUbNgBEKgaSMfb02gPM\n 6uuZsWzAbaNLk31tqQTF5D8Q/v309mQrhhNkq1mc9lp6aiUrx5XoCbMCJ/nI2uqdHCk5\n b7B6rkVr9nQhYP7XwA2oRag4xUhsRTjgj6AXYXfMm/uEYmIlt/v8WC6tPGVB3bDoEysf\n 8xM1SJ5aWMbZPCnI7+VQQUpDg6giptvRJlpkVAmNxmnUKA5A320ea2EkT/OiFjWoNg3k\n YrRD2RXcSfCxR5jpapAfNntJ8v63Na0YrgKvrooY9oudoV8HJ/sHb36qzOnrwAcjJo01\n CCKA==", "X-Gm-Message-State": "AOJu0Yws9VJEXhuQmHA8ykWxJMkaAeDCmgDxLGyZcZNAf0UUsD/5+TjT\n gs28h0P/XDTStuiK89zLtepDnMT+gVCovF4bZdSbpDEN1rvMVjiE2z55BGp4XDL/e6Q6+zvtoJC\n TyDJu8xjxtod2K7gzy22QHcLOflxhutlGuAaxkv6Mq3vL7Pu3i+hJuMJYl/Tt1ufhlwDAwoFeNo\n QIZ3MGDfJc+YRW33pA6MV+ts1SPvg9vE1iPdw6DWnL", "X-Gm-Gg": "ATEYQzxQzMHfR4M2fOTUE/4Ln4VEmwGwpJzO9+M080OJVUhHCmJ5TDvK4/DZe/Lf1w1\n kEotOvGz4D1w/xIE2VzMPsQ6WozPbzipNkVg1P0QCbmilXisDHQiL8/rPdijZbQFlL1pF2qgc7O\n HDAPLUpfHG+BwqPqHGgWD4gCP3wrim0w50138Tf5XcEVjNNFU9et/t8jvTeUG4K+zr/RMkMmO2r\n MuCX/CPPfZv07NSPVJIqoGg/A8wPOigJCoIlI4hDSJvLNcfcz7IcrV1Hc3JzyY73N5+8yc4ML0G\n LVk0zH5Y38ePsFYSf5TM7c1WSd390KrZc1KH199aFb28aNw5Mr46X1PszhVOEr1tPCk/PVj4YYb\n TUkCV8wDydT12u19YPxsu0q84qEk2lTBKrP1pD3Kqy4BYv+0FiZFqZdu7I5gQaHLaXYGu7GqqNV\n fzpPyEDkoKDQEeauLSUhCJpubm", "X-Received": [ "by 2002:a05:600c:a012:b0:480:6bef:63a0 with SMTP id\n 5b1f17b1804b1-48727ede8d3mr216732995e9.21.1774871442425;\n Mon, 30 Mar 2026 04:50:42 -0700 (PDT)", "by 2002:a05:600c:a012:b0:480:6bef:63a0 with SMTP id\n 5b1f17b1804b1-48727ede8d3mr216732415e9.21.1774871441797;\n Mon, 30 Mar 2026 04:50:41 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org", "Subject": "[PULL 09/12] lsi53c895a: keep lsi_request and SCSIRequest in local\n variables", "Date": "Mon, 30 Mar 2026 13:50:13 +0200", "Message-ID": "<20260330115017.256211-10-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260330115017.256211-1-pbonzini@redhat.com>", "References": "<20260330115017.256211-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Protect against changes from reentrant device MMIO during DMA, by always\noperating on the same request.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 29 +++++++++++++++++------------\n 1 file changed, 17 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 81b4f93f4d3..1180e601811 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -626,6 +626,8 @@ static void lsi_do_dma(LSIState *s, int out)\n uint32_t count;\n dma_addr_t addr;\n SCSIDevice *dev;\n+ SCSIRequest *req;\n+ lsi_request *p;\n \n if (!s->current || !s->current->dma_len) {\n /* Wait until data is available. */\n@@ -633,12 +635,14 @@ static void lsi_do_dma(LSIState *s, int out)\n return;\n }\n \n- dev = s->current->req->dev;\n+ p = s->current;\n+ req = s->current->req;\n+ dev = req->dev;\n assert(dev);\n \n count = s->dbc;\n- if (count > s->current->dma_len)\n- count = s->current->dma_len;\n+ if (count > p->dma_len)\n+ count = p->dma_len;\n \n addr = s->dnad;\n /* both 40 and Table Indirect 64-bit DMAs store upper bits in dnad64 */\n@@ -653,21 +657,22 @@ static void lsi_do_dma(LSIState *s, int out)\n s->csbc += count;\n s->dnad += count;\n s->dbc -= count;\n- if (s->current->dma_buf == NULL) {\n- s->current->dma_buf = scsi_req_get_buf(s->current->req);\n+ if (p->dma_buf == NULL) {\n+ p->dma_buf = scsi_req_get_buf(req);\n }\n /* ??? Set SFBR to first data byte. */\n if (out) {\n- lsi_mem_read(s, addr, s->current->dma_buf, count);\n+ lsi_mem_read(s, addr, p->dma_buf, count);\n } else {\n- lsi_mem_write(s, addr, s->current->dma_buf, count);\n+ lsi_mem_write(s, addr, p->dma_buf, count);\n }\n- s->current->dma_len -= count;\n- if (s->current->dma_len == 0) {\n- s->current->dma_buf = NULL;\n- scsi_req_continue(s->current->req);\n+\n+ p->dma_len -= count;\n+ if (p->dma_len == 0) {\n+ p->dma_buf = NULL;\n+ scsi_req_continue(req);\n } else {\n- s->current->dma_buf += count;\n+ p->dma_buf += count;\n lsi_resume_script(s);\n }\n }\n", "prefixes": [ "PULL", "09/12" ] }