Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217705/?format=api
{ "id": 2217705, "url": "http://patchwork.ozlabs.org/api/patches/2217705/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-11-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330115017.256211-11-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-30T11:50:14", "name": "[PULL,10/12] lsi53c895a: keep lsi_request alive as long as the SCSIRequest", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b0a3b33a47fa66d600d2b61d2cd425e52edb8a6a", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330115017.256211-11-pbonzini@redhat.com/mbox/", "series": [ { "id": 498008, "url": "http://patchwork.ozlabs.org/api/series/498008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498008", "date": "2026-03-30T11:50:04", "name": "[PULL,01/12] meson.build: remove i386-softmmu WHPX support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217705/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EobMz3zA;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=gWmUOgHj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkqNk07psz1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 22:52:06 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7B9q-0004Mg-4d; Mon, 30 Mar 2026 07:51:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8u-0003cB-UV\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:50:59 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7B8s-0005xq-9J\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:50:52 -0400", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-180-2Yyro-DEMH62zTrvbSU3tg-1; Mon, 30 Mar 2026 07:50:46 -0400", "by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-486fe36cf73so33475335e9.1\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 04:50:46 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf245f8a3sm19825485f8f.24.2026.03.30.04.50.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 04:50:42 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774871447;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=EobMz3zA7YsWNdOHQEbQB2W6YV7WXJJkOBVg4fFWthf4+Tp3g7Ozw5P5TYiifziCriLSS0\n 1U0C+uKuFd1CYcgVPkJ3t2rEETexUFV0uzM5riz/+SUthmdNqW2POw5yurgDelKFDF2wVf\n SKCQNKjIpTV74kyLtx1UMskf8LpU92w=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774871444; x=1775476244; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=gWmUOgHjM14MC8DTKb8VQiePPfvpfsVI5zUrLMdA2rbn8qSo63zBppINEOqtB6WhDB\n j3R8MoG5ZyGRrjO6PujNkXSxvI9shO2j6CxBB4cDqWjKeZiSYXekYOU2fLGmzXpHVrj8\n iN225LsmAdoPN8CTplsB4HZ0DYG2g6ZjFLZOQLxKVw7Y3r+w1R0KW5L7Wa78pStHLQQ6\n dZccv2Yx4sDymNFlI4i2uErbVn3GuUwXnK2GE4TvstLPwWntlWnoXB0ZX3uC7Jolusr2\n ssQgZjQhnHtbnfSPhBOQ5Wjso6jVQnuLerqFWB+VgwpUJL3wI956SoY0gx7HAA9ceozE\n 7HnQ==" ], "X-MC-Unique": "2Yyro-DEMH62zTrvbSU3tg-1", "X-Mimecast-MFC-AGG-ID": "2Yyro-DEMH62zTrvbSU3tg_1774871445", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774871444; x=1775476244;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=JbKfltReGeX0wfH8mt7Qpv+P4qHotBaJ/Cw7CHcvtl2SZF4N8cKoC5LlyZQoix22MN\n j/IlVrQzjPjIzGy3fnNV6yXioMfemOtyrwPqqr8j2vMBfws93Zp1Oc6DzSlT5j4B5xMa\n SF5C8s6Zk97x7OxWc5uWc87Q0vCKeFezyWxo6FBhB+oHgxjnUSDmj30dQoUEWb1hHukc\n SYPnCNftgoIzfFi3Xqj6B25K7+SvuKuuP8gQARhTZIY3Rmj6VGitAJDfD1ZVLVF7Qv0e\n ViEDJytQYxkrhJu/9okjAb4z21Z3Eq2ypZMX065GYhkQ1npTanY0VnMrwkP560FHWCu1\n Ht/w==", "X-Gm-Message-State": "AOJu0Yz+LXSZVNH9fmrZE4hYuMDo2F7ZSB4W3D0472wpMdarafOYOCAX\n GWeCUDs4fry3ZCcr0kS2wtSVZSnAzBOQYAUmgJrNpr1SvhPSOkt71yAFCfTwBCUATXA18QxukZn\n 4qykGM9B5aGrlMLgE+YIAqrxoLrU2RJ4Gwu7datA7L+3V91umJ/1cb7bMm+vL3zEFUmLOdi+2Sc\n 8mnILekGQXDkHCrlUomvzzgtqIFPwSEyE5WGYyOEsF", "X-Gm-Gg": "ATEYQzzbib8TSW1Wu6RWdewTqn9g8Kmh49NkHMKcJ8gkzU6wbLyTSzzYSkNpzTdGFxo\n TSCRlUZzFP1ZTcG9dGYIbvUjP2F3zkqQofx3ZOR8O1SQ2aqdxQubvzkhB3q0lLMJfFsqi2ojarY\n nTReEzKe6DzMwx9QRYnMCK/5CibUtCjFhvp6uiQM5oYhby0n6NwwkOGIZu+Y56qBkRgblluhDx0\n yX1+N4+MhhHUPRz5UqqfOZM1+bJgLQTpnoWqO0zs3r6QxnOJh4ikX1DNz8uSxLdXXXgoZvTuKQy\n dEcgoN0tyHcyXYHJrB9B76OEXrq8Gn635DgNtMKQQAHuAiL+QixDbfV4jmwUbTdhcwAzekJEclV\n ndFkHJzq767jr0TuYJ7C1gZbsBiPOJRrnnZ27Cyg5pWfP27/IID85QHE2RhTQgnpNYrPfBMIHrN\n XW6SXIHEIby5Tlvl4uzMJE6iPT", "X-Received": [ "by 2002:a05:600c:4744:b0:485:4278:2558 with SMTP id\n 5b1f17b1804b1-48727d5a313mr204229935e9.6.1774871443577;\n Mon, 30 Mar 2026 04:50:43 -0700 (PDT)", "by 2002:a05:600c:4744:b0:485:4278:2558 with SMTP id\n 5b1f17b1804b1-48727d5a313mr204229495e9.6.1774871443075;\n Mon, 30 Mar 2026 04:50:43 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org", "Subject": "[PULL 10/12] lsi53c895a: keep lsi_request alive as long as the\n SCSIRequest", "Date": "Mon, 30 Mar 2026 13:50:14 +0200", "Message-ID": "<20260330115017.256211-11-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260330115017.256211-1-pbonzini@redhat.com>", "References": "<20260330115017.256211-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "To protect against using the lsi_request after SCSIRequest has been freed,\nkeep the HBA-private data alive until the last reference to the SCSIRequest\nis gone. Because req->hba_private was used (even if just for an assertion)\nto check that the request was still either current or queued, add a boolean\nfield that is set when the SCSIRequest is cancelled or completed, which\nis when the lsi_request would have been unqueued.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 27 ++++++++++++++++-----------\n 1 file changed, 16 insertions(+), 11 deletions(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 1180e601811..b882fc02276 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -197,6 +197,7 @@ typedef struct lsi_request {\n uint8_t *dma_buf;\n uint32_t pending;\n int out;\n+ bool orphan;\n QTAILQ_ENTRY(lsi_request) next;\n } lsi_request;\n \n@@ -748,14 +749,20 @@ static lsi_request *lsi_find_by_tag(LSIState *s, uint32_t tag)\n return NULL;\n }\n \n-static void lsi_request_free(LSIState *s, lsi_request *p)\n+static void lsi_request_orphan(LSIState *s, lsi_request *p)\n {\n+ p->orphan = true;\n if (p == s->current) {\n s->current = NULL;\n } else {\n QTAILQ_REMOVE(&s->queue, p, next);\n }\n- g_free(p);\n+ scsi_req_unref(p->req);\n+}\n+\n+static void lsi_free_request(SCSIBus *bus, void *priv)\n+{\n+ g_free(priv);\n }\n \n static void lsi_request_cancelled(SCSIRequest *req)\n@@ -763,9 +770,7 @@ static void lsi_request_cancelled(SCSIRequest *req)\n LSIState *s = LSI53C895A(req->bus->qbus.parent);\n lsi_request *p = req->hba_private;\n \n- req->hba_private = NULL;\n- lsi_request_free(s, p);\n- scsi_req_unref(req);\n+ lsi_request_orphan(s, p);\n }\n \n /* Record that data is available for a queued command. Returns zero if\n@@ -817,9 +822,7 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n }\n \n if (req->hba_private == s->current) {\n- req->hba_private = NULL;\n- lsi_request_free(s, s->current);\n- scsi_req_unref(req);\n+ lsi_request_orphan(s, s->current);\n }\n if (!stop) {\n lsi_resume_script(s);\n@@ -830,10 +833,11 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n static void lsi_transfer_data(SCSIRequest *req, uint32_t len)\n {\n LSIState *s = LSI53C895A(req->bus->qbus.parent);\n+ lsi_request *p = req->hba_private;\n int out;\n \n- assert(req->hba_private);\n- if (s->waiting == LSI_WAIT_RESELECT || req->hba_private != s->current ||\n+ assert(!p->orphan);\n+ if (s->waiting == LSI_WAIT_RESELECT || p != s->current ||\n (lsi_irq_on_rsl(s) && !(s->scntl1 & LSI_SCNTL1_CON))) {\n if (lsi_queue_req(s, req, len)) {\n return;\n@@ -2325,7 +2329,8 @@ static const struct SCSIBusInfo lsi_scsi_info = {\n \n .transfer_data = lsi_transfer_data,\n .complete = lsi_command_complete,\n- .cancel = lsi_request_cancelled\n+ .cancel = lsi_request_cancelled,\n+ .free_request = lsi_free_request,\n };\n \n static void scripts_timer_cb(void *opaque)\n", "prefixes": [ "PULL", "10/12" ] }