Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217679/?format=api
{ "id": 2217679, "url": "http://patchwork.ozlabs.org/api/patches/2217679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330113241epcms2p61c09e78855ad9c7b0fa9d9e3a183e98a@epcms2p6/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330113241epcms2p61c09e78855ad9c7b0fa9d9e3a183e98a@epcms2p6>", "list_archive_url": null, "date": "2026-03-30T11:32:41", "name": "[3/5] hw/ufs: Add IDLE operation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8f517268d5654eef8da53573414ad337634b92e6", "submitter": { "id": 93006, "url": "http://patchwork.ozlabs.org/api/people/93006/?format=api", "name": "Jaemyung Lee", "email": "jaemyung.lee@samsung.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330113241epcms2p61c09e78855ad9c7b0fa9d9e3a183e98a@epcms2p6/mbox/", "series": [ { "id": 497999, "url": "http://patchwork.ozlabs.org/api/series/497999/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497999", "date": "2026-03-30T11:29:39", "name": "[1/5] hw/ufs: Apply UFS 4.1 Specification", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497999/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217679/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256\n header.s=mail20170921 header.b=XObh5Yph;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkpzJ17YWz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 22:33:32 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Arf-0000NR-NM; Mon, 30 Mar 2026 07:33:03 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7ArR-0000My-0G\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:32:51 -0400", "from mailout1.samsung.com ([203.254.224.24])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7ArO-0001Jw-Ie\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:32:48 -0400", "from epcas2p2.samsung.com (unknown [182.195.41.54])\n by mailout1.samsung.com (KnoxPortal) with ESMTP id\n 20260330113242epoutp01ed9714af6143ff317b46e5f0479ee23e~hmzDbqfwV0365303653epoutp01S\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 11:32:42 +0000 (GMT)", "from epsnrtp01.localdomain (unknown [182.195.42.153]) by\n epcas2p1.samsung.com (KnoxPortal) with ESMTPS id\n 20260330113241epcas2p101fd0087e8444aeb7488f5f48de74f09~hmzDEX3cE2147921479epcas2p1g;\n Mon, 30 Mar 2026 11:32:41 +0000 (GMT)", "from epcas2p1.samsung.com (unknown [182.195.38.206]) by\n epsnrtp01.localdomain (Postfix) with ESMTP id 4fkpyK4MGBz6B9m4; Mon, 30 Mar\n 2026 11:32:41 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.samsung.com\n 20260330113242epoutp01ed9714af6143ff317b46e5f0479ee23e~hmzDbqfwV0365303653epoutp01S", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1774870362;\n bh=/o3FlU03Oe6rl5Dj39HCVuOrtTZRLzXEPhkcD0TGGcI=;\n h=Subject:Reply-To:From:To:CC:Date:References:From;\n b=XObh5Yph0HzFh8NY8rjsOqKQZbjDq41pWE3LSr48lCDr1+BbGUwIzDv3HYxiW6MXG\n G0Nn5W43QUC6Kj7kxbdryEc0wTVTKnR9zy25eXkSN7oJKIWRFbxC+YrhYz2ASVTAsU\n JIUwzP1x468iKmrbbwG1V8qFlCRBDbzf6sV/pDPM=", "Mime-Version": "1.0", "Subject": "[PATCH 3/5] hw/ufs: Add IDLE operation", "From": "Jaemyung Lee <jaemyung.lee@samsung.com>", "To": "\"qemu-devel@nongnu.org\" <qemu-devel@nongnu.org>", "CC": "Jeuk Kim <jeuk20.kim@samsung.com>, \"kwolf@redhat.com\"\n <kwolf@redhat.com>, \"hreitz@redhat.com\" <hreitz@redhat.com>,\n \"qemu-block@nongnu.org\" <qemu-block@nongnu.org>, \"farosas@suse.de\"\n <farosas@suse.de>, \"lvivier@redhat.com\" <lvivier@redhat.com>,\n \"pbonzini@redhat.com\" <pbonzini@redhat.com>", "X-Priority": "3", "X-Content-Kind-Code": "NORMAL", "X-CPGS-Detection": "blocking_info_exchange", "X-Drm-Type": "N,general", "X-Msg-Generator": "Mail", "X-Msg-Type": "PERSONAL", "X-Reply-Demand": "N", "Message-ID": "<20260330113241epcms2p61c09e78855ad9c7b0fa9d9e3a183e98a@epcms2p6>", "Date": "Mon, 30 Mar 2026 20:32:41 +0900", "X-CMS-MailID": "20260330113241epcms2p61c09e78855ad9c7b0fa9d9e3a183e98a", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=\"utf-8\"", "X-Sendblock-Type": "AUTO_CONFIDENTIAL", "CMS-TYPE": "102P", "cpgsPolicy": "CPGSC10-223,Y", "X-CFilter-Loop": "Reflected", "X-CMS-RootMailID": "20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502", "References": "\n <CGME20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502@epcms2p6>", "Received-SPF": "pass client-ip=203.254.224.24;\n envelope-from=jaemyung.lee@samsung.com; helo=mailout1.samsung.com", "X-Spam_score_int": "-13", "X-Spam_score": "-1.4", "X-Spam_bar": "-", "X-Spam_report": "(-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-To": "jaemyung.lee@samsung.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add timer-based idle behaviour to UFS Device.\n\nWhen no I/O occurs, the UFS Device performs various internal operations.\nTo emulate this, adds a timer that periodically checks the current I/O\nstatus of the device and call the ufs_process_idle() function when idle.\n\nSigned-off-by: Jaemyung Lee <jameyung.lee@samsung.com>\n---\n hw/ufs/ufs.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++\n hw/ufs/ufs.h | 3 +++\n 2 files changed, 49 insertions(+)\n\n--\n2.34.1", "diff": "diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c\nindex 69f82ab462..19438c89e1 100644\n--- a/hw/ufs/ufs.c\n+++ b/hw/ufs/ufs.c\n@@ -1801,6 +1801,46 @@ static void ufs_sendback_req(void *opaque)\n ufs_irq_check(u);\n }\n\n+/* IDLE */\n+static void ufs_process_idle(UfsHc *u)\n+{\n+ /* Currently do nothing */\n+ return;\n+}\n+\n+static inline bool ufs_check_idle(UfsHc *u)\n+{\n+ return !u->reg.utrldbr;\n+}\n+\n+static inline bool ufs_mcq_check_idle(UfsHc *u)\n+{\n+ for (int i = 0; i < ARRAY_SIZE(u->sq); i++) {\n+ if (!ufs_mcq_sq_empty(u, i)) {\n+ return false;\n+ }\n+ }\n+\n+ for (int i = 0; i < ARRAY_SIZE(u->cq); i++) {\n+ if (!ufs_mcq_cq_empty(u, i)) {\n+ return false;\n+ }\n+ }\n+\n+ return true;\n+}\n+\n+#define UFS_IDLE_TIMER_TICK 100 /* 0.1s */\n+static void ufs_idle_timer_cb(void *opaque)\n+{\n+ UfsHc *u = opaque;\n+ int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL);\n+\n+ if (ufs_check_idle(u) && ufs_mcq_check_idle(u)) {\n+ ufs_process_idle(u);\n+ }\n+\n+ timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n+}\n+\n static bool ufs_check_constraints(UfsHc *u, Error **errp)\n {\n if (u->params.nutrs > UFS_MAX_NUTRS) {\n@@ -1863,6 +1903,7 @@ static void ufs_init_hc(UfsHc *u)\n uint32_t cap = 0;\n uint32_t mcqconfig = 0;\n uint32_t mcqcap = 0;\n+ int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL);\n\n u->reg_size = pow2ceil(ufs_reg_size(u));\n\n@@ -1959,6 +2000,9 @@ static void ufs_init_hc(UfsHc *u)\n * dynamically\n */\n u->temperature = UFS_TEMPERATURE;\n+\n+ timer_init_ms(&u->idle_timer, QEMU_CLOCK_VIRTUAL, ufs_idle_timer_cb, u);\n+ timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n }\n\n static void ufs_realize(PCIDevice *pci_dev, Error **errp)\n@@ -1986,6 +2030,8 @@ static void ufs_exit(PCIDevice *pci_dev)\n {\n UfsHc *u = UFS(pci_dev);\n\n+ timer_del(&u->idle_timer);\n+\n qemu_free_irq(u->irq);\n\n qemu_bh_delete(u->doorbell_bh);\ndiff --git a/hw/ufs/ufs.h b/hw/ufs/ufs.h\nindex 13d964c5ae..f0b1f8b0e0 100644\n--- a/hw/ufs/ufs.h\n+++ b/hw/ufs/ufs.h\n@@ -148,6 +148,9 @@ typedef struct UfsHc {\n UfsCq *cq[UFS_MAX_MCQ_QNUM];\n\n uint8_t temperature;\n+\n+ /* IDLE timer */\n+ QEMUTimer idle_timer;\n } UfsHc;\n\n static inline uint32_t ufs_mcq_sq_tail(UfsHc *u, uint32_t qid)\n", "prefixes": [ "3/5" ] }