Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217678/?format=api
{ "id": 2217678, "url": "http://patchwork.ozlabs.org/api/patches/2217678/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330113051epcms2p46cc074d17d10d409ad3db28febcaba14@epcms2p4/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330113051epcms2p46cc074d17d10d409ad3db28febcaba14@epcms2p4>", "list_archive_url": null, "date": "2026-03-30T11:30:51", "name": "[2/5] hw/ufs: Modify flag handling operation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a4ba62e1f3e445dd87be041c6e4404edf2fc4ab2", "submitter": { "id": 93006, "url": "http://patchwork.ozlabs.org/api/people/93006/?format=api", "name": "Jaemyung Lee", "email": "jaemyung.lee@samsung.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330113051epcms2p46cc074d17d10d409ad3db28febcaba14@epcms2p4/mbox/", "series": [ { "id": 497999, "url": "http://patchwork.ozlabs.org/api/series/497999/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497999", "date": "2026-03-30T11:29:39", "name": "[1/5] hw/ufs: Apply UFS 4.1 Specification", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497999/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217678/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256\n header.s=mail20170921 header.b=feYV7Wpc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkpxF6FRGz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 22:31:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7AqD-0007sz-3l; Mon, 30 Mar 2026 07:31:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7Apf-0007lX-9t\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:31:03 -0400", "from mailout2.samsung.com ([203.254.224.25])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7Apb-0000vx-5A\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:30:59 -0400", "from epcas2p4.samsung.com (unknown [182.195.41.56])\n by mailout2.samsung.com (KnoxPortal) with ESMTP id\n 20260330113052epoutp02bab6322a5118b3e264d77d9d35c7e1e1~hmxdKgiXS1041310413epoutp02E\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 11:30:52 +0000 (GMT)", "from epsnrtp01.localdomain (unknown [182.195.42.153]) by\n epcas2p3.samsung.com (KnoxPortal) with ESMTPS id\n 20260330113052epcas2p35205136150f457f9afe14ece30cef906~hmxc0egla2814528145epcas2p3P;\n Mon, 30 Mar 2026 11:30:52 +0000 (GMT)", "from epcas2p3.samsung.com (unknown [182.195.38.200]) by\n epsnrtp01.localdomain (Postfix) with ESMTP id 4fkpwC6bGCz6B9m5; Mon, 30 Mar\n 2026 11:30:51 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.samsung.com\n 20260330113052epoutp02bab6322a5118b3e264d77d9d35c7e1e1~hmxdKgiXS1041310413epoutp02E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1774870252;\n bh=72Hnbyab5rIiIqGMNPKIVQTGjFEj6k3mMkhnuqTB+SI=;\n h=Subject:Reply-To:From:To:CC:Date:References:From;\n b=feYV7Wpcuj1BBFPm2bmENy9HqY27/jZdFgjH6VLYcbEQEmyDMgbhGDm8Dcn7xUMAk\n eo9mTIdH2HL1dQ/6I/SO7oNqoo4jzYYG05tM+YaSqTwjT3jYTaG2KISTqo7Z9+kmpm\n gH3MGiIekZqjv2CUPLWqHkuGSg1RWyoSdNkzfI/c=", "Mime-Version": "1.0", "Subject": "[PATCH 2/5] hw/ufs: Modify flag handling operation", "From": "Jaemyung Lee <jaemyung.lee@samsung.com>", "To": "\"qemu-devel@nongnu.org\" <qemu-devel@nongnu.org>", "CC": "Jeuk Kim <jeuk20.kim@samsung.com>, \"kwolf@redhat.com\"\n <kwolf@redhat.com>, \"hreitz@redhat.com\" <hreitz@redhat.com>,\n \"qemu-block@nongnu.org\" <qemu-block@nongnu.org>, \"farosas@suse.de\"\n <farosas@suse.de>, \"lvivier@redhat.com\" <lvivier@redhat.com>,\n \"pbonzini@redhat.com\" <pbonzini@redhat.com>", "X-Priority": "3", "X-Content-Kind-Code": "NORMAL", "X-CPGS-Detection": "blocking_info_exchange", "X-Drm-Type": "N,general", "X-Msg-Generator": "Mail", "X-Msg-Type": "PERSONAL", "X-Reply-Demand": "N", "Message-ID": "<20260330113051epcms2p46cc074d17d10d409ad3db28febcaba14@epcms2p4>", "Date": "Mon, 30 Mar 2026 20:30:51 +0900", "X-CMS-MailID": "20260330113051epcms2p46cc074d17d10d409ad3db28febcaba14", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=\"utf-8\"", "X-Sendblock-Type": "AUTO_CONFIDENTIAL", "CMS-TYPE": "102P", "cpgsPolicy": "CPGSC10-223,Y", "X-CFilter-Loop": "Reflected", "X-CMS-RootMailID": "20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502", "References": "\n <CGME20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502@epcms2p4>", "Received-SPF": "pass client-ip=203.254.224.25;\n envelope-from=jaemyung.lee@samsung.com; helo=mailout2.samsung.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-To": "jaemyung.lee@samsung.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Change internal flag handling operation same as attribute's\n\nIn UFS device, some flag queries directly trigger specific device\nbehaviour like attribute's, not only changes the internal values.\nSo restructure flag query processing functions same as attribute\nprocessing, to facilitate linking detailed implementations based on\nindividual flag value changes.\n\nSigned-off-by: Jaemyung Lee <jameyung.lee@samsung.com>\n---\n hw/ufs/ufs.c | 152 ++++++++++++++++++++++++++++++++++++++++-----------\n 1 file changed, 119 insertions(+), 33 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c\nindex b2b70c8b38..69f82ab462 100644\n--- a/hw/ufs/ufs.c\n+++ b/hw/ufs/ufs.c\n@@ -1021,6 +1021,122 @@ static inline QueryRespCode ufs_flag_check_idn_valid(uint8_t idn, int op)\n return UFS_QUERY_RESULT_SUCCESS;\n }\n\n+static uint32_t ufs_read_flag_value(UfsHc *u, uint8_t idn)\n+{\n+ switch (idn) {\n+ case UFS_QUERY_FLAG_IDN_FDEVICEINIT:\n+ return u->flags.device_init;\n+ case UFS_QUERY_FLAG_IDN_PERMANENT_WPE:\n+ return u->flags.permanent_wp_en;\n+ case UFS_QUERY_FLAG_IDN_PWR_ON_WPE:\n+ return u->flags.power_on_wp_en;\n+ case UFS_QUERY_FLAG_IDN_BKOPS_EN:\n+ return u->flags.background_ops_en;\n+ case UFS_QUERY_FLAG_IDN_LIFE_SPAN_MODE_ENABLE:\n+ return u->flags.device_life_span_mode_en;\n+ case UFS_QUERY_FLAG_IDN_PURGE_ENABLE:\n+ return u->flags.purge_enable;\n+ case UFS_QUERY_FLAG_IDN_REFRESH_ENABLE:\n+ return u->flags.refresh_enable;\n+ case UFS_QUERY_FLAG_IDN_FPHYRESOURCEREMOVAL:\n+ return u->flags.phy_resource_removal;\n+ case UFS_QUERY_FLAG_IDN_BUSY_RTC:\n+ return u->flags.busy_rtc;\n+ case UFS_QUERY_FLAG_IDN_PERMANENTLY_DISABLE_FW_UPDATE:\n+ return u->flags.permanently_disable_fw_update;\n+ case UFS_QUERY_FLAG_IDN_WB_EN:\n+ return u->flags.wb_en;\n+ case UFS_QUERY_FLAG_IDN_WB_BUFF_FLUSH_EN:\n+ return u->flags.wb_buffer_flush_en;\n+ case UFS_QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8:\n+ return u->flags.wb_buffer_flush_during_hibernate;\n+ case UFS_QUERY_FLAG_IDN_UNPIN_EN:\n+ return u->flags.unpin_en;\n+ default:\n+ g_assert_not_reached();\n+ return 0;\n+ }\n+}\n+\n+static QueryRespCode ufs_write_flag_value(UfsHc *u, uint8_t idn, uint8_t value)\n+{\n+ switch (idn) {\n+ case UFS_QUERY_FLAG_IDN_FDEVICEINIT:\n+ u->flags.device_init = 0;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_PERMANENT_WPE:\n+ u->flags.permanent_wp_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_PWR_ON_WPE:\n+ u->flags.power_on_wp_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_BKOPS_EN:\n+ u->flags.background_ops_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_LIFE_SPAN_MODE_ENABLE:\n+ u->flags.device_life_span_mode_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_PURGE_ENABLE:\n+ u->flags.purge_enable = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_REFRESH_ENABLE:\n+ u->flags.refresh_enable = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_FPHYRESOURCEREMOVAL:\n+ u->flags.phy_resource_removal = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_PERMANENTLY_DISABLE_FW_UPDATE:\n+ u->flags.permanently_disable_fw_update = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_WB_EN:\n+ u->flags.wb_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_WB_BUFF_FLUSH_EN:\n+ u->flags.wb_buffer_flush_en = value;\n+ break;\n+ case UFS_QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8:\n+ u->flags.wb_buffer_flush_during_hibernate = value;\n+ break;\n+ default:\n+ return UFS_QUERY_RESULT_INVALID_VALUE;\n+ }\n+\n+ return UFS_QUERY_RESULT_SUCCESS;\n+}\n+\n+static QueryRespCode ufs_exec_query_flag(UfsRequest *req, int op)\n+{\n+ UfsHc *u = req->hc;\n+ uint8_t idn = req->req_upiu.qr.idn;\n+ uint8_t value;\n+ QueryRespCode ret;\n+\n+ ret = ufs_flag_check_idn_valid(idn, op);\n+ if (ret) {\n+ return ret;\n+ }\n+\n+ if (op == UFS_QUERY_FLAG_READ) {\n+ value = ufs_read_flag_value(u, idn);\n+ ret = UFS_QUERY_RESULT_SUCCESS;\n+ } else if (op == UFS_QUERY_FLAG_SET) {\n+ value = 1;\n+ ret = ufs_write_flag_value(u, idn, value);\n+ } else if (op == UFS_QUERY_FLAG_CLEAR) {\n+ value = 0;\n+ ret = ufs_write_flag_value(u, idn, value);\n+ } else if (op == UFS_QUERY_FLAG_TOGGLE) {\n+ value = !(ufs_read_flag_value(u, idn));\n+ ret = ufs_write_flag_value(u, idn, value);\n+ } else {\n+ trace_ufs_err_query_invalid_opcode(op);\n+ return UFS_QUERY_RESULT_INVALID_OPCODE;\n+ }\n+\n+ req->rsp_upiu.qr.value = cpu_to_be32(value);\n+ return ret;\n+}\n+\n static const int attr_permission[UFS_QUERY_ATTR_IDN_COUNT] = {\n /* booting is not supported */\n [UFS_QUERY_ATTR_IDN_BOOT_LU_EN] = UFS_QUERY_ATTR_READ,\n@@ -1103,39 +1219,6 @@ static inline QueryRespCode ufs_attr_check_idn_valid(uint8_t idn, int op)\n return UFS_QUERY_RESULT_SUCCESS;\n }\n\n-static QueryRespCode ufs_exec_query_flag(UfsRequest *req, int op)\n-{\n- UfsHc *u = req->hc;\n- uint8_t idn = req->req_upiu.qr.idn;\n- uint32_t value;\n- QueryRespCode ret;\n-\n- ret = ufs_flag_check_idn_valid(idn, op);\n- if (ret) {\n- return ret;\n- }\n-\n- if (idn == UFS_QUERY_FLAG_IDN_FDEVICEINIT) {\n- value = 0;\n- } else if (op == UFS_QUERY_FLAG_READ) {\n- value = *(((uint8_t *)&u->flags) + idn);\n- } else if (op == UFS_QUERY_FLAG_SET) {\n- value = 1;\n- } else if (op == UFS_QUERY_FLAG_CLEAR) {\n- value = 0;\n- } else if (op == UFS_QUERY_FLAG_TOGGLE) {\n- value = *(((uint8_t *)&u->flags) + idn);\n- value = !value;\n- } else {\n- trace_ufs_err_query_invalid_opcode(op);\n- return UFS_QUERY_RESULT_INVALID_OPCODE;\n- }\n-\n- *(((uint8_t *)&u->flags) + idn) = value;\n- req->rsp_upiu.qr.value = cpu_to_be32(value);\n- return UFS_QUERY_RESULT_SUCCESS;\n-}\n-\n static inline uint8_t ufs_read_device_temp(UfsHc *u)\n {\n uint8_t feat_sup = u->device_desc.ufs_features_support;\n@@ -1300,6 +1383,9 @@ static QueryRespCode ufs_write_attr_value(UfsHc *u, uint8_t idn, uint32_t value)\n case UFS_QUERY_ATTR_IDN_TIMESTAMP:\n u->attributes.timestamp = cpu_to_be64(value);\n break;\n+ default:\n+ g_assert_not_reached();\n+ return 0;\n }\n return UFS_QUERY_RESULT_SUCCESS;\n }\n", "prefixes": [ "2/5" ] }