Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217663/?format=api
{ "id": 2217663, "url": "http://patchwork.ozlabs.org/api/patches/2217663/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330103530.6873-1-venkat88@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260330103530.6873-1-venkat88@linux.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260330103530.6873-1-venkat88@linux.ibm.com/", "date": "2026-03-30T10:35:30", "name": "[v4] char/nvram: Remove redundant nvram_mutex", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "2d0b1dfb10ef24c4f389f7269390716153a49c89", "submitter": { "id": 89673, "url": "http://patchwork.ozlabs.org/api/people/89673/?format=api", "name": "Venkat Rao Bagalkote", "email": "venkat88@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330103530.6873-1-venkat88@linux.ibm.com/mbox/", "series": [ { "id": 497996, "url": "http://patchwork.ozlabs.org/api/series/497996/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497996", "date": "2026-03-30T10:35:30", "name": "[v4] char/nvram: Remove redundant nvram_mutex", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/497996/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217663/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2217663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19008-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=EhK3R7eZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19008-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=EhK3R7eZ;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=venkat88@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fknhn0d46z1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 21:35:53 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fknhm3F0Kz2yfl;\n\tMon, 30 Mar 2026 21:35:52 +1100 (AEDT)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fknhl4BYbz2xlK\n\tfor <linuxppc-dev@lists.ozlabs.org>; Mon, 30 Mar 2026 21:35:50 +1100 (AEDT)", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62TBTtd03183710;\n\tMon, 30 Mar 2026 10:35:45 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d64dge7x4-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 10:35:44 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62U9GjVZ021659;\n\tMon, 30 Mar 2026 10:35:44 GMT", "from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6sasckyk-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 10:35:43 +0000", "from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com\n [10.20.54.104])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62UAZdcK50856344\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 30 Mar 2026 10:35:40 GMT", "from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D553420040;\n\tMon, 30 Mar 2026 10:35:39 +0000 (GMT)", "from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 04BC02004B;\n\tMon, 30 Mar 2026 10:35:36 +0000 (GMT)", "from localhost.localdomain (unknown [9.61.240.154])\n\tby smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 30 Mar 2026 10:35:35 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774866952;\n\tcv=none;\n b=e7UCV3+jgEUH+gZeeetloKvP3MGSCx+VCC5Svwr5CMMlzQ1ronCkxKkGyWfelDLe4/pujbZ6Cbv7neQDyltHQFJmlUFTlN0pVFu3WLs/++u/jFmVPrJJHlOzhWNQIx2lGjBegHAPWHdknS1TmFlRrtHGgHoYEgc9D/65WyG9wQm3OmeKnkS68AkYtgO7t8Oskiz2nGKdlJ72Md/dzkoLuZJ1Vsng/4kS3PMdKzprOqJlA9B8Sz30RLt6DUg5GEwsU00TMN0sWWoep0Q7Sa+ofYKq7hdvulzUjjKDrUYma3wa+2Yp0uRQPugiUMA5e/1AQ8NGMw+kBC0HY6FKkPtj4Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774866952; c=relaxed/relaxed;\n\tbh=g7LjrMcOFJhmbQyG0g2szpe8vCVmFprox9SdpnjCYJc=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=baOPqpa8gKyQVpgqXEi0olRZ52K0snkrBVijnHdzStB5duVAqO8a7qRcuKnU1Q74cMqQtOhLfk5+bLgzOybYyGr0uwaxQWieSoo5smbwZdBreDb3xXTlfrs4mrKdGHv6oszPSqigBWGGZc7dB2J3naxY4TQOe3eA02LsGDnh+Evg0zhyo5IrMZ1qj/rh5buskkr76f5FSUyO/nOkydQ7vQHcmBaLA9fbLu4KI4LyXh/KOBZvEtpJb4+XvV/fTj5MfYiEywDBROVIvnv/eIZJzYxvUTGU914CFnR8yOFBxpeGYgH6MTWfZVHB2pVzKTecOqYPDRQNfebGdbv+DkTQhA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=EhK3R7eZ; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=venkat88@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=g7LjrMcOFJhmbQyG0g2szpe8vCVmFprox9SdpnjCY\n\tJc=; b=EhK3R7eZpd7WKExKloWHbUW6Fb/okwWZ7eoMjjoH09QwNwg3uHyPvH0kr\n\tojcSraNm728d0mj6HM10FZIvhuBMgaak2AM73qN9SLIoD6L4a/Wk5frQj/lPeMrf\n\tOLcVMhLIRTi9XNnH28RMWYmyvdBA1XG5hZCAwgjQVhMznzZqnQ9L2do8BCKyvPvr\n\tyIPuZkjDWuziu8TElNthFNYUAvPIRuS+AgLPyRc35SfrNTum6hOPEZ0LgqnmDf6O\n\t7nNibmS3tMLfYPfTMgvHZfRG5z8ySV6Jqt76TAA6Mj7Uel1h835dw3O6ZRo4c5/K\n\tqARbW73p6vd9UN17Ljn4DmcnWMrOg==", "From": "Venkat Rao Bagalkote <venkat88@linux.ibm.com>", "To": "linux-kernel@vger.kernel.org", "Cc": "linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n maddy@linux.ibm.com, ritesh.list@gmail.com, arnd@arndb.de,\n Christophe Leroy <chleroy@kernel.org>,\n Venkat Rao Bagalkote <venkat88@linux.ibm.com>", "Subject": "[PATCH v4] char/nvram: Remove redundant nvram_mutex", "Date": "Mon, 30 Mar 2026 16:05:30 +0530", "Message-ID": "<20260330103530.6873-1-venkat88@linux.ibm.com>", "X-Mailer": "git-send-email 2.45.2", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzMwMDA4MSBTYWx0ZWRfX9JIJMdW2o6GH\n pzstJj+QDYgDWTsETnZomNNrvtDWJXMfBD6my966xLp2kP8HEC/G5C+RMoerFDY9JU/XH06blqj\n U3wfikQaEy9qgJKDNOf7IotUwF5XLExbhZO12JKOQg2qkoEsf1x3BjQE9mz90qZXDzHmqAf612W\n KE8ez2o4GEDwm91pPBQo8FcvTsKAnAKNny4EGaWqvjKRUp7Vh41lCMVjyMbU3Mykz3FHOCJEdxv\n sEyOQEOYC86Mki6bAKAbBLy0ns6U3RF1AjkDYLaUF+w8dK64VK/kadeoRZiYUHk79YIuhiKSf54\n TeqCGOmrQIdYnmkYxji28tm2fo7DxB8t8MOLW0AQRW1HFJjkdmEVbB4QSzCko8Xt0DB/+QOp8/A\n Ek9e38oP//bPNZT8s6ryRY4MN70yHSkb8YoUkeIGFLvVlRYVUPAfbSER/uby3L5DYN8n1E2rtQ7\n goWrahyXL7y589z82hw==", "X-Authority-Analysis": "v=2.4 cv=QKZlhwLL c=1 sm=1 tr=0 ts=69ca5201 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=WqWmceQO84Qbs2Y3kP8A:9", "X-Proofpoint-GUID": "F4pH8-8kn4_Oa0IGX-WCgFw8S3Vpm_Xv", "X-Proofpoint-ORIG-GUID": "gUMo_ErNOkLDBBaR8XOZhuLo8XNfq3zZ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1015\n spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300081", "X-Spam-Status": "No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "The global nvram_mutex in drivers/char/nvram.c is redundant and unused,\nand this triggers compiler warnings on some configurations.\n\nAll platform-specific nvram operations already provide their own internal\nsynchronization, meaning the wrapper-level mutex does not provide any\nadditional safety.\n\nRemove the nvram_mutex definition along with all remaining lock/unlock\nusers across PPC32, x86, and m68k code paths, and rely entirely on the\nper-architecture nvram implementations for locking.\n\nSuggested-by: Arnd Bergmann <arnd@arndb.de>\nSigned-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>\n---\nv4:\n - Remove all remaining nvram_mutex call sites, completing the mutex removal\n\nv3:\n - Removed global nvram_mutex definition\n\n drivers/char/nvram.c | 16 +++-------------\n 1 file changed, 3 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c\nindex 9eff426a9286..e89cc1f1c89e 100644\n--- a/drivers/char/nvram.c\n+++ b/drivers/char/nvram.c\n@@ -53,7 +53,6 @@\n #include <asm/nvram.h>\n #endif\n \n-static DEFINE_MUTEX(nvram_mutex);\n static DEFINE_SPINLOCK(nvram_state_lock);\n static int nvram_open_cnt;\t/* #times opened */\n static int nvram_open_mode;\t/* special open modes */\n@@ -310,11 +309,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tbreak;\n #ifdef CONFIG_PPC32\n \tcase IOC_NVRAM_SYNC:\n-\t\tif (ppc_md.nvram_sync != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (ppc_md.nvram_sync)\n \t\t\tppc_md.nvram_sync();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tret = 0;\n \t\tbreak;\n #endif\n@@ -324,11 +320,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tif (!capable(CAP_SYS_ADMIN))\n \t\t\treturn -EACCES;\n \n-\t\tif (arch_nvram_ops.initialize != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (arch_nvram_ops.initialize)\n \t\t\tret = arch_nvram_ops.initialize();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tbreak;\n \tcase NVRAM_SETCKS:\n \t\t/* just set checksum, contents unchanged (maybe useful after\n@@ -336,11 +329,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tif (!capable(CAP_SYS_ADMIN))\n \t\t\treturn -EACCES;\n \n-\t\tif (arch_nvram_ops.set_checksum != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (arch_nvram_ops.set_checksum)\n \t\t\tret = arch_nvram_ops.set_checksum();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tbreak;\n #endif /* CONFIG_X86 || CONFIG_M68K */\n \t}\n", "prefixes": [ "v4" ] }