Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217661/?format=api
{ "id": 2217661, "url": "http://patchwork.ozlabs.org/api/patches/2217661/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260330102909.863484-2-vasileios.almpanis@virtuozzo.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330102909.863484-2-vasileios.almpanis@virtuozzo.com>", "list_archive_url": null, "date": "2026-03-30T10:20:24", "name": "[1/2] lib/checkpoint: add configurable timeout for checkpoint wake", "commit_ref": null, "pull_url": null, "state": "needs-review-ack", "archived": false, "hash": "52517888049c1e96a868b9462b6303fd58b1a6ca", "submitter": { "id": 92306, "url": "http://patchwork.ozlabs.org/api/people/92306/?format=api", "name": "Vasileios Almpanis", "email": "vasileios.almpanis@virtuozzo.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260330102909.863484-2-vasileios.almpanis@virtuozzo.com/mbox/", "series": [ { "id": 497995, "url": "http://patchwork.ozlabs.org/api/series/497995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=497995", "date": "2026-03-30T10:20:23", "name": "configurable wake timeout and memcontrol03 fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497995/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217661/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2217661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=HQEcrXtn;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=virtuozzo.com header.i=@virtuozzo.com header.a=rsa-sha256\n header.s=relay header.b=N4UVFz/+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fknYn3rGnz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 21:29:49 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 6C0F33E4F24\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 12:29:47 +0200 (CEST)", "from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 90B6F3E4F1A\n for <ltp@lists.linux.it>; Mon, 30 Mar 2026 12:29:40 +0200 (CEST)", "from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id B92652009A3\n for <ltp@lists.linux.it>; Mon, 30 Mar 2026 12:29:39 +0200 (CEST)", "from [130.117.225.5] (helo=dev010.aci.vzint.dev)\n by relay.virtuozzo.com with esmtp (Exim 4.96)\n (envelope-from <vasileios.almpanis@virtuozzo.com>)\n id 1w79qD-002jRx-1D; Mon, 30 Mar 2026 12:29:31 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1774866587; h=to : date :\n message-id : in-reply-to : references : mime-version : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : content-type :\n content-transfer-encoding : sender : from;\n bh=Zy39BCbJgkYoxANlWKrXfSXV7EotBNi0XV2PgYvD2Oc=;\n b=HQEcrXtnZfjLkbYVHjOpLt2v4zkS7WZn7QpSk0YsksRnjlUHR/xc2+d+/qGWaWY8qouVp\n 9cM1MRc+fIQ2ptbhoMWvYdU2VVwQ3W/p8GMfWL3k5WMlnVMVl5dPFVZhkxZzSGMs5fhy5LG\n 4lIGc+eX+nFtqY92Wa0VIhTrAkGp4zs=", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From:\n Content-Type; bh=dOkYEP9u96hbXLe1B8j4qp/0xQMUHvMHDmQyVYxLtV0=; b=N4UVFz/+Ce7h\n +7XzpFxOLcq/gXCc66FLYrtoanAEOry5x+5okpNZ2ej5E+NAYZ6/ZP7aeVhgVrcl1LEHnkMlDhVdV\n A+rFDFQ/sZCZno/Wyp9ZMTVKLxXISiq22wsKljpw6zRzf0l7HslI9b62ijNzN5WoviKtZXPs2xnX1\n /1qGZOBtJHDCgkXdruCqms2P3+UInmEze8qqfQktx6C/SuOEV0nUvqZYLlAeMdoaVdfMi5k19Sqzs\n hCIePYqiSruqbvpuQkWXzGLSsQZ4dVIUivap7PO8Kaii4hV4ZTbIMCwCiOnC9h/yrH8CX/flt617g\n +EUoLg82TAh01Xh/1/n9Og==;" ], "To": "ltp@lists.linux.it", "Date": "Mon, 30 Mar 2026 10:20:24 +0000", "Message-ID": "<20260330102909.863484-2-vasileios.almpanis@virtuozzo.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260330102909.863484-1-vasileios.almpanis@virtuozzo.com>", "References": "<20260330102909.863484-1-vasileios.almpanis@virtuozzo.com>", "MIME-Version": "1.0", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-7.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH 1/2] lib/checkpoint: add configurable timeout for\n checkpoint wake", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "From": "Vasileios Almpanis via ltp <ltp@lists.linux.it>", "Reply-To": "Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "tst_safe_checkpoint_wake() always used DEFAULT_MSEC_TIMEOUT (10s) for\ntst_checkpoint_wake(), which is too short when parents wait much longer\n(e.g. slow storage, KASAN, lockdep) while children allocate memory before\nthey reach the matching checkpoint wait.\n\nExtend tst_safe_checkpoint_wake(..., msec_timeout) so callers can pass an\nexplicit millisecond budget; msec_timeout 0 preserves the previous 10s\ndefault.\n\nAdd TST_CHECKPOINT_WAKE_TIMEOUT and TST_CHECKPOINT_WAKE2_TIMEOUT macros.\nExisting TST_CHECKPOINT_WAKE*, TST_CHECKPOINT_WAKE2, and\nTST_CHECKPOINT_WAKE_AND_WAIT pass 0 for the new argument so behavior is\nunchanged unless tests opt in.\n\nSigned-off-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>\n---\n include/tst_checkpoint.h | 41 ++++++++++++++++++++++++++++++++-----\n include/tst_checkpoint_fn.h | 2 +-\n lib/tst_checkpoint.c | 9 ++++++--\n 3 files changed, 44 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/tst_checkpoint.h b/include/tst_checkpoint.h\nindex f202dd03d..36089c1c5 100644\n--- a/include/tst_checkpoint.h\n+++ b/include/tst_checkpoint.h\n@@ -57,7 +57,7 @@\n * was reached the function calls tst_brk(TBROK, ...) which exits the test.\n */\n #define TST_CHECKPOINT_WAKE(id) \\\n- tst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, 1)\n+\ttst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, 1, 0)\n \n /**\n * TST_CHECKPOINT_WAKE2() - Wakes up several checkpoints.\n@@ -66,13 +66,44 @@\n * @nr_wake: A number of processes to wake.\n *\n * Wakes up nr_wake processes suspended on a checkpoint and retries if there\n- * wasn't enough process suspended on the checkpoint yet. The call does not\n+ * weren't enough processes suspended on the checkpoint yet. The call does not\n * retry indefinitely but gives up if it does not wake nr_wake processes after\n * 10 seconds. If an error happened or timeout was reached the function calls\n * tst_brk(TBROK, ...) which exits the test.\n */\n #define TST_CHECKPOINT_WAKE2(id, nr_wake) \\\n- tst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, nr_wake)\n+\ttst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, nr_wake, 0)\n+\n+/**\n+ * TST_CHECKPOINT_WAKE_TIMEOUT() - Wakes up a checkpoint.\n+ *\n+ * @id: A checkpoint id a positive integer.\n+ * @msec_timeout: A timeout.\n+ *\n+ * Wakes up a process suspended on a checkpoint and retries if there is no\n+ * process suspended on the checkpoint yet. The call does not retry\n+ * indefinitely but gives up if it does not wake a process after the timeout.\n+ * If an error happened or timeout was reached the function calls\n+ * tst_brk(TBROK, ...) which exits the test.\n+ */\n+#define TST_CHECKPOINT_WAKE_TIMEOUT(id, msec_timeout) \\\n+\ttst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, 1, msec_timeout)\n+\n+/**\n+ * TST_CHECKPOINT_WAKE2_TIMEOUT() - Wakes up several checkpoints.\n+ *\n+ * @id: A checkpoint id a positive integer.\n+ * @nr_wake: A number of processes to wake.\n+ * @msec_timeout: A timeout.\n+ *\n+ * Wakes up nr_wake processes suspended on a checkpoint and retries if there\n+ * weren't enough processes suspended on the checkpoint yet. The call does not\n+ * retry indefinitely but gives up if it does not wake nr_wake processes after\n+ * the timeout. If an error happened or timeout was reached the function calls\n+ * tst_brk(TBROK, ...) which exits the test.\n+ */\n+#define TST_CHECKPOINT_WAKE2_TIMEOUT(id, nr_wake, msec_timeout) \\\n+\ttst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, nr_wake, msec_timeout)\n \n /**\n * TST_CHECKPOINT_WAKE_AND_WAIT() - Wakes up a checkpoint and immediately waits on it.\n@@ -82,8 +113,8 @@\n * This is a combination of TST_CHECKPOINT_WAKE() and TST_CHECKPOINT_WAIT().\n */\n #define TST_CHECKPOINT_WAKE_AND_WAIT(id) do { \\\n- tst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, 1); \\\n- tst_safe_checkpoint_wait(__FILE__, __LINE__, NULL, id, 0); \\\n+\ttst_safe_checkpoint_wake(__FILE__, __LINE__, NULL, id, 1, 0); \\\n+\ttst_safe_checkpoint_wait(__FILE__, __LINE__, NULL, id, 0); \\\n } while (0)\n \n #endif /* TST_CHECKPOINT__ */\ndiff --git a/include/tst_checkpoint_fn.h b/include/tst_checkpoint_fn.h\nindex e061e00b9..13196b323 100644\n--- a/include/tst_checkpoint_fn.h\n+++ b/include/tst_checkpoint_fn.h\n@@ -30,6 +30,6 @@ void tst_safe_checkpoint_wait(const char *file, const int lineno,\n \n void tst_safe_checkpoint_wake(const char *file, const int lineno,\n void (*cleanup_fn)(void), unsigned int id,\n- unsigned int nr_wake);\n+\t\t\t unsigned int nr_wake, unsigned int msec_timeout);\n \n #endif /* TST_CHECKPOINT_FN__ */\ndiff --git a/lib/tst_checkpoint.c b/lib/tst_checkpoint.c\nindex f2faf6563..b9e6443e0 100644\n--- a/lib/tst_checkpoint.c\n+++ b/lib/tst_checkpoint.c\n@@ -100,9 +100,14 @@ void tst_safe_checkpoint_wait(const char *file, const int lineno,\n \n void tst_safe_checkpoint_wake(const char *file, const int lineno,\n void (*cleanup_fn)(void), unsigned int id,\n- unsigned int nr_wake)\n+\t\t\t unsigned int nr_wake, unsigned int msec_timeout)\n {\n-\tint ret = tst_checkpoint_wake(id, nr_wake, DEFAULT_MSEC_TIMEOUT);\n+\tint ret;\n+\n+\tif (!msec_timeout)\n+\t\tmsec_timeout = DEFAULT_MSEC_TIMEOUT;\n+\n+\tret = tst_checkpoint_wake(id, nr_wake, msec_timeout);\n \n \tif (ret) {\n \t\ttst_brkm_(file, lineno, TBROK | TERRNO, cleanup_fn,\n", "prefixes": [ "1/2" ] }