Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217660/?format=api
{ "id": 2217660, "url": "http://patchwork.ozlabs.org/api/patches/2217660/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330102815.6759-6-thuth@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330102815.6759-6-thuth@redhat.com>", "list_archive_url": null, "date": "2026-03-30T10:28:13", "name": "[PULL,5/7] hw/display/cirrus_vga_isa: Disable global_vmstate by default for new machines", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f2dfd512ec2716edb61cc57127d005d4525e1c29", "submitter": { "id": 66152, "url": "http://patchwork.ozlabs.org/api/people/66152/?format=api", "name": "Thomas Huth", "email": "thuth@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330102815.6759-6-thuth@redhat.com/mbox/", "series": [ { "id": 497994, "url": "http://patchwork.ozlabs.org/api/series/497994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497994", "date": "2026-03-30T10:28:09", "name": "[PULL,1/7] tests/functional/qemu_test: Silence (most) warnings from pylint in asset.py", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497994/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217660/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dCVfsgl7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fknYV5XqTz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 21:29:34 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w79rS-0001C6-MP; Mon, 30 Mar 2026 06:28:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w79rL-00016D-VH\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:40 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w79rK-0005Ef-Hj\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:39 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-LoQfeR6_OqG1p21QcL0q8g-1; Mon,\n 30 Mar 2026 06:28:34 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A911619560A2; Mon, 30 Mar 2026 10:28:32 +0000 (UTC)", "from thuth-p1g4.redhat.com (unknown [10.44.35.14])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 596A530001A2; Mon, 30 Mar 2026 10:28:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774866517;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Ww94gMkt11Wk7lcnwhAkRmngRIfU7Z3lB/Oh9OuXyhI=;\n b=dCVfsgl7t/Atxa4WgiqWl3QtRQqcIV2ZhvXPlsf9SOxwNGAeXrVQBJglj/NUGZZP7CgcOM\n Fkf8ZG1w7XvziTLTDKCgufN3E3E4ZllHTyoD+G9W58i7ZlAJHBg6sk0qPhSG8lfFpP7xr8\n PhCyBLuSjxEXcA6FM69l4+3bD7oEuL4=", "X-MC-Unique": "LoQfeR6_OqG1p21QcL0q8g-1", "X-Mimecast-MFC-AGG-ID": "LoQfeR6_OqG1p21QcL0q8g_1774866513", "From": "Thomas Huth <thuth@redhat.com>", "To": "Peter Maydell <peter.maydell@linaro.org>", "Cc": "qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>, =?utf-8?q?Philip?=\n\t=?utf-8?q?pe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PULL 5/7] hw/display/cirrus_vga_isa: Disable global_vmstate by\n default for new machines", "Date": "Mon, 30 Mar 2026 12:28:13 +0200", "Message-ID": "<20260330102815.6759-6-thuth@redhat.com>", "In-Reply-To": "<20260330102815.6759-1-thuth@redhat.com>", "References": "<20260330102815.6759-1-thuth@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Thomas Huth <thuth@redhat.com>\n\nIn the long run, we would like to get rid of the code that allows to\nregister migration state globally, so set global_vmstate to false when\nusing the isa-cirrus-vga device with new machines, and only enable it\nfor older machines to avoid breaking the migration there.\n\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Thomas Huth <thuth@redhat.com>\nMessage-ID: <20260326154850.301609-1-thuth@redhat.com>\n---\n hw/core/machine.c | 1 +\n hw/display/cirrus_vga_isa.c | 3 ++-\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 6cf0e2f404e..0aa77a57e95 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -40,6 +40,7 @@\n \n GlobalProperty hw_compat_10_2[] = {\n { \"scsi-block\", \"migrate-pr\", \"off\" },\n+ { \"isa-cirrus-vga\", \"global-vmstate\", \"true\" },\n };\n const size_t hw_compat_10_2_len = G_N_ELEMENTS(hw_compat_10_2);\n \ndiff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c\nindex bad9ec7599c..76034a88605 100644\n--- a/hw/display/cirrus_vga_isa.c\n+++ b/hw/display/cirrus_vga_isa.c\n@@ -56,7 +56,6 @@ static void isa_cirrus_vga_realizefn(DeviceState *dev, Error **errp)\n s->vram_size_mb);\n return;\n }\n- s->global_vmstate = true;\n if (!vga_common_init(s, OBJECT(dev), errp)) {\n return;\n }\n@@ -74,6 +73,8 @@ static const Property isa_cirrus_vga_properties[] = {\n cirrus_vga.vga.vram_size_mb, 4),\n DEFINE_PROP_BOOL(\"blitter\", struct ISACirrusVGAState,\n cirrus_vga.enable_blitter, true),\n+ DEFINE_PROP_BOOL(\"global-vmstate\", struct ISACirrusVGAState,\n+ cirrus_vga.vga.global_vmstate, false),\n };\n \n static void isa_cirrus_vga_class_init(ObjectClass *klass, const void *data)\n", "prefixes": [ "PULL", "5/7" ] }