Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217656/?format=api
{ "id": 2217656, "url": "http://patchwork.ozlabs.org/api/patches/2217656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330102815.6759-5-thuth@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330102815.6759-5-thuth@redhat.com>", "list_archive_url": null, "date": "2026-03-30T10:28:12", "name": "[PULL,4/7] hw/display/vga-isa: Fix migration of the isa-vga device", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0fb430ad20c306e27a4d08b8268ecd1d63caad30", "submitter": { "id": 66152, "url": "http://patchwork.ozlabs.org/api/people/66152/?format=api", "name": "Thomas Huth", "email": "thuth@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330102815.6759-5-thuth@redhat.com/mbox/", "series": [ { "id": 497994, "url": "http://patchwork.ozlabs.org/api/series/497994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497994", "date": "2026-03-30T10:28:09", "name": "[PULL,1/7] tests/functional/qemu_test: Silence (most) warnings from pylint in asset.py", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497994/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217656/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KSTnJlS1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fknYL572Kz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 21:29:26 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w79rQ-00018b-LL; Mon, 30 Mar 2026 06:28:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w79rG-00015H-6n\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:36 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w79rE-0005E6-No\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 06:28:33 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-f5BtmsjiMEGSDaz5-SKKMw-1; Mon,\n 30 Mar 2026 06:28:30 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5318D18002D0; Mon, 30 Mar 2026 10:28:29 +0000 (UTC)", "from thuth-p1g4.redhat.com (unknown [10.44.35.14])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3FCF430001A1; Mon, 30 Mar 2026 10:28:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774866512;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jM+h+o7CiJ2jVIona9N3hztx18aBnLRkjHdndA8t8eo=;\n b=KSTnJlS1VNgNzkILgdGNW55QsWN0quTQGP2HUQ2++s+smbxbUv7M0YcFVYa8UZgUQtOYNI\n pMVTKEZ+ChdqWHguVkAa5+4+3nTJVqIomHJOAa5lwqafFbIt9CAtNRxgCyv6syo64Vy/fA\n Dv1iN4cgnRZqCO1192QlwrmUpPbx0IQ=", "X-MC-Unique": "f5BtmsjiMEGSDaz5-SKKMw-1", "X-Mimecast-MFC-AGG-ID": "f5BtmsjiMEGSDaz5-SKKMw_1774866509", "From": "Thomas Huth <thuth@redhat.com>", "To": "Peter Maydell <peter.maydell@linaro.org>", "Cc": "qemu-devel@nongnu.org,\n\tFabiano Rosas <farosas@suse.de>", "Subject": "[PULL 4/7] hw/display/vga-isa: Fix migration of the isa-vga device", "Date": "Mon, 30 Mar 2026 12:28:12 +0200", "Message-ID": "<20260330102815.6759-5-thuth@redhat.com>", "In-Reply-To": "<20260330102815.6759-1-thuth@redhat.com>", "References": "<20260330102815.6759-1-thuth@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-5", "X-Spam_score": "-0.6", "X-Spam_bar": "/", "X-Spam_report": "(-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Thomas Huth <thuth@redhat.com>\n\nQEMU currently crashes when migrating a guest that uses the\nisa-vga device as display. This happens because vga_isa_class_initfn()\nregisters a vmsd for vmstate_vga_common that operates on VGACommonState.\nBut the isa-vga device is derived from ISADevice, not from VGACommonState,\nso the migration code tries to fill in the data for VGACommonState to\nthe memory that is a ISADevice instead, which is of cause causing trouble.\n\nWe need an indirection here as it's also e.g. done in vga-pci.c, so\nthat the migration data gets filled into the right location.\n\nWhile we're at it, also drop the \"global_vmstate = true\" here. Since\nmigration was broken for this device during the last 15 years (!) anyway,\nwe don't have to worry about maintaining backward compatibility with this\nswitch for older versions of QEMU anymore.\n\nFixes: 7435b791ca9 (\"vga-isa: convert to qdev\")\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nSigned-off-by: Thomas Huth <thuth@redhat.com>\nMessage-ID: <20260326113457.159065-1-thuth@redhat.com>\n---\n hw/display/vga-isa.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/display/vga-isa.c b/hw/display/vga-isa.c\nindex 95d85ff69a5..5f55c884a1b 100644\n--- a/hw/display/vga-isa.c\n+++ b/hw/display/vga-isa.c\n@@ -32,6 +32,7 @@\n #include \"qemu/timer.h\"\n #include \"hw/core/loader.h\"\n #include \"hw/core/qdev-properties.h\"\n+#include \"migration/vmstate.h\"\n #include \"ui/console.h\"\n #include \"qom/object.h\"\n \n@@ -62,7 +63,6 @@ static void vga_isa_realizefn(DeviceState *dev, Error **errp)\n MemoryRegion *vga_io_memory;\n const MemoryRegionPortio *vga_ports, *vbe_ports;\n \n- s->global_vmstate = true;\n if (!vga_common_init(s, OBJECT(dev), errp)) {\n return;\n }\n@@ -88,6 +88,15 @@ static void vga_isa_realizefn(DeviceState *dev, Error **errp)\n rom_add_vga(VGABIOS_FILENAME);\n }\n \n+static const VMStateDescription vmstate_vga_isa = {\n+ .name = \"vga-isa\",\n+ .version_id = 1,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_STRUCT(state, ISAVGAState, 0, vmstate_vga_common, VGACommonState),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n static const Property vga_isa_properties[] = {\n DEFINE_PROP_UINT32(\"vgamem_mb\", ISAVGAState, state.vram_size_mb, 8),\n };\n@@ -98,7 +107,7 @@ static void vga_isa_class_initfn(ObjectClass *klass, const void *data)\n \n dc->realize = vga_isa_realizefn;\n device_class_set_legacy_reset(dc, vga_isa_reset);\n- dc->vmsd = &vmstate_vga_common;\n+ dc->vmsd = &vmstate_vga_isa;\n device_class_set_props(dc, vga_isa_properties);\n set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);\n }\n", "prefixes": [ "PULL", "4/7" ] }