Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217632/?format=api
{ "id": 2217632, "url": "http://patchwork.ozlabs.org/api/patches/2217632/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/3d4293f1a2d3c43eacdc7306288bcb0060d39b23.camel@tugraz.at/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<3d4293f1a2d3c43eacdc7306288bcb0060d39b23.camel@tugraz.at>", "list_archive_url": null, "date": "2026-03-30T09:08:58", "name": "[STAGE1,C] Fix recursive structure / union redeclaration with qualifiers [PR124303]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0988c9fb8cf7526471be8029ab1a37ee9e7edbef", "submitter": { "id": 85465, "url": "http://patchwork.ozlabs.org/api/people/85465/?format=api", "name": "Martin Uecker", "email": "uecker@tugraz.at" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/3d4293f1a2d3c43eacdc7306288bcb0060d39b23.camel@tugraz.at/mbox/", "series": [ { "id": 497986, "url": "http://patchwork.ozlabs.org/api/series/497986/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=497986", "date": "2026-03-30T09:08:58", "name": "[STAGE1,C] Fix recursive structure / union redeclaration with qualifiers [PR124303]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497986/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217632/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217632/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=tugraz.at header.i=@tugraz.at header.a=rsa-sha256\n header.s=mailrelay header.b=PPdBGi5u;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=tugraz.at header.i=@tugraz.at header.a=rsa-sha256\n header.s=mailrelay header.b=PPdBGi5u", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=tugraz.at", "sourceware.org; spf=pass smtp.mailfrom=tugraz.at", "server2.sourceware.org;\n arc=none smtp.remote-ip=129.27.2.202" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fklsK5Lv2z1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 20:13:09 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 80FEE4B920C5\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 09:13:07 +0000 (GMT)", "from mailrelay.tugraz.at (mailrelay.tugraz.at [129.27.2.202])\n by sourceware.org (Postfix) with ESMTPS id 939F74BA23FE\n for <gcc-patches@gcc.gnu.org>; Mon, 30 Mar 2026 09:09:04 +0000 (GMT)", "from vra-171-236.tugraz.at (vra-171-236.tugraz.at [129.27.171.236])\n by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4fklmW3Y5Rz2xCy;\n Mon, 30 Mar 2026 11:08:59 +0200 (CEST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 80FEE4B920C5", "OpenDKIM Filter v2.11.0 sourceware.org 939F74BA23FE" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 939F74BA23FE", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 939F74BA23FE", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774861746; cv=none;\n b=AGCI64v2Y0CNfIe8/n3zMrMchulNaECLbZCBew2DgpLCaXXYXmXNLmtxruncEFEM3TKwFAL2BXdZIGaLJ1ZvcH5TlnWXg6QaSvYZYHxES3poTbexNGrvrmCoN0cSTIZcFzy5EHDBiifTk/dbTZUf4dVE2RK/pCcH+MqEh7Tpeqg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774861746; c=relaxed/simple;\n bh=nYwPFGIwVOcoOrTD4jecIA9L53Acqx1O2DgoziSe1gw=;\n h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version;\n b=n+tcfJJSRpcRj5E3xNT4screyQbgEAkRNyPCgmho3neo09RwONBU88KDeJQg2cbhx6z0v+gBtnOReKrO5S8h7prYPLIajmNlloLlvHISnigQkaYu4s2wog+bAIvh4+T7XV46m3GePcPDj1L6aWy67gGxfEIZDXCA7Nqo1614gGI=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;\n s=mailrelay; t=1774861739;\n bh=UrOxYfaxjt5nNgVWCBnWb+aeQIMMsM/MQDdHq7SxGfM=;\n h=Subject:From:To:Cc:Date;\n b=PPdBGi5uEjVgXDziz6qLE6Q8+vV4Qwp2eHDf5kDF2ErWGIqQppDCKKn54iCSkr6Xs\n COsoGVVjJaMekxcbsg0ZVcBn0lU/4BOn91NECphUWzu64SCaAg4oTtE4xdCMJO/OHQ\n +MyCNG81JbS+6hdjgRRMiyS+rn/6cVlctgYs87H4=", "Message-ID": "<3d4293f1a2d3c43eacdc7306288bcb0060d39b23.camel@tugraz.at>", "Subject": "[STAGE1] [C PATCH] Fix recursive structure / union redeclaration\n with qualifiers [PR124303]", "From": "Martin Uecker <uecker@tugraz.at>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Joseph Myers <josmyers@redhat.com>", "Date": "Mon, 30 Mar 2026 11:08:58 +0200", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "quoted-printable", "User-Agent": "Evolution 3.56.2-0+deb13u1 ", "MIME-Version": "1.0", "X-TUG-Backscatter-control": "G/VXY7/6zeyuAY/PU2/0qw", "X-Scanned-By": "MIMEDefang 2.74 on 129.27.10.116", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Bootstrapped and regression tested on x86_64.\n\n c: Fix recursive structure / union redeclaration with qualifiers [PR124303]\n \n We reject correct recursive redeclarations when qualifiers are involved.\n The reason is that the check is done before the variants are completed.\n \n PR c/124303\n \n gcc/c/ChangeLog:\n * c-decl.c (finish_struct): Check for consistency of\n declarations after completing variants.\n \n gcc/testsuite/ChangeLog:\n * gcc.dg/pr124303.c: New test.", "diff": "diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc\nindex 8a894de3a1b..37bd01ab7b0 100644\n--- a/gcc/c/c-decl.cc\n+++ b/gcc/c/c-decl.cc\n@@ -9970,6 +9970,23 @@ finish_struct (location_t loc, tree t, tree fieldlist, tree attributes,\n warning_at (loc, 0, \"union cannot be made transparent\");\n }\n \n+ tree incomplete_vars = C_TYPE_INCOMPLETE_VARS (TYPE_MAIN_VARIANT (t));\n+ for (x = TYPE_MAIN_VARIANT (t); x; x = TYPE_NEXT_VARIANT (x))\n+ {\n+ TYPE_FIELDS (x) = TYPE_FIELDS (t);\n+ TYPE_LANG_SPECIFIC (x) = TYPE_LANG_SPECIFIC (t);\n+ TYPE_TRANSPARENT_AGGR (x) = TYPE_TRANSPARENT_AGGR (t);\n+ TYPE_TYPELESS_STORAGE (x) = TYPE_TYPELESS_STORAGE (t);\n+ C_TYPE_FIELDS_READONLY (x) = C_TYPE_FIELDS_READONLY (t);\n+ C_TYPE_FIELDS_VOLATILE (x) = C_TYPE_FIELDS_VOLATILE (t);\n+ C_TYPE_FIELDS_NON_CONSTEXPR (x) = C_TYPE_FIELDS_NON_CONSTEXPR (t);\n+ C_TYPE_FIELDS_HAS_COUNTED_BY (x) = C_TYPE_FIELDS_HAS_COUNTED_BY (t);\n+ C_TYPE_VARIABLE_SIZE (x) = C_TYPE_VARIABLE_SIZE (t);\n+ C_TYPE_VARIABLY_MODIFIED (x) = C_TYPE_VARIABLY_MODIFIED (t);\n+ C_TYPE_INCOMPLETE_VARS (x) = NULL_TREE;\n+ TYPE_INCLUDES_FLEXARRAY (x) = TYPE_INCLUDES_FLEXARRAY (t);\n+ }\n+\n /* Check for consistency with previous definition. */\n if (flag_isoc23 && NULL != enclosing_struct_parse_info)\n {\n@@ -10024,23 +10041,6 @@ finish_struct (location_t loc, tree t, tree fieldlist, tree attributes,\n c_update_type_canonical (t);\n }\n \n- tree incomplete_vars = C_TYPE_INCOMPLETE_VARS (TYPE_MAIN_VARIANT (t));\n- for (x = TYPE_MAIN_VARIANT (t); x; x = TYPE_NEXT_VARIANT (x))\n- {\n- TYPE_FIELDS (x) = TYPE_FIELDS (t);\n- TYPE_LANG_SPECIFIC (x) = TYPE_LANG_SPECIFIC (t);\n- TYPE_TRANSPARENT_AGGR (x) = TYPE_TRANSPARENT_AGGR (t);\n- TYPE_TYPELESS_STORAGE (x) = TYPE_TYPELESS_STORAGE (t);\n- C_TYPE_FIELDS_READONLY (x) = C_TYPE_FIELDS_READONLY (t);\n- C_TYPE_FIELDS_VOLATILE (x) = C_TYPE_FIELDS_VOLATILE (t);\n- C_TYPE_FIELDS_NON_CONSTEXPR (x) = C_TYPE_FIELDS_NON_CONSTEXPR (t);\n- C_TYPE_FIELDS_HAS_COUNTED_BY (x) = C_TYPE_FIELDS_HAS_COUNTED_BY (t);\n- C_TYPE_VARIABLE_SIZE (x) = C_TYPE_VARIABLE_SIZE (t);\n- C_TYPE_VARIABLY_MODIFIED (x) = C_TYPE_VARIABLY_MODIFIED (t);\n- C_TYPE_INCOMPLETE_VARS (x) = NULL_TREE;\n- TYPE_INCLUDES_FLEXARRAY (x) = TYPE_INCLUDES_FLEXARRAY (t);\n- }\n-\n /* Update type location to the one of the definition, instead of e.g.\n a forward declaration. */\n if (TYPE_STUB_DECL (t))\ndiff --git a/gcc/testsuite/gcc.dg/pr124303.c b/gcc/testsuite/gcc.dg/pr124303.c\nnew file mode 100644\nindex 00000000000..a2ab6694af6\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/pr124303.c\n@@ -0,0 +1,7 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-std=c23\" } *//\n+\n+struct s { void (*p)(const struct s*); };\n+struct s { void (*p)(const struct s*); };\n+\n+\n", "prefixes": [ "STAGE1", "C" ] }