Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217630/?format=api
{ "id": 2217630, "url": "http://patchwork.ozlabs.org/api/patches/2217630/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-pcie-intel-gw-v2-5-8bd07367a298@dev.tdt.de/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330-pcie-intel-gw-v2-5-8bd07367a298@dev.tdt.de>", "list_archive_url": null, "date": "2026-03-30T09:07:15", "name": "[v2,5/7] PCI: intel-gw: Remove atu base assignment", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4b3458bc04b9533dcfc9f5b9b90f7648b008c282", "submitter": { "id": 72238, "url": "http://patchwork.ozlabs.org/api/people/72238/?format=api", "name": "Florian Eckert", "email": "fe@dev.tdt.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-pcie-intel-gw-v2-5-8bd07367a298@dev.tdt.de/mbox/", "series": [ { "id": 497985, "url": "http://patchwork.ozlabs.org/api/series/497985/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=497985", "date": "2026-03-30T09:07:13", "name": "PCI: intel-gw: Fixes to make the driver working again", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497985/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217630/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217630/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51427-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=temperror header.d=dev.tdt.de header.i=@dev.tdt.de header.a=rsa-sha256\n header.s=z1-selector1 header.b=kTaggtKJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-51427-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=\"kTaggtKJ\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=194.37.255.70", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=dev.tdt.de" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fklrd0Tt2z1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 20:12:33 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0AC7E3023A54\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 09:07:43 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9DB7E3B2FFB;\n\tMon, 30 Mar 2026 09:07:38 +0000 (UTC)", "from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C3C3B27E2;\n\tMon, 30 Mar 2026 09:07:36 +0000 (UTC)", "from [194.37.255.9] (helo=mxout.expurgate.net)\n\tby relay.expurgate.net with smtp (Exim 4.92)\n\t(envelope-from <prvs=65635f912b=fe@dev.tdt.de>)\n\tid 1w78aq-008YeN-Fd; Mon, 30 Mar 2026 11:07:32 +0200", "from [195.243.126.94] (helo=securemail.tdt.de)\n\tby relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n\t(Exim 4.92)\n\t(envelope-from <fe@dev.tdt.de>)\n\tid 1w78ap-008YcB-Rg; Mon, 30 Mar 2026 11:07:31 +0200", "from securemail.tdt.de (localhost [127.0.0.1])\n\tby securemail.tdt.de (Postfix) with ESMTP id 67C15240040;\n\tMon, 30 Mar 2026 11:07:31 +0200 (CEST)", "from mail.dev.tdt.de (unknown [10.2.4.42])\n\tby securemail.tdt.de (Postfix) with ESMTP id 5F04C240036;\n\tMon, 30 Mar 2026 11:07:31 +0200 (CEST)", "from [10.2.3.40] (unknown [10.2.3.40])\n\tby mail.dev.tdt.de (Postfix) with ESMTPSA id 29A7B20E49;\n\tMon, 30 Mar 2026 11:07:31 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774861658; cv=none;\n b=Ya95axyUmtLN7e/Z7j/Q7IFQ6iJ8Xywo4XRQ7nSPeUWt3aQBBv8W4+UpWx6m5d2bcReTuyGWf9nZrVI8N0kwpXu2yWs2/kdHOmu3oyiSiLWYfe5DYxnb7KZGYeYDA+lWfje9BEYGxExMRynn4/b+dc2QTXuIuOjVPMgYWYDDFT8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774861658; c=relaxed/simple;\n\tbh=Ati0WQXsi/BbMty7w9zy15si5sKm0IPY4TkcmlS7Z9Y=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References:\n\t In-Reply-To:To:Cc;\n b=TwiSOULND/gigdDtBC1biJ6yA5nqb+iL4zhm4D6fRIlu7ueDADawFDI1vVnCe60/ng8g333k3/JlbFITO5O89hmiNV1Tcf1m8T2gBAgUY94RS5Qg66QLeXM/r1gjWMHVexq1iLPOH2z4tsdhO0RI6iTs5sQHGKhNZ0fkApsU1J4=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de;\n spf=pass smtp.mailfrom=dev.tdt.de;\n dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=kTaggtKJ; arc=none smtp.client-ip=194.37.255.70", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de;\n\ts=z1-selector1; t=1774861651;\n\tbh=BofokuiPDJZU4b3Xyu05PlOTjPGWqOiC0E9vOzhVtD4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=kTaggtKJHvwlPslYA1urj+6xWZcviq4exu8SP6+kYfFe8W7Lnn3O8m5f7WBpJeRGa\n\t eqgrQsl+4wpN25EytML4Pkd00CRU/rNxN9xd1z1ij5BFIpea85IP30DaPpOHXg1gdC\n\t eIeeuBpMy5dybdI/Ydp/GkNjCr1+hkCnBy3NQBgaxSSMa91IFdQeTZQqrylkg3OE7Q\n\t owt/a3tEdGKA/QFdkdw0REyFthVPNwCzmcHE8Nn2DZA9hEpeeU3wx/FtripEchd24J\n\t ejKtzTD2JOblmg+DbpWDGCMYATiRj590vneD4ZCKqCB90A8dQYyqYhC/DB7omAkrBi\n\t gC+zaKAUVG4+A==", "From": "Florian Eckert <fe@dev.tdt.de>", "Date": "Mon, 30 Mar 2026 11:07:15 +0200", "Subject": "[PATCH v2 5/7] PCI: intel-gw: Remove atu base assignment", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-ID": "<20260330-pcie-intel-gw-v2-5-8bd07367a298@dev.tdt.de>", "References": "<20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de>", "In-Reply-To": "<20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de>", "To": "Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy?=\n\t=?utf-8?q?=C5=84ski?= <kwilczynski@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>, Johan Hovold <johan+linaro@kernel.org>,\n Sajid Dalvi <sdalvi@google.com>, Ajay Agarwal <ajayagarwal@google.com>,\n Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n Rahul Tanwar <rtanwar@maxlinear.com>", "Cc": "linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, Florian Eckert <fe@dev.tdt.de>,\n\tEckert.Florian@googlemail.com, ms@dev.tdt.de", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1774861650; l=2173;\n i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id;\n bh=Ati0WQXsi/BbMty7w9zy15si5sKm0IPY4TkcmlS7Z9Y=;\n b=kTeDwbb87ZDCFjB4oRXDikxEf8css8e5gSMQkHoRoDrxSAMvbLkmSNkFHdR3WQ72AuM5xJRUV\n foMvxU2nXl3DDPapCb6sGOvsz+EbdiHd4qDMd3eo6wgBb+hx/rdO18j", "X-Developer-Key": "i=fe@dev.tdt.de; a=ed25519;\n pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk=", "X-purgate-type": "clean", "X-purgate": "clean", "X-purgate-ID": "151534::1774861652-C6C25842-7B2AD83F/0/0" }, "content": "If no ATU resource is defined in the DTS, the default value is 0x300000[1].\nThis is set during probing in the function 'dw_pcie_get_resources()'[2].\nThe driver overwrites this again when its init callback is called in its\n'intel_pcie_host_setup()' [3] function. This is because the value here is\n'0xC0000' rather than '0x300000'. This callback is called by the dwc core\nvia 'pp->ops->init' [4].\n\nfunction callstack:\nintel_pcie_probe()\n dw_pcie_host_init()\n dw_pcie_host_get_resources()\n dw_pcie_get_resources() [2]\n pp->ops->init = intel_pcie_rc_init()\n intel_pcie_host_setup() [3]\n\nAs backwards compatibility is not an issue here [5], the value for the ATU\nresource is moved to the DTS and is therefore loaded by the dwc core. It\nis therefore no longer necessary to overwrite the pci->atu_base address in\nthe init callback. The DTS must be modified so that the additional resource\nis loaded correctly by the DWC core.\n\n[1] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller/dwc/pcie-designware.h#L292\n[2] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller/dwc/pcie-designware.c#L150\n[3] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller/dwc/pcie-intel-gw.c#L301\n[4] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller/dwc/pcie-designware-host.c#L589\n[5] https://lore.kernel.org/all/BY3PR19MB507667CE7531D863E1E5F8AEBDD82@BY3PR19MB5076.namprd19.prod.outlook.com/\n\nSigned-off-by: Florian Eckert <fe@dev.tdt.de>\n---\n drivers/pci/controller/dwc/pcie-intel-gw.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c\nindex 24c463781f1e31d5617a5ff81bdbce563ed5a1d0..f41b64ac48d5c05e6b0e5b14c3e0cd7a4c407d16 100644\n--- a/drivers/pci/controller/dwc/pcie-intel-gw.c\n+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c\n@@ -310,8 +310,6 @@ static int intel_pcie_host_setup(struct intel_pcie *pcie)\n \t\tgoto clk_err;\n \t}\n \n-\tpci->atu_base = pci->dbi_base + 0xC0000;\n-\n \tret = phy_init(pcie->phy);\n \tif (ret)\n \t\tgoto phy_err;\n", "prefixes": [ "v2", "5/7" ] }