Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217628/?format=api
{ "id": 2217628, "url": "http://patchwork.ozlabs.org/api/patches/2217628/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-pcie-intel-gw-v2-3-8bd07367a298@dev.tdt.de/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330-pcie-intel-gw-v2-3-8bd07367a298@dev.tdt.de>", "list_archive_url": null, "date": "2026-03-30T09:07:13", "name": "[v2,3/7] PCI: intel-gw: Enable clock before phy init", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "06b764a98d01d546fbcc9e9d45361ce91302bb27", "submitter": { "id": 72238, "url": "http://patchwork.ozlabs.org/api/people/72238/?format=api", "name": "Florian Eckert", "email": "fe@dev.tdt.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-pcie-intel-gw-v2-3-8bd07367a298@dev.tdt.de/mbox/", "series": [ { "id": 497985, "url": "http://patchwork.ozlabs.org/api/series/497985/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=497985", "date": "2026-03-30T09:07:13", "name": "PCI: intel-gw: Fixes to make the driver working again", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497985/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217628/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217628/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51425-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=temperror header.d=dev.tdt.de header.i=@dev.tdt.de header.a=rsa-sha256\n header.s=z1-selector1 header.b=kQfNrtS3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-51425-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=\"kQfNrtS3\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=194.37.255.70", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=dev.tdt.de" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fklrV4S5wz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 20:12:26 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 301CC301D30B\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 09:07:41 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8645D3B2FD5;\n\tMon, 30 Mar 2026 09:07:38 +0000 (UTC)", "from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E0A3AD531;\n\tMon, 30 Mar 2026 09:07:36 +0000 (UTC)", "from [194.37.255.9] (helo=mxout.expurgate.net)\n\tby relay.expurgate.net with smtp (Exim 4.92)\n\t(envelope-from <prvs=65635f912b=fe@dev.tdt.de>)\n\tid 1w78aq-008Ydf-6D; Mon, 30 Mar 2026 11:07:32 +0200", "from [195.243.126.94] (helo=securemail.tdt.de)\n\tby relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n\t(Exim 4.92)\n\t(envelope-from <fe@dev.tdt.de>)\n\tid 1w78ap-00GTFL-KD; Mon, 30 Mar 2026 11:07:31 +0200", "from securemail.tdt.de (localhost [127.0.0.1])\n\tby securemail.tdt.de (Postfix) with ESMTP id 143FA240046;\n\tMon, 30 Mar 2026 11:07:31 +0200 (CEST)", "from mail.dev.tdt.de (unknown [10.2.4.42])\n\tby securemail.tdt.de (Postfix) with ESMTP id 07392240042;\n\tMon, 30 Mar 2026 11:07:31 +0200 (CEST)", "from [10.2.3.40] (unknown [10.2.3.40])\n\tby mail.dev.tdt.de (Postfix) with ESMTPSA id D579F20E49;\n\tMon, 30 Mar 2026 11:07:30 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774861658; cv=none;\n b=UAFKVrZ+1KwA7Nc4zeJ4bzWyGDlLnMludrG+nf8O7QTjyuKCwK2OJhlA7YxP+hlD7C1WcX6Syn/Gm5TwOO/dmaJChwlHqrO08NC2cReBMe0581PTZ/meH4b40Fl1vHrXg3mpS3+Fo82+LVgbCeYinsbfMNvZ1/lwUaLw6OWBLt4=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774861658; c=relaxed/simple;\n\tbh=coHmsdtqcsW+dKyhuAd7vn7jGgDFbg9jYRqHLyenC9w=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References:\n\t In-Reply-To:To:Cc;\n b=GIgT4xWE0Bit0BJxydHm2rQCqihghZ8pXI2lD486lhGeCDAPrdX2btuk4OLRc82p0VhAJT3V3TOq6MRhPt3u3WCzIEx3P4e8Jqj2DC9x1zytw+2iZ65dpKh28GgcHyVt+fhZgs3Jdm5UjaJVXRK8vg1NV5242vBJegZ+HtBrkHc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de;\n spf=pass smtp.mailfrom=dev.tdt.de;\n dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=kQfNrtS3; arc=none smtp.client-ip=194.37.255.70", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de;\n\ts=z1-selector1; t=1774861651;\n\tbh=eTw8E3ezVzDUqc+dP4JdW7vl/OP8CGUQKxaL+SejZ2g=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=kQfNrtS3U/b1N3yvK+ooX+3QBH1QVBrgc36X6tdWU1UM9H5za5gSHr4oUIPYS0VMt\n\t jC/xgoN0TpBR0RQqVnYDpnpCY+aGHRNXxVzuL3j9FugVfJrFbOsaPYscu2clrZEgAw\n\t vmh4mgFKhdMmEMKQaGJMDUe5YY8SKauzwDYrbp5q8wOklS2Z2fnDD4G8j2MNUltb2o\n\t UaNOzK2+/evR6AaQ3EpcNk4Fya89XbtlF00fi9kCThAVm0BHGXzHuyvjkFzKUf3eV6\n\t nyRaAhkYXGXQ5NbYIbS+6770JoPgcfcEIVjagVv5wAqwxz1S4huT4iEWzq5dW1/il3\n\t Gqn+au3KwRwcw==", "From": "Florian Eckert <fe@dev.tdt.de>", "Date": "Mon, 30 Mar 2026 11:07:13 +0200", "Subject": "[PATCH v2 3/7] PCI: intel-gw: Enable clock before phy init", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-ID": "<20260330-pcie-intel-gw-v2-3-8bd07367a298@dev.tdt.de>", "References": "<20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de>", "In-Reply-To": "<20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de>", "To": "Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy?=\n\t=?utf-8?q?=C5=84ski?= <kwilczynski@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>, Johan Hovold <johan+linaro@kernel.org>,\n Sajid Dalvi <sdalvi@google.com>, Ajay Agarwal <ajayagarwal@google.com>,\n Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n Rahul Tanwar <rtanwar@maxlinear.com>", "Cc": "linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, Florian Eckert <fe@dev.tdt.de>,\n\tEckert.Florian@googlemail.com, ms@dev.tdt.de", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1774861650; l=2080;\n i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id;\n bh=coHmsdtqcsW+dKyhuAd7vn7jGgDFbg9jYRqHLyenC9w=;\n b=T7awTZDD/b7+5jEOtcR4CkLqqj61lqSA8enPoRPazwosA0itEgbgpwu+gglvzKCRpTT1so2Uw\n SdhHrH9PH9ZAcddIOzuilxpL6qU4agJRCrQ+7qoKyempnq7wdfaMzp2", "X-Developer-Key": "i=fe@dev.tdt.de; a=ed25519;\n pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk=", "X-purgate-ID": "151534::1774861652-EF422842-845B70A9/0/0", "X-purgate": "clean", "X-purgate-type": "clean" }, "content": "To ensure that the boot sequence is correct, the dwc pcie core clock must\nbe switched on before phy init call [1]. This changes are based on patched\nkernel sources of the MaxLinear SDK.\n\n[1] https://github.com/maxlinear/linux/blob/updk_9.1.90/drivers/pci/controller/dwc/pcie-intel-gw.c#L544\n\nSigned-off-by: Florian Eckert <fe@dev.tdt.de>\n---\n drivers/pci/controller/dwc/pcie-intel-gw.c | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c\nindex e88b8243cc41c607c39e4d58c4dcd8c8c082e8b0..6d9499d954674a26a74bff56b7fb5759767424c0 100644\n--- a/drivers/pci/controller/dwc/pcie-intel-gw.c\n+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c\n@@ -291,13 +291,9 @@ static int intel_pcie_host_setup(struct intel_pcie *pcie)\n \n \tintel_pcie_core_rst_assert(pcie);\n \tintel_pcie_device_rst_assert(pcie);\n-\n-\tret = phy_init(pcie->phy);\n-\tif (ret)\n-\t\treturn ret;\n-\n \tintel_pcie_core_rst_deassert(pcie);\n \n+\t/* Controller clock must be provided earlier than PHY */\n \tret = clk_prepare_enable(pcie->core_clk);\n \tif (ret) {\n \t\tdev_err(pcie->pci.dev, \"Core clock enable failed: %d\\n\", ret);\n@@ -306,13 +302,17 @@ static int intel_pcie_host_setup(struct intel_pcie *pcie)\n \n \tpci->atu_base = pci->dbi_base + 0xC0000;\n \n+\tret = phy_init(pcie->phy);\n+\tif (ret)\n+\t\tgoto phy_err;\n+\n \tintel_pcie_ltssm_disable(pcie);\n \tintel_pcie_link_setup(pcie);\n \tintel_pcie_init_n_fts(pci);\n \n \tret = dw_pcie_setup_rc(&pci->pp);\n \tif (ret)\n-\t\tgoto app_init_err;\n+\t\tgoto err;\n \n \tdw_pcie_upconfig_setup(pci);\n \n@@ -321,17 +321,18 @@ static int intel_pcie_host_setup(struct intel_pcie *pcie)\n \n \tret = dw_pcie_wait_for_link(pci);\n \tif (ret)\n-\t\tgoto app_init_err;\n+\t\tgoto err;\n \n \tintel_pcie_core_irq_enable(pcie);\n \n \treturn 0;\n \n-app_init_err:\n+err:\n+\tphy_exit(pcie->phy);\n+phy_err:\n \tclk_disable_unprepare(pcie->core_clk);\n clk_err:\n \tintel_pcie_core_rst_assert(pcie);\n-\tphy_exit(pcie->phy);\n \n \treturn ret;\n }\n", "prefixes": [ "v2", "3/7" ] }