Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217626/?format=api
{ "id": 2217626, "url": "http://patchwork.ozlabs.org/api/patches/2217626/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330090944.1008027-8-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330090944.1008027-8-lulu@redhat.com>", "list_archive_url": null, "date": "2026-03-30T08:58:15", "name": "[RFC,v3,7/7] net/filter-redirector: check CAP_NET_RAW before creating AF_PACKET", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "14a181bba2efc8cf2dc17cff0f86e103e13fa347", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330090944.1008027-8-lulu@redhat.com/mbox/", "series": [ { "id": 497984, "url": "http://patchwork.ozlabs.org/api/series/497984/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497984", "date": "2026-03-30T08:58:09", "name": "net/filter: Add AF_PACKET support for vhost-net", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497984/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217626/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KkRxtZcT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fklqN5BFKz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 20:11:28 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w78eO-0006Wb-WC; Mon, 30 Mar 2026 05:11:13 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1w78e2-0006EW-Nt\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 05:10:55 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1w78e1-0000Qd-7t\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 05:10:50 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-dfcDTA4NNOeE5keocY1m2w-1; Mon,\n 30 Mar 2026 05:10:44 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 851451944B13; Mon, 30 Mar 2026 09:10:43 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.39])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 44B2319560B1; Mon, 30 Mar 2026 09:10:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774861848;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UIjxUX2mjHNiOeF8MWR0J6MRSnLuzQeAzy0f09dGBzM=;\n b=KkRxtZcTsR827KA28SmbegKweBCZNogA+TgXuBWsvIt1vQ0ZGn/EqZXlEI4zvqbwEOakcl\n RtPWPpP0nDYtuqRVZaeetZAcoqUnoA5WAHwwdCdO45MWE3r6UqBRY+UE/hY3dpd0By6kqZ\n NeZvjhnltC/eVvUA8JsxoRp++koBWzU=", "X-MC-Unique": "dfcDTA4NNOeE5keocY1m2w-1", "X-Mimecast-MFC-AGG-ID": "dfcDTA4NNOeE5keocY1m2w_1774861843", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, jmarcin@redhat.com, qemu-devel@nongnu.org", "Subject": "[RFC v3 7/7] net/filter-redirector: check CAP_NET_RAW before creating\n AF_PACKET", "Date": "Mon, 30 Mar 2026 16:58:15 +0800", "Message-ID": "<20260330090944.1008027-8-lulu@redhat.com>", "In-Reply-To": "<20260330090944.1008027-1-lulu@redhat.com>", "References": "<20260330090944.1008027-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Creating an AF_PACKET SOCK_RAW socket requires the CAP_NET_RAW\ncapability. Without it the qemu_socket() call fails with EPERM,\nproducing a generic error that gives no hint about the missing\ncapability.\n\nAdd an explicit capget()-based check in filter_redirector_netdev_setup()\nbefore the socket call.\n\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n net/filter-mirror.c | 24 ++++++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/net/filter-mirror.c b/net/filter-mirror.c\nindex 165a7ee1ea..a521eec02b 100644\n--- a/net/filter-mirror.c\n+++ b/net/filter-mirror.c\n@@ -34,6 +34,8 @@\n #include <net/if.h>\n #include <linux/if_packet.h>\n #include <netinet/if_ether.h>\n+#include <linux/capability.h>\n+#include <sys/syscall.h>\n \n typedef struct MirrorState MirrorState;\n DECLARE_INSTANCE_CHECKER(MirrorState, FILTER_MIRROR,\n@@ -579,6 +581,21 @@ static void filter_redirector_maybe_enable_read_poll(NetFilterState *nf)\n }\n }\n \n+static bool filter_redirector_has_cap_net_raw(void)\n+{\n+ struct __user_cap_header_struct hdr = {\n+ .version = _LINUX_CAPABILITY_VERSION_3,\n+ .pid = 0,\n+ };\n+ struct __user_cap_data_struct data[2] = {};\n+\n+ if (syscall(SYS_capget, &hdr, data) < 0) {\n+ return false;\n+ }\n+\n+ return data[CAP_NET_RAW >> 5].effective & (1u << (CAP_NET_RAW & 31));\n+}\n+\n static bool filter_redirector_netdev_setup(NetFilterState *nf, Error **errp)\n {\n MirrorState *s = FILTER_REDIRECTOR(nf);\n@@ -615,6 +632,13 @@ static bool filter_redirector_netdev_setup(NetFilterState *nf, Error **errp)\n return false;\n }\n \n+ if (!filter_redirector_has_cap_net_raw()) {\n+ error_setg(errp,\n+ \"AF_PACKET raw socket requires CAP_NET_RAW; \"\n+ \"run with 'setcap cap_net_raw+ep <qemu-binary>' or as root\");\n+ return false;\n+ }\n+\n fd = qemu_socket(AF_PACKET, SOCK_RAW | SOCK_NONBLOCK, htons(ETH_P_ALL));\n if (fd < 0) {\n error_setg_errno(errp, errno, \"failed to create AF_PACKET socket\");\n", "prefixes": [ "RFC", "v3", "7/7" ] }