Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217622/?format=api
{ "id": 2217622, "url": "http://patchwork.ozlabs.org/api/patches/2217622/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330090944.1008027-4-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330090944.1008027-4-lulu@redhat.com>", "list_archive_url": null, "date": "2026-03-30T08:58:11", "name": "[RFC,v3,3/7] net/filter-redirector: add AF_PACKET netdev setup helpers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0cb55df0248483fc73c8294da70f926e5bc5118f", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330090944.1008027-4-lulu@redhat.com/mbox/", "series": [ { "id": 497984, "url": "http://patchwork.ozlabs.org/api/series/497984/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497984", "date": "2026-03-30T08:58:09", "name": "net/filter: Add AF_PACKET support for vhost-net", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497984/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217622/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217622/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HbqI5c4/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fklpC5CgBz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 20:10:27 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w78dS-0005SK-VJ; Mon, 30 Mar 2026 05:10:15 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1w78dQ-0005Q3-SF\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 05:10:12 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1w78dO-0000NX-Vl\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 05:10:12 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-0eCi7j8tP_iSZyg5YERkfA-1; Mon,\n 30 Mar 2026 05:10:06 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C93C618005B3; Mon, 30 Mar 2026 09:10:05 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.39])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7F34C30001A1; Mon, 30 Mar 2026 09:10:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774861810;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RRWno4DoMHQAFKmIk4fJA+2FKgaKaWQkcckpkoQAejg=;\n b=HbqI5c4/18vBvE2PtiJOHlKmEDiXsSVYGBwA7/D0RozOEuli0P3lWJ2ORTY6xMgY/I1LDc\n ejFJL5l9+nu9UNjE7/6i2wOblkT2cJ5FRzSNeAXprpvH1qEunN/VMEDhg7sKbzCMriENcs\n 6OgNLmrVhqlX43u8SFrWQ6fK09T6Ta0=", "X-MC-Unique": "0eCi7j8tP_iSZyg5YERkfA-1", "X-Mimecast-MFC-AGG-ID": "0eCi7j8tP_iSZyg5YERkfA_1774861806", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, jmarcin@redhat.com, qemu-devel@nongnu.org", "Subject": "[RFC v3 3/7] net/filter-redirector: add AF_PACKET netdev setup\n helpers", "Date": "Mon, 30 Mar 2026 16:58:11 +0800", "Message-ID": "<20260330090944.1008027-4-lulu@redhat.com>", "In-Reply-To": "<20260330090944.1008027-1-lulu@redhat.com>", "References": "<20260330090944.1008027-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-5", "X-Spam_score": "-0.6", "X-Spam_bar": "/", "X-Spam_report": "(-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Prepare filter-redirector for direct TAP access through AF_PACKET sockets.\n\nAdd the setup-side plumbing needed by later capture/inject changes:\n- extend MirrorState with dedicated AF_PACKET fds and a capture buffer\n- resolve the TAP ifname from the backend fd\n- create and bind a nonblocking AF_PACKET socket on that interface\n- store the socket as the capture or inject endpoint based on the\n redirector role\n- clean up the AF_PACKET resources from cleanup/finalize paths\n\nThis commit only prepares the sockets and object state. The actual\ncapture and inject datapaths are added by follow-up commits.\n\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n net/filter-mirror.c | 91 +++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 91 insertions(+)", "diff": "diff --git a/net/filter-mirror.c b/net/filter-mirror.c\nindex ab711e8835..d9f6a11d6b 100644\n--- a/net/filter-mirror.c\n+++ b/net/filter-mirror.c\n@@ -22,10 +22,18 @@\n #include \"qemu/error-report.h\"\n #include \"trace.h\"\n #include \"chardev/char-fe.h\"\n+#include \"net/vhost_net.h\"\n #include \"qemu/iov.h\"\n #include \"qemu/sockets.h\"\n #include \"block/aio-wait.h\"\n #include \"system/runstate.h\"\n+#include \"net/tap.h\"\n+#include \"net/tap_int.h\"\n+\n+#include <sys/socket.h>\n+#include <net/if.h>\n+#include <linux/if_packet.h>\n+#include <netinet/if_ether.h>\n \n typedef struct MirrorState MirrorState;\n DECLARE_INSTANCE_CHECKER(MirrorState, FILTER_MIRROR,\n@@ -40,6 +48,9 @@ struct MirrorState {\n NetFilterState parent_obj;\n char *indev;\n char *outdev;\n+ int in_netfd;\n+ uint8_t *in_netbuf;\n+ int out_netfd;\n CharFrontend chr_in;\n CharFrontend chr_out;\n SocketReadState rs;\n@@ -267,6 +278,15 @@ static void filter_redirector_cleanup(NetFilterState *nf)\n qemu_chr_fe_deinit(&s->chr_in, false);\n qemu_chr_fe_deinit(&s->chr_out, false);\n qemu_del_vm_change_state_handler(s->vmsentry);\n+ if (s->in_netfd >= 0) {\n+ qemu_set_fd_handler(s->in_netfd, NULL, NULL, NULL);\n+ close(s->in_netfd);\n+ s->in_netfd = -1;\n+ }\n+ if (s->out_netfd >= 0) {\n+ close(s->out_netfd);\n+ s->out_netfd = -1;\n+ }\n \n if (nf->netdev) {\n nf->netdev->allow_send_when_stopped = 0;\n@@ -360,6 +380,70 @@ static void filter_redirector_maybe_enable_read_poll(NetFilterState *nf)\n }\n }\n \n+static bool filter_redirector_netdev_setup(NetFilterState *nf, Error **errp)\n+{\n+ MirrorState *s = FILTER_REDIRECTOR(nf);\n+ struct sockaddr_ll sll = { 0 };\n+ char ifname[IFNAMSIZ] = { 0 };\n+ bool capture_role;\n+ bool inject_role;\n+ int ifindex;\n+ int fd;\n+ NetClientState *nc = nf->netdev;\n+ int tapfd;\n+\n+ if (!nc || nc->info->type != NET_CLIENT_DRIVER_TAP) {\n+ return true;\n+ }\n+\n+ capture_role = s->outdev && !s->indev && get_vhost_net(nc);\n+ inject_role = s->indev && !s->outdev && get_vhost_net(nc);\n+ if (!capture_role && !inject_role) {\n+ return true;\n+ }\n+\n+ tapfd = tap_get_fd(nc);\n+ if (tapfd < 0 || tap_fd_get_ifname(tapfd, ifname) != 0) {\n+ error_setg(errp, \"failed to resolve TAP ifname for netdev '%s'\",\n+ nf->netdev_id);\n+ return false;\n+ }\n+\n+ ifindex = if_nametoindex(ifname);\n+ if (!ifindex) {\n+ error_setg_errno(errp, errno,\n+ \"failed to resolve ifindex for '%s'\", ifname);\n+ return false;\n+ }\n+\n+ fd = qemu_socket(AF_PACKET, SOCK_RAW | SOCK_NONBLOCK, htons(ETH_P_ALL));\n+ if (fd < 0) {\n+ error_setg_errno(errp, errno, \"failed to create AF_PACKET socket\");\n+ return false;\n+ }\n+\n+ sll.sll_family = AF_PACKET;\n+ sll.sll_ifindex = ifindex;\n+ sll.sll_protocol = htons(ETH_P_ALL);\n+ if (bind(fd, (struct sockaddr *)&sll, sizeof(sll)) < 0) {\n+ error_setg_errno(errp, errno,\n+ \"failed to bind AF_PACKET socket for ifname '%s'\",\n+ ifname);\n+ close(fd);\n+ return false;\n+ }\n+\n+ if (capture_role) {\n+ s->in_netfd = fd;\n+ g_free(s->in_netbuf);\n+ s->in_netbuf = g_malloc(REDIRECTOR_MAX_LEN);\n+ } else {\n+ s->out_netfd = fd;\n+ }\n+\n+ return true;\n+}\n+\n static void filter_redirector_setup(NetFilterState *nf, Error **errp)\n {\n MirrorState *s = FILTER_REDIRECTOR(nf);\n@@ -410,6 +494,10 @@ static void filter_redirector_setup(NetFilterState *nf, Error **errp)\n }\n }\n \n+ if (!filter_redirector_netdev_setup(nf, errp)) {\n+ return;\n+ }\n+\n s->vmsentry = qemu_add_vm_change_state_handler(\n filter_redirector_vm_state_change, nf);\n \n@@ -623,6 +711,8 @@ static void filter_redirector_init(Object *obj)\n MirrorState *s = FILTER_REDIRECTOR(obj);\n \n s->vnet_hdr = false;\n+ s->in_netfd = -1;\n+ s->out_netfd = -1;\n }\n \n static void filter_mirror_fini(Object *obj)\n@@ -638,6 +728,7 @@ static void filter_redirector_fini(Object *obj)\n \n g_free(s->indev);\n g_free(s->outdev);\n+ g_free(s->in_netbuf);\n }\n \n static const TypeInfo filter_redirector_info = {\n", "prefixes": [ "RFC", "v3", "3/7" ] }