Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217527/?format=api
{ "id": 2217527, "url": "http://patchwork.ozlabs.org/api/patches/2217527/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330-aoa-i2sbus-ofnode-lifetime-v1-1-51c309f4ff06@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260330-aoa-i2sbus-ofnode-lifetime-v1-1-51c309f4ff06@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260330-aoa-i2sbus-ofnode-lifetime-v1-1-51c309f4ff06@gmail.com/", "date": "2026-03-30T04:00:34", "name": "ALSA: aoa: i2sbus: fix OF node lifetime handling", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "901f866a9a8064e57aa6ea8d7e9e72cdd65a723f", "submitter": { "id": 93004, "url": "http://patchwork.ozlabs.org/api/people/93004/?format=api", "name": "Cássio Gabriel", "email": "cassiogabrielcontato@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330-aoa-i2sbus-ofnode-lifetime-v1-1-51c309f4ff06@gmail.com/mbox/", "series": [ { "id": 497948, "url": "http://patchwork.ozlabs.org/api/series/497948/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497948", "date": "2026-03-30T04:00:34", "name": "ALSA: aoa: i2sbus: fix OF node lifetime handling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497948/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217527/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2217527/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18989-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mLlH6X5x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18989-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1229\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mLlH6X5x;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::1229; helo=mail-dl1-x1229.google.com;\n envelope-from=cassiogabrielcontato@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkdJB4YVDz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 15:17:30 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fkdJ941Cpz2xpt;\n\tMon, 30 Mar 2026 15:17:29 +1100 (AEDT)", "from mail-dl1-x1229.google.com (mail-dl1-x1229.google.com\n [IPv6:2607:f8b0:4864:20::1229])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fkcwt20vxz2xlK\n\tfor <linuxppc-dev@lists.ozlabs.org>; Mon, 30 Mar 2026 15:00:45 +1100 (AEDT)", "by mail-dl1-x1229.google.com with SMTP id\n a92af1059eb24-12a74039dc6so2992693c88.0\n for <linuxppc-dev@lists.ozlabs.org>;\n Sun, 29 Mar 2026 21:00:45 -0700 (PDT)", "from [192.168.1.18] (177-4-161-254.user3p.v-tal.net.br.\n [177.4.161.254])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12ab970da7fsm6715590c88.0.2026.03.29.21.00.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2026 21:00:42 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774843247;\n\tcv=none;\n b=cQxayPbFPt57Ap1uFoOmoLDubD6Q+qTxNUQj3zFx6HlqTgmw5Uk86676vkTQBferfvi1X8EMgjxP4kw3quS+3vrm8uqWi++Uu5iIq4rZnLXO9t4SoUnYQJWDSiZNF568bVoSU2jkVaYBizbjtDeVssAdmZQlM4z224Z01Yn3LcgSXQKDX1mllmyk7lM1isqag7AYSusSCUpzGcGDzc5vPgJImt1cFcZwzH6WQB9/kCCsMLBafqDTkjiqtJ4eFsmPqkNWP8gQpa2r06BmFZWKB6A0sOcwsDbUdI1+cpPfvn+TmfzTXKEqCvW6MT6Q3eFp7zxOhAQMLrPhz/WsvcoFOA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774843247; c=relaxed/relaxed;\n\tbh=2MiznXVnaOQN1Ty0L+R2YmSXm0gykn8v0J+C8W1yOKA=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=KA6hAgUSYplKSuzzgG/7oy+66v3bG+JmRyTk3RYslsnOu6wA7LOz5Lg6dDyw4GsprlotcDcLIGxITirkL82n0QP0VhlpKHBhfxKE1iFiuxTI7gfnQDRVtNMB9zTIZ6WpQrRvTK/80lctDjoQ87taJKmQP8Ny5CCRIdA8xdZf4KY1hOe1tq+lUM/TZGSw+ztbELdggbwSh9TrQJqdiDH5mH3QMmH2pzExc2BLlbAgdAVdkJHYEMIuvTSVKURbBG0paDRaS8Ksy73UNahGBYW2bRADxMa/41WFq+1DVBCoX6z2T0d3wy/OhYPvsyNxTF/SXhJtnL81rPyteqDjuRgtcA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mLlH6X5x; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1229; helo=mail-dl1-x1229.google.com;\n envelope-from=cassiogabrielcontato@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774843243; x=1775448043;\n darn=lists.ozlabs.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=2MiznXVnaOQN1Ty0L+R2YmSXm0gykn8v0J+C8W1yOKA=;\n b=mLlH6X5xcqjme+I8sceSmZwbH4H6rz0RMJKWN/dLcMk7kwholzcYLO5q2pA0KPmYtt\n b+ZcwjdO7f/jKC8l9Z1M2VwDD4+sExh6ov/jKw4izTO/Nefz254cGgD315RQfCucv14W\n RfXCt7hMxvLx2gfjfptswdtGe/UP7MHRtd0GX1JPGEvWI6Xa213aOAZaxDbZKpw7uJoU\n kNfaVkyRwkuU1uyVz34EgkS/rL0roVxibYi1jJzM1+ABNEjPY7ZP1k1ugnKMtU9NHC3M\n +2ud+CTMFs2ppCl3XbZ+0mD/OQwxqATEVg5gNG4gzVy7Vsdhu6QYY3ehRQFc60SP1wYg\n EJ7A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774843243; x=1775448043;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2MiznXVnaOQN1Ty0L+R2YmSXm0gykn8v0J+C8W1yOKA=;\n b=ptC2lN3IV5P/jeUpM3XiMvXX5vnOyUhQQ97hh/emk3o7xciKRMhQXRA06vhsEGrWOs\n MktzrDe8Yxsl6DWt1Efpk3bspIcMHu0Tkp/fq2jVuxJaTmjDW6d+Un8zZDYZ/jivtyMG\n ipA7jl/kVoLcol5EwvQDS1p/gubLJRpt3rW/Aa3JMclebPC8qfhD+RFMxyEXoAbLDYAh\n 5HcaiY6Z5q6eNxz6Gg+H9PwvfFgqkwlecgxE7MDfsOwZtQauezi2ZdRP9nSsGNUUwgNH\n KoRZt4V/dONhZWBnIfyqxW7Fx9mWXgk4/RzzzxBmWauzdGFm0sX0ystEvW7/XUR/5Y0i\n VIUA==", "X-Gm-Message-State": "AOJu0Yxxx8yl6riFXczVKhQ/XB1/ylDGgvzx9fbKTMg6dCjxt4eQxS0E\n\tHoC+2EX2x8Pz1j8416rTmNKvfObfPQEigDgHc9hQaOu2lOkJx/ALwDLp", "X-Gm-Gg": "ATEYQzxFbepr3IMbpKqfRkSP20M/6VRI5MHzUhkaZZUk3bQfjooP0t4Iat0seV1oXoX\n\tGijRLysU5cKDPRvJEbrbANDshqD1moqM1Pjr+1P+IeEViHnzPzuv5lwUeyFEUyA6H5oC8r0Qnrc\n\tNFMtU/wyJRyDrntxi9yD0BbtqQNg/5XXfXBeLXBuLzyf5SvapzXah9QKn+9qN4HBZc8Iawsfx8B\n\t91+vcOILaN2S9w3GNugeny06YMOaC2F4fVDYWK+RGO3+S7DL3cVluKNHsYIfOMjB0tDM5/Ux4F+\n\t3WUNXtCNAgU9lwh03sliwwBe1hXQk1Vx82C8ihegkfzjFRzfWL9slPBg27xj9DHKRzvRz4OItv9\n\tc92BWQDghGmpzM0NftaQZD+T3FX27pAd5z94GXQmkumliy+gWsh9niee9oFvc76qbqedgzsrxHI\n\t47e6UMgDmJPpXoOZ0XK+wOs3H8MHy4vZUvUN79XcXT6gw5DpmhkNs9Ar0KRKvq1KB1uiDp62pyI\n\tf0IAcoYtrK8aCU=", "X-Received": "by 2002:a05:7022:6887:b0:12a:8ea4:24d with SMTP id\n a92af1059eb24-12ab28d13fcmr5818158c88.19.1774843242791;\n Sun, 29 Mar 2026 21:00:42 -0700 (PDT)", "From": "=?utf-8?q?C=C3=A1ssio_Gabriel?= <cassiogabrielcontato@gmail.com>", "Date": "Mon, 30 Mar 2026 01:00:34 -0300", "Subject": "[PATCH] ALSA: aoa: i2sbus: fix OF node lifetime handling", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260330-aoa-i2sbus-ofnode-lifetime-v1-1-51c309f4ff06@gmail.com>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/yXMywrCMBBG4Vcps3agTr1QX0W6SJM/OqKJZFoRS\n t/dqHA23+YsZCgKo1OzUMFLTXOq2G4a8leXLmAN1SStHNpOenbZsYqNs3GOKQfwXSMmfYD3Rwm\n 73qOrUR08C6K+f/Pz8LfN4w1++h5pXT/b61n9fgAAAA==", "X-Change-ID": "20260329-aoa-i2sbus-ofnode-lifetime-572d49ce3ce3", "To": "Johannes Berg <johannes@sipsolutions.net>,\n Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>", "Cc": "linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,\n linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssi?=\n\t=?utf-8?q?o_Gabriel?= <cassiogabrielcontato@gmail.com>", "X-Mailer": "b4 0.15.1", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3170;\n i=cassiogabrielcontato@gmail.com; h=from:subject:message-id;\n bh=PlmjxGt4JGDRqDssZg/k5xlqGZcdiyv/+rwibqyvJPk=;\n b=owGbwMvMwCV2IdZeKur/u2bG02pJDJknv2aUvCrkz2m7q6S9zJlV0mjjbw39tPLC1LoTJw9F6\n 7Lax3F3lLIwiHExyIopsqxOWmS5p+vB1fq4FR4wc1iZQIYwcHEKwERqjzAynF77b78RV7eAssbv\n 3Xds3ddcPeUtXO93Nqqg4xfrq2WzyhkZLuyVq/7X+cN3hj5Tt3ixb1ioyod3Pg191cV6F04/2Gn\n GAwA=", "X-Developer-Key": "i=cassiogabrielcontato@gmail.com; a=openpgp;\n fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "i2sbus_add_dev() keeps the matched \"sound\" child pointer after\nfor_each_child_of_node() has dropped the iterator reference. Take an\nextra reference before saving that node and drop it after the\nlayout-id/device-id lookup is complete.\n\nThe function also stores np in dev->sound.ofdev.dev.of_node without\ntaking a reference for the embedded soundbus device. Since i2sbus\noverrides the embedded platform device release callback, balance that\nreference explicitly in the local error path and in i2sbus_release_dev().\n\nFixes: f3d9478b2ce4 (\"[ALSA] snd-aoa: add snd-aoa\")\nCc: stable@vger.kernel.org\nSigned-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>\n---\n sound/aoa/soundbus/i2sbus/core.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)\n\n\n---\nbase-commit: bea8d9e445caf009ccadc17c353cc82f07885dd6\nchange-id: 20260329-aoa-i2sbus-ofnode-lifetime-572d49ce3ce3\n\nBest regards,\n-- \nCássio Gabriel <cassiogabrielcontato@gmail.com>", "diff": "diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c\nindex 22c956267f4e..833c44c0a950 100644\n--- a/sound/aoa/soundbus/i2sbus/core.c\n+++ b/sound/aoa/soundbus/i2sbus/core.c\n@@ -84,6 +84,7 @@ static void i2sbus_release_dev(struct device *dev)\n \tfor (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++)\n \t\tfree_irq(i2sdev->interrupts[i], i2sdev);\n \ti2sbus_control_remove_dev(i2sdev->control, i2sdev);\n+\tof_node_put(i2sdev->sound.ofdev.dev.of_node);\n \tmutex_destroy(&i2sdev->lock);\n \tkfree(i2sdev);\n }\n@@ -147,7 +148,6 @@ static int i2sbus_get_and_fixup_rsrc(struct device_node *np, int index,\n }\n \n /* Returns 1 if added, 0 for otherwise; don't return a negative value! */\n-/* FIXME: look at device node refcounting */\n static int i2sbus_add_dev(struct macio_dev *macio,\n \t\t\t struct i2sbus_control *control,\n \t\t\t struct device_node *np)\n@@ -178,8 +178,9 @@ static int i2sbus_add_dev(struct macio_dev *macio,\n \ti = 0;\n \tfor_each_child_of_node(np, child) {\n \t\tif (of_node_name_eq(child, \"sound\")) {\n+\t\t\tof_node_put(sound);\n \t\t\ti++;\n-\t\t\tsound = child;\n+\t\t\tsound = of_node_get(child);\n \t\t}\n \t}\n \tif (i == 1) {\n@@ -205,6 +206,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,\n \t\t\t}\n \t\t}\n \t}\n+\tof_node_put(sound);\n \t/* for the time being, until we can handle non-layout-id\n \t * things in some fabric, refuse to attach if there is no\n \t * layout-id property or we haven't been forced to attach.\n@@ -219,7 +221,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,\n \tmutex_init(&dev->lock);\n \tspin_lock_init(&dev->low_lock);\n \tdev->sound.ofdev.archdata.dma_mask = macio->ofdev.archdata.dma_mask;\n-\tdev->sound.ofdev.dev.of_node = np;\n+\tdev->sound.ofdev.dev.of_node = of_node_get(np);\n \tdev->sound.ofdev.dev.dma_mask = &dev->sound.ofdev.archdata.dma_mask;\n \tdev->sound.ofdev.dev.parent = &macio->ofdev.dev;\n \tdev->sound.ofdev.dev.release = i2sbus_release_dev;\n@@ -327,6 +329,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,\n \tfor (i=0;i<3;i++)\n \t\trelease_and_free_resource(dev->allocated_resource[i]);\n \tmutex_destroy(&dev->lock);\n+\tof_node_put(dev->sound.ofdev.dev.of_node);\n \tkfree(dev);\n \treturn 0;\n }\n", "prefixes": [] }