Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217516/?format=api
{ "id": 2217516, "url": "http://patchwork.ozlabs.org/api/patches/2217516/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260330025400.2010331-4-chris.chiu@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330025400.2010331-4-chris.chiu@canonical.com>", "list_archive_url": null, "date": "2026-03-30T02:53:55", "name": "[SRU,R,3/7] ASoC: SDCA: Improve mapping of Q7.8 SDCA volumes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "96fd19591287ed5c7e96bfc501c3e26619dd848a", "submitter": { "id": 81418, "url": "http://patchwork.ozlabs.org/api/people/81418/?format=api", "name": "Chris Chiu", "email": "chris.chiu@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260330025400.2010331-4-chris.chiu@canonical.com/mbox/", "series": [ { "id": 497946, "url": "http://patchwork.ozlabs.org/api/series/497946/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=497946", "date": "2026-03-30T02:53:52", "name": "Enable audio functions on Dell Huracan/Renegade platforms w/o built-in microphone", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497946/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217516/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=oqj/6RjG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkbSb2mwJz1yGk\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 13:54:38 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1w72lq-0001Lg-TC; Mon, 30 Mar 2026 02:54:30 +0000", "from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <chris.chiu@canonical.com>)\n id 1w72lq-0001LN-GK\n for kernel-team@lists.ubuntu.com; Mon, 30 Mar 2026 02:54:30 +0000", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 66DB63F071\n for <kernel-team@lists.ubuntu.com>; Mon, 30 Mar 2026 02:54:30 +0000 (UTC)", "by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-485345e2fdfso23718015e9.2\n for <kernel-team@lists.ubuntu.com>; Sun, 29 Mar 2026 19:54:30 -0700 (PDT)", "from localhost.localdomain (211-75-139-218.hinet-ip.hinet.net.\n [211.75.139.218]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48730628efasm242867945e9.5.2026.03.29.19.54.27\n for <kernel-team@lists.ubuntu.com>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2026 19:54:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1774839270;\n bh=BPxvqCcq5WkOwzNGl4tbGu5bdbFr4YA4JkiSANj4oHw=;\n h=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=oqj/6RjG7NGIldg3/82Gcyx3vslV/htEdGb+Qg4HIWLYbqEc897bgOrcRzoxcsMV7\n lkLOnTm+2l6Uwpe2fhlwq8NPKNjM8hb3QYV3k0Q9cyyjzFVgFRNQOMOSsXGTYNuKft\n 8cPezcgv4uZjXaDtfor0YXygF+jVZN5V8wcoL9awJKs6kmnJMiLI1eyfevTH79F9v7\n F4p6m1CMvmrMfRDwo0GzBOjijWeLHjfKjJFwSIk1URG6OE0/YzaQ2ipnSg881OTy+J\n 6Y04Tv/Y6NNspxCzXkLCH3UO6eusLIpyYk06iXezBD+N8BC+MJwIp238Bge+M8Pt5q\n 5DiKyh64FU/hYDOoWISBtLKTfjKlDX2tmNuyiiU8/GuqlHpXF8Tzlrg9BAtIDp+2Q2\n VVKDTaasQB7j2UihBO8IREzSMML1pyLJr1llShznhpE0Pfq/dJL8Rl40ohjj+qLC2o\n CGFOCI9Ldb+zcgBr6B9tpdPjsbWRRfseVXbej7xQUxzx8Cx9mbUbQqycHJ1/dHNtDr\n OOFEjBLwFlY1Y4qshoO2k/OffM3qDzSwj9ST+ced4AkIUvm0nDGKNvaU7sDYm30mNv\n z79rJ1vMOaHjkcE1TItaigj/CKzdaMYiX1LTuSpQsWYVyOtQaaCP3D6ryVxP3T7pKH\n CZqWR7dSE3CA6EbWvPsOkFEY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774839270; x=1775444070;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=BPxvqCcq5WkOwzNGl4tbGu5bdbFr4YA4JkiSANj4oHw=;\n b=fKlNa8bAKxNqsUH1ez+ukcwhtCx30NZ1wosRt1zVabMFQCB+nl9M4Bk0dMtcew6C7r\n cGvKmw4IZAmGrPrK37Zi3PJ4MXv8PiLJRtg6nq3pzsCfgz35Mv4JHSO7LOGc+HX1d0/i\n FrLPy6tyFq/sMceRDSecY5ocZFaXoKyhR4BWlkUIAotgcmHAAipGJrsmAD0/Ru+Z2h4l\n 9YBzfQTwtLgyxkGUuP638XSr2anVMIqQjnNLmmcRB/Ru4TMYokkEb/pZtAvoUwm5m+ls\n hRl2kofWYF2dKR59Mp0vYxsS3Q5peu2ByKfh33C9LlPyMNUNVuMa8WzXK8LcZYrtV7wd\n etDg==", "X-Gm-Message-State": "AOJu0YwhfH8OVIZ1aU3mOUF+M3Nd4Hp2++Vm97NioZjsJZK5qkbvSkjr\n aIbeKF7QRB69oqoPegV7oe4qrlBg5HcsyQq9ctGu6S4XYOq9sXyJs2BnlTdLmNCHKL8eBU0nq/O\n HJBNPxJLSV4/WDA+2CK7mCxqk1TECwkyG+EZvV8VA5+bErr+uB5wVrBf8Ha+1/uLxl7bukhRUCj\n 6zXvoJddnBs5oNzw==", "X-Gm-Gg": "ATEYQzxQ5Dz4AbAYSj3Z3HzBX/rxAUgG4laoT0sBYZRLAXFSLgyDfD/Nqxe+McrQzCE\n eI8hWjVUf2uqE+ggF0rRxm+gqetinCOvDhFQ4giDmLqxAYvqtrIh2zQRcEafvbM1GTeMcCYJnXO\n zTExLFjhn/yb+iyS7h02bM95mQUI7Z8ntOT9mzUyY9hmcoVFBd5bpIC6C6E2Udb3PyRB/nZ8bKF\n 2dGa1tkTO6kM0CCnmYaRrAviSCtErBjJR/okqumW2cRjc1u7L8pA1f+JRJJVqCydP4TNCXAsQEO\n gJgm21McH+tfQ/ovmTGOuuLhml9FztOLomFSwUn6ZJevC02+MT0PJsFaY/tH6vcc+bCm4foesw/\n UmBlzYWWGYk4bGAq+hK22py8KOytI4voBqNgqJIcYsGBY+C7Jjh67ULJ4SJlhmjglV73VhBiKgY\n vb", "X-Received": [ "by 2002:a05:600c:4f53:b0:485:45fb:3472 with SMTP id\n 5b1f17b1804b1-48727ee9872mr182359235e9.7.1774839269636;\n Sun, 29 Mar 2026 19:54:29 -0700 (PDT)", "by 2002:a05:600c:4f53:b0:485:45fb:3472 with SMTP id\n 5b1f17b1804b1-48727ee9872mr182358915e9.7.1774839269155;\n Sun, 29 Mar 2026 19:54:29 -0700 (PDT)" ], "From": "Chris Chiu <chris.chiu@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[SRU][R][PATCH 3/7] ASoC: SDCA: Improve mapping of Q7.8 SDCA volumes", "Date": "Mon, 30 Mar 2026 02:53:55 +0000", "Message-ID": "<20260330025400.2010331-4-chris.chiu@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260330025400.2010331-1-chris.chiu@canonical.com>", "References": "<20260330025400.2010331-1-chris.chiu@canonical.com>", "MIME-Version": "1.0", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "From: Charles Keepax <ckeepax@opensource.cirrus.com>\n\nBugLink: https://bugs.launchpad.net/bugs/2143902\n\nSDCA measures volumes in 256ths of a dB, whereas ALSA measures\nvolumes in 100ths of a dB. Currently the SDCA volume controls are\nmapped to ALSA controls by mapping the step size and working out\nthe number of steps for this mapped step size. Due to quantization\nof the step size this means the number of steps in the ALSA\ncontrol will rarely match the number of steps in the SDCA control,\nleading to skipped values and multiple values that map to the\nsame volume. This is not a huge problem, the volume is still\nincreasing and the differences will be small but it is not really\ndesirable.\n\nIt is simpler and more accurate to count the number of steps based on\nthe SDCA volume levels. This gives a 1-to-1 mapping between control\nvalues and register volumes. The TLV is based on a minimum and maximum\nvolume so still accurately specifies the volume range.\n\nTested-by: Richard Fitzgerald <rf@opensource.cirrus.com>\nReviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>\nSigned-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>\nLink: https://patch.msgid.link/20260225140118.402695-4-ckeepax@opensource.cirrus.com\nSigned-off-by: Mark Brown <broonie@kernel.org>\n(cherry picked from commit d4f7d5a9a0f963dc895c18084425ce332a80d3a8 linux-next)\nSigned-off-by: Chris Chiu <chris.chiu@canonical.com>\n---\n sound/soc/sdca/sdca_asoc.c | 6 ++----\n sound/soc/soc-ops.c | 12 ++----------\n 2 files changed, 4 insertions(+), 14 deletions(-)", "diff": "diff --git a/sound/soc/sdca/sdca_asoc.c b/sound/soc/sdca/sdca_asoc.c\nindex 49cbf38b7adb..beee024622a5 100644\n--- a/sound/soc/sdca/sdca_asoc.c\n+++ b/sound/soc/sdca/sdca_asoc.c\n@@ -805,10 +805,8 @@ static int control_limit_kctl(struct device *dev,\n \ttlv[2] = (min * 100) >> 8;\n \ttlv[3] = (max * 100) >> 8;\n \n-\tstep = (step * 100) >> 8;\n-\n-\tmc->min = ((int)tlv[2] / step);\n-\tmc->max = ((int)tlv[3] / step);\n+\tmc->min = min / step;\n+\tmc->max = max / step;\n \tmc->shift = step;\n \tmc->sign_bit = 15;\n \tmc->sdca_q78 = 1;\ndiff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c\nindex 624e9269fc25..133a2e6fbd7a 100644\n--- a/sound/soc/soc-ops.c\n+++ b/sound/soc/soc-ops.c\n@@ -120,25 +120,17 @@ static int sdca_soc_q78_reg_to_ctl(struct soc_mixer_control *mc, unsigned int re\n \t\treturn -EINVAL;\n \n \tval = sign_extend32(val, mc->sign_bit);\n-\tval = (((val * 100) >> 8) / (int)mc->shift);\n-\tval -= mc->min;\n \n-\treturn val & mask;\n+\treturn ((val / mc->shift) - mc->min) & mask;\n }\n \n static unsigned int sdca_soc_q78_ctl_to_reg(struct soc_mixer_control *mc, int val,\n \t\t\t\t\t unsigned int mask, unsigned int shift, int max)\n {\n-\tunsigned int ret_val;\n-\tint reg_val;\n-\n \tif (WARN_ON(!mc->shift))\n \t\treturn -EINVAL;\n \n-\treg_val = val + mc->min;\n-\tret_val = (int)((reg_val * mc->shift) << 8) / 100;\n-\n-\treturn ret_val & mask;\n+\treturn ((val + mc->min) * mc->shift) & mask;\n }\n \n static int soc_mixer_reg_to_ctl(struct soc_mixer_control *mc, unsigned int reg_val,\n", "prefixes": [ "SRU", "R", "3/7" ] }