Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217510/?format=api
{ "id": 2217510, "url": "http://patchwork.ozlabs.org/api/patches/2217510/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260329231754.2325557-3-vineet.gupta@linux.dev/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260329231754.2325557-3-vineet.gupta@linux.dev>", "list_archive_url": null, "date": "2026-03-29T23:17:53", "name": "[2/3] bpf: md: fix \"*movsi\" to generate wN regs [PR124688]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "066ca08a59f94b73f0f3c594f54d4cc4234d964e", "submitter": { "id": 82303, "url": "http://patchwork.ozlabs.org/api/people/82303/?format=api", "name": "Vineet Gupta", "email": "vineet.gupta@linux.dev" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260329231754.2325557-3-vineet.gupta@linux.dev/mbox/", "series": [ { "id": 497942, "url": "http://patchwork.ozlabs.org/api/series/497942/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=497942", "date": "2026-03-29T23:17:51", "name": "bpf: Enable wN reg codegen for bug-fix and fun", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497942/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217510/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=lpdEHAsB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=lpdEHAsB", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev", "sourceware.org; spf=pass smtp.mailfrom=linux.dev", "server2.sourceware.org;\n arc=none smtp.remote-ip=95.215.58.173" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkVjH17fQz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 10:20:19 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 38AA94B9DB56\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 23:20:17 +0000 (GMT)", "from out-173.mta1.migadu.com (out-173.mta1.migadu.com\n [95.215.58.173])\n by sourceware.org (Postfix) with ESMTPS id 248B64BA23ED\n for <gcc-patches@gcc.gnu.org>; Sun, 29 Mar 2026 23:18:18 +0000 (GMT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 38AA94B9DB56", "OpenDKIM Filter v2.11.0 sourceware.org 248B64BA23ED" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 248B64BA23ED", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 248B64BA23ED", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774826299; cv=none;\n b=ulYLLZdwcs27Koscswdqnpedjc0MaQiYmXrDubhidgd/5Lxlrmf+JKc+Z1o3Z/6yy8CiNDwoblNiG0EmO1zfV9QM5epxKxB1Di3xnz6FJ58lkM/8Id+TrgAuow8RrBRprXf31pOswdytAw66ijF0AqL/o5k4dKrVap7YQJYSdjY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774826299; c=relaxed/simple;\n bh=cIbQOaSYrVZISbxuMDE4SfzvjcZs3IQ5j5mBnPoesBk=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=XO4CR4FhK5xKBfokhoi1kktJUsjiZy8Jt4slbTywFmoIgzwHo/DKX9qVpNdBX/6P9gBLfBZKD6lgQQAC3h4EYCZYn3NrGdHO79iz69dxTLjyppYPATcwnLOsXj6mFQ4iVtgDqzlPlAhI/ylT3O9ouNrp12jd5zjJfE4ag9iMXWc=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "X-Report-Abuse": "Please report any abuse attempt to abuse@migadu.com and\n include these headers.", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;\n t=1774826296;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OCWFHbhNFJ+ktfM3IV2/r4Ay6c0kVwLdRShv/ZKsH9w=;\n b=lpdEHAsBxBE+pnD5K5Tz+PvMmI1NEE43Zn6Otx22gnqQ/kfcx+qAMLuzmDxsJ4yBhjIMer\n +FzAoblp7UyKAK4P49fjjmEvdcpXE04r7BwTlCOCsJwkR0hhULRFgPaeHijkwbYQOvmP7V\n Dbbzqyhm+rqWA8rLwy/auunWTXcmjhY=", "From": "Vineet Gupta <vineet.gupta@linux.dev>", "To": "bpf@gcc.gnu.org", "Cc": "gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com, ast@kernel.org,\n Eduard Zingerman <eddyz87@gmail.com>,\n Yonghong Song <yonghong.song@linux.dev>, Vineet Gupta <gvineet@fb.com>,\n Vineet Gupta <vineet.gupta@linux.dev>", "Subject": "[PATCH 2/3] bpf: md: fix \"*movsi\" to generate wN regs [PR124688]", "Date": "Sun, 29 Mar 2026 16:17:53 -0700", "Message-ID": "<20260329231754.2325557-3-vineet.gupta@linux.dev>", "In-Reply-To": "<20260329231754.2325557-1-vineet.gupta@linux.dev>", "References": "<20260329231754.2325557-1-vineet.gupta@linux.dev>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Migadu-Flow": "FLOW_OUT", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Vineet Gupta <gvineet@fb.com>\n\nmovsi currently only generates DImode rN regs, despite RTL being SImode.\n\n| (insn 14 5 11 (set (reg:SI 1 %r1 [23])\n| (reg:SI 0 %r0)) {*movsi}\n| (expr_list:REG_DEAD (reg:SI 0 %r0)\n| (nil)))\n\ngenerates\n\n| r1 = r0\n\nas opposed to\n\n| w1 = w0\n\nThis is not just issue of taste or getting more wN regs. As\nillustrated by test, this can be a correctness issue where mov\nneeds to zero out the upper bits.\n\nAgain the issue is asm teplmate of pattern missing 'w' specifier,\nleading bpf_print_register() to only generate 64-bit rN regs.\nUsing 'w' allows either wN/rN reg depending on the mode.\n\n\tPR target/124688\n\ngcc/ChangeLog:\n\n\t* config/bpf/bpf.md (*movsi): Add 'w' to asm template.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.target/bpf/ret-reuse-arg-1.c: New test.\n\nSigned-off-by: Vineet Gupta <vineet.gupta@linux.dev>\n---\n gcc/config/bpf/bpf.md | 10 +++++-----\n gcc/testsuite/gcc.target/bpf/ret-reuse-arg-1.c | 14 ++++++++++++++\n 2 files changed, 19 insertions(+), 5 deletions(-)\n create mode 100644 gcc/testsuite/gcc.target/bpf/ret-reuse-arg-1.c", "diff": "diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md\nindex a2bceb8998d7..e6776a94e7e4 100644\n--- a/gcc/config/bpf/bpf.md\n+++ b/gcc/config/bpf/bpf.md\n@@ -383,11 +383,11 @@\n (match_operand:MM 1 \"mov_src_operand\" \" q,rIc,BC,r,I\"))]\n \"\"\n \"@\n- *return bpf_output_move (operands, \\\"{ldx<mop>\\t%0,%1|%0 = *(<smop> *) %1}\\\");\n- *return bpf_output_move (operands, \\\"{mov\\t%0,%1|%0 = %1}\\\");\n- *return bpf_output_move (operands, \\\"{lddw\\t%0,%1|%0 = %1 ll}\\\");\n- *return bpf_output_move (operands, \\\"{stx<mop>\\t%0,%1|*(<smop> *) %0 = %1}\\\");\n- *return bpf_output_move (operands, \\\"{st<mop>\\t%0,%1|*(<smop> *) %0 = %1}\\\");\"\n+ *return bpf_output_move (operands, \\\"{ldx<mop>\\t%0,%1|%w0 = *(<smop> *) %w1}\\\");\n+ *return bpf_output_move (operands, \\\"{mov\\t%0,%1|%w0 = %w1}\\\");\n+ *return bpf_output_move (operands, \\\"{lddw\\t%0,%1|%w0 = %w1 ll}\\\");\n+ *return bpf_output_move (operands, \\\"{stx<mop>\\t%0,%1|*(<smop> *) %w0 = %w1}\\\");\n+ *return bpf_output_move (operands, \\\"{st<mop>\\t%0,%1|*(<smop> *) %w0 = %w1}\\\");\"\n [(set_attr \"type\" \"ldx,alu,alu,stx,st\")])\n \n ;;;; Shifts\ndiff --git a/gcc/testsuite/gcc.target/bpf/ret-reuse-arg-1.c b/gcc/testsuite/gcc.target/bpf/ret-reuse-arg-1.c\nnew file mode 100644\nindex 000000000000..6d0a4f280cd7\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/bpf/ret-reuse-arg-1.c\n@@ -0,0 +1,14 @@\n+/* Return value of first call is arg to second call. */\n+\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -mcpu=v4\" } */\n+\n+int ret_int ();\n+void arg_int (int);\n+\n+void foo () {\n+ arg_int(ret_int ());\n+}\n+\n+/* { dg-final { scan-assembler-not {r1 = r0} } } */\n+/* { dg-final { scan-assembler-times {w1 = w0} 1 } } */\n", "prefixes": [ "2/3" ] }