Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217491/?format=api
{ "id": 2217491, "url": "http://patchwork.ozlabs.org/api/patches/2217491/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165217.241038-1-tpluszz77@gmail.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260329165217.241038-1-tpluszz77@gmail.com>", "list_archive_url": null, "date": "2026-03-29T16:52:17", "name": "netfilter: ctnetlink: zero expect NAT fields when CTA_EXPECT_NAT absent", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "9564033008af9810d196739a939f8d6eacbe8018", "submitter": { "id": 93002, "url": "http://patchwork.ozlabs.org/api/people/93002/?format=api", "name": "Qi Tang", "email": "tpluszz77@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165217.241038-1-tpluszz77@gmail.com/mbox/", "series": [ { "id": 497933, "url": "http://patchwork.ozlabs.org/api/series/497933/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497933", "date": "2026-03-29T16:52:17", "name": "netfilter: ctnetlink: zero expect NAT fields when CTA_EXPECT_NAT absent", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497933/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217491/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11485-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=AmMljpc0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11485-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"AmMljpc0\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkL7H2t4jz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 03:53:47 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 981DD3019518\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 16:52:30 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7DA9738229B;\n\tSun, 29 Mar 2026 16:52:29 +0000 (UTC)", "from mail-pj1-f50.google.com (mail-pj1-f50.google.com\n [209.85.216.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0955A37F75A\n\tfor <netfilter-devel@vger.kernel.org>; Sun, 29 Mar 2026 16:52:27 +0000 (UTC)", "by mail-pj1-f50.google.com with SMTP id\n 98e67ed59e1d1-35d971fbcddso517492a91.1\n for <netfilter-devel@vger.kernel.org>;\n Sun, 29 Mar 2026 09:52:27 -0700 (PDT)", "from localhost.localdomain ([47.236.127.140])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c22b9fc96sm9854141a91.7.2026.03.29.09.52.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2026 09:52:25 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774803149; cv=none;\n b=u5FUppBFAW0iR6tNRThFttkUbwjVhx9QEJjOiVu8800d2MNP7hHAfDT/iVHoe8BQrT2WM1aBRY7j9IPXiYHgpLBTAyIsg433cvvVp3SFg/3ZCjdupFOC+dzrmhI0Jxor4AMEkTNujdKa2qkyCN8vuBzHZqS8le7TjSedOKvY/nI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774803149; c=relaxed/simple;\n\tbh=b2bwpUQRoHCr+Bn8QVQtUP36sssXWqkwyRequ+KE2dU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=luYOKPTTqNZ8i3A+eqRpXBujZ82aaz9Ui6CWaxlt4CFVxzGNZfiG7CHz8pG8PXWanJClhZ8GKkCQyvkiXvNMuNzsxOoI+F6gYq9xz4Q8D9tKmrmJ5ThM5fBTLCIeWAjYlVdnuE+TfuCnSpGVokbZOXDHS4vPh+BpgUxgtVwaFEE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=AmMljpc0; arc=none smtp.client-ip=209.85.216.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774803147; x=1775407947;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=1/dtluh18hHrnfgX94Rzw61kxdR4s6K+3hZ7ZcF6n8c=;\n b=AmMljpc0Dv4XFB84YTntmrQkUY5mzH0/ux74qKHgKpvqvUVIj/aA028gnMWUNC4eIK\n e912tcIrIW4a1aWnVuNAoXN/ne6C1IWz7ooy5kGsy7VddvVWX3vXsulsTyJLI14p++PT\n euLypg215+g8Y2Ea+VnwLfndmQBpWSt3ASPrq/qDcqQODK7wvTvedO4bbcp7EbRsv79q\n nZWZbAfKpruXf+41bILJSKvqTqlJfU13J/2FyAZ32xok5iehEoNrHVynBNbxUPdjgBB0\n TcmB3m5uNaFm05Kx0aIoPgir/DilTemFHyJLZ807N63wH1XzHgu/qq9fdsC5FPv616Ga\n XCkA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774803147; x=1775407947;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1/dtluh18hHrnfgX94Rzw61kxdR4s6K+3hZ7ZcF6n8c=;\n b=bPdw0fdVyIi1PxdWtkIsUhvD8QSrAZZQn+AqKeOSaAMxi02dnzy/cIBbrAJrU+dM+X\n 36v/EZ92k5o2lE2SLsqN5vkmUREeKH3NbmUK+4KYKufAlgdCxIRrsZ2CzCzzX0ZI/FRV\n TkCSZ87YMuOjFVa/SbCJmKiW3lecBStjVPRti6rRk0QdOFrFUwIXwIl+rkg/mnN35kI8\n 0HxJo//+9GtSOSLFcpeu0Nj6xRXuBVEactPGcv9qJnOV9EScBgdueIN3MI8jbzUA+G6r\n lcZTNcYBDcbIeg0vDuJXvniNsBjsKcfNGx8/VYg/zC6hI8TJdYCVPeoxjlJZJiEZ7BM0\n JW0A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWz4pAuyCRY2VTkt8GYEPdu3r/6j8PBHZyq21gkegdktl2C+vmq6/36fzeBpjb1hWeY70U4wXWMHCtJ8fYVGfs=@vger.kernel.org", "X-Gm-Message-State": "AOJu0YxXZ5B6VHvTAqR6xd17jVYRLzfAX2sAdImah5pNWX8j42P5bTTV\n\t4EtXGDJZupRFI3BfQbiHHD+j82QjT9IcWjybepHLv1ut0MjIePgXmc2r", "X-Gm-Gg": "ATEYQzzCF5VyRitU1sl41nW7MgtfxNKBcG6QeclWFMmFDEozZ8r54jPUBsCCKWJLx7j\n\t3vKWbSXG8P3puAqYZ7BHdIDwBFn6dQDY/2U6CQF30iwTfni4brai2H1e+ZMBsv3Iwwes6TxPhIh\n\tamCPDagaYX0hEpyIuuq4+GVAJMznkGKomuKUqpkO2ePA1TPHYuavH5Z7NSPiP5bLhzBC6bcfDjG\n\tdS+q/4mrbV6vy+ukm4rhPdMgTD7UwkGgSuo6T5tpOqDmvwcGw3dwLlbAiOmJK4+ksnp8Lu3w2mb\n\t3+28mYf/WQWZYqp2Mi9lfPtp4cQB5AOUvDxxQ1WnsodkRPqNtiLxTWK/D1r6ghl0+2iVztQQrR4\n\tHQjZ0bbtPhHx1AoZNbNJ1+cQ0THJSN5hsy/o1NIPdtqcypg2NuUtMMXtfreGKWFu2n5Zv77940t\n\tYyia9QfRo1eTMHhK2gQ1drmH4NKFjb+QBi9N4=", "X-Received": "by 2002:a17:90a:1108:b0:35d:9276:eba7 with SMTP id\n 98e67ed59e1d1-35d9276f7b1mr3183202a91.7.1774803147220;\n Sun, 29 Mar 2026 09:52:27 -0700 (PDT)", "From": "Qi Tang <tpluszz77@gmail.com>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tQi Tang <tpluszz77@gmail.com>", "Subject": "[PATCH] netfilter: ctnetlink: zero expect NAT fields when\n CTA_EXPECT_NAT absent", "Date": "Mon, 30 Mar 2026 00:52:17 +0800", "Message-ID": "<20260329165217.241038-1-tpluszz77@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "ctnetlink_alloc_expect() allocates expectations from a non-zeroing\nslab cache via nf_ct_expect_alloc(). When CTA_EXPECT_NAT is not\npresent in the netlink message, saved_addr and saved_proto are\nnever initialized. Stale data from a previous slab occupant can\nthen be dumped to userspace by ctnetlink_exp_dump_expect(), which\nchecks these fields to decide whether to emit CTA_EXPECT_NAT.\n\nThe safe sibling nf_ct_expect_init(), used by the packet path,\nexplicitly zeroes these fields.\n\nZero saved_addr and saved_proto in the else branch so that\nexpectations created without NAT metadata cannot leak kernel heap\ncontents to userspace.\n\nConfirmed by priming the expect slab with NAT-bearing expectations,\nfreeing them, creating a new expectation without CTA_EXPECT_NAT,\nand observing that the ctnetlink dump emits a spurious\nCTA_EXPECT_NAT containing stale data from the prior allocation.\n\nFixes: 076a0ca02644 (\"netfilter: ctnetlink: add NAT support for expectations\")\nSigned-off-by: Qi Tang <tpluszz77@gmail.com>\n---\n net/netfilter/nf_conntrack_netlink.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c\nindex c57c665363e0..c152079f5ac7 100644\n--- a/net/netfilter/nf_conntrack_netlink.c\n+++ b/net/netfilter/nf_conntrack_netlink.c\n@@ -3593,6 +3593,10 @@ ctnetlink_alloc_expect(const struct nlattr * const cda[], struct nf_conn *ct,\n \t\t\t\t\t\t exp, nf_ct_l3num(ct));\n \t\tif (err < 0)\n \t\t\tgoto err_out;\n+\t} else {\n+\t\tmemset(&exp->saved_addr, 0, sizeof(exp->saved_addr));\n+\t\tmemset(&exp->saved_proto, 0, sizeof(exp->saved_proto));\n+\t\texp->dir = 0;\n \t}\n \treturn exp;\n err_out:\n", "prefixes": [] }