Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217490/?format=api
{ "id": 2217490, "url": "http://patchwork.ozlabs.org/api/patches/2217490/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165036.240932-1-tpluszz77@gmail.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260329165036.240932-1-tpluszz77@gmail.com>", "list_archive_url": null, "date": "2026-03-29T16:50:36", "name": "netfilter: nf_conntrack_helper: pass helper to expect cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8b94e9f7b1a4d9fe3783265c739f027c19d2a218", "submitter": { "id": 93002, "url": "http://patchwork.ozlabs.org/api/people/93002/?format=api", "name": "Qi Tang", "email": "tpluszz77@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165036.240932-1-tpluszz77@gmail.com/mbox/", "series": [ { "id": 497932, "url": "http://patchwork.ozlabs.org/api/series/497932/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497932", "date": "2026-03-29T16:50:36", "name": "netfilter: nf_conntrack_helper: pass helper to expect cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497932/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217490/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217490/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11483-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=RLnAJ29P;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11483-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"RLnAJ29P\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.176", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkL6H3bbYz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 03:52:55 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 723CD30160D3\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 16:50:50 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9FAC2382291;\n\tSun, 29 Mar 2026 16:50:49 +0000 (UTC)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F573822B4\n\tfor <netfilter-devel@vger.kernel.org>; Sun, 29 Mar 2026 16:50:44 +0000 (UTC)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-82a07738118so2066789b3a.0\n for <netfilter-devel@vger.kernel.org>;\n Sun, 29 Mar 2026 09:50:44 -0700 (PDT)", "from localhost.localdomain ([47.236.127.140])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82ca8498489sm4708920b3a.27.2026.03.29.09.50.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2026 09:50:43 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774803049; cv=none;\n b=eY3XRevEZYarEsmn+/MxJWLaz2kLbHr4uX67LFnxHjzglQJnSzxXb2/I8WlYfR041XSsasBQYZtSSUCmt4Zuj4PmWySE833z6pi+BPjv/sZjUOW8/1wstpeEngkuCw80RiRn38yWq410S6Pgc34QGDV/licnWS2cOJbBiPHUPu4=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774803049; c=relaxed/simple;\n\tbh=B8Wh+OKhBzmwRsiBIJtM2UgSuJEeudpnLpYyPMFLMFg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=GVxyEuC0hetKbKEZyIA63CJhUrkdO0YGZgjb/Hwu2jtBvSdBxvht/0cIoh6kkk+tiMfB0Nhqp5k8EjerPR0KEqGZ+YId4R7j6cFfxIMzRpBAm4Qa52gQx0uaa1kFZxi3x/guj79gNYWjUBqVao/W+iEocOy8k/UzF8FVbxNzl0E=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=RLnAJ29P; arc=none smtp.client-ip=209.85.210.176", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774803043; x=1775407843;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=DPnBm+ae0zOwy+ktvv0TAbSToo1fEQfvYGqtSpxCLrQ=;\n b=RLnAJ29PfdpYVP/XF0P++SG4GuVZBJNYRiUL87iLUVtlA0ChcSKCVZqfYtiuDtnGEh\n Jfgk2+ExJ4Hj4LzvXqSP1Hc6OqoNZAKe1lyShyDcFwDs7lyLtuYn0Z/Pfd8Ph9xBH3lJ\n g2w8dbxlLIFpn4K6lwIjliBnQ/2A7LZz8HWtFoBbyf7QzXqvcERW/x1eQ+8lyCpui+0H\n P9owGmY2tgDWgcFP29C2NQHt1tfLNpON9Oet4a9I8D3SAhPYy1JsPJQ3KpJ7LtsofYpU\n m1/hs7UW5sksgoXU31jzxAQiiWJUvpLbOcQV4CBLSCyfgUWFtkYnSc8u2gJPE+CU+9Tq\n QsEA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774803043; x=1775407843;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DPnBm+ae0zOwy+ktvv0TAbSToo1fEQfvYGqtSpxCLrQ=;\n b=qGZhaxzEXEKkPEG9sqT8Q8XR7f48iGgom3DQkOVToPdfB6bWKunJLS/qVWuafhA3Hz\n tb5habbItjskr5BTknDzc1kb9Pz43wyKGnJT23EoBAjVS1ICv4gEGNnrSLgN8p8Lc+M7\n cj2v0zAaX2q1oSmZDa+Wxu/zP6Re5QXtWEFCpp+1dncSAcqVK5BhJ/E6uyOG2NIFE3WE\n kEmZc6oLX3AZGbVrTb4GN+lFetff84QVMlBXiPVDBOmaPCxfOBR8EqN77OTX7ASEolmw\n xL6tucJkurw6bWUW0oXKWqYQvR+VCRdhXkgEi76PRRicFISecYapzZ0JPPacXeMGCDbf\n Sv+A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWmKCFEbCBWXE2SERyF8ze7LQeJr7i251zbOSRxMeyM+mTmIF5m0qTuxsoKMsErR+yMFYZFg6YhJfBsyyUk9t0=@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yxe45ttsHkptBEtUADsuDVHYSrj6YTwwJZK2MXNEUu31NrjB8SO\n\thuI6uaAvgyWnYyHRZ9Rd3J34/rzLDk6dhofCLPUBsrw2AawfBrVM0QQk", "X-Gm-Gg": "ATEYQzxYMcpeprG2Yo+MLS8XV1HIQG9LiFPR8CyGe+D3CrNjm9MjEkfowt6+kO+2ehZ\n\tRWiuZBCI2yi/b8g/TlqhCqTxhDz25AXP8D4wdNbsJVZ6zEHCpfoU9vm/p4uCqkHNhC5Qt2viy9/\n\taihmtwhgmpdP3l5YoJIhXO5H0j66deYx4JNq/IdxYJ81LafW17ZabzgDR+XvzhKFimIQ1Ts0jo0\n\tUBwjDJEc/CJo/pr60b1dPcLrAG88X+M+K3H1Oadn/WL91/2gMi89UFMUxHI5K2CV6RZ45X2s8yq\n\t/mCqvOm60EPUpl/ESiDemFKtwvhvkS83rUPA34rbFwrrMBbo6XGKf/JMjcgSvA/aWDWJ8LQvHsh\n\tnI5q9jXC/OoxrCCMncITcGHOQHwmg0IgtzPUlZn57rSAoDel/Y1QycSnRL4npGTIY8aN3JhT9io\n\tasbl3ORrNRXWvaM2eQyeOlKIPT9A50r6RkalH11XRSUNqtvA==", "X-Received": "by 2002:a05:6a00:2d9c:b0:829:862d:6b46 with SMTP id\n d2e1a72fcca58-82c95e58edcmr8610359b3a.6.1774803043470;\n Sun, 29 Mar 2026 09:50:43 -0700 (PDT)", "From": "Qi Tang <tpluszz77@gmail.com>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tQi Tang <tpluszz77@gmail.com>", "Subject": "[PATCH] netfilter: nf_conntrack_helper: pass helper to expect cleanup", "Date": "Mon, 30 Mar 2026 00:50:36 +0800", "Message-ID": "<20260329165036.240932-1-tpluszz77@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "nf_conntrack_helper_unregister() calls nf_ct_expect_iterate_destroy()\nto remove expectations belonging to the helper being unregistered.\nHowever, it passes NULL instead of the helper pointer as the data\nargument, so expect_iter_me() never matches any expectation and all\nof them survive the cleanup.\n\nAfter unregister returns, nfnl_cthelper_del() frees the helper\nobject immediately. Subsequent expectation dumps or packet-driven\ninit_conntrack() calls then dereference the freed exp->helper,\ncausing a use-after-free.\n\nPass the actual helper pointer so expectations referencing it are\nproperly destroyed before the helper object is freed.\n\n BUG: KASAN: slab-use-after-free in string+0x38f/0x430\n Read of size 1 at addr ffff888003b14d20 by task poc/103\n Call Trace:\n string+0x38f/0x430\n vsnprintf+0x3cc/0x1170\n seq_printf+0x17a/0x240\n exp_seq_show+0x2e5/0x560\n seq_read_iter+0x419/0x1280\n proc_reg_read+0x1ac/0x270\n vfs_read+0x179/0x930\n ksys_read+0xef/0x1c0\n Freed by task 103:\n The buggy address is located 32 bytes inside of\n freed 192-byte region [ffff888003b14d00, ffff888003b14dc0)\n\nFixes: ac7b84839003 (\"netfilter: expect: add and use nf_ct_expect_iterate helpers\")\nSigned-off-by: Qi Tang <tpluszz77@gmail.com>\n---\n net/netfilter/nf_conntrack_helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c\nindex 1b330ba6613b..a715304a53d8 100644\n--- a/net/netfilter/nf_conntrack_helper.c\n+++ b/net/netfilter/nf_conntrack_helper.c\n@@ -415,7 +415,7 @@ void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me)\n \t */\n \tsynchronize_rcu();\n \n-\tnf_ct_expect_iterate_destroy(expect_iter_me, NULL);\n+\tnf_ct_expect_iterate_destroy(expect_iter_me, me);\n \tnf_ct_iterate_destroy(unhelp, me);\n \n \t/* nf_ct_iterate_destroy() does an unconditional synchronize_rcu() as\n", "prefixes": [] }