Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217489/?format=api
{ "id": 2217489, "url": "http://patchwork.ozlabs.org/api/patches/2217489/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165131.240989-1-tpluszz77@gmail.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260329165131.240989-1-tpluszz77@gmail.com>", "list_archive_url": null, "date": "2026-03-29T16:51:31", "name": "netfilter: ctnetlink: validate expect class against master helper", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2314b47166e011163e68416f8646fbc4dbe2c877", "submitter": { "id": 93002, "url": "http://patchwork.ozlabs.org/api/people/93002/?format=api", "name": "Qi Tang", "email": "tpluszz77@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260329165131.240989-1-tpluszz77@gmail.com/mbox/", "series": [ { "id": 497931, "url": "http://patchwork.ozlabs.org/api/series/497931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497931", "date": "2026-03-29T16:51:31", "name": "netfilter: ctnetlink: validate expect class against master helper", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497931/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217489/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217489/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11484-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QbNMOS4w;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11484-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"QbNMOS4w\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.51", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkL5V1zHSz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 03:52:14 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 4A8C83014565\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 16:51:44 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 79F8A37DEBC;\n\tSun, 29 Mar 2026 16:51:42 +0000 (UTC)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBCC3815FD\n\tfor <netfilter-devel@vger.kernel.org>; Sun, 29 Mar 2026 16:51:40 +0000 (UTC)", "by mail-pj1-f51.google.com with SMTP id\n 98e67ed59e1d1-358e3cc5e7eso1784290a91.0\n for <netfilter-devel@vger.kernel.org>;\n Sun, 29 Mar 2026 09:51:40 -0700 (PDT)", "from localhost.localdomain ([47.236.127.140])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c22ba5700sm10416654a91.8.2026.03.29.09.51.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2026 09:51:38 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774803102; cv=none;\n b=aAK3ck7b5KnyDdWzjvPA9JKEKcCLxgGtZjpsFFgF7E8LYTofVBzgjzTzkRtF3Q6kX3/X8apLpcM3AyqJvFLGoh9CuDJ1mJy9JWVI2LBHQgT75T282ClKsYxPzK+UbBrbmqVPOjj0J9L+0bUpPTywwZga/c+r8yv5fbPSPzhPxDg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774803102; c=relaxed/simple;\n\tbh=+/li8ir0cS6ptJjeq5uk7yw+iqBQNmezjlb7upWUo0U=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=PFbRXq9Y6YbV2q1rCuqtkfLe03tC7AGNS+txDpHj/ks8IQXf3egxb3suN+RcK/U155p+HsR9d8xLTuxao+UblV4ilCnH2a/T4giiHc8/PAafiG/USIQqfY/2dIOtLvQzNcocSohbpDvrlhvdjcNenOu9ChWZ1nFqeQ9eX/xKMtM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=QbNMOS4w; arc=none smtp.client-ip=209.85.216.51", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774803099; x=1775407899;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=SXMpi9W0ohIEOw0qI/5F6ExlkOwkg6UyfvzQqFC3OoM=;\n b=QbNMOS4wRUWU2R6DenjyxiucOrCYfXMqn1uIZ/2ZRnam2zRVtQz91YcgrJU4TzPAoy\n QReKhxtwVZHWk+g8VT9xGnwYEY+WnSpyIMNKWvhg54iH+i8Gca7RD1QKsRq2m4KBA19+\n fIe8dEPJeeMTTqDwfOB+RRTBujFnWB+RcfmBmUvCVt7zc7SZjRHecKidx88oUax7sXA4\n Q2JoxxZhPkQaNVsRuZZ+pg7D1YRMwcGoQMhmRPGQmjWhw5cY9I11Fs6xgwKnoUpwDgoL\n uLSqWJ8lG9aYpHP5+EvwNW/Byl7p43SB2l3yF1q17JhKll13x9R9ZF2OcTm/pJbVgfW4\n 0FOg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774803099; x=1775407899;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SXMpi9W0ohIEOw0qI/5F6ExlkOwkg6UyfvzQqFC3OoM=;\n b=Ouwj7BGjC/CvcY2EDUObIu6RKjZTnhwGU+xaMs/3BLP9Ks0OaU0m7ZmMSJi2p5jgNa\n vEBIwDf0mqh8byVXJTzWCz7/iQE1fGO5enGGRD89IO07HVlmemtsvASK4rl1t+M3e/d2\n 74tPDoc+CPUMRWRiSrdg2HBvZ73+lKiW+anB+RG+MhntgbQJ0LLeP+b/C0RDs5/emVio\n m1JS7PAaKSjtyjAunShZGn2sN26oRMT19iAmcRVqbD9yuiY/lg/qXzIRLW8lSDeGHWmh\n qCu2GafO8R2kVlk5h8O7XGhbBw4pXugUEs/nfdi5YUG3vSpDIX6fNZha1Xw93WiXyYE0\n DbSQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXwOBdt+vzvuuiD+ANGg7jFm5EwfCML46ZopL7hb0zqVDTAKgrnGWPniSthrFHWoHspkPA6hwbcuaSDsIeO7fM=@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yw+oDYyqpmyvKaDTADkUhw6MEMOc2ju0lT4IVyXU+2lt0B61MyI\n\tJLZ6uEI9qkLOhAHNJDPkjeHLllbGHna4BpiCBm9h2Ju74XkMFdhUBXRu", "X-Gm-Gg": "ATEYQzy5mbEHY9r9rZm7+x9m2q2NLfNRusPfg6ZT+IhEpvjALg/cYBflTnfZtqKerZk\n\tYNDtbtY1FC/jq0WmCfBAhNTmFIyYnRg1JdUAU9K4X3LiaADmsR3IaAxo/g0COeifwBaf/RJiRJh\n\thB2Sz75vLGxbM9S8kM5FxWJm3qK2iXP0GHLZ64zzbbf2NdwFkjSjyY0mWSTNYZZwp/oH7naFIdz\n\tb+VY6vWSkeDD7SQjtVdrbpgd9bhR9YE9vyP2OPEvAznROYopwAsa6fRIRqas9EaniyK1ASZ/QB7\n\tMvJ/9Z+HsGnocx0/MH3122XTZESAuMTU3rD48MK8ZAv4+kO4ME6yuv2X0UaL2VOt1e/M9xmU6XE\n\t3wON10dh21/9OfN3EewVsKijDtr03bSmjgIDDM3DBthYhZjcRokXXhikGWOOIswGVZ55YxF7MhY\n\twNNzrviwORY4oRXfG7V01WbskU4wQDePVrL6g=", "X-Received": "by 2002:a17:90b:164a:b0:35c:30a8:322 with SMTP id\n 98e67ed59e1d1-35c30a80a30mr9555894a91.0.1774803099575;\n Sun, 29 Mar 2026 09:51:39 -0700 (PDT)", "From": "Qi Tang <tpluszz77@gmail.com>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tQi Tang <tpluszz77@gmail.com>", "Subject": "[PATCH] netfilter: ctnetlink: validate expect class against master\n helper", "Date": "Mon, 30 Mar 2026 00:51:31 +0800", "Message-ID": "<20260329165131.240989-1-tpluszz77@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "ctnetlink_alloc_expect() validates CTA_EXPECT_CLASS against the\nhelper specified by CTA_EXPECT_HELP_NAME. However,\n__nf_ct_expect_check() and nf_ct_expect_insert() later index the\nexpect_policy array using the master conntrack's actual helper.\n\nWhen the supplied helper has a larger expect_class_max than the\nmaster's helper, the class passes validation but produces an\nout-of-bounds read on the master helper's heap-allocated policy\narray during expectation insertion.\n\nValidate the class against the master conntrack's own helper\ninstead, since that is the helper whose policy array will actually\nbe indexed.\n\n BUG: KASAN: slab-out-of-bounds in nf_ct_expect_related_report+0x2479/0x27c0\n Read of size 4 at addr ffff8880043fe408 by task poc/102\n Call Trace:\n nf_ct_expect_related_report+0x2479/0x27c0\n ctnetlink_create_expect+0x22b/0x3b0\n ctnetlink_new_expect+0x4bd/0x5c0\n nfnetlink_rcv_msg+0x67a/0x950\n netlink_rcv_skb+0x120/0x350\n\nFixes: b8c5e52c13ed (\"netfilter: ctnetlink: allow to set expectation class\")\nSigned-off-by: Qi Tang <tpluszz77@gmail.com>\n---\n net/netfilter/nf_conntrack_netlink.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c\nindex 3f408f3713bb..c57c665363e0 100644\n--- a/net/netfilter/nf_conntrack_netlink.c\n+++ b/net/netfilter/nf_conntrack_netlink.c\n@@ -3542,9 +3542,14 @@ ctnetlink_alloc_expect(const struct nlattr * const cda[], struct nf_conn *ct,\n \tif (!help)\n \t\treturn ERR_PTR(-EOPNOTSUPP);\n \n-\tif (cda[CTA_EXPECT_CLASS] && helper) {\n+\tif (cda[CTA_EXPECT_CLASS]) {\n+\t\tstruct nf_conntrack_helper *master_helper;\n+\n+\t\tmaster_helper = rcu_dereference(help->helper);\n+\t\tif (!master_helper)\n+\t\t\treturn ERR_PTR(-EOPNOTSUPP);\n \t\tclass = ntohl(nla_get_be32(cda[CTA_EXPECT_CLASS]));\n-\t\tif (class > helper->expect_class_max)\n+\t\tif (class > master_helper->expect_class_max)\n \t\t\treturn ERR_PTR(-EINVAL);\n \t}\n \texp = nf_ct_expect_alloc(ct);\n", "prefixes": [] }