Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217465/?format=api
{ "id": 2217465, "url": "http://patchwork.ozlabs.org/api/patches/2217465/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260329145122.126040-1-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260329145122.126040-1-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-03-29T14:50:49", "name": "[iwl-net,v1] igc: fix potential skb leak in igc_fpe_xmit_smd_frame()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0d5d05736db4f5e77b32374c2b92b6cd24f5157e", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260329145122.126040-1-kohei@enjuk.jp/mbox/", "series": [ { "id": 497920, "url": "http://patchwork.ozlabs.org/api/series/497920/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497920", "date": "2026-03-29T14:50:49", "name": "[iwl-net,v1] igc: fix potential skb leak in igc_fpe_xmit_smd_frame()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497920/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217465/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217465/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=fSzghTQm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkHQp67nNz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 01:52:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 9EB2A40C08;\n\tSun, 29 Mar 2026 14:51:58 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RXHeCJ_zCS8w; Sun, 29 Mar 2026 14:51:58 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DE3F540BEE;\n\tSun, 29 Mar 2026 14:51:57 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 506F010F\n for <intel-wired-lan@lists.osuosl.org>; Sun, 29 Mar 2026 14:51:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 429B540BEE\n for <intel-wired-lan@lists.osuosl.org>; Sun, 29 Mar 2026 14:51:57 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gmfp1NmDmYRS for <intel-wired-lan@lists.osuosl.org>;\n Sun, 29 Mar 2026 14:51:56 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 449AE40BCC\n for <intel-wired-lan@lists.osuosl.org>; Sun, 29 Mar 2026 14:51:55 +0000 (UTC)", "from ms-a2 (69.51.30.125.dy.iij4u.or.jp [125.30.51.69])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 62TEpO7F031324\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Sun, 29 Mar 2026 23:51:24 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org DE3F540BEE", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 449AE40BCC" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774795917;\n\tbh=gjOV5C00kY76/U1S/KKA1vjIbODY8S7kc+xpGzqxKak=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=fSzghTQms628rAsHXdYwaoAefJmMwDh1vMNxBJfnb/Ndk6Ygf3h3dNM7j/0+CJuWu\n\t 8c4X4YfWUdF4sUAf7IAcU1towoxFI2FutaPGM/QXmNpf913qLQKkpJ77Imiz0G34Rf\n\t rLA7Mx6o2c5qRyH3cuRKS3BsEdsix08rKemRl9HQK5Bv1b7znwYHOVeS3NlU08nKzn\n\t u3gd80kgBl02GtwzWdYh1R0mLFd3129H3BoVOB5oKSLNo3G9SiqPo36gbQ182IlcYF\n\t prxS5zfayr5Pt7w7vlJKZrIo1lx6tmOk8wJKdRmGV3ewNlokwnWcbWyU4z6DkhkSZP\n\t jHjCjyuwb/45Q==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 449AE40BCC", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,\n Kohei Enju <kohei@enjuk.jp>", "Date": "Sun, 29 Mar 2026 14:50:49 +0000", "Message-ID": "<20260329145122.126040-1-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=gjOV5C00kY76/U1S/KKA1vjIbODY8S7kc+xpGzqxKak=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:Message-ID:To:Subject:Date;\n s=rs20251215; t=1774795884; v=1;\n b=peKiOgFjTsQzG/E0esMgKXrrC0Q7IK5/gZjL48SrxeGbuVZJ072Mg1SOZKb1+XoF\n gJCaB1IBifsQIsYBPYhiRHemSDzi6idHYDSo36YpQ9qd8aa7/MS4hGDvL5c53l2E\n Hq4n1e1Dt9S+IGyLagaTTSAr6hw2JZBimeZRLcwXlkLo4IYEWBRyxr0wdtAEs93K\n CLJXlC5i7I/UQE2DjNZtVTpqmp3KCcnM4AyfMoJgIJAvFDrVWdcumu7km5jHuRGc\n CyITnQfBOYwK/LGRRYHMHu8sbpEc+m5SN32fLFAuu4qCcQWiyZxeOCXPAYZ5yVoB\n rQpWVa8X0JX0y/btsz9Z+Q==", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=peKiOgFj" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] igc: fix potential skb leak in\n igc_fpe_xmit_smd_frame()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When igc_fpe_init_tx_descriptor() fails, no one takes care of an\nallocated skb, leaking it. [1]\n\nUse dev_kfree_skb_any() on failure.\nAlso call igc_flush_tx_descriptors() only on success.\n\n[1]\nunreferenced object 0xffff88813aee1b40 (size 224):\n comm \"softirq\", pid 0, jiffies 4294709256\n[...]\n backtrace (crc dee31384):\n kmem_cache_alloc_node_noprof+0x54f/0x640\n __alloc_skb+0xd9/0x5b0\n igc_fpe_xmit_smd_frame.isra.0+0xad/0x510\n igc_fpe_send_mpacket+0x32/0x80\n[...]\n\nFixes: 5422570c0010 (\"igc: add support for frame preemption verification\")\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/igc/igc_tsn.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c\nindex 8a110145bfee..eaa274248d54 100644\n--- a/drivers/net/ethernet/intel/igc/igc_tsn.c\n+++ b/drivers/net/ethernet/intel/igc/igc_tsn.c\n@@ -109,10 +109,14 @@ static int igc_fpe_xmit_smd_frame(struct igc_adapter *adapter,\n \t__netif_tx_lock(nq, cpu);\n \n \terr = igc_fpe_init_tx_descriptor(ring, skb, type);\n-\tigc_flush_tx_descriptors(ring);\n+\tif (!err)\n+\t\tigc_flush_tx_descriptors(ring);\n \n \t__netif_tx_unlock(nq);\n \n+\tif (err)\n+\t\tdev_kfree_skb_any(skb);\n+\n \treturn err;\n }\n \n", "prefixes": [ "iwl-net", "v1" ] }