Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217425/?format=api
{ "id": 2217425, "url": "http://patchwork.ozlabs.org/api/patches/2217425/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/2__2tXx9Hngg7rDwgOdZVY8FFBkjQGk_0TviV3dVWkoCa9CZznTtxHJsVvgg9U0lyXUo-_6KKPTPFZTIGTLo9YfQczBj2CxTZypXB2ydr7c=@proton.me/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<2__2tXx9Hngg7rDwgOdZVY8FFBkjQGk_0TviV3dVWkoCa9CZznTtxHJsVvgg9U0lyXUo-_6KKPTPFZTIGTLo9YfQczBj2CxTZypXB2ydr7c=@proton.me>", "list_archive_url": null, "date": "2026-03-29T02:03:38", "name": "fs/smb/client: add verbose error logging for UNC parsing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ca4d76f70b8d8d8767254f86c582809ccf955fb8", "submitter": { "id": 92999, "url": "http://patchwork.ozlabs.org/api/people/92999/?format=api", "name": "FredTheDude", "email": "FredTheDude@proton.me" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/2__2tXx9Hngg7rDwgOdZVY8FFBkjQGk_0TviV3dVWkoCa9CZznTtxHJsVvgg9U0lyXUo-_6KKPTPFZTIGTLo9YfQczBj2CxTZypXB2ydr7c=@proton.me/mbox/", "series": [ { "id": 497892, "url": "http://patchwork.ozlabs.org/api/series/497892/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=497892", "date": "2026-03-29T02:03:38", "name": "fs/smb/client: add verbose error logging for UNC parsing", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497892/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217425/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217425/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10577-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=proton.me header.i=@proton.me header.a=rsa-sha256\n header.s=protonmail header.b=ERsfArzz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10577-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me\n header.b=\"ERsfArzz\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=109.224.244.25", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=proton.me", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=proton.me" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjyNd4BTCz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 13:04:01 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A1E49301B175\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 02:03:57 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2DC1478F39;\n\tSun, 29 Mar 2026 02:03:54 +0000 (UTC)", "from mail-24425.protonmail.ch (mail-24425.protonmail.ch\n [109.224.244.25])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4616B76025\n\tfor <linux-cifs@vger.kernel.org>; Sun, 29 Mar 2026 02:03:49 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774749834; cv=none;\n b=nLV/ugUgEBBtsAlt74ytWHBV6fnS20whP/sg2CKeqR2TnkUWc7xH4/vQxfQgZm4Wsjl5g5LzMPeLBVwH3R50bIUeCCa/2sTh2DzBzYHOJ5W5xdrNwuW4KS7rXQSykP+MKDDesX/gj1ML4cK2EuCbG91opbUDaXZ8PoAOQGq1PY0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774749834; c=relaxed/simple;\n\tbh=MPpX+1V6sVnrbYjFzZoWq8S2QJs+13VLPXX8jUTZTI0=;\n\th=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type;\n b=TN/rXZTymtfyeMqvknbbce+iMDm9scFAduisZnA+MmYEbiNDDfDYIFBxOeuXFq57GpOVAF8uGm3uvPvYGEQVVQJhlr6bzGSBiVTt1hci3/w45NbUlSy+J2mEqEuhJpFWwA9NWWH+yovvYCm0P3QngUZyI85SIYY+eZZZ015ohzc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=proton.me;\n spf=pass smtp.mailfrom=proton.me;\n dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me\n header.b=ERsfArzz; arc=none smtp.client-ip=109.224.244.25", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;\n\ts=protonmail; t=1774749821; x=1775009021;\n\tbh=jw7+sfd+qB0vbVbLoMklzSKEktx9W18DbP2b4yckE6w=;\n\th=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\t Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=ERsfArzzV92+H7OtUJKXH+gRSGPlsbzrQR3grewV/1WUKEyLS786ALUKRgeCj0Txn\n\t Bm//TJRydyyh5x5wxQuCm2LeYdGIELt+B3JpTxRVPfhsNB+XQ2cLE/TykTaYPUjA/x\n\t jgpXTRSb+curNe1+wqvrICF/FFuPX9Ej7a0+BxFxElQZPbiRBT94CsHrfFucUBWS5A\n\t doINANtiS0NFsFFfs16wLZeW62ewxZ8GZ7dC6m2x0S9XK2yFFg0zloV54SIYLf4Qw2\n\t 30JHO9oR11C1hVa3KZVIfev7jEUz65BpHQszrymWutLvlZjZ9z2ToKq4EWmnBcseRB\n\t hAaSip7uu0Bww==", "Date": "Sun, 29 Mar 2026 02:03:38 +0000", "To": "\"sfrench@samba.org\" <sfrench@samba.org>", "From": "FredTheDude <FredTheDude@proton.me>", "Cc": "\"pc@manguebit.org\" <pc@manguebit.org>,\n \"ronniesahlberg@gmail.com\" <ronniesahlberg@gmail.com>,\n \"sprasad@microsoft.com\" <sprasad@microsoft.com>,\n \"tom@talpey.com\" <tom@talpey.com>,\n \"bharathsm@microsoft.com\" <bharathsm@microsoft.com>,\n \"linux-cifs@vger.kernel.org\" <linux-cifs@vger.kernel.org>,\n \"samba-technical@lists.samba.org\" <samba-technical@lists.samba.org>,\n \"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>", "Subject": "[PATCH] fs/smb/client: add verbose error logging for UNC parsing", "Message-ID": "\n <2__2tXx9Hngg7rDwgOdZVY8FFBkjQGk_0TviV3dVWkoCa9CZznTtxHJsVvgg9U0lyXUo-_6KKPTPFZTIGTLo9YfQczBj2CxTZypXB2ydr7c=@proton.me>", "Feedback-ID": "151443565:user:proton", "X-Pm-Message-ID": "e1b80ed98d432ae410aefef9a25b1ff45a792b96", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable" }, "content": "Add cifs_dbg(VFS, ...) statements to smb3_parse_devname() to provide\nexplicit feedback when parsing fails. Currently, the function returns\n-EINVAL silently, making it difficult to debug mount failures caused\nby malformed paths or missing share names.\n\nSigned-off-by: Fredric Cover <FredTheDude@proton.me>\n---\n\nIf I made any stupid mistakes, please be patient with me.\nC is not my best language, and this is my first patch, and I am just a high school freshman. Thanks!\n---\n fs/smb/client/fs_context.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)\n\n--\n2.43.0", "diff": "diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex a4a7c7eee..03c112f4d 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -658,13 +658,17 @@ smb3_parse_devname(const char *devname, struct smb3_fs_context *ctx)\n\n /* make sure we have a valid UNC double delimiter prefix */\n len = strspn(devname, delims);\n- if (len != 2)\n+ if (len != 2) {\n+ cifs_dbg(VFS, \"UNC: path must begin with // or \\\\\\\\\\n\");\n return -EINVAL;\n+ }\n\n /* find delimiter between host and sharename */\n pos = strpbrk(devname + 2, delims);\n- if (!pos)\n+ if (!pos) {\n+ cifs_dbg(VFS, \"UNC: missing delimiter between hostname and share name\\n\");\n return -EINVAL;\n+ }\n\n /* record the server hostname */\n kfree(ctx->server_hostname);\n@@ -677,8 +681,10 @@ smb3_parse_devname(const char *devname, struct smb3_fs_context *ctx)\n\n /* now go until next delimiter or end of string */\n len = strcspn(pos, delims);\n- if (!len)\n+ if (!len) {\n+ cifs_dbg(VFS, \"UNC: missing share name\\n\");\n return -EINVAL;\n+ }\n\n /* move \"pos\" up to delimiter or NULL */\n pos += len;\n", "prefixes": [] }