Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217392/?format=api
{ "id": 2217392, "url": "http://patchwork.ozlabs.org/api/patches/2217392/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/dc1b0139fc250e188657e874ce4bb67f60af6e0c.1774659119.git.n05ec@lzu.edu.cn/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<dc1b0139fc250e188657e874ce4bb67f60af6e0c.1774659119.git.n05ec@lzu.edu.cn>", "list_archive_url": null, "date": "2026-03-28T14:51:23", "name": "[v2] netfilter: xt_multiport: reject trailing range markers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d6e16309cc595e9dad0b86a3ce978deb9d1c8a8b", "submitter": { "id": 92912, "url": "http://patchwork.ozlabs.org/api/people/92912/?format=api", "name": "Ren Wei", "email": "n05ec@lzu.edu.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/dc1b0139fc250e188657e874ce4bb67f60af6e0c.1774659119.git.n05ec@lzu.edu.cn/mbox/", "series": [ { "id": 497871, "url": "http://patchwork.ozlabs.org/api/series/497871/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497871", "date": "2026-03-28T14:51:23", "name": "[v2] netfilter: xt_multiport: reject trailing range markers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497871/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217392/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11480-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11480-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=129.150.39.64", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=lzu.edu.cn", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lzu.edu.cn" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjgTz1Lx6z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 29 Mar 2026 01:52:39 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 92EC43027D8E\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 14:52:24 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 87EF82F83B7;\n\tSat, 28 Mar 2026 14:52:23 +0000 (UTC)", "from sgoci-sdnproxy-4.icoremail.net (sgoci-sdnproxy-4.icoremail.net\n [129.150.39.64])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DFADB331A44\n\tfor <netfilter-devel@vger.kernel.org>; Sat, 28 Mar 2026 14:52:17 +0000 (UTC)", "from enjou-Legion-Y7000P-2019.coin-barley.ts.net (unknown\n [172.23.56.36])\n\tby app3 (Coremail) with SMTP id ywmowADHAJjr6sdph94rAA--.35221S2;\n\tSat, 28 Mar 2026 22:51:24 +0800 (CST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774709543; cv=none;\n b=DcCoeXWqmry0BhK4kigif53Ot/HjGF76T+YhlOgz3v53zccXOXllRb7FexFSfnGtDaorsMQN52I0p3zl2ybPB+/+rtf0HiAFjreuDAO6cgpnsSpaYO0BmjHF+2A9plYcqG7a4f7xv3BveWZhRBsKaHOHTyAMIGGJA7uuWTVq//c=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774709543; c=relaxed/simple;\n\tbh=gpqj4ko0bX3bD1IeooY2opj6uWZUfRBkAQaY/KNltNI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=EhPcMKMt3xOllTxWEUaElkJWws0Af5MAbX7o8ZZe0VQyd5bhIbQKlY39iC072h+KqLm/SAMeJ/I3+q1xz5x8rZlC7Wcen65T7rSi/Z+8wlchboRNRzXBPh7NHyLnAtR/g649X+muUaUPvvo/7XxHP9A2AfzWMVI5fK/gKPnCr3g=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=lzu.edu.cn;\n spf=pass smtp.mailfrom=lzu.edu.cn; arc=none smtp.client-ip=129.150.39.64", "From": "Ren Wei <n05ec@lzu.edu.cn>", "To": "netfilter-devel@vger.kernel.org", "Cc": "security@kernel.org,\n\tpablo@netfilter.org,\n\tfw@strlen.de,\n\tphil@nwl.cc,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\thorms@kernel.org,\n\tshuah@kernel.org,\n\tyuantan098@gmail.com,\n\tbird@lzu.edu.cn,\n\tz1652074432@gmail.com,\n\tkaber@trash.net,\n\tyasuyuki.kozakai@toshiba.co.jp,\n\tyifanwucs@gmail.com,\n\ttomapufckgml@gmail.com,\n\tn05ec@lzu.edu.cn,\n\tenjou1224z@gmail.com", "Subject": "[PATCH v2] netfilter: xt_multiport: reject trailing range markers", "Date": "Sat, 28 Mar 2026 22:51:23 +0800", "Message-ID": "\n <dc1b0139fc250e188657e874ce4bb67f60af6e0c.1774659119.git.n05ec@lzu.edu.cn>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<cover.1774624314.git.n05ec@lzu.edu.cn>", "References": "<cover.1774624314.git.n05ec@lzu.edu.cn>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "ywmowADHAJjr6sdph94rAA--.35221S2", "X-Coremail-Antispam": "1UD129KBjvJXoWxZw45Zr1UJrWDtr47KrykKrg_yoWrAFyUpa\n\ty5WF13JrW8XFWaqrs2yrykXF4rCrs7Jr47ua43G34xtFy3XryYqa1rtayv9F95AryYkFW7\n\tJF4kZw1Yk345A37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUBj1xkIjI8I6I8E6xAIw20EY4v20xvaj40_JFC_Wr1l1IIY67AE\n\tw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2\n\tIY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2\n\tjsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52\n\tx082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWU\n\tGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4\n\t8JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kIc2xKxwCY1x0262kK\n\te7AKxVW8ZVWrXwCY02Avz4vE-syl42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxFaVAv8V\n\tW8GwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480\n\tY4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7\n\tIYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2\n\t6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV\n\tAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRpOJnUUUUU=", "X-CM-SenderInfo": "zqqvvuo6o23hxhgxhubq/1tbiAQQACWnGp-sGXQAXsz" }, "content": "ports_match_v1() treats any non-zero pflags entry as the start of a\nport range and unconditionally consumes the next ports[] element as\nthe range end.\n\nThe checkentry path currently validates protocol, flags and count, but\nit does not reject a malformed rule whose final slot is marked as a\nrange start. That leaves ports_match_v1() to step past the last valid\nports[] element when such a rule is installed.\n\nFix this by rejecting multiport v1 rules with a trailing range marker\nin checkentry. This keeps malformed rules out of the runtime matching\npath and preserves the existing exact-match and valid-range behavior.\n\nFixes: a89ecb6a2ef7 (\"[NETFILTER]: x_tables: unify IPv4/IPv6 multiport match\")\nReported-by: Yifan Wu <yifanwucs@gmail.com>\nReported-by: Juefei Pu <tomapufckgml@gmail.com>\nCo-developed-by: Yuan Tan <yuantan098@gmail.com>\nSigned-off-by: Yuan Tan <yuantan098@gmail.com>\nSuggested-by: Xin Liu <bird@lzu.edu.cn>\nTested-by: Yuhang Zheng <z1652074432@gmail.com>\nSigned-off-by: Ren Wei <n05ec@lzu.edu.cn>\n---\nChanges in v2:\n- drop the selftest patch\n- send the fix publicly to netfilter-devel\n net/netfilter/xt_multiport.c | 50 +++++++++++++++++++++++-------------\n 1 file changed, 32 insertions(+), 18 deletions(-)", "diff": "diff --git a/net/netfilter/xt_multiport.c b/net/netfilter/xt_multiport.c\nindex 44a00f5acde8..38aa5b90d38e 100644\n--- a/net/netfilter/xt_multiport.c\n+++ b/net/netfilter/xt_multiport.c\n@@ -26,10 +26,10 @@ MODULE_ALIAS(\"ip6t_multiport\");\n /* Returns 1 if the port is matched by the test, 0 otherwise. */\n static inline bool\n ports_match_v1(const struct xt_multiport_v1 *minfo,\n-\t u_int16_t src, u_int16_t dst)\n+\t u16 src, u16 dst)\n {\n \tunsigned int i;\n-\tu_int16_t s, e;\n+\tu16 s, e;\n \n \tfor (i = 0; i < minfo->count; i++) {\n \t\ts = minfo->ports[i];\n@@ -106,20 +106,36 @@ multiport_mt(const struct sk_buff *skb, struct xt_action_param *par)\n }\n \n static inline bool\n-check(u_int16_t proto,\n- u_int8_t ip_invflags,\n- u_int8_t match_flags,\n- u_int8_t count)\n+multiport_valid_ranges(const struct xt_multiport_v1 *multiinfo)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < multiinfo->count; i++) {\n+\t\tif (!multiinfo->pflags[i])\n+\t\t\tcontinue;\n+\n+\t\tif (i == multiinfo->count - 1)\n+\t\t\treturn false;\n+\n+\t\ti++;\n+\t}\n+\n+\treturn true;\n+}\n+\n+static inline bool\n+check(u16 proto, u8 ip_invflags, const struct xt_multiport_v1 *multiinfo)\n {\n \t/* Must specify supported protocol, no unknown flags or bad count */\n-\treturn (proto == IPPROTO_TCP || proto == IPPROTO_UDP\n-\t\t|| proto == IPPROTO_UDPLITE\n-\t\t|| proto == IPPROTO_SCTP || proto == IPPROTO_DCCP)\n-\t\t&& !(ip_invflags & XT_INV_PROTO)\n-\t\t&& (match_flags == XT_MULTIPORT_SOURCE\n-\t\t || match_flags == XT_MULTIPORT_DESTINATION\n-\t\t || match_flags == XT_MULTIPORT_EITHER)\n-\t\t&& count <= XT_MULTI_PORTS;\n+\treturn (proto == IPPROTO_TCP || proto == IPPROTO_UDP ||\n+\t\tproto == IPPROTO_UDPLITE ||\n+\t\tproto == IPPROTO_SCTP || proto == IPPROTO_DCCP) &&\n+\t !(ip_invflags & XT_INV_PROTO) &&\n+\t (multiinfo->flags == XT_MULTIPORT_SOURCE ||\n+\t\tmultiinfo->flags == XT_MULTIPORT_DESTINATION ||\n+\t\tmultiinfo->flags == XT_MULTIPORT_EITHER) &&\n+\t multiinfo->count <= XT_MULTI_PORTS &&\n+\t multiport_valid_ranges(multiinfo);\n }\n \n static int multiport_mt_check(const struct xt_mtchk_param *par)\n@@ -127,8 +143,7 @@ static int multiport_mt_check(const struct xt_mtchk_param *par)\n \tconst struct ipt_ip *ip = par->entryinfo;\n \tconst struct xt_multiport_v1 *multiinfo = par->matchinfo;\n \n-\treturn check(ip->proto, ip->invflags, multiinfo->flags,\n-\t\t multiinfo->count) ? 0 : -EINVAL;\n+\treturn check(ip->proto, ip->invflags, multiinfo) ? 0 : -EINVAL;\n }\n \n static int multiport_mt6_check(const struct xt_mtchk_param *par)\n@@ -136,8 +151,7 @@ static int multiport_mt6_check(const struct xt_mtchk_param *par)\n \tconst struct ip6t_ip6 *ip = par->entryinfo;\n \tconst struct xt_multiport_v1 *multiinfo = par->matchinfo;\n \n-\treturn check(ip->proto, ip->invflags, multiinfo->flags,\n-\t\t multiinfo->count) ? 0 : -EINVAL;\n+\treturn check(ip->proto, ip->invflags, multiinfo) ? 0 : -EINVAL;\n }\n \n static struct xt_match multiport_mt_reg[] __read_mostly = {\n", "prefixes": [ "v2" ] }