Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217365/?format=api
{ "id": 2217365, "url": "http://patchwork.ozlabs.org/api/patches/2217365/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260328072424.10611-1-vikingtc4@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260328072424.10611-1-vikingtc4@gmail.com>", "list_archive_url": null, "date": "2026-03-28T07:24:24", "name": "migration: validate page_size in mapped-ram header before use", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cb0bf82b150bb4817173bc3f090c789fbb230989", "submitter": { "id": 92831, "url": "http://patchwork.ozlabs.org/api/people/92831/?format=api", "name": "Trieu Huynh", "email": "vikingtc4@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260328072424.10611-1-vikingtc4@gmail.com/mbox/", "series": [ { "id": 497854, "url": "http://patchwork.ozlabs.org/api/series/497854/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497854", "date": "2026-03-28T07:24:24", "name": "migration: validate page_size in mapped-ram header before use", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497854/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217365/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217365/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=UvRwweYQ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjTYd2Mbfz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 18:25:09 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6O26-0006qq-Tm; Sat, 28 Mar 2026 03:24:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w6O25-0006qf-AP\n for qemu-devel@nongnu.org; Sat, 28 Mar 2026 03:24:34 -0400", "from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w6O23-000101-LV\n for qemu-devel@nongnu.org; Sat, 28 Mar 2026 03:24:33 -0400", "by mail-pj1-x1033.google.com with SMTP id\n 98e67ed59e1d1-35d971fb6f1so145344a91.0\n for <qemu-devel@nongnu.org>; Sat, 28 Mar 2026 00:24:31 -0700 (PDT)", "from trieu2-huynh-trieuhpn-ubuntu24.bee-live.svc.cluster.local\n ([27.122.242.65]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35d9507d505sm1145089a91.10.2026.03.28.00.24.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 28 Mar 2026 00:24:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774682670; x=1775287470; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=rkGbqrRIaNoI0eLMZJPokRYI36vWC2mPB9X260ixyX0=;\n b=UvRwweYQsriVH8S93tv9hB0PFDXcl19DQ/Jz71+ka40S8/oGzDrpLkWWslrow5QUqE\n EPCY5i1Y358+UzkZy70D7ncbptdjed1H73hq4lLuSsn3RVaIgT/abDtDp/pkfJLH0XCD\n Z2iBJNe/DhDW+7P8DGrO2QXC54B3ZAg7rU5+cKB5Xt0eToHG6GyC5ELdYLD9OmbW7MsX\n rGKb6ZP3cM1/CpCF1eKXqpZ3tZ6+FLEFtiF1eRuhgXIDLCfrHNeJoV3iAKsc3lOP1L5r\n ZqvKG8WyqIGaHoiIHy2C+bahpyU6Oh8c+PPoWjOJRTVni+201F9cLyuryivZxw4d9qjZ\n ChXQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774682670; x=1775287470;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rkGbqrRIaNoI0eLMZJPokRYI36vWC2mPB9X260ixyX0=;\n b=cDEhW08cqeTB6/88uQKOn1U4KOjvvLef5hLTU9TFutazVbbyW5IxsYOCS8I14nJ+Sd\n d7wYW58Q/4g9G4pabp55mBSzpj2VwpEAbwEj0Gqj82vrsQJFLzD5sU7mlOJ810/I2t1E\n 9+GBdqFozTtbOd6pygMSmioLmoO586c5K4nxxSXfTikFqYwLDpEJ2nOwEUm4pbhR0oK/\n VWr80gDGTg0cnmrS2srF16pRu5BBujFQQjF9/r6szzjO1dCe87nknWwsh43Rep6UBiv5\n VYW1I7MPLue7MQddUAvORNedjWruKjFqbCZZAIg4Xa31D9Cib3cMdy8d+YfZhf8SNWAG\n ODew==", "X-Gm-Message-State": "AOJu0YxuFnjlZ11oNiLUWx9m2gaecFMKnclne8EyLno1we+VW1DpAUKa\n +9kzYCP6AHXs+TgfZZhgr+BOtowjMyiAQACkau+1m2m3Z6bmdMXRGCAIbxBGEIG4", "X-Gm-Gg": "ATEYQzxRRy76go/NN92M82O8FuRGDhDHzFStzrrah2+KZYk8Fk26ACbew1gEqIR02d/\n Zlf1dwYnLXSC5O42s3OK2TSqwYwkQg2Iujzgq3lspogr2f7cz3ucVx0eLcxLaPWFKMWDi6cVP1j\n gEHyzEavAqWwGU82HVc27gGZDI2WoXN8QaMQ28HCZUSf9JDUyX5KK0aGHV2hllbykeOvoI/NM8i\n MaH1mrKyO8Vy0RIwv7NVMXner4Wf3j5x7az6TV3mK4uZIakyto0i4XOzvk4dP5PtPu1bLIBxeRV\n OAORd/RbNcWwI58udHrtaJGAu/cLOIyAHEHzJy4vO5GB4NaX86z+Mq4H0R4ogbG+b4wCw5qZ0xJ\n 5QUDlRN4YzD2HA53zFG/DmtO+rVE2j3Q/PhajbD/QKNCZNXz7dCoHTK2XJRgoEqsLxB5ELGInyb\n j8D7BYfauy2nQTWJ6Qi+7Fg/Oq+B9/S3LSzrKst3JXN8NLNJUbse+6p9dWbqYWD9cERwivjwz7j\n yZsWW/Tmg==", "X-Received": "by 2002:a17:90a:d406:b0:359:7c55:c166 with SMTP id\n 98e67ed59e1d1-35c2ffa80c1mr5192836a91.7.1774682669585;\n Sat, 28 Mar 2026 00:24:29 -0700 (PDT)", "From": "Trieu Huynh <vikingtc4@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Trieu Huynh <vikingtc4@gmail.com>, Peter Xu <peterx@redhat.com>,\n Fabiano Rosas <farosas@suse.de>", "Subject": "[PATCH] migration: validate page_size in mapped-ram header before use", "Date": "Sat, 28 Mar 2026 16:24:24 +0900", "Message-ID": "<20260328072424.10611-1-vikingtc4@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=vikingtc4@gmail.com; helo=mail-pj1-x1033.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "mapped_ram_read_header() reads page_size from the migration stream and\nstores it in MappedRamHeader, but does not validate that the value is\nnon-zero before it is later used in parse_ramblock_mapped_ram():\n\nnum_pages = length / header.page_size;\n\nIf a corrupted or malformed migration stream provides page_size = 0,\nQEMU unexpectedly crashes.\n\nAdd validation in mapped_ram_read_header() to reject zero page_size\nvalues early and return an error instead of continuing with an invalid\nheader.\n\nSteps to reproduce:\n\nCreate a migration snapshot with mapped-ram enabled:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate file:/tmp/qemu-snapshots/snapshot.bin\nModify the snapshot so that MappedRamHeader.page_size becomes 0.\nRestore the snapshot:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate_incoming file:/tmp/qemu-bug-test/snapshot.bin\n\nAs-is: qemu crashes immediately\n(qemu) Floating point exception (core dumped)\nTo-be: qemu continue running\n(qemu) qemu-system-x86_64: Migration mapped-ram header has invalid\npage_size of 0\n\nSigned-off-by: Trieu Huynh <vikingtc4@gmail.com>\n---\n migration/ram.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/migration/ram.c b/migration/ram.c\nindex 979751f61b..2a7e958e87 100644\n--- a/migration/ram.c\n+++ b/migration/ram.c\n@@ -3088,6 +3088,11 @@ static bool mapped_ram_read_header(QEMUFile *file, MappedRamHeader *header,\n }\n \n header->page_size = be64_to_cpu(header->page_size);\n+ if (header->page_size == 0) {\n+ error_setg(errp, \"Migration mapped-ram header has invalid \"\n+ \"page_size of 0\");\n+ return false;\n+ }\n header->bitmap_offset = be64_to_cpu(header->bitmap_offset);\n header->pages_offset = be64_to_cpu(header->pages_offset);\n \n", "prefixes": [] }