Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217344/?format=api
{ "id": 2217344, "url": "http://patchwork.ozlabs.org/api/patches/2217344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20260327221905.267410-1-devnexen@gmail.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327221905.267410-1-devnexen@gmail.com>", "list_archive_url": null, "date": "2026-03-27T22:19:04", "name": "[1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ee6e37587fbee3bf1af140972ded31e18c4ce4e0", "submitter": { "id": 76714, "url": "http://patchwork.ozlabs.org/api/people/76714/?format=api", "name": "David Carlier", "email": "devnexen@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20260327221905.267410-1-devnexen@gmail.com/mbox/", "series": [ { "id": 497842, "url": "http://patchwork.ozlabs.org/api/series/497842/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=497842", "date": "2026-03-27T22:19:05", "name": "[1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497842/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217344/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openbmc+bounces-1738-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NP7qLTIO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1738-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::330\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NP7qLTIO;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com;\n envelope-from=devnexen@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjKjH6d3kz1y1P\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 12:31:15 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fjKjD3pYqz2yS4;\n\tSat, 28 Mar 2026 12:31:12 +1100 (AEDT)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjFRj4wPXz2xMQ\n\tfor <openbmc@lists.ozlabs.org>; Sat, 28 Mar 2026 09:19:12 +1100 (AEDT)", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-486fb14227cso33055005e9.3\n for <openbmc@lists.ozlabs.org>; Fri, 27 Mar 2026 15:19:12 -0700 (PDT)", "from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-487306acb47sm8489965e9.15.2026.03.27.15.19.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 15:19:08 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774649954;\n\tcv=none;\n b=I6icC28IVh13d4G2mmrx2y96zIpxUpeWjl5mMGWGcwwyCDs0ZBOhzPjScMTjmdldwL+FaoeBPpgz05Z+LeZKW4IdLJGbPMabsIyHIbvIh3lNmFo9wOEGFS+duPAeUhUKbeU5hz42nyzUw11zmOgM/wForbF5VK/pcPNF0rxpUCidbBpsljAwKoZjMGUmaZXSN+6luCLZauhjHZ3kUJbRo99z+/HFcuV+S0ZOkofnxOW67tKrNrMMwnQ9XDjUdp32guGn3wydE99AILaq4GlHvE4by0b9dY6gytr63/2cAqIdUsXDAr8mY2mWIcVgjDfgAMOlIXztqCALb1bPtz0HQg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774649954; c=relaxed/relaxed;\n\tbh=oOr5ARwTTylH9deTx77kYmBkTdRY5+SBIZ8AjtFWZFY=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=WmwEXJ9BoySOkwMDzXvV97DS/61DtKtKdtKGnsF7+rHlPWf/10OmirLl/j0qVvdl0VqXYZeBfgGzkbbnQ6r0W1iNY6kmcJGkeIIM2cZRjamDhFeEE2B2zuBM0ZtalkJuYuP6572NBYw8JPwcZS+NgzwEWAUdufq2JxWirSv4eR2fpu2HewbBcOonGRksIwI7YDAB98UOjjhZ97GvzfToY1K1uVdKOy+Naji+ZSb8PKXnCwq8GympEJCSoHVgMpxjXfTScQ8mX5ie9aQF5oMbduzbuqSgk8hzWTNX9WZIjdGS8MwkevJLhau75T2QOWV2arYX4eaIAQ6S3LpUVD66pQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NP7qLTIO; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com;\n envelope-from=devnexen@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774649949; x=1775254749;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=oOr5ARwTTylH9deTx77kYmBkTdRY5+SBIZ8AjtFWZFY=;\n b=NP7qLTIOgnXMvG4F52fhCz7zkbwmTWBesl7khpUX6Pw9c1DVGOmyH6dMH8ZXcClUYz\n 57mQ+VYJ3c5q5kIc8CrlTBy1Z1uPwsgXdX2QQTHnJ0AZ6nWOU7t3uLvF//U5y85x7S2t\n jZ2uV+LQUQoD/I+agdb124vtpnPqlkREs92blBDplDL81+EQM3i2dV8f8pd69KkshSvr\n m+WVP5MOA3Cloj7iDU3cz16O1lY5q/kLoOIVPM1g3GZTk+vTQZ8z5AiBb2lhj0SnMaCu\n Z4ZV5+FroHVe9HOOFpC5/p7O1hTQPcIAYiNJHiSXdvRc64BvYJl9TagXouREktWAJVy0\n k0hg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774649949; x=1775254749;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oOr5ARwTTylH9deTx77kYmBkTdRY5+SBIZ8AjtFWZFY=;\n b=Pr1tpofOjgJSzCVif6HClYDyF4ObgXwvs4hK+3gJWla2WDEGDczE8xIVftfxPim1xU\n alVo0Nw1lygfabf96/gRwuBqd/4D/dLQipI4mfoHOge96bSbJfA/S6WnLpdzX7ad4hv/\n X6GkLo+xrM/UqA7bGMOx4/NKFcohjwYvzeC1AUuvt3Vv96GlUqhD6sjj3vxYBljw56fT\n lFRQW2pW895EIhljrcmWeCJGEZGydxdt0NADu8gdYdJB9LrNgT/kItVwDAvb/ZrjuVl2\n jSs4eY9RjlmkoF4/LFpNS6Uz5LEP23P4mNzw4+XAdKoioDOPsLgS4Bc7umBJ5DE9eXAk\n g7gw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUEH+Kpc8ZeyTYXg/vrucTpAZYOA3oApnvAqs1XmdliGqNyCW1gftjrrdxj5r8SmEZfOgkVWOJ0@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YxrmsKLRq5yoVyChyEW2w9xANd0gbRJy7pPon34/40f3Pczom4O\n\tnnaRAhLnSWc/Ylso6gK+Qundx7MRy4eGF8VD+GRMqFF+9CPMDvNazFuf", "X-Gm-Gg": "ATEYQzzEC+7zMdSsTZ0VB16S4j7IodJ2GbjkmOEHTRpb28fWP2x2JLn2Ht4VjuDnXz+\n\tH7TJTNIYlN2uUimKmjyMybQyhLGWfGXiJmcdgMvEttIxrAkGBeV4pi1bIEEos6eYmmmjovkQDw3\n\tQ8zW0b+Sjx1z7UHKg4H+1Bf85VU7fs+J9J+VP/xVAwk47Dp28JFJhwAbNOb6+pfziY+LRPxNbhN\n\tKH4WdTbcBMXzYaL4MBDyjVG4/P5Wct7NZytsgauRdRZ235yLD0U/lT+2dtpyLRfyY1S34tf1lDK\n\tMEGGBZDY3vZXAybga0H1fVb4lbo9vKEha5gM4rFVChz6uA85/BUgdpr0rOLxs6Qz9dKK411MtF5\n\t9u9PsWAWZzv6Hti2ldPK/Q4njefpiDrpg3vigVqi42d2jkE0nE0pP63nod5X/JufG255K/lRE7C\n\t9qloZoBIqCFcZmi7ozzUmk3oG7vrRaGD1Ph7KboAnACjgcrXKnY2/r4HXEAr3FFLkEIny3UQNQw\n\tQbxJo8eW+aH", "X-Received": "by 2002:a05:600c:3112:b0:485:3b34:2f62 with SMTP id\n 5b1f17b1804b1-48727ea2803mr72526885e9.14.1774649949040;\n Fri, 27 Mar 2026 15:19:09 -0700 (PDT)", "From": "David Carlier <devnexen@gmail.com>", "To": "kwliu@nuvoton.com,\n\tkflin@nuvoton.com,\n\tmchehab@kernel.org", "Cc": "linux-media@vger.kernel.org,\n\topenbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tDavid Carlier <devnexen@gmail.com>", "Subject": "[PATCH 1/2] media: nuvoton: npcm-video: fix error handling in\n npcm_video_init()", "Date": "Fri, 27 Mar 2026 22:19:04 +0000", "Message-ID": "<20260327221905.267410-1-devnexen@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "X-Mailing-List": "openbmc@lists.ozlabs.org", "List-Id": "<openbmc.lists.ozlabs.org>", "List-Help": "<mailto:openbmc+help@lists.ozlabs.org>", "List-Owner": "<mailto:openbmc+owner@lists.ozlabs.org>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Subscribe": "<mailto:openbmc+subscribe@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-digest@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:openbmc+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "npcm_video_init() has two error handling issues after\nof_reserved_mem_device_init() is called:\n\nWhen dma_set_mask_and_coherent() fails, the function releases the\nreserved memory but does not return, allowing execution to fall through\ninto npcm_video_ece_init() with a failed DMA configuration.\n\nWhen npcm_video_ece_init() fails, the function returns an error without\ncalling of_reserved_mem_device_release(), leaking the reserved memory\nassociation.\n\nFix both by adding the missing return after the DMA mask failure and\nadding the missing of_reserved_mem_device_release() call on the ECE init\nerror path.\n\nFixes: 7c3a5e744482 (\"media: nuvoton: Add driver for NPCM video capture/encode engine\")\nSigned-off-by: David Carlier <devnexen@gmail.com>\n---\n drivers/media/platform/nuvoton/npcm-video.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c\nindex b2a562e1ee1c..5c6bddfe8073 100644\n--- a/drivers/media/platform/nuvoton/npcm-video.c\n+++ b/drivers/media/platform/nuvoton/npcm-video.c\n@@ -1720,10 +1720,12 @@ static int npcm_video_init(struct npcm_video *video)\n \tif (rc) {\n \t\tdev_err(dev, \"Failed to set DMA mask\\n\");\n \t\tof_reserved_mem_device_release(dev);\n+\t\treturn rc;\n \t}\n \n \trc = npcm_video_ece_init(video);\n \tif (rc) {\n+\t\tof_reserved_mem_device_release(dev);\n \t\tdev_err(dev, \"Failed to initialize ECE\\n\");\n \t\treturn rc;\n \t}\n", "prefixes": [ "1/2" ] }