Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217336/?format=api
{ "id": 2217336, "url": "http://patchwork.ozlabs.org/api/patches/2217336/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260327214242.4051172-4-john.cabaj@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327214242.4051172-4-john.cabaj@canonical.com>", "list_archive_url": null, "date": "2026-03-27T21:42:41", "name": "[SRU,Q:linux-azure,2/3] net: mana: Add standard counter rx_missed_errors", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "27f59e9b4f34d99837f37d68eb17f0d9627253e2", "submitter": { "id": 85032, "url": "http://patchwork.ozlabs.org/api/people/85032/?format=api", "name": "John Cabaj", "email": "john.cabaj@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260327214242.4051172-4-john.cabaj@canonical.com/mbox/", "series": [ { "id": 497836, "url": "http://patchwork.ozlabs.org/api/series/497836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=497836", "date": "2026-03-27T21:42:38", "name": "net: mana: Trigger VF reset/recovery on health check failure due to HWC timeout", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497836/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217336/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=Dm3LJCsR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDdt0CHyz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:42:58 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1w6ExA-00072y-6e; Fri, 27 Mar 2026 21:42:52 +0000", "from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <john.cabaj@canonical.com>)\n id 1w6Ex5-0006xG-UT\n for kernel-team@lists.ubuntu.com; Fri, 27 Mar 2026 21:42:47 +0000", "from mail-qv1-f71.google.com (mail-qv1-f71.google.com\n [209.85.219.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id BC60F3F1DA\n for <kernel-team@lists.ubuntu.com>; Fri, 27 Mar 2026 21:42:47 +0000 (UTC)", "by mail-qv1-f71.google.com with SMTP id\n 6a1803df08f44-899e89bf366so26219966d6.0\n for <kernel-team@lists.ubuntu.com>; Fri, 27 Mar 2026 14:42:47 -0700 (PDT)", "from smtp.gmail.com\n (h208-73-92-250.mdtnwi.broadband.dynamic.tds.net. [208.73.92.250])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-89ecf95f4f9sm3448206d6.37.2026.03.27.14.42.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:42:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1774647767;\n bh=ws185vHZni8ZYF0CY9HliHyYYdCrdnLCTj02nwQcwl8=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=Dm3LJCsRJZw+uoKwFOS6in/9cPe3Gfwh5oOyPOzqCD3lLvmyNaa2e4DCl9MfNZAyH\n DPWdw7/5IJdFmO3GzsOBe+fDm1SXHAbmpBeKQovMzrTp9gE8RfSf7EDPoPuR2v21Y0\n EaHfnZSPjhZakkqWcwQzHf0X7HccT/vThjfT9h+xAZnkdAGQ/UbtvIhN2G0W4idk80\n FMklsAYn7ZSdqesFh/BGJiR4Awm+QhZ1/HimfuGghA4C6Pc9nkK4NRapYFeAx0dgRU\n H61kGVfqWrzizvtvszd+zhu4sPhahYshhqNd25I16DfBDwA5A6JtW0BPvBxLqV3gPQ\n XfNA53jhbkx5kkcKWJzbdEhBvat8gjk9IbNGvf4Vu/jr9YcyFEFafm+dcVg+mU7wcK\n OPrquljRWVUtCkC61w5BCeuq06bBDXoS4vlebGYcba+Qbq0Gt+Q48eEFbkrNxe7WUG\n yEaH18PeRC3SJJRLjwl7wMOViNiIwKu+pKhxhhmhc2knz4bW/MU5BoOMsaj0p/+ABh\n Qf7iTo60TeDP3sz5xN6wiV3t+tcVeZnyJKfee4IHkhP7g0V0fTWnsSind0uqY9QBTX\n 9lrKGzCp21pB6IyyqLm1bVdT3zHmXAjtVO/QtVZ+ZFYrIGcQdQa+MMk8yEe12m2qZ8\n QsmMD0NkE59+ak1PynbcFTV0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774647767; x=1775252567;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ws185vHZni8ZYF0CY9HliHyYYdCrdnLCTj02nwQcwl8=;\n b=H6Ck7m44Z4VLKRqPeRPstT2HphH08llKHPPCTEEeX/c/1GSBT9hBe319520IAD7hBP\n E2/nJi7Arn5dclwlmx1jEU70QJ71F6KrjYstYhHWrinmAtGdjgxMGaE+NP4Ey9o3dWNT\n +3rkC+Yor0dcF+S5/CNb4+ZdBinV2lJ/VgAAieqehSU+PpFGNylnOZLuuzbA4Bauty1n\n Les5bdMeqflyU6vFA5dsJ5UrApuPMF2HsWSf39myVvv7saTTnrKgfSYga2p+uuWrX6gk\n hXiiQZogInEv6f8gPXM+7XB1UC87q+7D+c1Wc6Hpr3DVjvCkIw6yK0vY5mgKJ0FNm5UJ\n nl+w==", "X-Gm-Message-State": "AOJu0Yw5ZexcHpmVNURp5ZeG1+Uvy2FgDjA4kvUlA4zz+Nc+HL52GwGI\n 2yQONBT7BcXpRrfAxWi4z1xGxeistQsMaWtosELVlpohEMXWU1TmY0aMZglsxifXuNUO8xDWm8p\n hWIoq0OWGDpwJEP2+iyM7AiCmwyKa30a5Wwr4w+/PbKID2JIIMcpCUIdvXOSBQeYMSnq5xTyvZ2\n EwBG2PlhwCLkZO8w==", "X-Gm-Gg": "ATEYQzyI5so0RHom3ti5n1hPtWAJr7tfLlUheWSgstT/XMBQjdJ4Wa5bt+sumdT/XT7\n UUF/T9ahgts85USo9RgmTfcxCWSgpKsQp/1iWGp/ZbfVbQYHFtWSnh254rbsT5mwhR9IOk0Y2aE\n s7jItmatbqpQuD1nEjaxlnIWZYNfvsoHAtrBX3t3vIV/WBr7kJlEZpfpsBTkeFDGgljLNbDJX23\n mBu1gwA0q4eu6AYTFtkl08I/tSuhUUFChBA2ZdlU9oBmtZ7XtPKVzJfOzStQJ4bQpplw6uUyC+x\n umrR4wvNcrDSGPK7XCP3KFHGivjCjJfoyX5fu6bxJ6FGzsN/fBa0DqMamFSJehZVzrzbdB3DGSa\n u7Kvn8UpV30pwpejcVUpbHc8TNijBEGccXUzDu2nhgSQrHAChGlmQY7FLWeLQh8mALg9wNYcJL6\n 0eRUjkC/dYDQ==", "X-Received": [ "by 2002:a05:6214:5016:b0:89c:a2b2:8d3a with SMTP id\n 6a1803df08f44-89ce8cf306dmr60585576d6.4.1774647766664;\n Fri, 27 Mar 2026 14:42:46 -0700 (PDT)", "by 2002:a05:6214:5016:b0:89c:a2b2:8d3a with SMTP id\n 6a1803df08f44-89ce8cf306dmr60585256d6.4.1774647766247;\n Fri, 27 Mar 2026 14:42:46 -0700 (PDT)" ], "From": "John Cabaj <john.cabaj@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[SRU][Q:linux-azure][PATCH 2/3] net: mana: Add standard counter\n rx_missed_errors", "Date": "Fri, 27 Mar 2026 16:42:41 -0500", "Message-ID": "<20260327214242.4051172-4-john.cabaj@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260327214242.4051172-1-john.cabaj@canonical.com>", "References": "<20260327214242.4051172-1-john.cabaj@canonical.com>", "MIME-Version": "1.0", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "From: Erni Sri Satya Vennela <ernis@linux.microsoft.com>\n\nBugLink: https://bugs.launchpad.net/bugs/2146601\n\nReport standard counter stats->rx_missed_errors\nusing hc_rx_discards_no_wqe from the hardware.\n\nAdd a global workqueue to periodically run\nmana_query_gf_stats every 2 seconds to get the latest\ninfo in eth_stats and define a driver capability flag\nto notify hardware of the periodic queries.\n\nTo avoid repeated failures and log flooding, the workqueue\nis not rescheduled if mana_query_gf_stats fails on HWC timeout\nerror and the stats are reset to 0. Other errors are transient\nwhich will not need a VF reset for recovery.\n\nSigned-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>\nReviewed-by: Haiyang Zhang <haiyangz@microsoft.com>\nLink: https://patch.msgid.link/1763120599-6331-3-git-send-email-ernis@linux.microsoft.com\nSigned-off-by: Jakub Kicinski <kuba@kernel.org>\n(backported from commit be4f1d67ec56f23f37714ac73c01094e63c7ff28)\n[john-cabaj: context changes due to inclusion of 3b194343c250:\n\"net: mana: Implement ndo_tx_timeout and serialize queue resets\nper port.\"]\nSigned-off-by: John Cabaj <john.cabaj@canonical.com>\n---\n drivers/net/ethernet/microsoft/mana/mana_en.c | 36 +++++++++++++++++--\n .../ethernet/microsoft/mana/mana_ethtool.c | 2 --\n include/net/mana/gdma.h | 4 +++\n include/net/mana/mana.h | 6 +++-\n 4 files changed, 42 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c\nindex f0f6e0544663..568613c1dbb4 100644\n--- a/drivers/net/ethernet/microsoft/mana/mana_en.c\n+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c\n@@ -567,6 +567,11 @@ static void mana_get_stats64(struct net_device *ndev,\n \n \tnetdev_stats_to_stats64(st, &ndev->stats);\n \n+\tif (apc->ac->hwc_timeout_occurred)\n+\t\tnetdev_warn_once(ndev, \"HWC timeout occurred\\n\");\n+\n+\tst->rx_missed_errors = apc->ac->hc_stats.hc_rx_discards_no_wqe;\n+\n \tfor (q = 0; q < num_queues; q++) {\n \t\trx_stats = &apc->rxqs[q]->stats;\n \n@@ -2870,7 +2875,7 @@ int mana_config_rss(struct mana_port_context *apc, enum TRI_STATE rx,\n \treturn 0;\n }\n \n-void mana_query_gf_stats(struct mana_context *ac)\n+int mana_query_gf_stats(struct mana_context *ac)\n {\n \tstruct gdma_context *gc = ac->gdma_dev->gdma_context;\n \tstruct mana_query_gf_stat_resp resp = {};\n@@ -2913,14 +2918,14 @@ void mana_query_gf_stats(struct mana_context *ac)\n \t\t\t\tsizeof(resp));\n \tif (err) {\n \t\tdev_err(dev, \"Failed to query GF stats: %d\\n\", err);\n-\t\treturn;\n+\t\treturn err;\n \t}\n \terr = mana_verify_resp_hdr(&resp.hdr, MANA_QUERY_GF_STAT,\n \t\t\t\t sizeof(resp));\n \tif (err || resp.hdr.status) {\n \t\tdev_err(dev, \"Failed to query GF stats: %d, 0x%x\\n\", err,\n \t\t\tresp.hdr.status);\n-\t\treturn;\n+\t\treturn err;\n \t}\n \n \tac->hc_stats.hc_rx_discards_no_wqe = resp.rx_discards_nowqe;\n@@ -2955,6 +2960,8 @@ void mana_query_gf_stats(struct mana_context *ac)\n \tac->hc_stats.hc_tx_mcast_pkts = resp.hc_tx_mcast_pkts;\n \tac->hc_stats.hc_tx_mcast_bytes = resp.hc_tx_mcast_bytes;\n \tac->hc_stats.hc_tx_err_gdma = resp.tx_err_gdma;\n+\n+\treturn 0;\n }\n \n void mana_query_phy_stats(struct mana_port_context *apc)\n@@ -3495,6 +3502,24 @@ int mana_rdma_service_event(struct gdma_context *gc, enum gdma_service_type even\n \treturn 0;\n }\n \n+#define MANA_GF_STATS_PERIOD (2 * HZ)\n+\n+static void mana_gf_stats_work_handler(struct work_struct *work)\n+{\n+\tstruct mana_context *ac =\n+\t\tcontainer_of(to_delayed_work(work), struct mana_context, gf_stats_work);\n+\tint err;\n+\n+\terr = mana_query_gf_stats(ac);\n+\tif (err == -ETIMEDOUT) {\n+\t\t/* HWC timeout detected - reset stats and stop rescheduling */\n+\t\tac->hwc_timeout_occurred = true;\n+\t\tmemset(&ac->hc_stats, 0, sizeof(ac->hc_stats));\n+\t\treturn;\n+\t}\n+\tschedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD);\n+}\n+\n int mana_probe(struct gdma_dev *gd, bool resuming)\n {\n \tstruct gdma_context *gc = gd->gdma_context;\n@@ -3598,6 +3623,10 @@ int mana_probe(struct gdma_dev *gd, bool resuming)\n \t}\n \n \terr = add_adev(gd, \"eth\");\n+\n+\tINIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler);\n+\tschedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD);\n+\n out:\n \tif (err) {\n \t\tmana_remove(gd, false);\n@@ -3622,6 +3651,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending)\n \tint i;\n \n \tdisable_work_sync(&ac->link_change_work);\n+\tcancel_delayed_work_sync(&ac->gf_stats_work);\n \n \t/* adev currently doesn't support suspending, always remove it */\n \tif (gd->adev)\ndiff --git a/drivers/net/ethernet/microsoft/mana/mana_ethtool.c b/drivers/net/ethernet/microsoft/mana/mana_ethtool.c\nindex 3dfd96146424..99e811208683 100644\n--- a/drivers/net/ethernet/microsoft/mana/mana_ethtool.c\n+++ b/drivers/net/ethernet/microsoft/mana/mana_ethtool.c\n@@ -213,8 +213,6 @@ static void mana_get_ethtool_stats(struct net_device *ndev,\n \n \tif (!apc->port_is_up)\n \t\treturn;\n-\t/* we call mana function to update stats from GDMA */\n-\tmana_query_gf_stats(apc->ac);\n \n \t/* We call this mana function to get the phy stats from GDMA and includes\n \t * aggregate tx/rx drop counters, Per-TC(Traffic Channel) tx/rx and pause\ndiff --git a/include/net/mana/gdma.h b/include/net/mana/gdma.h\nindex b61c5aae5ec7..04a13a6960f6 100644\n--- a/include/net/mana/gdma.h\n+++ b/include/net/mana/gdma.h\n@@ -602,6 +602,9 @@ enum {\n \n #define GDMA_DRV_CAP_FLAG_1_HW_VPORT_LINK_AWARE BIT(6)\n \n+/* Driver can send HWC periodically to query stats */\n+#define GDMA_DRV_CAP_FLAG_1_PERIODIC_STATS_QUERY BIT(21)\n+\n /* Driver can handle hardware recovery events during probe */\n #define GDMA_DRV_CAP_FLAG_1_PROBE_RECOVERY BIT(22)\n \n@@ -615,6 +618,7 @@ enum {\n \t GDMA_DRV_CAP_FLAG_1_SELF_RESET_ON_EQE | \\\n \t GDMA_DRV_CAP_FLAG_1_HANDLE_RECONFIG_EQE | \\\n \t GDMA_DRV_CAP_FLAG_1_HW_VPORT_LINK_AWARE | \\\n+\t GDMA_DRV_CAP_FLAG_1_PERIODIC_STATS_QUERY | \\\n \t GDMA_DRV_CAP_FLAG_1_PROBE_RECOVERY | \\\n \t GDMA_DRV_CAP_FLAG_1_HANDLE_STALL_SQ_RECOVERY)\n \ndiff --git a/include/net/mana/mana.h b/include/net/mana/mana.h\nindex 9d3dce07d020..27f2ad47a1ed 100644\n--- a/include/net/mana/mana.h\n+++ b/include/net/mana/mana.h\n@@ -482,6 +482,10 @@ struct mana_context {\n \n \tstruct workqueue_struct *per_port_queue_reset_wq;\n \n+\t/* Workqueue for querying hardware stats */\n+\tstruct delayed_work gf_stats_work;\n+\tbool hwc_timeout_occurred;\n+\n \tstruct net_device *ports[MAX_PORTS_IN_MANA_DEV];\n \n \t/* Link state change work */\n@@ -584,7 +588,7 @@ u32 mana_run_xdp(struct net_device *ndev, struct mana_rxq *rxq,\n struct bpf_prog *mana_xdp_get(struct mana_port_context *apc);\n void mana_chn_setxdp(struct mana_port_context *apc, struct bpf_prog *prog);\n int mana_bpf(struct net_device *ndev, struct netdev_bpf *bpf);\n-void mana_query_gf_stats(struct mana_context *ac);\n+int mana_query_gf_stats(struct mana_context *ac);\n int mana_query_link_cfg(struct mana_port_context *apc);\n int mana_set_bw_clamp(struct mana_port_context *apc, u32 speed,\n \t\t int enable_clamping);\n", "prefixes": [ "SRU", "Q:linux-azure", "2/3" ] }