Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217313/?format=api
{ "id": 2217313, "url": "http://patchwork.ozlabs.org/api/patches/2217313/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-13-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-13-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:43", "name": "[12/16] ncr710: clean up ncr710_transfer_data", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e930ba5e374b463dfd57ef389e0dd64253692930", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-13-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217313/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XmNZ6bDZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=qsrVPpO2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDJm1F2Rz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:28:08 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EiH-0005mh-A6; Fri, 27 Mar 2026 17:27:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EiF-0005Yu-Cb\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:27 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EiD-0003p5-OZ\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:27 -0400", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-586-uydHhSxyOyqO2FRWK0zR4w-1; Fri, 27 Mar 2026 17:27:14 -0400", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-43b96365ea8so2481924f8f.2\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:27:14 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21f1749sm790860f8f.14.2026.03.27.14.26.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:27:00 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646843;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=V8WL7DzJeKU4ayulWVhy2puPdPuY2wFd4bIkD8S1wS0=;\n b=XmNZ6bDZqrh6CIkC5o8c7+5wGcMsKQnK4ORxKPP09/DD336PBkxaUtLAm3t/6c0n3n6sja\n U07z8ckNpWMG43huCZVoaZwPiSmtuAg0Uz/ENntKOvxvCQu+9d/txFsGcw2MVjRgcSoMS7\n LbgM+9ibpoNlb9VhzIMPLoKCp/QUjtA=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646826; x=1775251626; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=V8WL7DzJeKU4ayulWVhy2puPdPuY2wFd4bIkD8S1wS0=;\n b=qsrVPpO2EWe+ZMcUfPdBYh6GZHKhY9KZRumETfQVYKSYNh706SBIZgnIZFVwDg45kv\n w3eY/ldxxO8dphS8MLYTl9uEuXf+E4svDWHJRJmQqDgLtOScECSmBh3X49rxErFgIh3L\n 888c871YMcX8H8mCh2k2l+eILJNqq4zEMChd+nj+9M/aLYqth3dA86n2PkMnWscpsBZq\n Xo5IrOegGRgNrMikhV6mpxYPgdd1wX0H+CuOrp/7LZhNVAt25HbtuD2CaWxTDvH3nr1G\n Ssw7l9ONZ/keRXn3oXi3WA00pFobVHoX++EgdtdTSYys7C5RG3CEH+Wdhmd4fATe0mpY\n xfPw==" ], "X-MC-Unique": "uydHhSxyOyqO2FRWK0zR4w-1", "X-Mimecast-MFC-AGG-ID": "uydHhSxyOyqO2FRWK0zR4w_1774646831", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646826; x=1775251626;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=V8WL7DzJeKU4ayulWVhy2puPdPuY2wFd4bIkD8S1wS0=;\n b=Tq1yglkcKuRJAgCax0dtcxv6DRF4uZuNHkUomI71YyHeB1VE+jGRig5X5fSiRi5bIq\n 1QcY0nLArpJZ2UKu8YkGtufbsbdH/NQl6rsNtoi6wRMs8S55tsVkt7NC7NpRPuYoGr/v\n I+OBWmHN7OlIvwnt1ZU4HUdkysBwloc0T4eJKWlOIUNMxee+JV9f7k2g2924jqi4msf6\n naxR0EyrInB1ieKbwdkfFq5LyEp4/5qwQNCUN5cfmFcCgP8IonwpqgGiLKIzMQOfoRsj\n oUqsQNpIgOJPaSnTO2rFEFbICVBBpqstfNHmzpt3g9ul1Y3R62wJH8vAuNdWvwpD/5g9\n nbvA==", "X-Gm-Message-State": "AOJu0YymdPxlZocJ3uztl1wcAeUzUcwey/dL7GjdCgMEl42DcORvseGd\n E1Nj8XJP2uVH+aeRkdd7t+0xzPzfNz3XA31WKLsdYj5yvaDUcoZt4E91novDkQ/NxSMjtiNbSHb\n 40RP67w18384OJMIIiqOfdGlpx7BUX4I66/H2eN3uNfnajUTgRd34qz8FmWfI+IuQsYocE3TdmZ\n x6AB8dtlGavcEpgOB4p5I1aOWHjXvYrlZj+XH2rUAm", "X-Gm-Gg": "ATEYQzyggaVrS65RPX2eYUxalhcR1ZmG2Qn20qfr4NTxbctGANSBUe5EElgFMuPoPgQ\n otvpEr0j/y1rsF9U3Ajc1VJ0bgLB02ptISc3IsaCbaNMKYf25Ls9eMlhiF1rex/UmNG3S98moCL\n Je6MPASjrNH7wKo7pYhT84L9ts3LCfShV1JmUhVi/ei2/XFGNI2wUk0JqexM+ocv1GbTtQvkXZc\n 6jLVxiGPWtpWLC7G9i4Dzb5Fn4aBjO51HcHphpsBMjivQNi3Ok7iFJ/50H+fVMybCYoV7hEo7vD\n SW9QQChxtBlYzCgfpABWKV7Zy9D9Wjb10eKBnA5DGiwr6I0pCbAU2QV6tQwxsTKEDov0ubou+qO\n SePnkU5ACUi7rxEWlvRspic3C2Wjkb61Cjgj+2uz8z3QR3FlWkQf6vn4y+rzQFronaUS0IhaVb4\n v9p3Pe6D1T0Ht5S89ZsKAjooz7", "X-Received": [ "by 2002:a05:6000:40cb:b0:43b:5003:e300 with SMTP id\n ffacd0b85a97d-43b9ea66e1emr6684259f8f.43.1774646825988;\n Fri, 27 Mar 2026 14:27:05 -0700 (PDT)", "by 2002:a05:6000:40cb:b0:43b:5003:e300 with SMTP id\n ffacd0b85a97d-43b9ea66e1emr6684205f8f.43.1774646825382;\n Fri, 27 Mar 2026 14:27:05 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>", "Subject": "[PATCH 12/16] ncr710: clean up ncr710_transfer_data", "Date": "Fri, 27 Mar 2026 22:25:43 +0100", "Message-ID": "<20260327212547.460420-13-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Move the short ncr710_execute_script case first. Remove redundant\ns->current check.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/ncr53c710.c | 65 ++++++++++++++++++++++-----------------------\n 1 file changed, 32 insertions(+), 33 deletions(-)", "diff": "diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c\nindex fd03f243eda..f768ad74237 100644\n--- a/hw/scsi/ncr53c710.c\n+++ b/hw/scsi/ncr53c710.c\n@@ -842,43 +842,42 @@ void ncr710_transfer_data(SCSIRequest *req, uint32_t len)\n }\n s->current->dma_len = len;\n \n- if (s->waiting) {\n- s->scntl1 |= NCR710_SCNTL1_CON;\n- s->istat |= NCR710_ISTAT_CON;\n- s->sbcl = NCR710_SBCL_IO | NCR710_SBCL_CD | NCR710_SBCL_MSG |\n- NCR710_SBCL_BSY | NCR710_SBCL_SEL | NCR710_SBCL_REQ;\n- uint8_t host_id = (s->scid & 0x07);\n-\n- /* Special case: both target and host are ID 0 */\n- if (req->dev->id == 0 && host_id == 0) {\n- s->sfbr = 0x00;\n- } else {\n- s->sfbr = (req->dev->id == 0 ? 0 : (1 << req->dev->id)) |\n- (host_id == 0 ? 0 : (1 << host_id));\n+ if (!s->waiting) {\n+ if (!s->script_active) {\n+ ncr710_execute_script(s);\n }\n-\n- ncr710_set_phase(s, PHASE_MI);\n-\n- if (s->current) {\n- uint8_t identify_msg = 0x80 | (req->lun & 0x07);\n- ncr710_add_msg_byte(s, identify_msg);\n-\n- if (s->current->tag) {\n- ncr710_add_msg_byte(s, 0x20); /* SIMPLE_TAG_MSG */\n- ncr710_add_msg_byte(s, s->current->tag & 0xff);\n- }\n- }\n-\n- s->sstat0 |= NCR710_SSTAT0_SEL;\n- s->istat |= NCR710_ISTAT_SIP;\n- s->dsps = RESELECTED_DURING_SELECTION;\n- s->waiting = NCR710_WAIT_NONE;\n- ncr710_update_irq(s);\n return;\n }\n- if (!s->script_active && !s->waiting) {\n- ncr710_execute_script(s);\n+\n+ s->scntl1 |= NCR710_SCNTL1_CON;\n+ s->istat |= NCR710_ISTAT_CON;\n+ s->sbcl = NCR710_SBCL_IO | NCR710_SBCL_CD | NCR710_SBCL_MSG |\n+ NCR710_SBCL_BSY | NCR710_SBCL_SEL | NCR710_SBCL_REQ;\n+ uint8_t host_id = (s->scid & 0x07);\n+\n+ /* Special case: both target and host are ID 0 */\n+ if (req->dev->id == 0 && host_id == 0) {\n+ s->sfbr = 0x00;\n+ } else {\n+ s->sfbr = (req->dev->id == 0 ? 0 : (1 << req->dev->id)) |\n+ (host_id == 0 ? 0 : (1 << host_id));\n }\n+\n+ ncr710_set_phase(s, PHASE_MI);\n+\n+ uint8_t identify_msg = 0x80 | (req->lun & 0x07);\n+ ncr710_add_msg_byte(s, identify_msg);\n+\n+ if (s->current->tag) {\n+ ncr710_add_msg_byte(s, 0x20); /* SIMPLE_TAG_MSG */\n+ ncr710_add_msg_byte(s, s->current->tag & 0xff);\n+ }\n+\n+ s->sstat0 |= NCR710_SSTAT0_SEL;\n+ s->istat |= NCR710_ISTAT_SIP;\n+ s->dsps = RESELECTED_DURING_SELECTION;\n+ s->waiting = NCR710_WAIT_NONE;\n+ ncr710_update_irq(s);\n }\n \n static int idbitstonum(uint8_t id)\n", "prefixes": [ "12/16" ] }