Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217310/?format=api
{ "id": 2217310, "url": "http://patchwork.ozlabs.org/api/patches/2217310/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-6-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-6-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:36", "name": "[05/16] lsi53c895a: keep SCSIRequest alive during DMA", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69dc8849a7eaaff2aa618f2fa4beb4f4ad3635ba", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-6-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217310/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217310/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PzJHE7O0;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=fPt59BAl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDJN1L5kz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:27:48 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EhM-0002ui-KP; Fri, 27 Mar 2026 17:26:32 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhL-0002tq-Kq\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:31 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhK-0003dt-A7\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:31 -0400", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-351-cjdAACioPq2zLwSPM7PsFQ-1; Fri, 27 Mar 2026 17:26:28 -0400", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-439ae2cba40so1932536f8f.1\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:27 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf1db08e6sm1906528f8f.0.2026.03.27.14.26.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:19 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646789;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=PzJHE7O0cF8DZPtF3M7Aa6amVMUYiY7AauyF26oQIuNVbfATYhiIKiXhmkULuQJI+w/SHp\n kDm9OfYIklorzAztt49/Tm7VIxD4mwPETtVU4zyl+SrxVNoI/GPArMWX3ZeoAj6mEDsdcb\n J2H/xLDIZ30aNXOZQw5ZKKJHiMqbK48=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646784; x=1775251584; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=fPt59BAlMlA+BtANcCh+Vf4pk3nN3LKgMYStC2O7/ZxMxOudJahyK93Zo5p4GKwRHS\n C2rJMs1OVjSFGAq+eE0nbyYK9aUEyp0nJyNZUdpRr8wcGZ/zLheOLb0MOFT8WOsSbmCg\n 3PjrRa0awNJqNjC/oE7X8DxSz6se+V8gqZ9pVYrIlzV7Gc30erKOVcHFfF8v+Wvq69na\n awn96dT2lZnQB+LXaf272Gu16jZtYC2ELR5FZ0xCHf/AubH9f/5//AXbq/ZPdjmheU/I\n Q4Jc9Ow0bG+ldn8Ijjt6U/wY4zpe9Qfevsx02OHc86AZeNAFumR0la3lQrRyDaUHzsCq\n q+lg==" ], "X-MC-Unique": "cjdAACioPq2zLwSPM7PsFQ-1", "X-Mimecast-MFC-AGG-ID": "cjdAACioPq2zLwSPM7PsFQ_1774646787", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646784; x=1775251584;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=iZniXf7Th5qb+Qh//mdwiOoh7tVxEGpoHVgDrxDagI0=;\n b=RX0pwF8sAHwSwXWAXzmuJfNaWV6K4Qp2gC/F7fIEifNi0uNT9zscdZer4Jx5NARQHA\n bnU20pdfbUoguRmDkcodsLKLRD0xS0c4NwKVg6uccsta3N1bWaroO/DITeU5TS072pY8\n OolXH1widNc8iN+3pAv70lqobZ8AUsWSvTBBvlhk6xJ6j9AitkGbkxdAhKi+SMjLCWUq\n kBJHU+jBnbfiBj7f+EXNNNQ+K3M7NDXJtvPEYRc6T3i72go8QbOT0cEjuV6yrdi+4OBE\n 0pm8aE82XnSNt9vy4fFBwbbhLwnIMYztj6ZmjFxKIDxGdw7WpiOPxkYvXAr8hPQcOT4o\n gmJw==", "X-Gm-Message-State": "AOJu0YwX2Z2g/dA0y39fERWBDtx3V+NGYf+qmhSq5qmDye0rt/78sfdx\n b8cSdbovTaR9Q/6ncEVloLt+M5vnxiDkDuYL9VaVxH43VTKavyDqZ7IGPQMFEO7VVUk9N4AkN4u\n SF9KQkFZRcY2m7KmgeT0Hn5WJekHwSL3OVTToM1cHGKOVEWT6B5V+CUAdQ8IHUnKC/cRPTLnkep\n /KuslbB2FnsFQQMyS4iaJgxTTiMhWJF6HgV8yjTLLR", "X-Gm-Gg": "ATEYQzy5bprq38eIe+NlaEwi6t+wpmgC3nYCALlqz+eU6dqrByrb0WQzNrg6mlbz9wf\n kBBJVmJ6aW73BK9+n7BzCxFKNfDXiWcxuizly+93xcNoK7DpyuOn/xG/X9mOy1LwBEuLZM3P7Ug\n ALafsILTlBjq6iJXQ/txdoTJwNmtaQswTEKwptxmsIjSIUTx78RYVRdJfOhAvykJBIwZfdqfkrm\n qw78+TIjsvHxtwx5HdhIihTlwDl3sml6tXRErgChyEvDnOoD4lYpl8Z3ao0Dek2xj5rWDRRu9W7\n gZ/pliwrjsz+whVKGAlXds1YHm+bDAYOQJjx1Nk2nb2j1iKjL1oEcn4TGkJe5JuRlVRlYBEKL4n\n qZ90PA8sWe0CrdMvrflFw/8qqGuD8D0DHRGkuEiumHYlcBjom8ytLAADXqr7OlRnEeOjs4O4gUO\n 8bPx2ga3gZhu005+uB5bVDCHR5", "X-Received": [ "by 2002:adf:ec4f:0:b0:43c:dc99:7722 with SMTP id\n ffacd0b85a97d-43cdc99778amr1474189f8f.42.1774646784320;\n Fri, 27 Mar 2026 14:26:24 -0700 (PDT)", "by 2002:adf:ec4f:0:b0:43c:dc99:7722 with SMTP id\n ffacd0b85a97d-43cdc99778amr1474152f8f.42.1774646783701;\n Fri, 27 Mar 2026 14:26:23 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>, Jihe Wang <wangjihe.mail@gmail.com>,\n qemu-stable@nongnu.org", "Subject": "[PATCH 05/16] lsi53c895a: keep SCSIRequest alive during DMA", "Date": "Fri, 27 Mar 2026 22:25:36 +0100", "Message-ID": "<20260327212547.460420-6-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reentrant MMIO can cause the SCSIRequest to be completed, at which\npoint lsi_request_orphan would drop the last reference. Anything\nthat happens afterwards would access freed data. Keep a reference\nto the SCSIRequest and, through req->hba_private, to the lsi_request*\nfor as long as DMA runs.\n\nReported-by: Jihe Wang <wangjihe.mail@gmail.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex b882fc02276..54123f77579 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -637,7 +637,7 @@ static void lsi_do_dma(LSIState *s, int out)\n }\n \n p = s->current;\n- req = s->current->req;\n+ req = scsi_req_ref(s->current->req);\n dev = req->dev;\n assert(dev);\n \n@@ -667,6 +667,11 @@ static void lsi_do_dma(LSIState *s, int out)\n } else {\n lsi_mem_write(s, addr, p->dma_buf, count);\n }\n+ if (p->orphan) {\n+ scsi_req_unref(req);\n+ return;\n+ }\n+ scsi_req_unref(req);\n \n p->dma_len -= count;\n if (p->dma_len == 0) {\n", "prefixes": [ "05/16" ] }