Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217309/?format=api
{ "id": 2217309, "url": "http://patchwork.ozlabs.org/api/patches/2217309/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-8-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-8-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:38", "name": "[07/16] lsi53c895a: always use enum constants for s->waiting", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ea254fca9ab2558a7ee8983ef43c92df78e9d62e", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-8-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217309/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NSaWbBuo;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=I+rVMam6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDJD0tg4z1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:27:40 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EhY-0003Eb-By; Fri, 27 Mar 2026 17:26:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhW-0003E5-KA\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:42 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhV-0003h4-76\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:42 -0400", "from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-561-LAf42xDPORuFuAcIyP2UeA-1; Fri, 27 Mar 2026 17:26:39 -0400", "by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-48534941525so32035095e9.2\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:38 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48725ebe9dfsm33989145e9.4.2026.03.27.14.26.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:31 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646800;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Ag0x9W61+MLi+fSgFl+jWBLoe9JN7um6jSU0ZIBfrJQ=;\n b=NSaWbBuo9x/R8XU6/do4jI39zULSbd1ugdaiRjJwGqyScj1tTL2/iSgRXwGCDiP7ojOwoV\n FhCNZUNOQxfANBanO9GOwEA7qF2r9J7dSVznNyNsDWaxDDfE0gf8+FJC3bEroFkR4jVjE1\n Id+nyiSGCd153NLvLVGNQYKSXi4jTSQ=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646795; x=1775251595; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Ag0x9W61+MLi+fSgFl+jWBLoe9JN7um6jSU0ZIBfrJQ=;\n b=I+rVMam6zBIEhspQP+bERPn4izbkbZfHp/qErWBlKatjnydB+gVu6YQ6jUIL9NdLaw\n XR5V/eM3ouXsO8FQWW7wi6bE+oDYQpJaVD2IlRkZSVFynZPhoRxoEXEZDl83XOpSCKD/\n R1pr1sgrk/Y/CBZpn/gnTPLaMIBmZ2wtzFOTrG26nJOCg7mZaem7YhgHGZbi69wdDt4Y\n OoXNIavaHQfoXq7swZmacv8Uc8oh6JSq7gCebPwuueds+BSpDrUX6LSimZh5HN0B+o7T\n VV/DQoVltNhLfpom2Ykj8KMgwVge6cUQZsPvDjkA7cWr2oh9z5HWqFOD8/YATw1cGaZ/\n CJdg==" ], "X-MC-Unique": "LAf42xDPORuFuAcIyP2UeA-1", "X-Mimecast-MFC-AGG-ID": "LAf42xDPORuFuAcIyP2UeA_1774646798", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646795; x=1775251595;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Ag0x9W61+MLi+fSgFl+jWBLoe9JN7um6jSU0ZIBfrJQ=;\n b=PW0CudDSuDh7gbfjsu29CgHs52vG4rcK5SHCoRHQ6LSpLvz21WNTFII2NabMll4DhH\n 9dm6a1lgo94657Q8LtPLnFxsP9EzAxRJ+rC3FjYbvEKArdNtFGGo5bIykJ72aMwm8Lcg\n fg6Oo/N9Z4Dj0+Rq6o+GVllPmko14CW9r9DXU1URu6jkcCs0XPqNE4Hoi8Z/T4azfqC0\n Bb0rr5oQSRJ2mO/BZ+u/VwoXFgaDar0RZADIoxS3bB68Z1C4fTjgvHDUPPgten2+Q27W\n 6dtjs0nUdspbapqZtdLUQUyfO16JcxJRQl/ooxqpadRZZ6plzpOL1TYHzkRylzbVEu50\n nI3Q==", "X-Gm-Message-State": "AOJu0YwTgEjJdMYbMUuPE+rc4L86crb9zXI4RFhl5aifGkheYBBkRzVe\n 0J2hCgN3h1MP1UQwiiEcfUGvoh/1bp46MQqKCvDs4DAzkMoj2cumA23ui7quMc8FnM3veRzFXZz\n M/7RJcn4+xc2At/UDl3px0ed7U4O9amGx7gVM79KYvgw+2MMK0wXTZlBn3wATU3BE3qEBO5KsDC\n HIOhIas7bORf2+4q9a9moQdWBFq/XVWBX/ZeBbb0/l", "X-Gm-Gg": "ATEYQzz56PsJejLwHkOravjLy8FsvdCSl1K1t7OW+CRe7i1ijoTJqKOmHMMqs5yO6Ac\n gsE1Kyrq3MbirMX8ryP6YVvAknB2vukWmH7K8Cv7TC4ACN1jqj6YjQv4HBGgeh2VSCNiLF9W76N\n BII+QF3V4M4j5ZyNjfYnyzKTFWn4wiebPcStNSMLm0QRbBH1c2z4PdP6uoW4nkIfT2+961CYUjP\n lUqcRTA9lXn17ABG9U45L+63zZE52Uv1rG7o7MMhb3SPSJR7SsYC7d+AokE9wjmXP3vCXsYoRBA\n GZvFutVO1xqye4atL7k4dbGOFEFaw4YkIPGy0x/6e7U+YI1aS4amEJwXkV249yx1YiyGsUaOENg\n LeJye5bdfmptMvgBZlu4j66cxOHTx0Ctpn87PJUJXT1JmVK8e7GO3KhimCDfY7i4j7I0ku6t9zK\n 0ifD73hYonIweG9C5vFfKC30CI", "X-Received": [ "by 2002:a05:600c:6487:b0:485:3d00:efd with SMTP id\n 5b1f17b1804b1-48727d679e5mr66323035e9.7.1774646795475;\n Fri, 27 Mar 2026 14:26:35 -0700 (PDT)", "by 2002:a05:600c:6487:b0:485:3d00:efd with SMTP id\n 5b1f17b1804b1-48727d679e5mr66322815e9.7.1774646794952;\n Fri, 27 Mar 2026 14:26:34 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>", "Subject": "[PATCH 07/16] lsi53c895a: always use enum constants for s->waiting", "Date": "Fri, 27 Mar 2026 22:25:38 +0100", "Message-ID": "<20260327212547.460420-8-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 6b0c97d98e3..6f65a2188c1 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -201,13 +201,13 @@ typedef struct lsi_request {\n QTAILQ_ENTRY(lsi_request) next;\n } lsi_request;\n \n-enum {\n+typedef enum {\n LSI_NOWAIT, /* SCRIPTS are running or stopped */\n LSI_WAIT_RESELECT, /* Wait Reselect instruction has been issued */\n LSI_DMA_SCRIPTS, /* processing DMA from lsi_execute_script */\n LSI_DMA_IN_PROGRESS, /* DMA operation is in progress */\n LSI_WAIT_SCRIPTS, /* SCRIPTS stopped because of instruction count limit */\n-};\n+} LSIWaitState;\n \n typedef enum {\n LSI_CMD_SENT, /* command is running */\n@@ -239,7 +239,7 @@ struct LSIState {\n int msg_action;\n int msg_len;\n uint8_t msg[LSI_MAX_MSGIN_LEN];\n- int waiting;\n+ LSIWaitState waiting;\n SCSIBus bus;\n int current_lun;\n /* The tag is a combination of the device ID and the SCSI tag. */\n@@ -605,7 +605,7 @@ static int lsi_bad_phase(LSIState *s, int out, int new_phase)\n /* Resume SCRIPTS execution after a DMA operation. */\n static void lsi_resume_script(LSIState *s)\n {\n- if (s->waiting != 2) {\n+ if (s->waiting != LSI_DMA_SCRIPTS) {\n s->waiting = LSI_NOWAIT;\n lsi_execute_script(s);\n } else {\n@@ -822,11 +822,11 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n trace_lsi_command_complete(req->status);\n s->status = req->status;\n s->command_complete = LSI_CMD_COMPLETE;\n- if (s->waiting && s->dbc != 0) {\n+ if (s->waiting != LSI_NOWAIT && s->dbc != 0) {\n /* Raise phase mismatch for short transfers. */\n stop = lsi_bad_phase(s, out, PHASE_ST);\n if (stop) {\n- s->waiting = 0;\n+ s->waiting = LSI_NOWAIT;\n }\n } else {\n lsi_set_phase(s, PHASE_ST);\n@@ -861,7 +861,7 @@ static void lsi_transfer_data(SCSIRequest *req, uint32_t len)\n trace_lsi_transfer_data(req->tag, len);\n s->current->dma_len = len;\n s->command_complete = LSI_CMD_READY;\n- if (s->waiting) {\n+ if (s->waiting != LSI_NOWAIT) {\n if (s->waiting == LSI_WAIT_RESELECT || s->dbc == 0) {\n lsi_resume_script(s);\n } else {\n", "prefixes": [ "07/16" ] }