Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217307/?format=api
{ "id": 2217307, "url": "http://patchwork.ozlabs.org/api/patches/2217307/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-14-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-14-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:44", "name": "[13/16] ncr710: do not load s->current in advance", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1ce148fb321784ccfc74db96770dac8fce7551d0", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-14-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217307/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=K1wJh/fL;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=pUwdrosO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDJ3272hz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:27:31 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EiC-0005KU-UO; Fri, 27 Mar 2026 17:27:24 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EiA-0005Ct-N6\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:22 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6Ei9-0003oh-D8\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:22 -0400", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-59-OaygELqpNhyapIMMBB32qw-1; Fri, 27 Mar 2026 17:27:19 -0400", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-43b9a86b9b0so1556727f8f.0\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:27:19 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21e2487sm812846f8f.5.2026.03.27.14.27.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:27:06 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646840;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4hPfYq4/WFarXboY4nnyRVuUgvfU5bRhiXWfm+ko4U8=;\n b=K1wJh/fLvMtJsI+wwqBiimS1g++Z27THTf/V2C9rMKaeQ6iOKlQ0qvnsL37NZDfg3qv/Le\n sYkUDPRrQTAkLH4akaLz72xyEmjtlQZuVL92V6wYStunWQSX+871+UF9dQsmSkt/CK/B21\n HhKWFKayZZeuGlg0NTUdf/bt5HtCIYw=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646835; x=1775251635; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4hPfYq4/WFarXboY4nnyRVuUgvfU5bRhiXWfm+ko4U8=;\n b=pUwdrosOn9D1rh7KcmLZlm3wHD/cXPk6dkzflbFPZqYCMlZN5sFxDq/f7i0JIsn+rU\n 7O2hoKJfBiMp3Fbp9qftEgMo23pe3siiCnzA/OAGsf+Ys2/dMqjYzxsl36YOMCbH4xKp\n e38Moferjw/DaZFLo4f3sjcBuP/OM3xzWIFZ13mKrvfARiAn/SjVX3lAgnowJOgNkkGg\n DCi2tZtCCxjD+7h0C43LLPe4ZbveTKfgPZ7jjgF3FHttrRdumLmkaQ7guYIdNUCNfJiB\n 6uO3fVj0vEuUNr2DFU06x3OIM/IlWqAhM+kSmwpZ7zwfSH3GOS9AyzNFwJ6vpWqevd16\n VHfQ==" ], "X-MC-Unique": "OaygELqpNhyapIMMBB32qw-1", "X-Mimecast-MFC-AGG-ID": "OaygELqpNhyapIMMBB32qw_1774646838", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646835; x=1775251635;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4hPfYq4/WFarXboY4nnyRVuUgvfU5bRhiXWfm+ko4U8=;\n b=SSiNk9kHy06DQ3ZTGDIPdXUx5VaPCrD0W7moVgcbUOC0oiZtutXOQmQ7k4H40niZIm\n jm9xVyyD+ak0tW2+h+hS/pz+RgdlQzSVANXzBIG3AQoCOtvP8PbREOkRN6AfKxbpfqKc\n foxgI5V0vZxfTQNuKwza+hD+x2TUX5QvDtS5KyliDbJ5i5FqwjPKGt+ab6VMqgaG3Drh\n DnF/9O4n61ldz6FsJg9sQeRgk4MVbsLxZ1gPoie4SaAQbxJ7mDFeADLdKAv+bCrrGjZf\n mIf9OfdgLRWt4sbmsORTpjLMcmhviyX70ic8sSheGHgLgiEosRqHOlLOpqOmRSEmzDvZ\n KqNw==", "X-Gm-Message-State": "AOJu0YziD0FMguiTiWSfE+Qdty3dQr0dB3DzuB8bsS0HVOKqEl96P1iT\n mawkJOb3n1D2oD2dfuA/mfXApc7Aw+8kDlsmHGtJMqhq3DRzTRQW8WmtBBNetzihjuN0elPrSbc\n ULZovbXrbxA8p9bUp/R14z60KO9q1qvPAUisyAbBKbH02fwlKNDiJOgjgggW3VPrL53ovCpftk/\n oTaFQ5AvwmwFmXsdvIhsxVXveezNeFp7KahGAzpwA0", "X-Gm-Gg": "ATEYQzy1SCUFPYecsqCGfoRrf52DsKWVSp2FcL3T3VOe4Vkfwlo99TmLXXCqp+DTCVp\n qrJN7QzrlBbjnArn1rwSPBw0kcNfP7croCRiwUl9ZZ3enxj4bvmQLlAHHMmR8n2ukJCqMzHmfOe\n SVGobjOtDmaJ3xrij11gpJPHnyii43/oJ+O1W/WIMyELURQ2K0gNQi0cv7tkVotlB+wGiYlQwS2\n 6CQ/Ni1ELo1aa1JX2+BBneuxoLdWP0YDKifPV1IKlHAbvCTFzWsCVSY/EnA3pkwuSIiEsuvliyu\n 6V+lu8X86fN25aKhp8eIt3SvK2zj9o1Qo0TkZEuEwGH3FhlEZ4tBhXiQrMSks+XPTpCFOw9bMmb\n BKdyBCQGOTYUfhfbJuaL9hVz/Pubw32JiAwRQsrFMO7qIcXD968hgV7wZrMtFGPC3BIQKuxixpS\n EzJWTACkUWvMBlCeztW2ck5W8k", "X-Received": [ "by 2002:a5d:584b:0:b0:43b:7ff5:fdf7 with SMTP id\n ffacd0b85a97d-43b9ea4a3a8mr6435933f8f.29.1774646835586;\n Fri, 27 Mar 2026 14:27:15 -0700 (PDT)", "by 2002:a5d:584b:0:b0:43b:7ff5:fdf7 with SMTP id\n ffacd0b85a97d-43b9ea4a3a8mr6435901f8f.29.1774646835078;\n Fri, 27 Mar 2026 14:27:15 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>", "Subject": "[PATCH 13/16] ncr710: do not load s->current in advance", "Date": "Fri, 27 Mar 2026 22:25:44 +0100", "Message-ID": "<20260327212547.460420-14-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "It is unnnecessary and potentially could use stale data. Load\ns->current just before use.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/ncr53c710.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c\nindex f768ad74237..298e0317b70 100644\n--- a/hw/scsi/ncr53c710.c\n+++ b/hw/scsi/ncr53c710.c\n@@ -1040,8 +1040,6 @@ static void ncr710_do_msgin(NCR710State *s)\n \n static void ncr710_do_msgout(NCR710State *s)\n {\n- NCR710Request *current_req = s->current;\n-\n while (s->dbc > 0) {\n int to_move = MIN((int)s->dbc, NCR710_SCSI_FIFO_SIZE);\n uint8_t temp_buf[NCR710_SCSI_FIFO_SIZE];\n@@ -1169,8 +1167,8 @@ static void ncr710_do_msgout(NCR710State *s)\n break;\n \n case 0x0d: /* ABORT TAG */\n- if (current_req) {\n- scsi_req_cancel(current_req->req);\n+ if (s->current) {\n+ scsi_req_cancel(s->current->req);\n }\n ncr710_disconnect(s);\n break;\n", "prefixes": [ "13/16" ] }