Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217305/?format=api
{ "id": 2217305, "url": "http://patchwork.ozlabs.org/api/patches/2217305/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-11-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-11-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:41", "name": "[10/16] ncr710: remove weird p->req == NULL case", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "129467a60516cdbf9d92b7a20d9dc796104eaecd", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-11-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217305/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Vmzxgmzh;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=tB7kMR89;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDHw0FsHz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:27:24 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6Ehv-0003ui-AI; Fri, 27 Mar 2026 17:27:08 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6Ehp-0003fd-LQ\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:01 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6Ehl-0003iJ-Su\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:27:00 -0400", "from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-654-HFpQQ921MTSMdlM8WSCXIQ-1; Fri, 27 Mar 2026 17:26:55 -0400", "by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-4871fc50fe7so16847985e9.0\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:55 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48722d49c18sm115720295e9.14.2026.03.27.14.26.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646817;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=;\n b=VmzxgmzhYltZu+llmVcmKUainiiHDMzLlnFaeV19XEB7hatZxETTWJKgBfliPIk+dE/kRU\n Xpm96nAXEX+pMBxn7x3F0YSSAzDPhg06Myhthx+IRhfN4GcSX+XjCG8JmbywwJCd+8kI+7\n 6LEfrZoiQYZDc8kR2iitUg+VWJ+pdvo=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646813; x=1775251613; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=;\n b=tB7kMR89smjw2mOcULJ9lL30zg+EWagjKuOx1eUh6YstpVadFR4IZSvzyhtl3mnHmS\n REUtI8jVezDPO1y3bfkbQSZQUCxH4WiHwauGqWVoBwUvItVn7+bzlTyrEzodTICxOBTo\n QGay/6hhyEO+p2iwJmzZ6BFMFhH0JgsI5aQahPyNwhbskNCZlUYPDEiA3ETA01cmRtOV\n KnOi5Uf41j5EFpKhg3vQsFZWhZ/8jSreyd6Ap7NG461pD8isrR63EZgl0cO9FH10zWnX\n jN31QdFtUB589yKDTeWrNjoXaYzVwHECo00Lf10+ceXF+trxLeEezXiKLEW4o79VtGxX\n L6CA==" ], "X-MC-Unique": "HFpQQ921MTSMdlM8WSCXIQ-1", "X-Mimecast-MFC-AGG-ID": "HFpQQ921MTSMdlM8WSCXIQ_1774646815", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646813; x=1775251613;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6j+8F9WY80KMSNsIWnJr/7G6jY4kVXncWxg0JKnHv9A=;\n b=Hr3AYx7SVLWIoI+2bumWAip8hyeDpNCWStCjoHcgLmHi/PBM8yyFwB2p7kxAJlfF0O\n AlpoHegPewUlx+mo5KT4EB/0dL6kzmLzT0ETPRK+jd1vv+vKM7Qwpv88yRD6dzE+hBTw\n LQ0NIf4c33BcgZYNIZwjpQdsUPbhGOV1mFi8nyh2j8NKMJZiLKt7MVmkqwuwQIfKnTzr\n bGavpaMww43jsA48ZcGVdhPK7avOoMYlpcWtvPRAedkzRW/k7MJQns4OfNnfsATKbFAI\n LyORBLfmZhI8+ozw02j/ISnrLY4RsXi67RjmodwGFypMzQQXoX+NuviPliUDpgbhLAW/\n sS+A==", "X-Gm-Message-State": "AOJu0YwLFHRRvvS8mJIw/dReAWxYrgeSCdZy9KE6+aS/nYSBnrAO5VKL\n bGIvmFJGPciznD5Gs+IMCq+qP6cive+iHrhcN0H6YrKtnDePf8eTcBH8CCiDzXDlRyjxWw6QLVp\n ng3Hrck9ypI5OzMLWACXj8cjjpkqiddothKugEwsoNHHLaZT+Mov8yz1umaa1qqlJAYfeCwCUL7\n 1VNjCmirJuOm5Q2otN0USxArwkTMtq9zCf9J5GyWtc", "X-Gm-Gg": "ATEYQzwaCB4gxJVOXN+e5hkY/AwQNooyHlWoDb12X1GG2OXjhsQUIchz7IhnYMhzvu2\n jv0sKCTjmUwNiMEWqdpWffmauo7G96KCs3lZZdi4iNjIMLIHvNdJ9zpplQf66TEujfe0MqR2qp8\n uY2OvFmFUbewWzlPW9SLtY3Na4XJD5PqnbKCbOdEQeKoTPfw+2qROwL605dxm4D7R6YoEVgyeW7\n 19HfSgtnHkix9EX6oP+XhMYr2aEmogiWXnUKQEKTNmX6ZYPh+GDOq2UFiisO2XCD6DsTGj/4O+v\n bs48kS/sZPB3mZ4SeHmhDINkmoeqhNr+4IFHsxqqHVB6RdE2TV0oYjkSSPUkYkIH3uwmcBhertw\n uCDpMw6XXkL18rYOIJjWGgjn0bUWNS1k7cZtLoabThHhgsEZrz4p/D215qW4/QxZKoRlxFkehUD\n z2skyT0UVIkEuNs1Y1aoZhsfjv", "X-Received": [ "by 2002:a05:600c:a10a:b0:485:3f72:324d with SMTP id\n 5b1f17b1804b1-48727e9ea73mr65002955e9.14.1774646813588;\n Fri, 27 Mar 2026 14:26:53 -0700 (PDT)", "by 2002:a05:600c:a10a:b0:485:3f72:324d with SMTP id\n 5b1f17b1804b1-48727e9ea73mr65002735e9.14.1774646813152;\n Fri, 27 Mar 2026 14:26:53 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>", "Subject": "[PATCH 10/16] ncr710: remove weird p->req == NULL case", "Date": "Fri, 27 Mar 2026 22:25:41 +0100", "Message-ID": "<20260327212547.460420-11-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Setting p->req to NULL in ncr710_request_cancelled and ncr710_command_complete\nonly protects from clearing p->req->hba_private in ncr_request_free. However,\nin this case p->req->hba_private must have been already cleared (by the same\nncr710_request_cancelled and ncr710_command_complete); so the reference to the\nSCSIRequest can be kept until ncr710_request_free (called eventually by e.g.\nncr710_do_command) and that assignment can be made unconditional in\nncr710_request_free.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/ncr53c710.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)", "diff": "diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c\nindex 7503d791205..ff0d3cf0c86 100644\n--- a/hw/scsi/ncr53c710.c\n+++ b/hw/scsi/ncr53c710.c\n@@ -735,12 +735,11 @@ static void ncr710_add_msg_byte(NCR710State *s, uint8_t data)\n \n static void ncr710_request_free(NCR710State *s, NCR710Request *p)\n {\n- if (p->req && p->req->hba_private == p) {\n- p->req->hba_private = NULL;\n- }\n+ p->req->hba_private = NULL;\n if (p == s->current) {\n s->current = NULL;\n }\n+ scsi_req_unref(p->req);\n g_free(p);\n }\n \n@@ -750,10 +749,8 @@ void ncr710_request_cancelled(SCSIRequest *req)\n NCR710Request *p = (NCR710Request *)req->hba_private;\n if (p) {\n req->hba_private = NULL;\n- p->req = NULL;\n ncr710_request_free(s, p);\n }\n- scsi_req_unref(req);\n }\n \n static int ncr710_queue_req(NCR710State *s, SCSIRequest *req, uint32_t len)\n@@ -795,12 +792,9 @@ void ncr710_command_complete(SCSIRequest *req, size_t resid)\n \n if (p) {\n req->hba_private = NULL;\n- if (p == s->current) {\n- p->req = NULL;\n- } else {\n+ if (p != s->current) {\n ncr710_request_free(s, p);\n }\n- scsi_req_unref(req);\n }\n \n if (s->waiting == NCR710_WAIT_RESELECT || s->waiting == NCR710_WAIT_DMA) {\n", "prefixes": [ "10/16" ] }