Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217302/?format=api
{ "id": 2217302, "url": "http://patchwork.ozlabs.org/api/patches/2217302/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-7-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-7-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:37", "name": "[06/16] ncr710, lsi: use same enums for command_complete", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "de546d8fcb95beb45cda7f41b7b6043ec6b0e7e9", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-7-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217302/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217302/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AxXj8/kk;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=L9z9IXAc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDHZ5Fmwz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:27:06 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EhT-0003CR-3v; Fri, 27 Mar 2026 17:26:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhR-00035P-El\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:37 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhP-0003gJ-Qx\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:37 -0400", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-137-eiqHmz1MNsqbAqmgxCTQWA-1; Fri, 27 Mar 2026 17:26:33 -0400", "by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43ba0d2e46dso812023f8f.3\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:33 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21f173dsm909682f8f.15.2026.03.27.14.26.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:24 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646795;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=cUsd9sUtiSiyq2C2ZiaTTBXPp31lw16nowEZdc00IaI=;\n b=AxXj8/kkjJT8T4VB6My2V5bXEA99FVMF4Dc6ZswdZhMdx0rTYWlmqBep1MXhZq3SrbfTZC\n MvlFSAfLp5lZ2u/mCcYf6Lsv8cLSEAapNJKnSAq8fjAIAJc+RHr8WQ5OtTmMNguR4U91nX\n 4cTvVe1S1Il1O0rek4O6Qtv2z/xEPhQ=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646790; x=1775251590; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cUsd9sUtiSiyq2C2ZiaTTBXPp31lw16nowEZdc00IaI=;\n b=L9z9IXAcy4WvW85xDAddNB/01/asuAm5ojRCfdG5FO5X/kmiHNyOq3D6mBFp3PSSoH\n 5qdMlWgCtKhjBI0cO6VHxK/1OwRYIp2TsWZzdM7/bt8o8mXPNXS0mw3PSexwul6I+Dj3\n VOTJEofffAvtBBBVGoO6MVWD82V8J/XoipalleBFLVuvrLd0cFvHaWRKOhyOOJol/Clc\n Sn4EJuumeOz7eXQNs/0qZShnLA0517RZUbqbwIIZ/2mGqQhmdLb92+fXAkAVM24yCpPz\n hx0SQAZylnsohWnR6O/QAnANHmVfGCsKPviC49Z3izm3cEdmjgSa9EVMsu5xiA8wR4fT\n JTZQ==" ], "X-MC-Unique": "eiqHmz1MNsqbAqmgxCTQWA-1", "X-Mimecast-MFC-AGG-ID": "eiqHmz1MNsqbAqmgxCTQWA_1774646792", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646790; x=1775251590;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=cUsd9sUtiSiyq2C2ZiaTTBXPp31lw16nowEZdc00IaI=;\n b=WeCvbn4WilOx0h0CagWAlnjUj6ViMmn+hu+UkIEZYvn+cfyKkHQmyrL9zo39UPJUmv\n EkeFydDRvOx++h8H8G3LoOPETcXI5vhvYtXFFuhOPXb1l5tfc1Pk2ywIvmK1/z2Y+iit\n PRxLD16kFn/c9wuUVVcpRE5QltIHLAdUFFJkRTjklRKF4qElxpnJK/4G/sbxyRStF+qI\n T/ZS69Ns0YWY8i4Me0NDhktdUaupJgHTZ9bHNWbNxQda9GxfgNaz2HrlMBgv8VF/3dfD\n bASxi78T0+e3jtf+hBbDla/6iv22JLZVZh0mDRKYN5d7mzXJkOvMUFfkY4z9mbUakKxk\n ztXw==", "X-Gm-Message-State": "AOJu0Yz95lG02hkzvpUbWLPcKgrrQbJTe5gZWDiuJxYqgyZbh3hWmiyv\n chnpulpR1lNOomazRf8a6QbsaDwA5jmIvP5DIknSUsQs0dYsqI4HHOjUG6juMrFOFWBeymsuYOe\n k2uCACT8MVzOi7oC1U22pKf+R7mwnBFGek3jg+609QfWMwHpPO07Nfjf59NgWl9vr5PdO4/a6Qp\n 5qT+1bsi+Wthg89kngNNEidPzN20ri+BcYDaEvcA2T", "X-Gm-Gg": "ATEYQzzKgtBW69DtXtiL2H/lt2036qupD4u0wltkquiK0dZr2t9j9gzmxQAVLJlKnQX\n 9AgLCaRtwdn6cMuNpeue1L0NMyToWUaWFgn4oVyFVOVzpDpV/Jw4tnZ8MPl9c5hwe7la2Ay0Cbp\n yJqddb23dLsdedNO8MyqEKTzxQYDHQYx/Y9ZkYGddzHtjU7EopDx645KRqWt4a6UMm9aC25GRwm\n MgurLOWX4mtqgwWT/1F8bmUr/xorCClkYf+I6Uxe2l2ltTPS7JtcNE3tATM9ufE8yZ2gdGQZR4S\n 9xp53IubSazEzpw8aQQts3ifELT0kbHngxZn6M/+UkXpP0CPR4DjLurIKYZIha1okKVmBUoXv06\n EItgmsM6kpsI2Rzrhouf03UE12vpuoy56PvmuGfRtpIZ+SEbulJb0srfGN1RXBQSc7Lu8MwMkD1\n gNashtld7QQymcseUZL5wZu2WB", "X-Received": [ "by 2002:a05:600c:8207:b0:485:3f1c:d887 with SMTP id\n 5b1f17b1804b1-48727ee4d13mr67741965e9.26.1774646790190;\n Fri, 27 Mar 2026 14:26:30 -0700 (PDT)", "by 2002:a05:600c:8207:b0:485:3f1c:d887 with SMTP id\n 5b1f17b1804b1-48727ee4d13mr67741705e9.26.1774646789627;\n Fri, 27 Mar 2026 14:26:29 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>", "Subject": "[PATCH 06/16] ncr710, lsi: use same enums for command_complete", "Date": "Fri, 27 Mar 2026 22:25:37 +0100", "Message-ID": "<20260327212547.460420-7-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The ncr710 and lsi53c895a HBAs share some of the logic, also make\nthem use the same enum for the command_complete variable. Change\nthe names for ncr710 to something that is more representative,\nfor example NCR710_CMD_DATA_READY might also indicate that the\ndevice is ready to *receive* data, not just that it has data\nready to send.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/ncr53c710.h | 4 ++--\n hw/scsi/lsi53c895a.c | 16 +++++++++++-----\n hw/scsi/ncr53c710.c | 10 +++++-----\n 3 files changed, 18 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/scsi/ncr53c710.h b/hw/scsi/ncr53c710.h\nindex 00b6a01577c..97f1bf5fe22 100644\n--- a/hw/scsi/ncr53c710.h\n+++ b/hw/scsi/ncr53c710.h\n@@ -100,8 +100,8 @@ typedef enum {\n } NCR710WaitState;\n \n typedef enum {\n- NCR710_CMD_PENDING = 0,\n- NCR710_CMD_DATA_READY = 1,\n+ NCR710_CMD_SENT = 0,\n+ NCR710_CMD_READY = 1,\n NCR710_CMD_COMPLETE = 2\n } NCR710CommandState;\n \ndiff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 54123f77579..6b0c97d98e3 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -209,6 +209,12 @@ enum {\n LSI_WAIT_SCRIPTS, /* SCRIPTS stopped because of instruction count limit */\n };\n \n+typedef enum {\n+ LSI_CMD_SENT, /* command is running */\n+ LSI_CMD_READY, /* one round of data transfer completed */\n+ LSI_CMD_COMPLETE, /* command completed */\n+} LSICommandState;\n+\n enum {\n LSI_MSG_ACTION_COMMAND = 0,\n LSI_MSG_ACTION_DISCONNECT = 1,\n@@ -238,7 +244,7 @@ struct LSIState {\n int current_lun;\n /* The tag is a combination of the device ID and the SCSI tag. */\n uint32_t select_tag;\n- int command_complete;\n+ LSICommandState command_complete;\n QTAILQ_HEAD(, lsi_request) queue;\n lsi_request *current;\n \n@@ -815,7 +821,7 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n out = (s->sstat1 & PHASE_MASK) == PHASE_DO;\n trace_lsi_command_complete(req->status);\n s->status = req->status;\n- s->command_complete = 2;\n+ s->command_complete = LSI_CMD_COMPLETE;\n if (s->waiting && s->dbc != 0) {\n /* Raise phase mismatch for short transfers. */\n stop = lsi_bad_phase(s, out, PHASE_ST);\n@@ -854,7 +860,7 @@ static void lsi_transfer_data(SCSIRequest *req, uint32_t len)\n /* host adapter (re)connected */\n trace_lsi_transfer_data(req->tag, len);\n s->current->dma_len = len;\n- s->command_complete = 1;\n+ s->command_complete = LSI_CMD_READY;\n if (s->waiting) {\n if (s->waiting == LSI_WAIT_RESELECT || s->dbc == 0) {\n lsi_resume_script(s);\n@@ -876,7 +882,7 @@ static void lsi_do_command(LSIState *s)\n s->dbc = 16;\n pci_dma_read(PCI_DEVICE(s), s->dnad, buf, s->dbc);\n s->sfbr = buf[0];\n- s->command_complete = 0;\n+ s->command_complete = LSI_CMD_PENDING;\n \n id = (s->select_tag >> 8) & 0xf;\n dev = scsi_device_find(&s->bus, 0, id, s->current_lun);\n@@ -900,7 +906,7 @@ static void lsi_do_command(LSIState *s)\n }\n scsi_req_continue(s->current->req);\n }\n- if (!s->command_complete) {\n+ if (s->command_complete == LSI_CMD_PENDING) {\n if (n) {\n /* Command did not complete immediately so disconnect. */\n lsi_add_msg_byte(s, 2); /* SAVE DATA POINTER */\ndiff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c\nindex 57967e7a84f..7113ce2d8a9 100644\n--- a/hw/scsi/ncr53c710.c\n+++ b/hw/scsi/ncr53c710.c\n@@ -849,7 +849,7 @@ void ncr710_transfer_data(SCSIRequest *req, uint32_t len)\n }\n \n /* Host adapter (re)connected */\n- s->command_complete = NCR710_CMD_DATA_READY;\n+ s->command_complete = NCR710_CMD_READY;\n if (!s->current) {\n return;\n }\n@@ -924,7 +924,7 @@ static void ncr710_do_command(NCR710State *s)\n s->dbc -= bytes_read;\n s->sfbr = buf[0];\n \n- s->command_complete = NCR710_CMD_PENDING;\n+ s->command_complete = NCR710_CMD_SENT;\n id = (s->select_tag >> 8) & 0xff;\n s->lcrc = id;\n \n@@ -1279,7 +1279,7 @@ void ncr710_reselection_retry_callback(void *opaque)\n p->pending = 0;\n \n SCSIRequest *req = p->req;\n- s->command_complete = NCR710_CMD_PENDING;\n+ s->command_complete = NCR710_CMD_SENT;\n p->dma_len = len;\n \n s->scntl1 |= NCR710_SCNTL1_CON;\n@@ -1466,7 +1466,7 @@ again:\n break;\n case 1: /* Disconnect */\n \n- if (s->command_complete != NCR710_CMD_PENDING) {\n+ if (s->command_complete != NCR710_CMD_SENT) {\n s->scntl1 &= ~NCR710_SCNTL1_CON;\n s->istat &= ~NCR710_ISTAT_CON;\n s->waiting = NCR710_WAIT_NONE;\n@@ -1640,7 +1640,7 @@ again:\n \"preserved for driver processing\\n\");\n ncr710_script_dma_interrupt(s,\n NCR710_DSTAT_SIR);\n- s->command_complete = NCR710_CMD_PENDING;\n+ s->command_complete = NCR710_CMD_SENT;\n } else {\n ncr710_script_dma_interrupt(s, NCR710_DSTAT_SIR);\n }\n", "prefixes": [ "06/16" ] }