Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217299/?format=api
{ "id": 2217299, "url": "http://patchwork.ozlabs.org/api/patches/2217299/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-4-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-4-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:34", "name": "[03/16] lsi53c895a: keep lsi_request and SCSIRequest in local variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9e3af0200e840c8717e342fd9adb731488d268cc", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-4-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217299/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=CvJ8+sxS;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=qUiiukuU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDHJ6pr7z1yGQ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:26:52 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EhC-0002pc-NS; Fri, 27 Mar 2026 17:26:22 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhA-0002p9-Vh\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:21 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6Eh7-0003bW-Gu\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:18 -0400", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-336-s9pHYuhnNYu7LVNfjoc0rA-1; Fri, 27 Mar 2026 17:26:13 -0400", "by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-439f5c57c52so735573f8f.1\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:13 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21e2487sm808172f8f.5.2026.03.27.14.26.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:05 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646777;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=CvJ8+sxSLLZQ9RZisbFGDH9D2rTjlUUjtv07qpUAxWlfz4Lmb7nvEeJLsLCNvE2L1Fwm3C\n Pxdux/emwmHNOhp59mnM21Et5KDSH+Nu6JJ63jbNmxnMqUm34rDHsyN7mpL+s1flo/dsen\n cocoMv+yvayT8hmn95C73sU59umvVm0=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646771; x=1775251571; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=qUiiukuUHFeQaAetHd3uKKFJBynp797tO7Gjxc88LnFSs2SrgwZ/hLM0ysLSZIF11a\n 4OB+znHbFI0ieWvMIsC3TspFmbTdyqsD4G9+UfEnXFlbW+C6FltHs8jw2tqiX/UDha52\n vGJ2GyJq3rcoUa3K+u18ifxj+CC1LCbGN//yeaNyIIr+HtOO5gSoO0whnIPqN3zAH2qn\n /19gDVr+/muOMmEjHC6d+kdrrN8YSTCrmXgxxB5uXqIr7QkpXBlmQjMfA0UHH8h9sPem\n CW7z0/Uk7nzBdGl9CNDvygjwFnPAuIep88WF82JOkDM1Yw69PAp00zRWK23eaEaB7wvL\n mXwQ==" ], "X-MC-Unique": "s9pHYuhnNYu7LVNfjoc0rA-1", "X-Mimecast-MFC-AGG-ID": "s9pHYuhnNYu7LVNfjoc0rA_1774646773", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646771; x=1775251571;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=XB8m7Sndyux0qiJrEVjHOmARiOQkTMH4+4NUfWzFM0Y=;\n b=Euc3tgpV7tVkYyidFZw7I3hIxXTepk9jmU3Id+ZFs/H+Vmb8Ype+tC/0P/I+0yvzEV\n 3CJPyUA6u8XedklnwOMuYNa1qN0Mkt4KfV85rFJdRUxh1nTODEfThO58E5XicB+YDABD\n WTMsFvw8fRHYe9VC5BsIp4eiIvJ6xv9485jsYO1Ec1YSSs+yAHizFNeniTj3KhHbnO+8\n KNaeLY6w/ZQtZ7JuX89b3I5ZQfkwNUl4HWV8oKsZJ+anKHcRRlIyZdgKc+UXGzawygrs\n iHkgap6F7/walHc2KM7bSxkmUTce/fW+yocRQJDWNZWZ2903OEGBLA0+rrD3m42eCAto\n k2xg==", "X-Gm-Message-State": "AOJu0YzXKaPOFyX2S6CzQL0A9+h23L20YNkNgJI8hRN2Ws1WnescRflm\n a/p+M/vV1wiMQdjAvlpEGnUVEMEQd0yvir9/iKdofgup6iUrpuJM2O4MDpi6jGbRpuraxRyfiZY\n 7CQ6VIA7dwQdJ3DIUta+qOxKK309NH+SZWK9D9xvJ/SuLEebzC90xqBDR8/o+l+A1RYJHzxQy44\n /wEx7st789ri/3t6/IJg0IGGoRy56Onrm+aw5Rz1XS", "X-Gm-Gg": "ATEYQzzHtVdfdZTwGR+iwdVPzGe4a2cUeVQcbIcVMOpqqDWicccDgdaPfFx3XxQ4YF1\n tpRrGKQWqtVVZzHowq4pQvDqc5Hd0Xca6TXft1uDb2boOUP9eYE1kmnbSLt1iMIX+Hr46pAw9Ws\n t18vg8YB6sv6Z2WppPykxAbuR662a9dunZqMiva+mPvaLI7pfSFudnqlXp/XFc0u8P/85wPdPIX\n AZbqYopAnxX03/t06kvwb810xMdfGryfyb0CRS6emTGb5TcxV5IJ4sfGKdknbfeC2cItfPOK+ck\n 9Jv2JOLTWVLXgYGV/ZxgnNdhOhn6bOMBtJAqS/UJLUwR0DozbxSCrU8lq1t78mXYnUgilxtFVUo\n O7+KVTgawkbaGUuv2BqXvzqXfchaKAqMKbsqIVhbS59A8+Oz7QkpBNFA2rNMZpm8ncbTr1sAHUA\n 6VtwFXG2/ogdNnZjPMjjF5lLL9", "X-Received": [ "by 2002:a05:6000:40dd:b0:43b:445f:3177 with SMTP id\n ffacd0b85a97d-43b9e9e83f6mr6360011f8f.31.1774646771012;\n Fri, 27 Mar 2026 14:26:11 -0700 (PDT)", "by 2002:a05:6000:40dd:b0:43b:445f:3177 with SMTP id\n ffacd0b85a97d-43b9e9e83f6mr6359983f8f.31.1774646770527;\n Fri, 27 Mar 2026 14:26:10 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>,\n\tqemu-stable@nongnu.org", "Subject": "[PATCH 03/16] lsi53c895a: keep lsi_request and SCSIRequest in local\n variables", "Date": "Fri, 27 Mar 2026 22:25:34 +0100", "Message-ID": "<20260327212547.460420-4-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Protect against changes from reentrant device MMIO during DMA, by always\noperating on the same request.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 29 +++++++++++++++++------------\n 1 file changed, 17 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 81b4f93f4d3..1180e601811 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -626,6 +626,8 @@ static void lsi_do_dma(LSIState *s, int out)\n uint32_t count;\n dma_addr_t addr;\n SCSIDevice *dev;\n+ SCSIRequest *req;\n+ lsi_request *p;\n \n if (!s->current || !s->current->dma_len) {\n /* Wait until data is available. */\n@@ -633,12 +635,14 @@ static void lsi_do_dma(LSIState *s, int out)\n return;\n }\n \n- dev = s->current->req->dev;\n+ p = s->current;\n+ req = s->current->req;\n+ dev = req->dev;\n assert(dev);\n \n count = s->dbc;\n- if (count > s->current->dma_len)\n- count = s->current->dma_len;\n+ if (count > p->dma_len)\n+ count = p->dma_len;\n \n addr = s->dnad;\n /* both 40 and Table Indirect 64-bit DMAs store upper bits in dnad64 */\n@@ -653,21 +657,22 @@ static void lsi_do_dma(LSIState *s, int out)\n s->csbc += count;\n s->dnad += count;\n s->dbc -= count;\n- if (s->current->dma_buf == NULL) {\n- s->current->dma_buf = scsi_req_get_buf(s->current->req);\n+ if (p->dma_buf == NULL) {\n+ p->dma_buf = scsi_req_get_buf(req);\n }\n /* ??? Set SFBR to first data byte. */\n if (out) {\n- lsi_mem_read(s, addr, s->current->dma_buf, count);\n+ lsi_mem_read(s, addr, p->dma_buf, count);\n } else {\n- lsi_mem_write(s, addr, s->current->dma_buf, count);\n+ lsi_mem_write(s, addr, p->dma_buf, count);\n }\n- s->current->dma_len -= count;\n- if (s->current->dma_len == 0) {\n- s->current->dma_buf = NULL;\n- scsi_req_continue(s->current->req);\n+\n+ p->dma_len -= count;\n+ if (p->dma_len == 0) {\n+ p->dma_buf = NULL;\n+ scsi_req_continue(req);\n } else {\n- s->current->dma_buf += count;\n+ p->dma_buf += count;\n lsi_resume_script(s);\n }\n }\n", "prefixes": [ "03/16" ] }