Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217298/?format=api
{ "id": 2217298, "url": "http://patchwork.ozlabs.org/api/patches/2217298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-5-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327212547.460420-5-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-27T21:25:35", "name": "[04/16] lsi53c895a: keep lsi_request alive as long as the SCSIRequest", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b0a3b33a47fa66d600d2b61d2cd425e52edb8a6a", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327212547.460420-5-pbonzini@redhat.com/mbox/", "series": [ { "id": 497830, "url": "http://patchwork.ozlabs.org/api/series/497830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497830", "date": "2026-03-27T21:25:35", "name": "Reentrancy fixes for lsi53c895a, and cleanups to ncr710", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217298/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XoZSQtNn;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=D3BRKlno;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjDHJ5sl2z1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 08:26:52 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w6EhF-0002qX-US; Fri, 27 Mar 2026 17:26:25 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhE-0002q7-Qh\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:24 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w6EhD-0003cI-9k\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 17:26:24 -0400", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-477-_vk_PstNPP6cJuuFZaSO_A-1; Fri, 27 Mar 2026 17:26:21 -0400", "by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43b8c472f3eso1665370f8f.0\n for <qemu-devel@nongnu.org>; Fri, 27 Mar 2026 14:26:21 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21f279bsm768401f8f.16.2026.03.27.14.26.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 14:26:11 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774646782;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=XoZSQtNn6vzGmkrzbo/BeldV1fbFwS0XIxHZK0K8Hm2fPeVmaDHBiCYyZnvrZ8ch0Y8JeH\n hrYhntIC6PWAhv1B1PBko5k0/xcD32SvMtPgqfWImeFBJtC9hR0R2siHRjHUvip58+8iwt\n hDamjip39Ci/wNtssR4ih0efii8VoOk=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774646779; x=1775251579; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=D3BRKlnoSdenaT6UaznpfQWNJsq9EgpxCB6eKKp42oRih0lC6KTWT1v4pPK1jr0ljA\n hyUVdu4AT/ONnvN+m/UfiQMhd9BOt7VsHWWoG0FVtFBVswgL4mCzpqX1sjCXNH9k15PX\n ThvEfpwk+G2nU9+5gmjerMXYi3HVJuDujoUD6kkofgiBXsPRayM1jOlwmvCypsJUAMzG\n QMrUgsYJAqaDUPKRIblsdBCojmSm40Kj8iz9TXC18ZE8lmtVUZJQwd9B/JeZb6coMWDu\n WhgryoX/26VqaBIr1KG3ipIc5Z9O5o2ZBSmjR6FI6sZ5baVUxURmPifRkbrd19mxpKAm\n bgSg==" ], "X-MC-Unique": "_vk_PstNPP6cJuuFZaSO_A-1", "X-Mimecast-MFC-AGG-ID": "_vk_PstNPP6cJuuFZaSO_A_1774646780", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774646779; x=1775251579;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=N96Cvh9nP6r8XFXHnMsPNyo3ZrU8DUpNDRPrE2edM1c=;\n b=UHWxNt7kbgntWQ3o5Bwtk2zzOOmIkvgG0Fmn0abHLvAASmkRKBVUszDFYk68WeIU59\n 79IyoVc1IzMZnjCl8JNuySap2dJ5vucCdqpb3tTPI4F03OBbQOO7k9mENj33QF5sDk1c\n hxh50pB1kwP/Qo1ZMGUJH2S9PSG0eX8VsWl+FzV/OXwt06iqEpaGNu9R7aNYBk0y9FA9\n sgunOd5At9acCLNtM+N/z/aoHOhHLIQCuwSi2Tp9T7KWhLorhycx4jGuSqNsLbQvFH7q\n uxe093l1k9KFctiRG6uRH6XczZtNpebE/HncHU1zOXLLNX3d/T4tn6xoVK+thKFI+Uju\n YOyQ==", "X-Gm-Message-State": "AOJu0Yz3g2/t6mknmHd5a58qWLJuZ0cTU9DjAcfLBpSgRGOvhr0AA887\n 8lDAXszE6HgXhDY+/HT3+4TeNrV/nPHmvB1rDoTA02T9pHzXmxz2A7hicQsDPTNXq31WBCJ4dPI\n J8Mi/KA3DVZG4o1UbT604IaCRfto00VmJjqzK3XK4qCCeqcNHrn6S1+a0JbGFeprnwQmaosAY30\n Xr9o70KOMCz6y1KfYK4ZXOnPOWGFuLNG18fLL8+G2/", "X-Gm-Gg": "ATEYQzy263h47HpVTiu/uJSRAUkg0AAblQVaaHaRTrgsmVNmIYvCYr3gc7cZDeGCNUg\n 1fKTxMBMbA+qAyk032kBb1AOKBr+/OGA3Fn0BMM5WxOhIl5uM5hNnsUDAKGODc5GCfdB1aGy5fH\n vnEz7P/9bgnwZ9l+0jKnrGdEiC2Vmm1QIWlC+s4ZOrzXotq6B9SKnyF6mMWrc4vGWVv2tfewpAl\n qNj7AUcONnPf0FLPUFcLSnQdZXFTzv64gyMSIkz9DQoXPmLyFgj3amHk9eYLyX1sG/xsOztBlvM\n CQaixcpgoIpUcFUqMoB4i48TEgp07MX8pa1mMf0aZv3TSUlPoozpITBzcFl8lXeKG6K7wWJnz+M\n B1F1rclu1F6XNh91GdkZB8FGzWpT0CZdrvbgI0DB+PRKw+1HchSRFSp+PM+VIFSGW6PD10Uf0D2\n P3eO8WTFvdJLUUlOJIsNRlZS2p", "X-Received": [ "by 2002:a05:6000:22ca:b0:43b:921e:d2fc with SMTP id\n ffacd0b85a97d-43b9ea672f1mr6847156f8f.46.1774646778669;\n Fri, 27 Mar 2026 14:26:18 -0700 (PDT)", "by 2002:a05:6000:22ca:b0:43b:921e:d2fc with SMTP id\n ffacd0b85a97d-43b9ea672f1mr6847123f8f.46.1774646778133;\n Fri, 27 Mar 2026 14:26:18 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Helge Deller <deller@gmx.de>,\n\tqemu-stable@nongnu.org", "Subject": "[PATCH 04/16] lsi53c895a: keep lsi_request alive as long as the\n SCSIRequest", "Date": "Fri, 27 Mar 2026 22:25:35 +0100", "Message-ID": "<20260327212547.460420-5-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327212547.460420-1-pbonzini@redhat.com>", "References": "<20260327212547.460420-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "To protect against using the lsi_request after SCSIRequest has been freed,\nkeep the HBA-private data alive until the last reference to the SCSIRequest\nis gone. Because req->hba_private was used (even if just for an assertion)\nto check that the request was still either current or queued, add a boolean\nfield that is set when the SCSIRequest is cancelled or completed, which\nis when the lsi_request would have been unqueued.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/lsi53c895a.c | 27 ++++++++++++++++-----------\n 1 file changed, 16 insertions(+), 11 deletions(-)", "diff": "diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c\nindex 1180e601811..b882fc02276 100644\n--- a/hw/scsi/lsi53c895a.c\n+++ b/hw/scsi/lsi53c895a.c\n@@ -197,6 +197,7 @@ typedef struct lsi_request {\n uint8_t *dma_buf;\n uint32_t pending;\n int out;\n+ bool orphan;\n QTAILQ_ENTRY(lsi_request) next;\n } lsi_request;\n \n@@ -748,14 +749,20 @@ static lsi_request *lsi_find_by_tag(LSIState *s, uint32_t tag)\n return NULL;\n }\n \n-static void lsi_request_free(LSIState *s, lsi_request *p)\n+static void lsi_request_orphan(LSIState *s, lsi_request *p)\n {\n+ p->orphan = true;\n if (p == s->current) {\n s->current = NULL;\n } else {\n QTAILQ_REMOVE(&s->queue, p, next);\n }\n- g_free(p);\n+ scsi_req_unref(p->req);\n+}\n+\n+static void lsi_free_request(SCSIBus *bus, void *priv)\n+{\n+ g_free(priv);\n }\n \n static void lsi_request_cancelled(SCSIRequest *req)\n@@ -763,9 +770,7 @@ static void lsi_request_cancelled(SCSIRequest *req)\n LSIState *s = LSI53C895A(req->bus->qbus.parent);\n lsi_request *p = req->hba_private;\n \n- req->hba_private = NULL;\n- lsi_request_free(s, p);\n- scsi_req_unref(req);\n+ lsi_request_orphan(s, p);\n }\n \n /* Record that data is available for a queued command. Returns zero if\n@@ -817,9 +822,7 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n }\n \n if (req->hba_private == s->current) {\n- req->hba_private = NULL;\n- lsi_request_free(s, s->current);\n- scsi_req_unref(req);\n+ lsi_request_orphan(s, s->current);\n }\n if (!stop) {\n lsi_resume_script(s);\n@@ -830,10 +833,11 @@ static void lsi_command_complete(SCSIRequest *req, size_t resid)\n static void lsi_transfer_data(SCSIRequest *req, uint32_t len)\n {\n LSIState *s = LSI53C895A(req->bus->qbus.parent);\n+ lsi_request *p = req->hba_private;\n int out;\n \n- assert(req->hba_private);\n- if (s->waiting == LSI_WAIT_RESELECT || req->hba_private != s->current ||\n+ assert(!p->orphan);\n+ if (s->waiting == LSI_WAIT_RESELECT || p != s->current ||\n (lsi_irq_on_rsl(s) && !(s->scntl1 & LSI_SCNTL1_CON))) {\n if (lsi_queue_req(s, req, len)) {\n return;\n@@ -2325,7 +2329,8 @@ static const struct SCSIBusInfo lsi_scsi_info = {\n \n .transfer_data = lsi_transfer_data,\n .complete = lsi_command_complete,\n- .cancel = lsi_request_cancelled\n+ .cancel = lsi_request_cancelled,\n+ .free_request = lsi_free_request,\n };\n \n static void scripts_timer_cb(void *opaque)\n", "prefixes": [ "04/16" ] }