Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217295/?format=api
{ "id": 2217295, "url": "http://patchwork.ozlabs.org/api/patches/2217295/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327205457.604224-6-surenb@google.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260327205457.604224-6-surenb@google.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260327205457.604224-6-surenb@google.com/", "date": "2026-03-27T20:54:56", "name": "[v6,5/6] mm: use vma_start_write_killable() in process_vma_walk_lock()", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "350d7ca5eae1c724b86fd2ce78553aced90b25a7", "submitter": { "id": 74729, "url": "http://patchwork.ozlabs.org/api/people/74729/?format=api", "name": "Suren Baghdasaryan", "email": "surenb@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327205457.604224-6-surenb@google.com/mbox/", "series": [ { "id": 497828, "url": "http://patchwork.ozlabs.org/api/series/497828/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497828", "date": "2026-03-27T20:54:51", "name": "Use killable vma write locking in most places", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/497828/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217295/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18943-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=b4qcdKoa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18943-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1249\"", "lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=b4qcdKoa;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=flex--surenb.bounces.google.com\n (client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com;\n envelope-from=3so7gaqykdp0xzwjsglttlqj.htrqnsz2uuh-ij0qnxyx.t4qfgx.twl@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjCbQ5LS3z1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 07:55:46 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fjCZq3rNcz2yv8;\n\tSat, 28 Mar 2026 07:55:15 +1100 (AEDT)", "from mail-dl1-x1249.google.com (mail-dl1-x1249.google.com\n [IPv6:2607:f8b0:4864:20::1249])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjCZp4yxtz2ysZ\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 28 Mar 2026 07:55:14 +1100 (AEDT)", "by mail-dl1-x1249.google.com with SMTP id\n a92af1059eb24-127876be621so1606524c88.1\n for <linuxppc-dev@lists.ozlabs.org>;\n Fri, 27 Mar 2026 13:55:14 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774644915;\n\tcv=none;\n b=c7Dv9WYjMpCwhjHO3b64uFs/ArEMOc98GhVRkAsgrZjDLLDTHncd8TuxkXjBKU/13Q1YdAM+yRVhTW0vAXAZL5cDyWkFlc1gNTK0hAcDKltdENqQzMRlgSWCcbalC36U8Qic1KkPLVzLPCug8B3HvP2aDHURseM2MC9WVKuIe9f/GEm/ES49J+FfXdQrFv/vfZG0aJKQyXNi5idQ683jgrSLCNqFlpOY/UWcLWk1OMvXBAeUxQReKxi9C4KWM3/3HrrJ1WUQ8f9zrab7g1jXW5meBHS1tmrWzcXyOtkjUGwKZ5WCWmQNSLb6T3PC4FMiztSJEtORxGKXs1+61bRGtw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774644915; c=relaxed/relaxed;\n\tbh=gEJVuDKnjdgqU8zwIL3/sLmobVk+HSWnDM5ddTiDQu8=;\n\th=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:\n\t To:Cc:Content-Type;\n b=Lw4l/LPFymbvm/KuJQob9E9qkTnGyseFoRF/BfxJL3MFViMRyil/Z7Rf/WCmtsQGSFta9GshWH/xnrnxg/DuqimGj3MwjgoFvFo7lNoxZuHk/mTRV3iJhsRrta9+ivfKh+dHLK4d/L0vZS0HqeLb8H+Z0p9ugYIIi2XcPoYwiJWU4ubDGTQZIO9bEn3XCgSM8tOadLAwwjQWo+1NtjuYFqx+GIFhtYDR0cuxghzYlqEAMfDStfdmQWFxytYbjaPZRRw3MKYqx6DEFoTQWzxkD91/HP/fiejLNrAp9qU5+J9nn7jGCok16uXsjO2lYPfJuduoomgk7KOnWIQkBAlM/Q==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=b4qcdKoa; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com;\n envelope-from=3so7gaqykdp0xzwjsglttlqj.htrqnsz2uuh-ij0qnxyx.t4qfgx.twl@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=flex--surenb.bounces.google.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1774644913; x=1775249713;\n darn=lists.ozlabs.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=gEJVuDKnjdgqU8zwIL3/sLmobVk+HSWnDM5ddTiDQu8=;\n b=b4qcdKoaWEaTYpD5LOEJ1I8D/Oa0oHXW7QI5XUeLT68b0/CUFzmZ612GAiQriX3e05\n CDJEwRGfEBYXFKV2XzB7vZgmVstVlL+mv+/VbyEyElBvG3XAjLGSV7StOan++g5SRX87\n lniq258tVZPPaF3hTi7SS4+kbMSTCDuhESahlB+Bga+2wrwM7tAHEHoUVQJ/hX7zmwFi\n TLFlLVprR0eqZINHevAlB1AbGTCU6S1BrbWIHClzD5xi6/m5DEF3sjLPgHGAyYAow3pa\n UqRiUxM4Am352SelNoRlY8umRZGFGtsbBJlWXe8ksuEvJQtnnDN2mUiM9GeQ4WkmmtCg\n YiuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774644913; x=1775249713;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=gEJVuDKnjdgqU8zwIL3/sLmobVk+HSWnDM5ddTiDQu8=;\n b=VQGun9WUWBaqJBOVuPnaoREr/xlgmbp5A6WRSoZ4eOls71Rq9HBBkjiMnSqEGkWnAm\n xrTXU2TECXSqYL+RHSFNPQn0DTLGZf0GynJi8R8P7pxmC4uSd6yCluec6w+S5BBfDnWb\n DEWOMwndIEnl+8GRBHYywiYi5du23/9uNY/TH1uT65ldV0qz4GVUxVk1ELVH+4ER2Dqy\n R0JrNkOJ7+Qx+fqBxvBx4lXM7CU8yGRqvAhHQO3PQiURYOpFzghvh/v0JNMD65XZYrN/\n PWRT+fgRCbA4ciNN+fPXbX9z4Ku66eElnTRrNeV4JaBhmHe/77CRD7r2HzQB+Q+r8Xiz\n pjQw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVA68NJQ+BrzfCIjTwJYXo1vNoydFdkwu4Fy34iSAUP4wp+Dt/kGSUGWnn1cnLW5rRlDuEZ6T66H8+R0/Y=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0Yw/6qykuPT0CPqB3W/NIdt2cSNR0jqiUUBvZyzcqxqNiKQUryp8\n\t/vwF/TEShCqk+ThCKcQ7FBonG5ear5+39aOZCuXtO/S4N2xRWAIhTAmMdUeb6KNaccYECQtFk7m\n\tUQIGx+A==", "X-Received": "from dly16-n1.prod.google.com\n ([2002:a05:701b:2050:10b0:12a:7f27:56f7])\n (user=surenb job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7022:6099:b0:119:e569:f874\n with SMTP id a92af1059eb24-12ab3045876mr1405563c88.17.1774644912438; Fri, 27\n Mar 2026 13:55:12 -0700 (PDT)", "Date": "Fri, 27 Mar 2026 13:54:56 -0700", "In-Reply-To": "<20260327205457.604224-1-surenb@google.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "Mime-Version": "1.0", "References": "<20260327205457.604224-1-surenb@google.com>", "X-Mailer": "git-send-email 2.53.0.1018.g2bb0e51243-goog", "Message-ID": "<20260327205457.604224-6-surenb@google.com>", "Subject": "[PATCH v6 5/6] mm: use vma_start_write_killable() in\n process_vma_walk_lock()", "From": "Suren Baghdasaryan <surenb@google.com>", "To": "akpm@linux-foundation.org", "Cc": "willy@infradead.org, david@kernel.org, ziy@nvidia.com,\n\tmatthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com,\n\tbyungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com,\n\tapopple@nvidia.com, ljs@kernel.org, baolin.wang@linux.alibaba.com,\n\tLiam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,\n\tdev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, vbabka@suse.cz,\n\tjannh@google.com, rppt@kernel.org, mhocko@suse.com, pfalcato@suse.de,\n\tkees@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au,\n\tchleroy@kernel.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com,\n\timbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,\n\tagordeev@linux.ibm.com, svens@linux.ibm.com, gerald.schaefer@linux.ibm.com,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, surenb@google.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Spam-Status": "No, score=-7.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,\n\tUSER_IN_DEF_DKIM_WL autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Replace vma_start_write() with vma_start_write_killable() when\nprocess_vma_walk_lock() is used with PGWALK_WRLOCK option.\nAdjust its direct and indirect users to check for a possible error\nand handle it. Ensure users handle EINTR correctly and do not ignore\nit. When queue_pages_range() fails, check whether it failed due to\na fatal signal or some other reason and return appropriate error.\n\nSuggested-by: Matthew Wilcox <willy@infradead.org>\nSigned-off-by: Suren Baghdasaryan <surenb@google.com>\n---\n fs/proc/task_mmu.c | 12 ++++++------\n mm/mempolicy.c | 10 +++++++++-\n mm/pagewalk.c | 22 +++++++++++++++-------\n 3 files changed, 30 insertions(+), 14 deletions(-)", "diff": "diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c\nindex e091931d7ca1..33e5094a7842 100644\n--- a/fs/proc/task_mmu.c\n+++ b/fs/proc/task_mmu.c\n@@ -1774,15 +1774,15 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \tstruct vm_area_struct *vma;\n \tenum clear_refs_types type;\n \tint itype;\n-\tint rv;\n+\tint err;\n \n \tif (count > sizeof(buffer) - 1)\n \t\tcount = sizeof(buffer) - 1;\n \tif (copy_from_user(buffer, buf, count))\n \t\treturn -EFAULT;\n-\trv = kstrtoint(strstrip(buffer), 10, &itype);\n-\tif (rv < 0)\n-\t\treturn rv;\n+\terr = kstrtoint(strstrip(buffer), 10, &itype);\n+\tif (err)\n+\t\treturn err;\n \ttype = (enum clear_refs_types)itype;\n \tif (type < CLEAR_REFS_ALL || type >= CLEAR_REFS_LAST)\n \t\treturn -EINVAL;\n@@ -1824,7 +1824,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \t\t\t\t\t\t0, mm, 0, -1UL);\n \t\t\tmmu_notifier_invalidate_range_start(&range);\n \t\t}\n-\t\twalk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp);\n+\t\terr = walk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp);\n \t\tif (type == CLEAR_REFS_SOFT_DIRTY) {\n \t\t\tmmu_notifier_invalidate_range_end(&range);\n \t\t\tflush_tlb_mm(mm);\n@@ -1837,7 +1837,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \t}\n \tput_task_struct(task);\n \n-\treturn count;\n+\treturn err ? : count;\n }\n \n const struct file_operations proc_clear_refs_operations = {\ndiff --git a/mm/mempolicy.c b/mm/mempolicy.c\nindex c38a90487531..51f298cfc33b 100644\n--- a/mm/mempolicy.c\n+++ b/mm/mempolicy.c\n@@ -969,6 +969,7 @@ static const struct mm_walk_ops queue_pages_lock_vma_walk_ops = {\n * (a hugetlbfs page or a transparent huge page being counted as 1).\n * -EIO - a misplaced page found, when MPOL_MF_STRICT specified without MOVEs.\n * -EFAULT - a hole in the memory range, when MPOL_MF_DISCONTIG_OK unspecified.\n+ * -EINTR - walk got terminated due to pending fatal signal.\n */\n static long\n queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,\n@@ -1545,7 +1546,14 @@ static long do_mbind(unsigned long start, unsigned long len,\n \t\t\tflags | MPOL_MF_INVERT | MPOL_MF_WRLOCK, &pagelist);\n \n \tif (nr_failed < 0) {\n-\t\terr = nr_failed;\n+\t\t/*\n+\t\t * queue_pages_range() might override the original error with -EFAULT.\n+\t\t * Confirm that fatal signals are still treated correctly.\n+\t\t */\n+\t\tif (fatal_signal_pending(current))\n+\t\t\terr = -EINTR;\n+\t\telse\n+\t\t\terr = nr_failed;\n \t\tnr_failed = 0;\n \t} else {\n \t\tvma_iter_init(&vmi, mm, start);\ndiff --git a/mm/pagewalk.c b/mm/pagewalk.c\nindex 3ae2586ff45b..eca7bc711617 100644\n--- a/mm/pagewalk.c\n+++ b/mm/pagewalk.c\n@@ -443,14 +443,13 @@ static inline void process_mm_walk_lock(struct mm_struct *mm,\n \t\tmmap_assert_write_locked(mm);\n }\n \n-static inline void process_vma_walk_lock(struct vm_area_struct *vma,\n-\t\t\t\t\t enum page_walk_lock walk_lock)\n+static int process_vma_walk_lock(struct vm_area_struct *vma,\n+\t\t\t\t enum page_walk_lock walk_lock)\n {\n #ifdef CONFIG_PER_VMA_LOCK\n \tswitch (walk_lock) {\n \tcase PGWALK_WRLOCK:\n-\t\tvma_start_write(vma);\n-\t\tbreak;\n+\t\treturn vma_start_write_killable(vma);\n \tcase PGWALK_WRLOCK_VERIFY:\n \t\tvma_assert_write_locked(vma);\n \t\tbreak;\n@@ -462,6 +461,7 @@ static inline void process_vma_walk_lock(struct vm_area_struct *vma,\n \t\tbreak;\n \t}\n #endif\n+\treturn 0;\n }\n \n /*\n@@ -505,7 +505,9 @@ int walk_page_range_mm_unsafe(struct mm_struct *mm, unsigned long start,\n \t\t\tif (ops->pte_hole)\n \t\t\t\terr = ops->pte_hole(start, next, -1, &walk);\n \t\t} else { /* inside vma */\n-\t\t\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\t\t\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\t\t\tif (err)\n+\t\t\t\tbreak;\n \t\t\twalk.vma = vma;\n \t\t\tnext = min(end, vma->vm_end);\n \t\t\tvma = find_vma(mm, vma->vm_end);\n@@ -722,6 +724,7 @@ int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long start,\n \t\t.vma\t\t= vma,\n \t\t.private\t= private,\n \t};\n+\tint err;\n \n \tif (start >= end || !walk.mm)\n \t\treturn -EINVAL;\n@@ -729,7 +732,9 @@ int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long start,\n \t\treturn -EINVAL;\n \n \tprocess_mm_walk_lock(walk.mm, ops->walk_lock);\n-\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\tif (err)\n+\t\treturn err;\n \treturn __walk_page_range(start, end, &walk);\n }\n \n@@ -752,6 +757,7 @@ int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *ops,\n \t\t.vma\t\t= vma,\n \t\t.private\t= private,\n \t};\n+\tint err;\n \n \tif (!walk.mm)\n \t\treturn -EINVAL;\n@@ -759,7 +765,9 @@ int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *ops,\n \t\treturn -EINVAL;\n \n \tprocess_mm_walk_lock(walk.mm, ops->walk_lock);\n-\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\tif (err)\n+\t\treturn err;\n \treturn __walk_page_range(vma->vm_start, vma->vm_end, &walk);\n }\n \n", "prefixes": [ "v6", "5/6" ] }