Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217291/?format=api
{ "id": 2217291, "url": "http://patchwork.ozlabs.org/api/patches/2217291/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327205457.604224-2-surenb@google.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260327205457.604224-2-surenb@google.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260327205457.604224-2-surenb@google.com/", "date": "2026-03-27T20:54:52", "name": "[v6,1/6] mm/vma: cleanup error handling path in vma_expand()", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "3e8fa2d1b8a68abbf10c36897afec10625ae6dd7", "submitter": { "id": 74729, "url": "http://patchwork.ozlabs.org/api/people/74729/?format=api", "name": "Suren Baghdasaryan", "email": "surenb@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327205457.604224-2-surenb@google.com/mbox/", "series": [ { "id": 497828, "url": "http://patchwork.ozlabs.org/api/series/497828/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497828", "date": "2026-03-27T20:54:51", "name": "Use killable vma write locking in most places", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/497828/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217291/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18939-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=Ek+zmIqB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18939-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1249\"", "lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=Ek+zmIqB;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=flex--surenb.bounces.google.com\n (client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com;\n envelope-from=3p-7gaqykdpqoqnajxckkcha.ykihejqtlly-zarheopo.kvhwxo.knc@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjCZq0wkrz1yGQ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 07:55:14 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fjCZh08hNz2ygf;\n\tSat, 28 Mar 2026 07:55:08 +1100 (AEDT)", "from mail-dl1-x1249.google.com (mail-dl1-x1249.google.com\n [IPv6:2607:f8b0:4864:20::1249])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjCZf6vk2z2yVt\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 28 Mar 2026 07:55:06 +1100 (AEDT)", "by mail-dl1-x1249.google.com with SMTP id\n a92af1059eb24-12711ec96fbso1768264c88.0\n for <linuxppc-dev@lists.ozlabs.org>;\n Fri, 27 Mar 2026 13:55:06 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774644907;\n\tcv=none;\n b=GuEo69JA9EnYPRouRl5LS7U8q4Y4L/tfbpW241xB1Waek+niSm8wmpY8gGGOxyx8ZhpBkrfR0WxubCuIMO50mBsGh31MyI5kOp7QRouT1TI0CbRFjseF37bdWZkY27B5ZF93rGj2mKPJKsWoztTQsx6LuNzvjx5WncolfnkZCVKXwQWHFV7cYoWlqz8LaEOyRPX69nDMngqEQvZIY+EAX13/DzxwujVZiSnDzpYlGrFRFhns9tj/2Qv2fSN+V5CQWKikII0Clwmg/YAJYMzj6DGduREmUaulD6JNaAgh8mDYzJV5BpxvrPvd8hHdtW09MxYuyxQ84LGoiRVNZhs7rA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774644907; c=relaxed/relaxed;\n\tbh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n\th=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:\n\t To:Cc:Content-Type;\n b=NVj9rJ6CJ8rkpDoS2H92osmacLsaagZnyj4w0zLa1Pz3VbJNOnKafMxBAtoUdkjyVRHzuePHRFgBJvV0NJic/89spFAhQrQFhZw9cc9dABZF0Ay3ysHjuClEaO2O0hCA/jdNRcfm8eo/2AS/YehMp413tXKJKPZy2vHr63va4pdzC69Ei5KuwJ76XF2biiFZ3JlVZt/iFJHHMSSihd1+0M38A+cjA34H3JMyxIFLOu21X0tNd/Fi8AskTpJDQ3ioHAc5pkdv0rBuAJs26QN3HJoex9DbHwcAYkq5XGjgiWn70ZllNey0P6VIYoP5cXUB+pbscO18H2lBo76rO1yL5Q==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=Ek+zmIqB; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com;\n envelope-from=3p-7gaqykdpqoqnajxckkcha.ykihejqtlly-zarheopo.kvhwxo.knc@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=flex--surenb.bounces.google.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1774644904; x=1775249704;\n darn=lists.ozlabs.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n b=Ek+zmIqB76rjtlq/SF9JGgnsObvFLjRc0kr1GBudcLYsCVOaFUKHvgdGfXz7u49714\n v0NiNb1uIi58mEpD/VO5rda8JjXNl5qd4JkxFBng85Z5ZR0tjn7Lyh9NRMJtyk+zRLcS\n b0ADcU7e7y3esu5SHA5GM++68jbZIJVsUQzp4DUcDYmvJuuNi3GCjY918+PBlPctYVIW\n 2Oi9GeVwEZvWTQFDDBBqcLonv//bLskY8xz1MvSd9iuKccxeXVwbrL/L1NyN2VPc7rkr\n uD8vxfNx/d74LT5u337mXtRvjBqBCn+7d4rbhbQ5an964xyPfp9uQ8IbAMULohRz/Xh9\n Zy/w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774644904; x=1775249704;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n b=FbgIGhtMOZWIlDi4omgZuO8p8WmE7uFEShkhYtvkc1t/XQHLaFEHQQDnk8P4XBo53j\n rNHtJui/CBEdEoVJngi2jKvxdiPSNS10vfjO18IDfdK59+wevE4tTRoOdlQqWkkN62fj\n nMsgb37ghca9yEZQGLQiaQlajc7zJbIFD8XcQRFcPyS6aGU0Qi7bgBh5TTTaBVbRq07T\n c1QuNxsdttmb++0kgMJ+3EParsyBRzVANK1dbtUdXly3227YCc8FYKuAoIjWiAgTETLs\n cK6p6IHsw/tU+4XauORSsd0bfPIDSOTKoDd4fq9O/VyTVn/jQajESkX5QIsr1AIboNSY\n zwFA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUgo8jbV+go/QDZeX7IxKC25QZH+3nIUXIj6CPRASVpBpZbj3LTvd9IjIjIEbfyRWq1JQgMYyUv+6Xf6kE=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YyKFKG+QM74SkEGMqf8neMd6j5Htdw2aFFKC/mrh+oweKrUrPms\n\t6WkBuHeftmIqe9Fz1mAV/g3DPoyGwALiH6PNidUN4gFSbgN2ktiolWVp3G5xpb9lQ53Zi9Q4HAW\n\t6wnMMwg==", "X-Received": "from dlbsj11.prod.google.com\n ([2002:a05:7022:f90b:b0:128:dfaf:10ac])\n (user=surenb job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7022:e982:b0:119:e569:f277\n with SMTP id a92af1059eb24-12ab28f2848mr2382854c88.32.1774644903670; Fri, 27\n Mar 2026 13:55:03 -0700 (PDT)", "Date": "Fri, 27 Mar 2026 13:54:52 -0700", "In-Reply-To": "<20260327205457.604224-1-surenb@google.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "Mime-Version": "1.0", "References": "<20260327205457.604224-1-surenb@google.com>", "X-Mailer": "git-send-email 2.53.0.1018.g2bb0e51243-goog", "Message-ID": "<20260327205457.604224-2-surenb@google.com>", "Subject": "[PATCH v6 1/6] mm/vma: cleanup error handling path in vma_expand()", "From": "Suren Baghdasaryan <surenb@google.com>", "To": "akpm@linux-foundation.org", "Cc": "willy@infradead.org, david@kernel.org, ziy@nvidia.com,\n\tmatthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com,\n\tbyungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com,\n\tapopple@nvidia.com, ljs@kernel.org, baolin.wang@linux.alibaba.com,\n\tLiam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,\n\tdev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, vbabka@suse.cz,\n\tjannh@google.com, rppt@kernel.org, mhocko@suse.com, pfalcato@suse.de,\n\tkees@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au,\n\tchleroy@kernel.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com,\n\timbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,\n\tagordeev@linux.ibm.com, svens@linux.ibm.com, gerald.schaefer@linux.ibm.com,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, surenb@google.com,\n\tLorenzo Stoakes <lorenzo.stoakes@oracle.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Spam-Status": "No, score=-7.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,\n\tUSER_IN_DEF_DKIM_WL autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "vma_expand() error handling is a bit confusing with \"if (ret) return ret;\"\nmixed with \"if (!ret && ...) ret = ...;\". Simplify the code to check\nfor errors and return immediately after an operation that might fail.\nThis also makes later changes to this function more readable.\nChange variable name for storing the error code from \"ret\" to \"err\".\n\nNo functional change intended.\n\nSuggested-by: Jann Horn <jannh@google.com>\nSigned-off-by: Suren Baghdasaryan <surenb@google.com>\nReviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>\nReviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>\nReviewed-by: Barry Song <baohua@kernel.org>\n---\n mm/vma.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/mm/vma.c b/mm/vma.c\nindex a43f3c5d4b3d..ba78ab1f397a 100644\n--- a/mm/vma.c\n+++ b/mm/vma.c\n@@ -1170,7 +1170,7 @@ int vma_expand(struct vma_merge_struct *vmg)\n \tvma_flags_t sticky_flags =\n \t\tvma_flags_and_mask(&vmg->vma_flags, VMA_STICKY_FLAGS);\n \tvma_flags_t target_sticky;\n-\tint ret = 0;\n+\tint err = 0;\n \n \tmmap_assert_write_locked(vmg->mm);\n \tvma_start_write(target);\n@@ -1200,12 +1200,16 @@ int vma_expand(struct vma_merge_struct *vmg)\n \t * Note that, by convention, callers ignore OOM for this case, so\n \t * we don't need to account for vmg->give_up_on_mm here.\n \t */\n-\tif (remove_next)\n-\t\tret = dup_anon_vma(target, next, &anon_dup);\n-\tif (!ret && vmg->copied_from)\n-\t\tret = dup_anon_vma(target, vmg->copied_from, &anon_dup);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (remove_next) {\n+\t\terr = dup_anon_vma(target, next, &anon_dup);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n+\tif (vmg->copied_from) {\n+\t\terr = dup_anon_vma(target, vmg->copied_from, &anon_dup);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n \n \tif (remove_next) {\n \t\tvma_flags_t next_sticky;\n", "prefixes": [ "v6", "1/6" ] }