Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217142/?format=api
{ "id": 2217142, "url": "http://patchwork.ozlabs.org/api/patches/2217142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260327173252.1112192-4-pvorel@suse.cz/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327173252.1112192-4-pvorel@suse.cz>", "list_archive_url": null, "date": "2026-03-27T17:32:51", "name": "[v3,3/4] lib: Prefer LTP_DEBUG over -D", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "72335d78262eb3123c4f172f7ca3d9e446014b87", "submitter": { "id": 70792, "url": "http://patchwork.ozlabs.org/api/people/70792/?format=api", "name": "Petr Vorel", "email": "pvorel@suse.cz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260327173252.1112192-4-pvorel@suse.cz/mbox/", "series": [ { "id": 497808, "url": "http://patchwork.ozlabs.org/api/series/497808/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=497808", "date": "2026-03-27T17:32:49", "name": "lib: LTP_DEBUG cleanup", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497808/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217142/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2217142/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=axgObEW2;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=JiT2VS7N;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=axgObEW2;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=JiT2VS7N;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj76R34r2z1y1P\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 04:33:51 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 19DEF3D7E42\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:33:49 +0100 (CET)", "from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id DD8BC3DD308\n for <ltp@lists.linux.it>; Fri, 27 Mar 2026 18:33:32 +0100 (CET)", "from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 2CE231A010F0\n for <ltp@lists.linux.it>; Fri, 27 Mar 2026 18:33:31 +0100 (CET)", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 732D04D1F6;\n Fri, 27 Mar 2026 17:33:27 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 41D584A0B1;\n Fri, 27 Mar 2026 17:33:27 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id MD8yDme/xmm0DgAAD6G6ig\n (envelope-from <pvorel@suse.cz>); Fri, 27 Mar 2026 17:33:27 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1774632807;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dxn+3vdHASTESJ9xI3eWbrsjxneSIXMw3UOdNz0yqM8=;\n b=axgObEW2BGfig5BfLEPMMef8oF80Gcpq0y5n+DK/A+0jwAF6qIb4lO7DHkB4TMRq5QVTFT\n dOL0F3obfyl+DXHddvWhvThoyAEK2XGyDOTlX2XgVyH+ODv9WAQ3vvHYbVQoSm1WKXocE+\n rOnf7Rzf5wkbD5p9v+uz9YR4/KbJuYQ=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1774632807;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dxn+3vdHASTESJ9xI3eWbrsjxneSIXMw3UOdNz0yqM8=;\n b=JiT2VS7N1DwnkZRTCyVR52Zf5M90+rG1vJcpuLgiF6Z0SaBv8fAfVsholbxMRDK/HEErNH\n EWoYaKAqNsFQ6mDw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1774632807;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dxn+3vdHASTESJ9xI3eWbrsjxneSIXMw3UOdNz0yqM8=;\n b=axgObEW2BGfig5BfLEPMMef8oF80Gcpq0y5n+DK/A+0jwAF6qIb4lO7DHkB4TMRq5QVTFT\n dOL0F3obfyl+DXHddvWhvThoyAEK2XGyDOTlX2XgVyH+ODv9WAQ3vvHYbVQoSm1WKXocE+\n rOnf7Rzf5wkbD5p9v+uz9YR4/KbJuYQ=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1774632807;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dxn+3vdHASTESJ9xI3eWbrsjxneSIXMw3UOdNz0yqM8=;\n b=JiT2VS7N1DwnkZRTCyVR52Zf5M90+rG1vJcpuLgiF6Z0SaBv8fAfVsholbxMRDK/HEErNH\n EWoYaKAqNsFQ6mDw==" ], "From": "Petr Vorel <pvorel@suse.cz>", "To": "ltp@lists.linux.it", "Date": "Fri, 27 Mar 2026 18:32:51 +0100", "Message-ID": "<20260327173252.1112192-4-pvorel@suse.cz>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327173252.1112192-1-pvorel@suse.cz>", "References": "<20260327173252.1112192-1-pvorel@suse.cz>", "MIME-Version": "1.0", "X-Spam-Score": "-2.80", "X-Spam-Level": "", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.997];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-3.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v3 3/4] lib: Prefer LTP_DEBUG over -D", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "Environment variable has usually higher preference than getopt.\nThis includes disabling debugging even on -D:\nLTP_DEBUG= ./test05 -D2 means debugging disabled.\n\nAlso reduce duplicity of \"Enabling debug info (level %d)\" message and\ndocument that on -h and developers/debugging.rst.\n\nFixes: e434de62b4 (\"lib: Extend LTP_ENABLE_DEBUG to support verbosity levels\")\nSigned-off-by: Petr Vorel <pvorel@suse.cz>\n---\nChanges v2->v3:\n* Simplify -D code (Li)\n\n doc/developers/debugging.rst | 2 ++\n lib/tst_test.c | 25 +++++++++++--------------\n 2 files changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/doc/developers/debugging.rst b/doc/developers/debugging.rst\nindex 36dda0d90f..4e162068b4 100644\n--- a/doc/developers/debugging.rst\n+++ b/doc/developers/debugging.rst\n@@ -19,6 +19,8 @@ The ``-D`` parameter also supports the following verbosity levels:\n \n Suppress all debug logs if no '-D' flag passed (default behavior).\n \n+``LTP_DEBUG`` has higher preference than ``-D``.\n+\n Tracing and debugging syscalls\n ------------------------------\n \ndiff --git a/lib/tst_test.c b/lib/tst_test.c\nindex ea1aa5d306..61e357af3f 100644\n--- a/lib/tst_test.c\n+++ b/lib/tst_test.c\n@@ -654,11 +654,11 @@ static struct option {\n \tchar *optstr;\n \tchar *help;\n } options[] = {\n-\t{\"h\", \"-h Prints this help\"},\n-\t{\"i:\", \"-i n Execute test n times\"},\n-\t{\"I:\", \"-I x Execute test for n seconds\"},\n-\t{\"D::\", \"-D[1,2] Prints debug information\"},\n-\t{\"V\", \"-V Prints LTP version\"},\n+\t{\"h\", \"-h Prints this help\"},\n+\t{\"i:\", \"-i n Execute test n times\"},\n+\t{\"I:\", \"-I x Execute test for n seconds\"},\n+\t{\"D::\", \"-D[1,2] Prints debug information (can be overwriten by LTP_DEBUG\"},\n+\t{\"V\", \"-V Prints LTP version\"},\n };\n \n static void print_help(void)\n@@ -825,13 +825,9 @@ static void parse_opts(int argc, char *argv[])\n \t\t\ttst_brk(TBROK, \"Invalid option\");\n \t\tbreak;\n \t\tcase 'D':\n-\t\t\tif (optarg)\n-\t\t\t\tcontext->tdebug = SAFE_STRTOL(optarg, 1, 2);\n-\t\t\telse\n-\t\t\t\tcontext->tdebug = 1;\n-\n-\t\t\tif (context->tdebug)\n-\t\t\t\ttst_res(TINFO, \"Enabling debug info (level %d)\", context->tdebug);\n+\t\t\tif (getenv(\"LTP_DEBUG\"))\n+\t\t\t\tbreak;\n+\t\t\tcontext->tdebug = optarg ? SAFE_STRTOL(optarg, 1, 2) : 1;\n \t\tbreak;\n \t\tcase 'h':\n \t\t\tprint_help();\n@@ -1453,10 +1449,11 @@ static void do_setup(int argc, char *argv[])\n \t\telse\n \t\t\ttst_res(TWARN, \"Invalid LTP_DEBUG value: '%s'\", tdebug_env);\n \n-\t\tif (context->tdebug)\n-\t\t\ttst_res(TINFO, \"Enabling debug info (level %d)\", context->tdebug);\n \t}\n \n+\tif (context->tdebug)\n+\t\ttst_res(TINFO, \"Enabling debug info (level %d)\", context->tdebug);\n+\n \tif (tst_test->needs_kconfigs && tst_kconfig_check(tst_test->needs_kconfigs))\n \t\ttst_brk(TCONF, \"Aborting due to unsuitable kernel config, see above!\");\n \n", "prefixes": [ "v3", "3/4" ] }