Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217021/?format=api
{ "id": 2217021, "url": "http://patchwork.ozlabs.org/api/patches/2217021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260327151112.5202-2-wsa+renesas@sang-engineering.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327151112.5202-2-wsa+renesas@sang-engineering.com>", "list_archive_url": null, "date": "2026-03-27T15:10:21", "name": "[v3] mailbox: remove superfluous internal header", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bdc4bb700f6eafb8643fd007e71ec377bab66431", "submitter": { "id": 69646, "url": "http://patchwork.ozlabs.org/api/people/69646/?format=api", "name": "Wolfram Sang", "email": "wsa+renesas@sang-engineering.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260327151112.5202-2-wsa+renesas@sang-engineering.com/mbox/", "series": [ { "id": 497783, "url": "http://patchwork.ozlabs.org/api/series/497783/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=497783", "date": "2026-03-27T15:10:21", "name": "[v3] mailbox: remove superfluous internal header", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497783/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217021/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13337-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=sang-engineering.com header.i=@sang-engineering.com\n header.a=rsa-sha256 header.s=k1 header.b=G1YtZqRV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13337-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=sang-engineering.com\n header.i=@sang-engineering.com header.b=\"G1YtZqRV\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=194.117.254.33", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=sang-engineering.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=sang-engineering.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj4252XJKz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 02:14:53 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 1CC8530B61E0\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 15:11:31 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E2DD83101C8;\n\tFri, 27 Mar 2026 15:11:30 +0000 (UTC)", "from mail.zeus03.de (zeus03.de [194.117.254.33])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D3425A2B5\n\tfor <linux-tegra@vger.kernel.org>; Fri, 27 Mar 2026 15:11:28 +0000 (UTC)", "(qmail 234809 invoked from network); 27 Mar 2026 16:11:21 +0100", "by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted,\n authenticated); 27 Mar 2026 16:11:21 +0100" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774624290; cv=none;\n b=NNJYx0CIkws6+feKeXvoddtrK6o1R/jaRxpblrZMCLQ3QixVE7hah1JNXbzog26F+bH0Z3z5OKpj2PcvpPDfuMCUEMas3mUZjFh1ICkNOulqRkGZ/TozCVWUBCV150nE8r61/dvdkX7vVkk+PkSG5l3DJj23RTmsiL8T7na4iwQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774624290; c=relaxed/simple;\n\tbh=NB2iamtpP2XDsxs3VWRXl8P+a+DsKSP3dvELi8FMAHk=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=HqNGwqS5ZM1CCEnY3ZDfeDCwIkmUf0LJdaGW34PI5Bg6+oA4JrEcy/FKzMu0pv/+gk6rTB2Xvha9vF3E+LlpgVkdE4PK8F602e+AwRKOM4qppiIFDc9tarZmHShEr2fj7Ooq39hvF+Sb7+6JMYhRCUSbYZ2IOCl1Ypt5zVfO758=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=sang-engineering.com;\n spf=pass smtp.mailfrom=sang-engineering.com;\n dkim=pass (2048-bit key) header.d=sang-engineering.com\n header.i=@sang-engineering.com header.b=G1YtZqRV;\n arc=none smtp.client-ip=194.117.254.33", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tsang-engineering.com; h=from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding; s=k1; bh=hvrILReaMQTkxj\n\tIb7eTUOZLrycZQTQ1ic1L96eXKTHI=; b=G1YtZqRVu/1j4oG+Ud0ZMA6/neP8na\n\tA7VPNHe6N+kQq4TGawL1HmwWSpgVRiK3/+W5QxXN1qKh975PHbR8N5nD+lanI/f1\n\tpP8nVb5OkN48/axumgnNv1Sp3v/opELMO0CWqiqkc++IzvFlDNRjI/tKV5loIqA4\n\tEbxtF5hG0gUV4IOpRBBFu1cWd8cybewJyoJK0jO9DDE6mdnrCKZJojZn4uTbTbaC\n\tOhWnboxZ5n/QFjLHRYV9VsNnFNsg5bqs53Q5AB2rWxpFBAsMomsaXHl78oYrC7Pp\n\t7a/gb6OsPSJrOrrkwjPyiahBTXC57zI/+6syhG2BIe8VXNM1vqWsG15Q==", "X-UD-Smtp-Session": "l3s3148p1@hB3i6QJOnDRUhsJN", "From": "Wolfram Sang <wsa+renesas@sang-engineering.com>", "To": "linux-renesas-soc@vger.kernel.org", "Cc": "Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tSudeep Holla <sudeep.holla@kernel.org>,\n\tDaniel Baluta <daniel.baluta@nxp.com>,\n\tPeter Chen <peter.chen@cixtech.com>,\n\tFugang Duan <fugang.duan@cixtech.com>,\n\tCIX Linux Kernel Upstream Group <cix-kernel-upstream@cixtech.com>,\n\tJassi Brar <jassisinghbrar@gmail.com>,\n\tFrank Li <Frank.Li@nxp.com>,\n\tSascha Hauer <s.hauer@pengutronix.de>,\n\tPengutronix Kernel Team <kernel@pengutronix.de>,\n\tFabio Estevam <festevam@gmail.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\timx@lists.linux.dev,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org", "Subject": "[PATCH v3] mailbox: remove superfluous internal header", "Date": "Fri, 27 Mar 2026 16:10:21 +0100", "Message-ID": "<20260327151112.5202-2-wsa+renesas@sang-engineering.com>", "X-Mailer": "git-send-email 2.51.0", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Quite some controller drivers use the defines from the internal header\nalready. This prevents controller drivers outside the mailbox directory.\nMove the defines to the public controller header to allow this again as\nthe defines are not strictly internal anyhow.\n\nSigned-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>\nReviewed-by: Sudeep Holla <sudeep.holla@kernel.org>\nReviewed-by: Daniel Baluta <daniel.baluta@nxp.com>\n---\n\nChanges since v2:\n* rebased to 7.0-rc5\n* add tag (Thanks, Daniel!)\n\n drivers/mailbox/cix-mailbox.c | 2 --\n drivers/mailbox/hi3660-mailbox.c | 2 --\n drivers/mailbox/imx-mailbox.c | 2 --\n drivers/mailbox/mailbox-sti.c | 2 --\n drivers/mailbox/mailbox.c | 2 --\n drivers/mailbox/mailbox.h | 12 ------------\n drivers/mailbox/omap-mailbox.c | 2 --\n drivers/mailbox/pcc.c | 2 --\n drivers/mailbox/tegra-hsp.c | 2 --\n include/linux/mailbox_controller.h | 5 +++++\n 10 files changed, 5 insertions(+), 28 deletions(-)\n delete mode 100644 drivers/mailbox/mailbox.h", "diff": "diff --git a/drivers/mailbox/cix-mailbox.c b/drivers/mailbox/cix-mailbox.c\nindex 443620e8ae37..864f98f21fc3 100644\n--- a/drivers/mailbox/cix-mailbox.c\n+++ b/drivers/mailbox/cix-mailbox.c\n@@ -12,8 +12,6 @@\n #include <linux/module.h>\n #include <linux/platform_device.h>\n \n-#include \"mailbox.h\"\n-\n /*\n * The maximum transmission size is 32 words or 128 bytes.\n */\ndiff --git a/drivers/mailbox/hi3660-mailbox.c b/drivers/mailbox/hi3660-mailbox.c\nindex 17c29e960fbf..9b727a2b54a5 100644\n--- a/drivers/mailbox/hi3660-mailbox.c\n+++ b/drivers/mailbox/hi3660-mailbox.c\n@@ -15,8 +15,6 @@\n #include <linux/platform_device.h>\n #include <linux/slab.h>\n \n-#include \"mailbox.h\"\n-\n #define MBOX_CHAN_MAX\t\t\t32\n \n #define MBOX_RX\t\t\t\t0x0\ndiff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c\nindex 003f9236c35e..22331b579489 100644\n--- a/drivers/mailbox/imx-mailbox.c\n+++ b/drivers/mailbox/imx-mailbox.c\n@@ -23,8 +23,6 @@\n #include <linux/slab.h>\n #include <linux/workqueue.h>\n \n-#include \"mailbox.h\"\n-\n #define IMX_MU_CHANS\t\t24\n /* TX0/RX0/RXDB[0-3] */\n #define IMX_MU_SCU_CHANS\t6\ndiff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c\nindex b4b5bdd503cf..b6c9ecbbc8ec 100644\n--- a/drivers/mailbox/mailbox-sti.c\n+++ b/drivers/mailbox/mailbox-sti.c\n@@ -21,8 +21,6 @@\n #include <linux/property.h>\n #include <linux/slab.h>\n \n-#include \"mailbox.h\"\n-\n #define STI_MBOX_INST_MAX\t4 /* RAM saving: Max supported instances */\n #define STI_MBOX_CHAN_MAX\t20 /* RAM saving: Max supported channels */\n \ndiff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c\nindex e63b2292ee7a..9d41a1ab9018 100644\n--- a/drivers/mailbox/mailbox.c\n+++ b/drivers/mailbox/mailbox.c\n@@ -18,8 +18,6 @@\n #include <linux/property.h>\n #include <linux/spinlock.h>\n \n-#include \"mailbox.h\"\n-\n static LIST_HEAD(mbox_cons);\n static DEFINE_MUTEX(con_mutex);\n \ndiff --git a/drivers/mailbox/mailbox.h b/drivers/mailbox/mailbox.h\ndeleted file mode 100644\nindex e1ec4efab693..000000000000\n--- a/drivers/mailbox/mailbox.h\n+++ /dev/null\n@@ -1,12 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-only */\n-\n-#ifndef __MAILBOX_H\n-#define __MAILBOX_H\n-\n-#include <linux/bits.h>\n-\n-#define TXDONE_BY_IRQ\tBIT(0) /* controller has remote RTR irq */\n-#define TXDONE_BY_POLL\tBIT(1) /* controller can read status of last TX */\n-#define TXDONE_BY_ACK\tBIT(2) /* S/W ACK received by Client ticks the TX */\n-\n-#endif /* __MAILBOX_H */\ndiff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c\nindex d9f100c18895..5772c6b9886a 100644\n--- a/drivers/mailbox/omap-mailbox.c\n+++ b/drivers/mailbox/omap-mailbox.c\n@@ -22,8 +22,6 @@\n #include <linux/pm_runtime.h>\n #include <linux/mailbox_controller.h>\n \n-#include \"mailbox.h\"\n-\n #define MAILBOX_REVISION\t\t0x000\n #define MAILBOX_MESSAGE(m)\t\t(0x040 + 4 * (m))\n #define MAILBOX_FIFOSTATUS(m)\t\t(0x080 + 4 * (m))\ndiff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c\nindex 22e70af1ae5d..636879ae1db7 100644\n--- a/drivers/mailbox/pcc.c\n+++ b/drivers/mailbox/pcc.c\n@@ -59,8 +59,6 @@\n #include <linux/io-64-nonatomic-lo-hi.h>\n #include <acpi/pcc.h>\n \n-#include \"mailbox.h\"\n-\n #define MBOX_IRQ_NAME\t\t\"pcc-mbox\"\n \n /**\ndiff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c\nindex ed9a0bb2bcd8..2231050bb5a9 100644\n--- a/drivers/mailbox/tegra-hsp.c\n+++ b/drivers/mailbox/tegra-hsp.c\n@@ -16,8 +16,6 @@\n \n #include <dt-bindings/mailbox/tegra186-hsp.h>\n \n-#include \"mailbox.h\"\n-\n #define HSP_INT_IE(x)\t\t(0x100 + ((x) * 4))\n #define HSP_INT_IV\t\t0x300\n #define HSP_INT_IR\t\t0x304\ndiff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h\nindex 80a427c7ca29..16fef421c30c 100644\n--- a/include/linux/mailbox_controller.h\n+++ b/include/linux/mailbox_controller.h\n@@ -3,6 +3,7 @@\n #ifndef __MAILBOX_CONTROLLER_H\n #define __MAILBOX_CONTROLLER_H\n \n+#include <linux/bits.h>\n #include <linux/completion.h>\n #include <linux/device.h>\n #include <linux/hrtimer.h>\n@@ -11,6 +12,10 @@\n \n struct mbox_chan;\n \n+#define TXDONE_BY_IRQ\tBIT(0) /* controller has remote RTR irq */\n+#define TXDONE_BY_POLL\tBIT(1) /* controller can read status of last TX */\n+#define TXDONE_BY_ACK\tBIT(2) /* S/W ACK received by Client ticks the TX */\n+\n /**\n * struct mbox_chan_ops - methods to control mailbox channels\n * @send_data:\tThe API asks the MBOX controller driver, in atomic\n", "prefixes": [ "v3" ] }