Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216970/?format=api
{ "id": 2216970, "url": "http://patchwork.ozlabs.org/api/patches/2216970/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327134401.270186-7-kkostiuk@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327134401.270186-7-kkostiuk@redhat.com>", "list_archive_url": null, "date": "2026-03-27T13:43:52", "name": "[v2,06/15] target/sparc: Use glib2 instead of strcasecmp/strncasecmp", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c5b2a4eef52bcbc524fd099af02ef60efee16503", "submitter": { "id": 83198, "url": "http://patchwork.ozlabs.org/api/people/83198/?format=api", "name": "Kostiantyn Kostiuk", "email": "kkostiuk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260327134401.270186-7-kkostiuk@redhat.com/mbox/", "series": [ { "id": 497771, "url": "http://patchwork.ozlabs.org/api/series/497771/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497771", "date": "2026-03-27T13:43:46", "name": "Misc changes to allow building with Windows Clang", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497771/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216970/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HjnvTr4t;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj23F4f8Hz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Mar 2026 00:45:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w67Uv-0006Kh-4u; Fri, 27 Mar 2026 09:45:13 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1w67Uo-0006Ff-80\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 09:45:06 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1w67Um-0006TG-Mn\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 09:45:05 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-pR8oze6NPIeb-CDJB9r1aQ-1; Fri,\n 27 Mar 2026 09:45:00 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 541481800281; Fri, 27 Mar 2026 13:44:57 +0000 (UTC)", "from srv1.redhat.com (unknown [10.44.32.150])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id C548E1800671; Fri, 27 Mar 2026 13:44:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774619104;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=S64lHc8nDcDVXki4gsEE1CO0XdJngbvvtfp4BSK2uts=;\n b=HjnvTr4t/d3LRHoKVb4Sqvsn+EosbWO7F7puO9NiDNcscFACFzo5qBzQakhinZLTE2EQf/\n BpURS0YHVcz6JdWtVh3zX3MFUslERsar7v1XGEArQaAQSlbXx2GpfkfjlS7tVLc/eixBvm\n vyjfoK0ffI2xq8FdnSduYo+mqXrUoKk=", "X-MC-Unique": "pR8oze6NPIeb-CDJB9r1aQ-1", "X-Mimecast-MFC-AGG-ID": "pR8oze6NPIeb-CDJB9r1aQ_1774619097", "From": "Kostiantyn Kostiuk <kkostiuk@redhat.com>", "To": "qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org,\n qemu-ppc@nongnu.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org", "Cc": "Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n \"Edgar E . Iglesias\" <edgar.iglesias@gmail.com>,\n Alistair Francis <alistair@alistair23.me>,\n Peter Maydell <peter.maydell@linaro.org>,\n Nicholas Piggin <npiggin@gmail.com>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>, =?utf-8?q?Daniel_P_=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>,\n Palmer Dabbelt <palmer@dabbelt.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <dbarboza@ventanamicro.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>", "Subject": "[PATCH v2 06/15] target/sparc: Use glib2 instead of\n strcasecmp/strncasecmp", "Date": "Fri, 27 Mar 2026 15:43:52 +0200", "Message-ID": "<20260327134401.270186-7-kkostiuk@redhat.com>", "In-Reply-To": "<20260327134401.270186-1-kkostiuk@redhat.com>", "References": "<20260327134401.270186-1-kkostiuk@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=kkostiuk@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This is a change in semantics. g_ascii_strcasecmp() doesn't honour\nlocale but strcasecmp() does. But this is OK for at least one reason:\n (1) QEMU always runs with the C locale so there's not an actual\n behaviour change here\n (2) we want the comparison on boolean property value to be a plain\n ASCII one, not to do weird things with \"I\" in Turkish locales,\n so g_ascii_strcasecmp() is better as it's explicit about that\n\nSigned-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>\n---\n target/sparc/cpu.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c\nindex 1493336e7a..7704610428 100644\n--- a/target/sparc/cpu.c\n+++ b/target/sparc/cpu.c\n@@ -174,10 +174,10 @@ static void sparc_cpu_parse_features(const char *typename, char *features,\n * TODO: remove minus-override-plus semantics after\n * warning for a few releases\n */\n- if (!strcasecmp(val, \"on\") ||\n- !strcasecmp(val, \"off\") ||\n- !strcasecmp(val, \"true\") ||\n- !strcasecmp(val, \"false\")) {\n+ if (!g_ascii_strcasecmp(val, \"on\") ||\n+ !g_ascii_strcasecmp(val, \"off\") ||\n+ !g_ascii_strcasecmp(val, \"true\") ||\n+ !g_ascii_strcasecmp(val, \"false\")) {\n error_setg(errp, \"Boolean properties in format %s=%s\"\n \" are not supported\", name, val);\n return;\n", "prefixes": [ "v2", "06/15" ] }