Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216955/?format=api
{ "id": 2216955, "url": "http://patchwork.ozlabs.org/api/patches/2216955/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260327124136.983955-1-shivangu@linux.ibm.com/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327124136.983955-1-shivangu@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-27T12:41:36", "name": "[v2] ppc/pnv: generate dtb after machine initialization is complete", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7f2f1474c60da197c9e68f9036a3998d67225c3d", "submitter": { "id": 91952, "url": "http://patchwork.ozlabs.org/api/people/91952/?format=api", "name": "Shivang Upadhyay", "email": "shivangu@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260327124136.983955-1-shivangu@linux.ibm.com/mbox/", "series": [ { "id": 497761, "url": "http://patchwork.ozlabs.org/api/series/497761/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=497761", "date": "2026-03-27T12:41:36", "name": "[v2] ppc/pnv: generate dtb after machine initialization is complete", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497761/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216955/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=g12EANPS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj0fq1z7yz1y1P\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 23:42:59 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1w66WI-0003rC-4R; Fri, 27 Mar 2026 08:42:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <shivangu@linux.ibm.com>)\n id 1w66WG-0003qa-33; Fri, 27 Mar 2026 08:42:32 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <shivangu@linux.ibm.com>)\n id 1w66WE-0007RB-59; Fri, 27 Mar 2026 08:42:31 -0400", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62R303SN573231; Fri, 27 Mar 2026 12:42:16 GMT", "from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ky0gwk4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 27 Mar 2026 12:42:15 +0000 (GMT)", "from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62RB5u0l012213;\n Fri, 27 Mar 2026 12:42:14 GMT", "from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d27vkfabs-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 27 Mar 2026 12:42:14 +0000", "from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62RCgAc330867958\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Fri, 27 Mar 2026 12:42:10 GMT", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id BF2D22004B;\n Fri, 27 Mar 2026 12:42:10 +0000 (GMT)", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 61D0220043;\n Fri, 27 Mar 2026 12:42:07 +0000 (GMT)", "from shivang.com (unknown [9.124.223.21])\n by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Fri, 27 Mar 2026 12:42:07 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=rM5CqSwxGGyRgiWjqee5/1pXOOhnnNzwwZd0Yc5ms\n bQ=; b=g12EANPS9AtPljqcOAo9N+HW637jazRWrm5mgeQksSicRclnu8Yt8JT4B\n HqlhbBGZq4fLDKhXr2OcpBu+oL0xRW3fDj+95uFzdDeaPfrwh7iyJm7t8Go6ViA/\n Atb/esepcLyBzJbJ7kWIS0OWQACVtayTGIcZtBU+xfmNsBGfgyCXUeHbP/YHog5i\n +B96y6nqK7U0UVr+F4n1wk6+4iPVAG4FgJOfpri3gMWVzly+BP6aCJy+dOwSqbk+\n 0NJGpiWUS6xOYrQXgCXOvmmtsMUvR3Q79IDW1gn6At70lCSSMutfc0WyslIzMhj2\n TVXlVD909rXp6sbGk45lpEWDileyQ==", "From": "Shivang Upadhyay <shivangu@linux.ibm.com>", "To": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org", "Cc": "npiggin@gmail.com, milesg@linux.ibm.com,\n Shivang Upadhyay <shivangu@linux.ibm.com>,\n Aditya Gupta <adityag@linux.ibm.com>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n BALATON Zoltan <balaton@eik.bme.hu>, qemu-stable@nongnu.org,\n Nathan Chancellor <nathan@kernel.org>,\n Peter Maydell <peter.maydell@linaro.org>", "Subject": "[PATCH v2] ppc/pnv: generate dtb after machine initialization is\n complete", "Date": "Fri, 27 Mar 2026 18:11:36 +0530", "Message-ID": "<20260327124136.983955-1-shivangu@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzI3MDA4NCBTYWx0ZWRfX27iXYD2XvAEg\n z/AvgdP5ElKJWyn0q9eiZr5QSoyJsfOaDElnL7Q6kHQ2JOrgaPjJiHvO5RlSWSPRNRCbyYhKHvA\n mxM166uzn2AxU3a0SPkyw7SZIE3xJXgEXRqU9V69BPMJNOIe1YZnL/He+wzA3vBJ3jXjDKvHRzp\n oQL3rujdlovJkOHVxEQtTcfEC9YWra4PKXwOl3QZCrbYGKXB/bRsWIlevTauUvz8e39pOGcOgM/\n BMPTw03Zl7wqlh8qHyWXsWkg5kRivg6/M+AmJaK+aN5aMInAVWBY3aX93w8M5/LeTBf88PS0Sgm\n pzzlOxXYOucBt3msg9kZqAxAA2sxpXRIJbJKnfTCVdNowxPg7N7UXHH046qHd8X/SUTw4OppLkW\n KLEBtWpJCBGlicYGPiE54ci0TxOzPNmi6F1nNlTQ7V4WDVs8wm1Ni4KXSpmhT1ao5HMTp29C1rj\n 5H8AOTY8ZDbjZ5U5bIQ==", "X-Authority-Analysis": "v=2.4 cv=JK42csKb c=1 sm=1 tr=0 ts=69c67b27 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=69wJf7TsAAAA:8\n a=KKAkSRfTAAAA:8 a=EF3hw48zBu3OhOgeIqkA:9 a=Fg1AiH1G6rFz08G2ETeA:22\n a=cvBusfyB2V15izCimMoJ:22", "X-Proofpoint-ORIG-GUID": "S8BiI-sJ9k9MEIHVLcnIwksJPpYN-Vm3", "X-Proofpoint-GUID": "uquMS-PIIoPErc8R3hnE0TqxIUa38oFR", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0\n spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270084", "Received-SPF": "pass client-ip=148.163.158.5;\n envelope-from=shivangu@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently, the machine dtb is generated in pnv_init(), before all devices\nare fully initialized. This can result in an incomplete dtb for the system,\nas seen in bug [1].\n\nFix this by deferring dtb generation until machine initialization is complete,\nusing the machine_init_done_notifier hook.\n\n[1] https://lore.kernel.org/all/20260323231612.GA2637687@ax162/\n\nCc: Aditya Gupta <adityag@linux.ibm.com>\nCc: Harsh Prateek Bora <harshpb@linux.ibm.com>\nCc: BALATON Zoltan <balaton@eik.bme.hu>\nCc: qemu-stable@nongnu.org\nReported-by: Nathan Chancellor <nathan@kernel.org>\nSuggested-by: Peter Maydell <peter.maydell@linaro.org>\nFixes: a16d4c2f162a86d (\"ppc/pnv: fix dumpdtb option\")\nSigned-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>\n\n---\nChanges:\n\nv2:\n* moved pnv->bmc initialization to pnv_machine_init_done.\n\nv1:\n* https://lore.kernel.org/all/20260324135026.247418-1-shivangu@linux.ibm.com/\n---\n hw/ppc/pnv.c | 58 +++++++++++++++++++++++++-------------------\n include/hw/ppc/pnv.h | 2 ++\n 2 files changed, 35 insertions(+), 25 deletions(-)", "diff": "diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\nindex 7e54b6bc60..524563dcfc 100644\n--- a/hw/ppc/pnv.c\n+++ b/hw/ppc/pnv.c\n@@ -748,31 +748,10 @@ static void pnv_powerdown_notify(Notifier *n, void *opaque)\n \n static void pnv_reset(MachineState *machine, ResetType type)\n {\n- PnvMachineState *pnv = PNV_MACHINE(machine);\n- IPMIBmc *bmc;\n void *fdt;\n \n qemu_devices_reset(type);\n \n- /*\n- * The machine should provide by default an internal BMC simulator.\n- * If not, try to use the BMC device that was provided on the command\n- * line.\n- */\n- bmc = pnv_bmc_find(&error_fatal);\n- if (!pnv->bmc) {\n- if (!bmc) {\n- if (!qtest_enabled()) {\n- warn_report(\"machine has no BMC device. Use '-device \"\n- \"ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' \"\n- \"to define one\");\n- }\n- } else {\n- pnv_bmc_set_pnor(bmc, pnv->pnor);\n- pnv->bmc = bmc;\n- }\n- }\n-\n fdt = machine->fdt;\n cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));\n }\n@@ -984,6 +963,37 @@ static uint64_t pnv_chip_get_ram_size(PnvMachineState *pnv, int chip_id)\n return chip_id == 0 ? 1 * GiB : QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);\n }\n \n+static void pnv_machine_init_done(Notifier *notifier, void *data)\n+{\n+ PnvMachineState *pnv = container_of(notifier, PnvMachineState, machine_init_done);\n+ MachineState *machine = MACHINE(pnv);\n+ IPMIBmc *bmc;\n+\n+ /*\n+ * The machine should provide by default an internal BMC simulator.\n+ * If not, try to use the BMC device that was provided on the command\n+ * line.\n+ */\n+ bmc = pnv_bmc_find(&error_fatal);\n+ if (!pnv->bmc) {\n+ if (!bmc) {\n+ if (!qtest_enabled()) {\n+ warn_report(\"machine has no BMC device. Use '-device \"\n+ \"ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' \"\n+ \"to define one\");\n+ }\n+ } else {\n+ pnv_bmc_set_pnor(bmc, pnv->pnor);\n+ pnv->bmc = bmc;\n+ }\n+ }\n+\n+ if (!machine->fdt) {\n+ machine->fdt = pnv_dt_create(machine);\n+ _FDT((fdt_pack(machine->fdt)));\n+ }\n+}\n+\n static void pnv_init(MachineState *machine)\n {\n const char *bios_name = machine->firmware ?: FW_FILE_NAME;\n@@ -1244,10 +1254,8 @@ static void pnv_init(MachineState *machine)\n pmc->i2c_init(pnv);\n }\n \n- if (!machine->fdt) {\n- machine->fdt = pnv_dt_create(machine);\n- _FDT((fdt_pack(machine->fdt)));\n- }\n+ pnv->machine_init_done.notify = pnv_machine_init_done;\n+ qemu_add_machine_init_done_notifier(&pnv->machine_init_done);\n }\n \n /*\ndiff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h\nindex 24f8843a40..90028f974d 100644\n--- a/include/hw/ppc/pnv.h\n+++ b/include/hw/ppc/pnv.h\n@@ -111,6 +111,8 @@ struct PnvMachineState {\n \n bool big_core;\n bool lpar_per_core;\n+\n+ Notifier machine_init_done;\n };\n \n PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t chip_id);\n", "prefixes": [ "v2" ] }