Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216852/?format=api
{ "id": 2216852, "url": "http://patchwork.ozlabs.org/api/patches/2216852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260327102939.1095257-10-yi.zhang@huaweicloud.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327102939.1095257-10-yi.zhang@huaweicloud.com>", "list_archive_url": null, "date": "2026-03-27T10:29:35", "name": "[v4,09/13] ext4: ensure zeroed partial blocks are persisted in SYNC mode", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4053c638ffc5bc5aee135b337dab70127d110f5a", "submitter": { "id": 85428, "url": "http://patchwork.ozlabs.org/api/people/85428/?format=api", "name": "Zhang Yi", "email": "yi.zhang@huaweicloud.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260327102939.1095257-10-yi.zhang@huaweicloud.com/mbox/", "series": [ { "id": 497742, "url": "http://patchwork.ozlabs.org/api/series/497742/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=497742", "date": "2026-03-27T10:29:26", "name": "ext4: refactor partial block zero-out for iomap conversion", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/497742/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216852/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216852/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=4NUl=B3=vger.kernel.org=linux-ext4+bounces-15493-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=4nul=b3=vger.kernel.org=linux-ext4+bounces-15493-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15493-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.51", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhyD133Bhz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 21:53:05 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fhyD12Ysxz4wB7\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 21:53:05 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fhyD12RkYz4wDK; Fri, 27 Mar 2026 21:53:05 +1100 (AEDT)", "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fhyCx552tz4wB7\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 27 Mar 2026 21:53:01 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id EA6AB30B8CF1\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 27 Mar 2026 10:37:34 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D4B6F3E1230;\n\tFri, 27 Mar 2026 10:34:45 +0000 (UTC)", "from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com\n [45.249.212.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A29E3DB62F;\n\tFri, 27 Mar 2026 10:34:40 +0000 (UTC)", "from mail.maildlp.com (unknown [172.19.163.198])\n\tby dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4fhxpM0zdjzYQv7N;\n\tFri, 27 Mar 2026 18:34:19 +0800 (CST)", "from mail02.huawei.com (unknown [10.116.40.112])\n\tby mail.maildlp.com (Postfix) with ESMTP id B425A4057A;\n\tFri, 27 Mar 2026 18:34:32 +0800 (CST)", "from huaweicloud.com (unknown [10.50.85.155])\n\tby APP1 (Coremail) with SMTP id cCh0CgC3utouXcZp_T2cCQ--.28730S13;\n\tFri, 27 Mar 2026 18:34:32 +0800 (CST)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1774608785; cv=pass;\n\tb=Gy9x7d2y1HRxeWHeohBJGpv+YM8/46WaXIWM6lZ6IcjnDiGHd8FSCrvJiNMQdA/Djri8i1OmIDHbl+VjozewscFTEd6xeqqzymnH5/M/MRAwH+gRILuE2uY1b7L30AdmkhewJwxLcRJzRug9VBXUo9upR7pIrZaA2tePkRQPpYm7RXpHJUV8ce6aRyJCAL76qCPnjzR/TpfrrDkzDDSPWDwgODhK/NywYzftH10b4DsKj/qhXiaUfyhhC8++MC/hPuNDY4snPViICIzAXCTF6TPZmttjcNb+Hm4BJaTG4K/vk4Nda0pSegyVNHRfU7xm432q9JT9mHNr+njFdTYp3A==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774607685; cv=none;\n b=Yey7DGtDPXCk69FXzucDduG/6mShrK617Stmu9vAYdA+4X1alsnUiJsVTqRTfeBGXDmV2BOtNjwZsgPw8CHqBFeqErqBcTBAPPnVa+9wvWEajJkKl6Zz2m6W7JKVr4uYANhKgbpEceLHaC0qftnzAnCcGwJ2xBDOUr8ZZT5IkmQ=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1774608785; c=relaxed/relaxed;\n\tbh=qGhnrTW21mGbnT/bprQno9EIwoEerE7OwQbp5fLfciw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=bz9DsdLdqX/3+4kPUWwn2FnrqFF8M12GgSWMSRlKB3/MjoWjYVznQeAitWK9exi8F6QYO2z+OJtqHyudD4URySUTp1eBqeyMpfrTBrVIyZ+lUuLDHyfn4/VU3wN+mev2bPflR75B/crtJLxRvQZqCV2evoSgjNTp2h0kcGujrmfCnvgRojEmNSbCG4EwPoQ7DDZS0nPW7m9w8U8ef0ANrtCsZ9rbjT9ZHwKgK3xIFYs0/TTyyVym0PVLuOiVmfMNsuXmm9Az1noyeuYwW7pMJvbVSNm9VgfO2/EuCUW/HE32o7i5gcuvEO+qsUyb0odDS2YFPkubKMYDOZj55zjMYg==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774607685; c=relaxed/simple;\n\tbh=j/97nXmTe8IHvO2fi5SBryB3oogNc2Q7CceNOoEudAE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=ohfzne9O1GJxm4uN3coBeeNoAh2X8UXG9N2mGkCbgvn1EX/o4IHm0pGw1XfWiEe1djNMQ3lBXFwfCfL8MknARsAj1LdTTwD2uFbLyfaGjW9nPcVHuzob0sSOi2B0epAnm70oQ7IN6L+R6CP0MnlEY6aEN+AbH4EIhoK14d9VV9Y=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15493-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51" ], "From": "Zhang Yi <yi.zhang@huaweicloud.com>", "To": "linux-ext4@vger.kernel.org", "Cc": "linux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\ttytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tjack@suse.cz,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tlibaokun@linux.alibaba.com,\n\tyi.zhang@huawei.com,\n\tyi.zhang@huaweicloud.com,\n\tyizhang089@gmail.com,\n\tyangerkun@huawei.com,\n\tyukuai@fnnas.com", "Subject": "[PATCH v4 09/13] ext4: ensure zeroed partial blocks are persisted in\n SYNC mode", "Date": "Fri, 27 Mar 2026 18:29:35 +0800", "Message-ID": "<20260327102939.1095257-10-yi.zhang@huaweicloud.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327102939.1095257-1-yi.zhang@huaweicloud.com>", "References": "<20260327102939.1095257-1-yi.zhang@huaweicloud.com>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "cCh0CgC3utouXcZp_T2cCQ--.28730S13", "X-Coremail-Antispam": "1UD129KBjvJXoWxJw1UKFyUXw4UKF17uFy5twb_yoWrtF18p3\n\t43JFy3Gr4fW348ur4fKF4UZr1ay3Z3GF48Wry3Grn8Za97X34xtFyDKF1FvF1YgrW3C340\n\tvF4Yy347Kr15CFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUmS14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI\n\tkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2\n\tz4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F\n\t4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq\n\t3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7\n\tIYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U\n\tM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2\n\tkIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkE\n\tbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67\n\tAF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI\n\t42IY6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF\n\t4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBI\n\tdaVFxhVjvjDU0xZFpf9x0JUWMKtUUUUU=", "X-CM-SenderInfo": "d1lo6xhdqjqx5xdzvxpfor3voofrz/", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Zhang Yi <yi.zhang@huawei.com>\n\nIn ext4_zero_range() and ext4_punch_hole(), when operating in SYNC mode\nand zeroing a partial block, only data=journal modes guarantee that the\nzeroed data is synchronously persisted after the operation completes.\nFor data=ordered/writeback mode and non-journal modes, this guarantee is\nmissing.\n\nIntroduce a partial_zero parameter to explicitly trigger writeback for\nall scenarios where a partial block is zeroed, ensuring the zeroed data\nis durably persisted.\n\nSigned-off-by: Zhang Yi <yi.zhang@huawei.com>\n---\n fs/ext4/ext4.h | 2 +-\n fs/ext4/extents.c | 9 ++++++++-\n fs/ext4/inode.c | 19 ++++++++++++++-----\n 3 files changed, 23 insertions(+), 7 deletions(-)", "diff": "diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\nindex 859ae05339ad..bfe86479a83c 100644\n--- a/fs/ext4/ext4.h\n+++ b/fs/ext4/ext4.h\n@@ -3101,7 +3101,7 @@ extern int ext4_meta_trans_blocks(struct inode *inode, int lblocks,\n \t\t\t\t int pextents);\n extern int ext4_block_zero_eof(struct inode *inode, loff_t from, loff_t end);\n extern int ext4_zero_partial_blocks(struct inode *inode, loff_t lstart,\n-\t\t\t\t loff_t length);\n+\t\t\t\t loff_t length, bool *did_zero);\n extern vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf);\n extern qsize_t *ext4_get_reserved_space(struct inode *inode);\n extern int ext4_get_projid(struct inode *inode, kprojid_t *projid);\ndiff --git a/fs/ext4/extents.c b/fs/ext4/extents.c\nindex 002b1ec8cee2..16386f499138 100644\n--- a/fs/ext4/extents.c\n+++ b/fs/ext4/extents.c\n@@ -4673,6 +4673,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,\n \tloff_t align_start, align_end, new_size = 0;\n \tloff_t end = offset + len;\n \tunsigned int blocksize = i_blocksize(inode);\n+\tbool partial_zeroed = false;\n \tint ret, flags;\n \n \ttrace_ext4_zero_range(inode, offset, len, mode);\n@@ -4728,9 +4729,15 @@ static long ext4_zero_range(struct file *file, loff_t offset,\n \t\treturn ret;\n \n \t/* Zero out partial block at the edges of the range */\n-\tret = ext4_zero_partial_blocks(inode, offset, len);\n+\tret = ext4_zero_partial_blocks(inode, offset, len, &partial_zeroed);\n \tif (ret)\n \t\treturn ret;\n+\tif (((file->f_flags & O_SYNC) || IS_SYNC(inode)) && partial_zeroed) {\n+\t\tret = filemap_write_and_wait_range(inode->i_mapping, offset,\n+\t\t\t\t\t\t end - 1);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n \n \thandle = ext4_journal_start(inode, EXT4_HT_MISC, 1);\n \tif (IS_ERR(handle)) {\ndiff --git a/fs/ext4/inode.c b/fs/ext4/inode.c\nindex 8aa4369e3150..b934ad86a96d 100644\n--- a/fs/ext4/inode.c\n+++ b/fs/ext4/inode.c\n@@ -4227,7 +4227,8 @@ int ext4_block_zero_eof(struct inode *inode, loff_t from, loff_t end)\n \treturn 0;\n }\n \n-int ext4_zero_partial_blocks(struct inode *inode, loff_t lstart, loff_t length)\n+int ext4_zero_partial_blocks(struct inode *inode, loff_t lstart, loff_t length,\n+\t\t\t bool *did_zero)\n {\n \tstruct super_block *sb = inode->i_sb;\n \tunsigned partial_start, partial_end;\n@@ -4244,20 +4245,21 @@ int ext4_zero_partial_blocks(struct inode *inode, loff_t lstart, loff_t length)\n \t/* Handle partial zero within the single block */\n \tif (start == end &&\n \t (partial_start || (partial_end != sb->s_blocksize - 1))) {\n-\t\terr = ext4_block_zero_range(inode, lstart, length, NULL, NULL);\n+\t\terr = ext4_block_zero_range(inode, lstart, length, did_zero,\n+\t\t\t\t\t NULL);\n \t\treturn err;\n \t}\n \t/* Handle partial zero out on the start of the range */\n \tif (partial_start) {\n \t\terr = ext4_block_zero_range(inode, lstart, sb->s_blocksize,\n-\t\t\t\t\t NULL, NULL);\n+\t\t\t\t\t did_zero, NULL);\n \t\tif (err)\n \t\t\treturn err;\n \t}\n \t/* Handle partial zero out on the end of the range */\n \tif (partial_end != sb->s_blocksize - 1)\n \t\terr = ext4_block_zero_range(inode, byte_end - partial_end,\n-\t\t\t\t\t partial_end + 1, NULL, NULL);\n+\t\t\t\t\t partial_end + 1, did_zero, NULL);\n \treturn err;\n }\n \n@@ -4406,6 +4408,7 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)\n \tloff_t end = offset + length;\n \thandle_t *handle;\n \tunsigned int credits;\n+\tbool partial_zeroed = false;\n \tint ret;\n \n \ttrace_ext4_punch_hole(inode, offset, length, 0);\n@@ -4441,9 +4444,15 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)\n \tif (ret)\n \t\treturn ret;\n \n-\tret = ext4_zero_partial_blocks(inode, offset, length);\n+\tret = ext4_zero_partial_blocks(inode, offset, length, &partial_zeroed);\n \tif (ret)\n \t\treturn ret;\n+\tif (((file->f_flags & O_SYNC) || IS_SYNC(inode)) && partial_zeroed) {\n+\t\tret = filemap_write_and_wait_range(inode->i_mapping, offset,\n+\t\t\t\t\t\t end - 1);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n \n \tif (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))\n \t\tcredits = ext4_chunk_trans_extent(inode, 0);\n", "prefixes": [ "v4", "09/13" ] }