Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216831/?format=api
{ "id": 2216831, "url": "http://patchwork.ozlabs.org/api/patches/2216831/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/734338c2e8b669db5a5a3b45d34131b55ffebfca.1774605029.git.lukas@wunner.de/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<734338c2e8b669db5a5a3b45d34131b55ffebfca.1774605029.git.lukas@wunner.de>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/734338c2e8b669db5a5a3b45d34131b55ffebfca.1774605029.git.lukas@wunner.de/", "date": "2026-03-27T09:56:43", "name": "PCI/AER: Stop ruling out unbound devices as error source", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "4582fbc952dfa5e5efa69c8d880b51c143df1656", "submitter": { "id": 68499, "url": "http://patchwork.ozlabs.org/api/people/68499/?format=api", "name": "Lukas Wunner", "email": "lukas@wunner.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/734338c2e8b669db5a5a3b45d34131b55ffebfca.1774605029.git.lukas@wunner.de/mbox/", "series": [ { "id": 497739, "url": "http://patchwork.ozlabs.org/api/series/497739/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497739", "date": "2026-03-27T09:56:43", "name": "PCI/AER: Stop ruling out unbound devices as error source", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497739/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216831/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2216831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18921-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18921-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=83.223.95.204", "lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=wunner.de", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=wunner.de\n (client-ip=83.223.95.204; helo=mailout1.hostsharing.net;\n envelope-from=lukas@wunner.de; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhxBt6DtRz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 21:07:02 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhxBn5V9tz2yqW;\n\tFri, 27 Mar 2026 21:06:57 +1100 (AEDT)", "from mailout1.hostsharing.net (mailout1.hostsharing.net\n [83.223.95.204])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhxBm41pqz2yjm\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 27 Mar 2026 21:06:56 +1100 (AEDT)", "from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384\n\t client-signature ECDSA (secp384r1) client-digest SHA384)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"GlobalSign GCC R6 AlphaSSL CA 2025\" (verified OK))\n\tby mailout1.hostsharing.net (Postfix) with ESMTPS id 6C77538B4;\n\tFri, 27 Mar 2026 10:56:42 +0100 (CET)", "by h08.hostsharing.net (Postfix, from userid 100393)\n\tid 65B2D6024CB9; Fri, 27 Mar 2026 10:56:42 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774606017;\n\tcv=none;\n b=k6+qQMBjyd4S/i/JYghbDsClKgqEEEgGsJOUXWdkO14qQw3UgnYlgH5/SIhIzdDLPHiRYyYholflzMzh7BcGvEcIx+HOx7YM6beyTS4hgaz5dJUPsjD4AznYtpJ15AcDLaBCg9VpC+YcioK6zC2YrgwsKVp0oHcx8uXrlW/etmsAbZjk1wjfcx0tpSEDPNS1a7YL3BEThvjJDgPQ3DWb6wGARmm8CPM7LUYRLKeuXvdH2BAQ1bWpdSWQmFreP4pM1fUpkIcqmU5X0vWgwI5hORHIHt3bGDpa2SUHadAWNXkFhRL0YQsPG2ydyL1ViwrOxUTfnoCl4RG2hG8uNMsi7w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774606017; c=relaxed/relaxed;\n\tbh=AmXjMga8xYMmoEJQoej3DEiSR5iIJ7Y35Lu6qiFw1sQ=;\n\th=Message-Id:From:Date:Subject:To:Cc;\n b=CLmNo/rjUiT+ATe29reGuMGorKMgs7Yxkbp5Jmm5maYqfh2blzd7VLjFRdIc3W7bvzVthzQuTaVi0XItVCAuhK8zI6d/l2sXZm8gvPigOcpt6TyOKpI/ehpWBiMoOQm2LHVZiZMi44hhMyPV/S6Bt94GsCCmzUqTPmM+QjIR5yPYhcvrDb2GDtsU7kua7T7h9ahIjfb3uXlsv7gCRhlcAQ5eV28tkiknKH9+RJjbWc7OpL6xQw3pKdV3HfdNetKrnhjJdTiU54TWas7ssnKyO+8SxgaYCHBCnlBsDIQdE2YR0yhi8K5xuntI52bkRyGuxuvD5KqGA2ujxE+yo4B5WA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=wunner.de;\n spf=pass (client-ip=83.223.95.204; helo=mailout1.hostsharing.net;\n envelope-from=lukas@wunner.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=wunner.de", "X-Greylist": "delayed 606 seconds by postgrey-1.37 at boromir;\n Fri, 27 Mar 2026 21:06:56 AEDT", "Message-Id": "\n <734338c2e8b669db5a5a3b45d34131b55ffebfca.1774605029.git.lukas@wunner.de>", "From": "Lukas Wunner <lukas@wunner.de>", "Date": "Fri, 27 Mar 2026 10:56:43 +0100", "Subject": "[PATCH] PCI/AER: Stop ruling out unbound devices as error source", "To": "Bjorn Helgaas <helgaas@kernel.org>", "Cc": "linux-pci@vger.kernel.org, \"Mahesh J Salgaonkar\" <mahesh@linux.ibm.com>,\n Oliver OHalloran <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org,\n Stefan Roese <sr@denx.de>", "X-Spam-Status": "No, score=-0.7 required=3.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list" }, "content": "When searching for the error source, the AER driver rules out devices\nwhose enable_cnt is zero. This was introduced in 2009 by commit\n28eb27cf0839 (\"PCI AER: support invalid error source IDs\") without\nproviding a rationale.\n\nDrivers typically call pci_enable_device() on probe, hence the enable_cnt\ncheck essentially filters out unbound devices. At the time of the commit,\ndrivers had to opt in to AER by calling pci_enable_pcie_error_reporting()\nand so any AER-enabled device could be assumed to be bound to a driver.\nThe check thus made sense because it allowed skipping config space\naccesses to devices which were known not to be the error source.\n\nBut since 2022, AER is universally enabled on all devices when they are\nenumerated, cf. commit f26e58bf6f54 (\"PCI/AER: Enable error reporting when\nAER is native\").\n\nErrors may very well be reported by unbound devices, e.g. due to link\ninstability. By ruling them out as error source, errors reported by them\nare neither logged nor cleared. When they do get bound and another error\noccurs, the earlier error is reported together with the new error, which\nmay confuse users. Stop doing so.\n\nFixes: f26e58bf6f54 (\"PCI/AER: Enable error reporting when AER is native\")\nSigned-off-by: Lukas Wunner <lukas@wunner.de>\nCc: stable@vger.kernel.org # v6.0+\n---\n drivers/pci/pcie/aer.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c\nindex 4299c55..384d026 100644\n--- a/drivers/pci/pcie/aer.c\n+++ b/drivers/pci/pcie/aer.c\n@@ -1039,8 +1039,6 @@ static bool is_error_source(struct pci_dev *dev, struct aer_err_info *e_info)\n \t * 3) There are multiple errors and prior ID comparing fails;\n \t * We check AER status registers to find possible reporter.\n \t */\n-\tif (atomic_read(&dev->enable_cnt) == 0)\n-\t\treturn false;\n \n \t/* Check if AER is enabled */\n \tpcie_capability_read_word(dev, PCI_EXP_DEVCTL, ®16);\n", "prefixes": [] }