Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216817/?format=api
{ "id": 2216817, "url": "http://patchwork.ozlabs.org/api/patches/2216817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-11-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327073046.134085-11-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:30:45", "name": "[iwl-next] ixgbe: fix ITR value overflow in adaptive interrupt throttling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c88cdb2b0f4a15c6fd4893d71e9f66052b5042a9", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-11-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497726, "url": "http://patchwork.ozlabs.org/api/series/497726/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497726", "date": "2026-03-27T07:30:45", "name": "[iwl-next] ixgbe: fix ITR value overflow in adaptive interrupt throttling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497726/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216817/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Dy+jPIoK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsl36N2nz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:31:11 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 6A5F86129B;\n\tFri, 27 Mar 2026 07:31:08 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id X51Vd7M8nSOu; Fri, 27 Mar 2026 07:31:06 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B5CDB61290;\n\tFri, 27 Mar 2026 07:31:06 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 559CF249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 3C206415BB\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:04 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZoNB7AevEAtx for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:31:03 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 4F02E41598\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:03 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:31:03 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:31:02 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org B5CDB61290", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4F02E41598" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596666;\n\tbh=CxYJVqZcs+SuXUcMuDXP7eY085xAwR1Qp50LOdQ/NiU=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Dy+jPIoKb2bQHeNqWJGsMlK90+UC9QA0QKl9qgZcajq9cpEGKXY+5WgSp6vqlIj6e\n\t KnIvH8W8yH3hcAb49ULiQrBTsMgErKYoJmq+jVWZrb+r21VcmSrFLdcVE7H9a18P2M\n\t kEWZ7TdaDgl3M8zeeFReZRzVu63JuS+HC7dUu5LKtOghr9hWgVF6w1l/XcmxUNaiL7\n\t SNBwm2sd9iuYnDyTixE2n2nh2jI1zAfkZKPl4SRRGh52KbdOyb7SrC9txebUys5pIx\n\t IyjFQb9E0r3vS7+fYv2MMMFCHCe7+fniI9XLuEJdaU1Mdw4+17mGKWnlaW1S9dtqS/\n\t DRKS31P+C0zAg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4F02E41598", "X-CSE-ConnectionGUID": [ "vkOlKlJoSCW8VWeNIk/IZg==", "iwt7FBKaQt+b0OKEi/VAiA==" ], "X-CSE-MsgGUID": [ "GdOxrSltRRij8PohC6j5hw==", "7qbuhTliSaiKAsw4i5HMWQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75734333\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75734333\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255740432\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 27 Mar 2026 08:30:45 +0100", "Message-ID": "<20260327073046.134085-11-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "References": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596663; x=1806132663;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yOMRZi0/3SiDel76zDrsB6VaNT3oaM/8FJKDjA+kZU0=;\n b=VbO0fJbfXNqIWI1PB7iiygScdKHm/8HBotFnK7sGam988QeY3/nK+lw3\n hJdKxK/0EEeP9gxFfHgLxK6ccwpmQ3K9GG8zggoC0szh2Fs4cY1CBQzI9\n UJfO7bS6vISXqWANUIOPUonViRPV9vLvMfdkhXFaBTkEmWpF6YMwktEi7\n yqHmtgkG9nrmgZJyHZuOSAUHlfASafpNfgjUqEGJvdXxLMfM8gjZaw72u\n 70yBQK82xtALhATOsh6x4/l2u/Qt5srqOT2UdnfZBkAd2nLto20t/lmQd\n 1da5A43jcW4MD9Ij1imvLBkU75wnuQQ4UTCOeiyO1g++faqli13RI2huM\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=VbO0fJbf" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ixgbe: fix ITR value overflow in\n adaptive interrupt throttling", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ixgbe_update_itr() packs a mode flag (IXGBE_ITR_ADAPTIVE_LATENCY, bit 7)\nand a usecs delay (bits [6:0]) into an unsigned int, then stores it in\nring_container->itr which is u8. Values above 0xFF wrap, corrupting both\nthe delay and the mode-flag on the next readback.\n\nSeparate the mode bits from the usecs sub-field; clamp only the latter to\n[0, IXGBE_ITR_ADAPTIVE_LATENCY - 1] via min_t(unsigned int, ...) so\noverflow cannot bleed into bit 7. Add a WARN_ONCE() when the raw usecs\nvalue exceeds U8_MAX so out-of-range ITR computations are visible in\ndmesg during development and testing.\n\nFixes: b4ded8327fea (\"ixgbe: Update adaptive ITR algorithm\")\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1885fe8..4d53bd63 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -2901,8 +2901,12 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,\n \tif ((itr & IXGBE_ITR_ADAPTIVE_LATENCY) && itr < ring_container->itr)\n \t\titr = ring_container->itr - IXGBE_ITR_ADAPTIVE_MIN_INC;\n clear_counts:\n-\t/* write back value */\n-\tring_container->itr = itr;\n+\tWARN_ONCE((itr & ~IXGBE_ITR_ADAPTIVE_LATENCY) > U8_MAX,\n+\t\t \"ITR value %u exceeds U8_MAX, clamping\\n\", itr);\n+\n+\tring_container->itr = (itr & IXGBE_ITR_ADAPTIVE_LATENCY) |\n+\t\tmin_t(unsigned int, itr & ~IXGBE_ITR_ADAPTIVE_LATENCY,\n+\t\t IXGBE_ITR_ADAPTIVE_LATENCY - 1);\n \n \t/* next update should occur within next jiffy */\n \tring_container->next_update = next_update + 1;\n", "prefixes": [ "iwl-next" ] }