Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216815/?format=api
{ "id": 2216815, "url": "http://patchwork.ozlabs.org/api/patches/2216815/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-10-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327073046.134085-10-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:30:44", "name": "[iwl-next] ixgbe: fix integer overflow and wrong bit position in ixgbe_validate_rtr()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "444e001b796e0da763eb6916ff9c278b9abcd8dd", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-10-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497724, "url": "http://patchwork.ozlabs.org/api/series/497724/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497724", "date": "2026-03-27T07:30:44", "name": "[iwl-next] ixgbe: fix integer overflow and wrong bit position in ixgbe_validate_rtr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497724/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216815/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=CxOjwPB5;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhskz6GNjz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:31:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 7941383B57;\n\tFri, 27 Mar 2026 07:31:06 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id kPiJjCtzpcJN; Fri, 27 Mar 2026 07:31:05 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2328D825D3;\n\tFri, 27 Mar 2026 07:31:05 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 011C02D5\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:03 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id DBA12415BB\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:02 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ISC2_zu5QPbI for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:31:02 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id E9F7541598\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:31:01 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:31:01 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:31:00 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2328D825D3", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org E9F7541598" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596665;\n\tbh=8A8F+WxTWdlVSEUTUhVRFmtpTU3emeBCJZD3PUws2Vo=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=CxOjwPB5qDfuqaW5l6ocQrzbqCydgrC9Nx9y/VheEGE9RrXAYuQScjYRolkuakkq3\n\t FlrMYfZ8qvasoph1IVZwre5y7isV1azG1xALKQ+IgRaDGjuE0VIlRTJ71jxjDIxXna\n\t 66eUe8SXyVFvC+aD9/W+uXSl0cVzWSgY9rLRYbfkAlwcJZF28FPSIbdrsYE81d9ZfI\n\t cwDOi3gZJAHqHY1++EeYxKp01ZV5T9fvUL0w6ZNZH46rs5fGFKNAzWphqfP7FO7Y/2\n\t nK9Aa5DlFQa3ynBwJw+riXlsYbz84RgwgLA+M2ZKNrNHcZ/ZVRnz+FArWRWvVzGAKz\n\t VEsv7gelO9wdQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org E9F7541598", "X-CSE-ConnectionGUID": [ "WS+0DzauRJiGOiaYhpfGTA==", "1BTtfh0LSuChAT0utFp2Lg==" ], "X-CSE-MsgGUID": [ "sZCC5/n1SgmUNmIwG3SoJg==", "CKhl9GRwQpmkmc23e/gMCg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75734331\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75734331\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255740420\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 27 Mar 2026 08:30:44 +0100", "Message-ID": "<20260327073046.134085-10-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "References": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596662; x=1806132662;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=PBQkM0oDq4CzXOVzrITHfcyD1KP6EOMIbnUXu+hWNak=;\n b=Tvu88POT3gl9AtDbpq8ycmDbomCenFpLP5gteCjkJlijwajZ6vnIHVHA\n ubey9EgfgH87iH9So8gN8feitCoDW5aDJoh6N6h3VFECcNC35gnt05D9v\n HDXu4q6KFU1vW6Tuc1GKIyIbFvGuKLYKvWROmZvCQYayCjKHBt0/SeAij\n TRkGmU+HYFa35ABP1BraMd30xenAVrk3hWJOAieYeQnKbY65a2KGHw+g6\n wOT6QjOjadHIkTnan03JyRPN+ZLn0rYCv75Bzg0RxBoSol4yCniEGCNGM\n 03ZX7VWPiyrvtsM7s7kgs5SoiRaet3UNnArD+A3KDbayv1ll7/yzYV5cw\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Tvu88POT" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ixgbe: fix integer overflow and\n wrong bit position in ixgbe_validate_rtr()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Two bugs in the same loop in ixgbe_validate_rtr():\n\n1. When extracting 3-bit traffic class values from the IXGBE_RTRUP2TC\n register the shifted value was assigned directly to a u8, silently\n truncating any bits above bit 7. Mask with IXGBE_RTRUP2TC_UP_MASK\n before the assignment so only the intended 3 bits are kept.\n\n2. When clearing an out-of-bounds entry the mask was always shifted by\n the fixed constant IXGBE_RTRUP2TC_UP_SHIFT (== 3), regardless of\n which loop iteration was being processed. This means only the entry\n at bit position 3 was ever cleared; entries at bit positions 0, 6, 9,\n ..., 21 were left unreset. Use i * IXGBE_RTRUP2TC_UP_SHIFT to target\n the correct field for each iteration.\n\nAlso replace the hardcoded 0x7 literal with the IXGBE_RTRUP2TC_UP_MASK\nconstant for consistency with other parts of the driver.\n\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 9aec66c..53b82a5 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9798,11 +9798,12 @@ static void ixgbe_validate_rtr(struct ixgbe_adapter *adapter, u8 tc)\n \trsave = reg;\n \n \tfor (i = 0; i < MAX_TRAFFIC_CLASS; i++) {\n-\t\tu8 up2tc = reg >> (i * IXGBE_RTRUP2TC_UP_SHIFT);\n+\t\tu8 up2tc = IXGBE_RTRUP2TC_UP_MASK &\n+\t\t\t (reg >> (i * IXGBE_RTRUP2TC_UP_SHIFT));\n \n \t\t/* If up2tc is out of bounds default to zero */\n \t\tif (up2tc > tc)\n-\t\t\treg &= ~(0x7 << IXGBE_RTRUP2TC_UP_SHIFT);\n+\t\t\treg &= ~(IXGBE_RTRUP2TC_UP_MASK << (i * IXGBE_RTRUP2TC_UP_SHIFT));\n \t}\n \n \tif (reg != rsave)\n", "prefixes": [ "iwl-next" ] }