Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216811/?format=api
{ "id": 2216811, "url": "http://patchwork.ozlabs.org/api/patches/2216811/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-6-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327073046.134085-6-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:30:40", "name": "[iwl-next] ixgbe: call ixgbe_setup_fc() before fc_enable() after NVM update", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ac6692abc7c5ded2e2230676a81b2b3d8645188d", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-6-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497720, "url": "http://patchwork.ozlabs.org/api/series/497720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497720", "date": "2026-03-27T07:30:40", "name": "[iwl-next] ixgbe: call ixgbe_setup_fc() before fc_enable() after NVM update", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497720/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216811/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ASAivqtO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsks2VxVz1yFr\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:31:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B558C83C29;\n\tFri, 27 Mar 2026 07:30:58 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Jo0ZYOvduATJ; Fri, 27 Mar 2026 07:30:58 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 35D3582768;\n\tFri, 27 Mar 2026 07:30:58 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 6B85D249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5DDCE415BB\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:57 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iqDUJHB-U70r for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:30:56 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 5AC4141598\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:56 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:30:56 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:30:55 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 35D3582768", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5AC4141598" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596658;\n\tbh=CHDEV9SJVAr/scFmg/+f7kg8oyI0u2IH8Rh7If+V4QQ=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ASAivqtO8225dAdBgwTuGWbAOmkp0OQzTdul20bnMTQUzeaCRsfQUjb4dsfsOfONc\n\t Gd3+Y2QAv5p7ICXx52iBFII7JqFOXetet1Rf5e7x+CxzDtEcPoV6gHiyoac8UpZ7qN\n\t zonf2wrv0Ph3twRgeLI2QVvKpxueWxvvLLF0SHt1jnQLhz/TJq8G6O6LaiOenLGBYO\n\t VCkAYBJ/yo6fNrotsQ2US8daSlXzNty/k8F379VjygW7JRjcbtG/J7PhiOoOJmKy17\n\t 61RIpq+X/6OmGk0S3UJScKClHv7wc++LdDQRE/M/assh8zAD+IbWD9NnZ70tInyb/Z\n\t WslYIahnmqbCA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5AC4141598", "X-CSE-ConnectionGUID": [ "Kas4GE1gTvuO2d4NvGz0Pg==", "NfVt3QrVR9SQ3aRWJamXHQ==" ], "X-CSE-MsgGUID": [ "ISSX0OCsQPi18N4W2C0z9A==", "IDICe1k5S/m3D9QIyM3DWg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75734320\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75734320\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255740381\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 27 Mar 2026 08:30:40 +0100", "Message-ID": "<20260327073046.134085-6-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "References": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596656; x=1806132656;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Hilwd6wmLhVdcH05Km0NTcg0JGgAPDArrIlWyELkXNU=;\n b=H6I9hmHguorRX4yXqNHLEks3FQWTAh55ZxoUKf1tdOo3QOOFe4e4gQMs\n 2XpmkeLqLzTUA1bkwgx5hPL5kVjLKZlscMFTI/Qb0LY832oshRtV2N8Sf\n xqM7qSDd9BJ5ySjTTz/vnxPTWcFQiyPnHltvEGV8C+X1nYW4qkQSc4VJ6\n 662LdbRZBxG5ZxVYBQDuJnaDW2IlnIz/t6dt7NScK0RqSTjRBd4j09a3p\n wj4J4zf+Y2LesQLxiffWHygci8e9E5BMqgXkA25lQldshpdocEPZEwlRp\n 0h2bYzp9yBfqClCOfeiXCno0+XWB02FywGFQuEVKIYWZfg4Hac0Wd6nQx\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=H6I9hmHg" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ixgbe: call ixgbe_setup_fc()\n before fc_enable() after NVM update", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Radoslaw Tyl <radoslawx.tyl@intel.com>\n\nDuring an NVM update the PHY reset clears the Technology Ability Field\n(IEEE 802.3 clause 37 register 7.10) back to hardware defaults. When\nthe driver subsequently calls only hw->mac.ops.fc_enable() the SRRCTL\nregister is recalculated from the stale autonegotiated capability bits,\nwhich the MDD (Malicious Driver Detect) logic treats as an invalid\nchange and halts traffic on the PF.\n\nFix by calling ixgbe_setup_fc() immediately before fc_enable() in\nixgbe_watchdog_update_link() so that flow-control autoneg and the\nPHY registers are re-programmed in the correct order after any reset.\n\nSigned-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 52f0cdc..db954e9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8041,6 +8041,12 @@ static void ixgbe_watchdog_update_link(struct ixgbe_adapter *adapter)\n \t\tpfc_en |= !!(adapter->ixgbe_ieee_pfc->pfc_en);\n \n \tif (link_up && !((adapter->flags & IXGBE_FLAG_DCB_ENABLED) && pfc_en)) {\n+\t\tif (hw->mac.ops.setup_fc) {\n+\t\t\tint err = hw->mac.ops.setup_fc(hw);\n+\n+\t\t\tif (err)\n+\t\t\t\te_warn(drv, \"setup_fc failed: %d\\n\", err);\n+\t\t}\n \t\thw->mac.ops.fc_enable(hw);\n \t\tixgbe_set_rx_drop_en(adapter);\n \t}\n", "prefixes": [ "iwl-next" ] }