Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216809/?format=api
{ "id": 2216809, "url": "http://patchwork.ozlabs.org/api/patches/2216809/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-4-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327073046.134085-4-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:30:38", "name": "[iwl-next] ixgbe: remove ixgbe_ping_all_vfs() from watchdog link-up handler", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d5943de24c95cb30ef1373f0754594fdd128feda", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327073046.134085-4-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497718, "url": "http://patchwork.ozlabs.org/api/series/497718/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497718", "date": "2026-03-27T07:30:38", "name": "[iwl-next] ixgbe: remove ixgbe_ping_all_vfs() from watchdog link-up handler", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497718/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216809/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216809/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ahs4ylri;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhskq4lbhz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:30:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BBB4983B46;\n\tFri, 27 Mar 2026 07:30:57 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id LtAR0qeQbW6n; Fri, 27 Mar 2026 07:30:55 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B3E28827C5;\n\tFri, 27 Mar 2026 07:30:55 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 99861249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 97D02415BB\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:54 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Mzp6cL7RIcf7 for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:30:53 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id A868A41598\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:30:53 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:30:53 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:30:52 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org B3E28827C5", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org A868A41598" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596655;\n\tbh=TYENORkKL+1MyfdPNQMJdsvxXDtsODY7/lgbM1HmRd0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ahs4ylri8gO5hyUjx/digZ4GlsPXjX8DHqxa2lW0Z2Jhi+Mniyo8urhCawbdtPuPe\n\t MF1qxYUspPnSO+4rqmaU+ywtiWFYucej5h2Eh2F/TKJSPp7uJztGPL8uwwckOKJnPX\n\t yu0SPdG+g6NA4sF7bDH2PO2GJ5up3H2UmWC6lfoWJNEM337mI7Rdv7Mazc3cmwqExb\n\t i9OK+xYK1i24pThWDxYrOFABh6RTD9FiTLV+Dzln8AgvbAmUcC0G4HHMX8Q61WmTLu\n\t piFMvmHm9u5WMqjbTd3Giedt5BOgaWjlrhFRbgzy7wLEbA7A1/AdIiSuPTRrbFiUPJ\n\t blQHZJrNqFvRQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org A868A41598", "X-CSE-ConnectionGUID": [ "2/0UdATLSG2Oh9rYyMlcCQ==", "qYt7L5tcQa6CZ+Bhdp9cFw==" ], "X-CSE-MsgGUID": [ "1SfNHvprTweJdY0o7czOIw==", "XGN6zzyPTyaMtWGSdXzjew==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75734304\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75734304\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255740371\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 27 Mar 2026 08:30:38 +0100", "Message-ID": "<20260327073046.134085-4-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "References": "<20260327073046.134085-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596653; x=1806132653;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=l+5PB8hG8ASiz0Q+Qy0iNx3ZoIMPNW7rHg47asvNjxA=;\n b=gMH7D3dq3VYnUv6b2ONgP9ehH4NCTB/F4x8aoGpwELbL15zhvpaKpzdB\n U7s+FVViBvAoBn4XJD6fuAW9azKK0jrNaztMnVCwogZ1p/VolAZy3x1Zt\n lHmtPbFhv94xpqZLraxFAmDeQAJpwJuC6s1m4+yE6ARAhLQ2nOPE2AhGv\n Zehi+8Hvw8GN3h5xhzPKxnvbRczjM+/BG+d2EXE4JzCdCtYI8UIFuOeY/\n JtSoU30V5LUAn2Bcw0QsvDmD08b7EqsBVU7KoqXbLg6UYCtSMED5s8uRw\n 1bgh83RxeNT7ytCDX4DsZWOZIKhJ9DFDoPmhwec9C5nkoNvivo3OiktOa\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=gMH7D3dq" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ixgbe: remove\n ixgbe_ping_all_vfs() from watchdog link-up handler", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Sebastian Basierski <sebastianx.basierski@intel.com>\n\nWhen multiple VFs are brought up simultaneously, a VF can receive a\nCTS (Clear To Send) mailbox message instead of the expected RESET |\n(N)ACK response, because the watchdog is sending a gratuitous ping\nright as the VF mailbox transaction is in progress.\n\nRemove the ixgbe_ping_all_vfs() call from ixgbe_watchdog_link_is_up().\nLink-state changes are already communicated to VFs through the normal\nmailbox protocol; the extra ping here is redundant and races with VF\ninitialization.\n\nSigned-off-by: Sebastian Basierski <sebastianx.basierski@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1885fe8..52f0cdc 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8163,9 +8163,6 @@ static void ixgbe_watchdog_link_is_up(struct ixgbe_adapter *adapter)\n \n \t/* update the default user priority for VFs */\n \tixgbe_update_default_up(adapter);\n-\n-\t/* ping all the active vfs to let them know link has changed */\n-\tixgbe_ping_all_vfs(adapter);\n }\n \n /**\n", "prefixes": [ "iwl-next" ] }