Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216803/?format=api
{ "id": 2216803, "url": "http://patchwork.ozlabs.org/api/patches/2216803/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-7-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-7-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:30", "name": "[net] ice: fix netdev bring-up and bring-down in self-test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "286a7de8e97c30378b06628789957e956c4390ac", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-7-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497712, "url": "http://patchwork.ozlabs.org/api/series/497712/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497712", "date": "2026-03-27T07:23:30", "name": "[net] ice: fix netdev bring-up and bring-down in self-test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497712/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216803/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216803/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=urT1t829;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZc2K23z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9DC7383C6A;\n\tFri, 27 Mar 2026 07:23:48 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2WD4iHjYzYxB; Fri, 27 Mar 2026 07:23:48 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id D4A6183C3B;\n\tFri, 27 Mar 2026 07:23:47 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 259ED249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 1809C415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:46 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MKfMlWrI868b for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:45 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 2A66741574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:45 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:45 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:43 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org D4A6183C3B", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2A66741574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596227;\n\tbh=hfr/V0XeCghX3MYEj6NQq5W5AxnsTramHk9v4WbpJzY=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=urT1t829MaNNLqAKk45x+O2suWXioBNSWOGrPOhxdHRTtDTEtHxBQyZKUeCVuUwZ5\n\t El0KJtvr1AOfRew48TS4a8UKnLH3XFBuqi3Kd3kls2/hCCH7qy+Ybz5E+0KJ5K5uyW\n\t 2K2itxPu/TayvQM6xSYH93bj799vIiH7T99sjcprp8tqlMqkvsdTgJ7wz5lvbMR/3h\n\t fBaMBsmJvc2jkngvsvGJVBqiheaPPA0jQeo21fpKQ/nT604bmKZOrda6zWQ1SXuosO\n\t cnek+cW1TAa34r7RHcinTxWPAxEAld+xhw3sKCPd0TGPUMLr+jWHeKrUBzKTgmkSfj\n\t exfK0HCuVYgcQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2A66741574", "X-CSE-ConnectionGUID": [ "NY/j+PlJT/KjY5mxqEL8lA==", "gtJv4Gg8SM+0/j4xItdRpg==" ], "X-CSE-MsgGUID": [ "nBDXwrIZT3e8Q+duaFa90Q==", "cfCkn3ZyQHWEJAepH4flog==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733978\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733978\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739111\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Date": "Fri, 27 Mar 2026 08:23:30 +0100", "Message-ID": "<20260327072332.130320-7-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "References": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596225; x=1806132225;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=LBFE63JaCQqSofulUu3xv89vB3PFNkSXDiss19Iht1Q=;\n b=Oj7y0drJRI/wzHhphg9DRQUsn9Qepclcj4LjHlGh54EA/qiKBsBRu63i\n VkVIAyvL8iiq57qHeEWuE2ASzL1sWS4eUzU6talIUOQAgEslAcvJxWXAZ\n ki/DnrGN85fK5gnEdP1chgba3F7ZMSwkv8knfeO3wfe1VEK4i6VaYIr3R\n +D8u8zxukhcIAg7CJDp2vGhOe2Rt0tVfRnKQruENVNjuW5LZaXDj3IHrr\n 5k0Yc0x5PeaIh82GPsBus+z0EY6DuoZ3BZp5LuZY00326EsjU4sd13rgn\n RR8S/H39F+NwtnnNzZaC2u3utqD7cvfmWeN8Ym9aYJcYjZWP8i7b2+P1o\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Oj7y0drJ" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix netdev bring-up and\n bring-down in self-test", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Konstantin Ilichev <konstantin.ilichev@intel.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Konstantin Ilichev <konstantin.ilichev@intel.com>\n\nWhen an offline self-test is initiated with ethtool -t, any ongoing\ntraffic could get stuck because ice_stop() and ice_open() are called\nwithout letting the OS know about state transitions. In most cases\na write() system call would block.\n\nFix this by calling dev_change_flags() to bring the netdev up and\ndown, which ensures ndo_open()/ndo_stop() are called and all watchers\nare notified correctly.\n\nFixes: 0e674aeb0b77 (\"ice: Add handler for ethtool selftest\")\nCc: stable@vger.kernel.org\nCo-developed-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\nSigned-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\nSigned-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 96d95af..2a4f06f 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1416,7 +1416,7 @@ ice_self_test(struct net_device *netdev, struct ethtool_test *eth_test,\n \t\t/* If the device is online then take it offline */\n \t\tif (if_running)\n \t\t\t/* indicate we're in test mode */\n-\t\t\tice_stop(netdev);\n+\t\t\tdev_change_flags(netdev, netdev->flags & ~IFF_UP, NULL);\n \n \t\tdata[ICE_ETH_TEST_LINK] = ice_link_test(netdev);\n \t\tdata[ICE_ETH_TEST_EEPROM] = ice_eeprom_test(netdev);\n@@ -1434,10 +1434,12 @@ ice_self_test(struct net_device *netdev, struct ethtool_test *eth_test,\n \t\tclear_bit(ICE_TESTING, pf->state);\n \n \t\tif (if_running) {\n-\t\t\tint status = ice_open(netdev);\n+\t\t\tint status = dev_change_flags(netdev,\n+\t\t\t\t\t\t netdev->flags | IFF_UP,\n+\t\t\t\t\t\t NULL);\n \n \t\t\tif (status) {\n-\t\t\t\tdev_err(dev, \"Could not open device %s, err %d\\n\",\n+\t\t\t\tdev_err(dev, \"Could not bring up device %s, err %d\\n\",\n \t\t\t\t\tpf->int_name, status);\n \t\t\t}\n \t\t}\n", "prefixes": [ "net" ] }