Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216802/?format=api
{ "id": 2216802, "url": "http://patchwork.ozlabs.org/api/patches/2216802/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-6-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-6-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:29", "name": "[net] ice: fix ice_init_link() error return preventing probe", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7ef6f48e09930f4b9c86244041e2a569f6765b0f", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-6-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497711, "url": "http://patchwork.ozlabs.org/api/series/497711/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497711", "date": "2026-03-27T07:23:29", "name": "[net] ice: fix ice_init_link() error return preventing probe", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497711/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216802/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=soDjAmHC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZZ09xTz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 21A2C83C5F;\n\tFri, 27 Mar 2026 07:23:48 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jgZsznhrqrX2; Fri, 27 Mar 2026 07:23:47 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5528383C2B;\n\tFri, 27 Mar 2026 07:23:47 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 5BED72D5\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 4E64C415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:44 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VVkaAuG5H2Rm for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:43 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 5FFEF41574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:43 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:43 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:41 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5528383C2B", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5FFEF41574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596227;\n\tbh=FRF/1SIUlEaaNn+Z1/W7n/zpIu9RWX+CV8uEuPZRV+0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=soDjAmHCZKC3xAyiEJUo9qhk9tmmmng3tQbhZtTWmYUSk0FYFFn+W4UqgrRB1MKYa\n\t 7ZLmkjUcxKklow3p21rK79iLJqvogr1bCw2ARtI2QexYcy+wTqj+PKIjFxGHUl6bz6\n\t 7Ds/e/nI/qRbZ9mU+iPozwsCMPZtpdWfM7FjeFlp7P0bL7N+Aq1uH7b7ZTEfz2nu0/\n\t 5Ums9AmuO7OoPCA0O/hZqBjz7FIUTPWSG7h6CFwUe8TeQd5R+IE4LTCsiy54s0ggSU\n\t 1PbqgjEONB2uSomGhVTGBdCapdBC9QQ/TAX7/uYFwBJwHu/BG9RfVclB496BcOoQo1\n\t Rv+wNVyTuNK1g==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5FFEF41574", "X-CSE-ConnectionGUID": [ "D1j9wghqQl6RAAhr5X2lUw==", "yXJSkaxCRrmA3SbECyKMvg==" ], "X-CSE-MsgGUID": [ "EPnPc5mXSxKujgzr26U2Ww==", "/kEvgtCPTr6pxTrnnaVeIA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733976\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733976\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739106\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tPaul Greenwalt <paul.greenwalt@intel.com>", "Date": "Fri, 27 Mar 2026 08:23:29 +0100", "Message-ID": "<20260327072332.130320-6-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "References": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596223; x=1806132223;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=2UNQ4rhnM15geXDEabeCEnD3chRO9ol4IHoKs85OO5o=;\n b=U9Rdjlp+qiv+g8d3EUA78+fDo3P1L7gTIPWMcsaRbNkXiybuqbp3aeMM\n fVz8NdCoiU7dH8zKs6cul6i8weo4uQmRl+rzAHOgmGRHImziCDSN4pmrs\n pOzKMaT2cZ3BL9wLN5vR0k+Ofeh9awacrEmlc8MdKGvVuWCeEbQbiaH/O\n v5rBBC1jAJbZF8Rh8SdbD4EVKDxa9zE9j1XJ2p/3vwiKFwr5XKF9bI6cE\n UWVHSeS6WvP88rKAIhDfqH54Ko3P07lwv1OGL303+1i/lV4ulB+NlA8Vy\n H7g87LvgAt6X3svXAIu7qjlxLiwz2RoWo/RrsMFx6xd3fgfZB2mZ5NpAt\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=U9Rdjlp+" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix ice_init_link() error return\n preventing probe", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul Greenwalt <paul.greenwalt@intel.com>\n\nice_init_link() can return an error status from ice_update_link_info()\nor ice_init_phy_user_cfg(), causing probe to fail.\n\nAn incorrect NVM update procedure can result in link/PHY errors, and\nthe recommended resolution is to update the NVM using the correct\nprocedure. If the driver fails probe due to link errors, the user\ncannot update the NVM to recover. The link/PHY errors logged are\nnon-fatal: they are already annotated as 'not a fatal error if this\nfails'.\n\nSince none of the errors inside ice_init_link() should prevent probe\nfrom completing, convert it to void and remove the error check in the\ncaller. All failures are already logged; callers have no meaningful\nrecovery path for link init errors.\n\nFixes: 5b246e533d01 (\"ice: split probe into smaller functions\")\nCc: stable@vger.kernel.org\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/ice_main.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex cf116bb..a6b0c09 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4856,16 +4856,14 @@ static void ice_init_wakeup(struct ice_pf *pf)\n \tdevice_set_wakeup_enable(ice_pf_to_dev(pf), false);\n }\n \n-static int ice_init_link(struct ice_pf *pf)\n+static void ice_init_link(struct ice_pf *pf)\n {\n \tstruct device *dev = ice_pf_to_dev(pf);\n \tint err;\n \n \terr = ice_init_link_events(pf->hw.port_info);\n-\tif (err) {\n+\tif (err)\n \t\tdev_err(dev, \"ice_init_link_events failed: %d\\n\", err);\n-\t\treturn err;\n-\t}\n \n \t/* not a fatal error if this fails */\n \terr = ice_init_nvm_phy_type(pf->hw.port_info);\n@@ -4899,8 +4897,6 @@ static int ice_init_link(struct ice_pf *pf)\n \t} else {\n \t\tset_bit(ICE_FLAG_NO_MEDIA, pf->flags);\n \t}\n-\n-\treturn err;\n }\n \n static int ice_init_pf_sw(struct ice_pf *pf)\n@@ -5043,9 +5039,7 @@ static int ice_init(struct ice_pf *pf)\n \n \tice_init_wakeup(pf);\n \n-\terr = ice_init_link(pf);\n-\tif (err)\n-\t\tgoto err_init_link;\n+\tice_init_link(pf);\n \n \terr = ice_send_version(pf);\n \tif (err)\n", "prefixes": [ "net" ] }