Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216801/?format=api
{ "id": 2216801, "url": "http://patchwork.ozlabs.org/api/patches/2216801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-5-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-5-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:28", "name": "[net] ice: fix setting promisc mode while adding VID filter", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f1d835e657b667ebfd7c8af4081d5d99ad9f4d4f", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-5-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497710, "url": "http://patchwork.ozlabs.org/api/series/497710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497710", "date": "2026-03-27T07:23:28", "name": "[net] ice: fix setting promisc mode while adding VID filter", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497710/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216801/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=D2OB+p8v;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZX1tcBz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id E28A061283;\n\tFri, 27 Mar 2026 07:23:46 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id w0a88lXcZ-aG; Fri, 27 Mar 2026 07:23:44 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id AE8CE6127C;\n\tFri, 27 Mar 2026 07:23:44 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id E8B4B249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id D9F23415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fKa8ZgA3EMGM for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D7BBD41574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:41 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:41 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:40 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org AE8CE6127C", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org D7BBD41574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596224;\n\tbh=nCSYgWIB15/P3SeLWfLqOrRUFazcrXBtYBUsYjcfe5U=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=D2OB+p8vVhTmWyOqzpdmRa77RuFkb4l9kI2J0N8XzWaZQ7VZgw5fTioe4RASD01Db\n\t t+jkXlk6U38naU056m8XLkv+AI0JEtpv98RDOd4QyNe66kHYocV8nUGv3jc8vNKtbY\n\t LeMZQyky89lPCQd/BPMft6mPoJJW1G4FqmWVDsN+14sqvLGGbpUkU7DP/blJGxgXMq\n\t tBgqibzEGqwjJTl4c9kurPqhj3poB5rJNCD/7Skwjm595L4Yl31JVsPpZKi9vd/2It\n\t PcNXVuM601PG1sQXEjSF1pVSxtFlp6S2I9eBImJZZSKra/RDSB/F14gqx8goF0R0WU\n\t 9WHUl7Wokk8Kw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org D7BBD41574", "X-CSE-ConnectionGUID": [ "HffCr0g3RJCWa3JqxuqDGg==", "oW78nACyQZCHMhKDGVyJxQ==" ], "X-CSE-MsgGUID": [ "OSgc3wbFRX2IzMloPRzLcw==", "MuZ9vhdqSlaFa4OmXDk+sQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733974\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733974\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739100\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tMarcin Szycik <marcin.szycik@intel.com>", "Date": "Fri, 27 Mar 2026 08:23:28 +0100", "Message-ID": "<20260327072332.130320-5-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "References": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596222; x=1806132222;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ingbZmd2Pb3SYiTnzq1cCDdJm7Fy7ywH4K9TDIc577s=;\n b=SSx4Qi6WdwlRau3K1erec1ZB/z8NgT3vCveWVZweNJBAh9aZyyrK//Ev\n 4fLb/ULUe91gxyDg/Ws1pYHqcDlQOcu8+PoJKH8DFP1sh81OHilQidEbM\n oo/e8nX5yRvju8sKECyd/hgdk5AO12TB5WtuTWPaM9Rc8nDP17NadmdBZ\n YLtTilXZI9MWJ1DKrWdNMtLtpew4MSLQihjO0CfzwjENvJerWh6RTxVbH\n kMMx9kxbiqCXDSiGzN3MnRtXmyhUPQ/EnkfJrlNm9HqJ5jNkPTw5BYYWS\n a0r1sBywhuT1hLultz8aa8JhhhhZ2MzyCtVay3lFFWszBjwiqEPDEZwS4\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=SSx4Qi6W" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix setting promisc mode while\n adding VID filter", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Marcin Szycik <marcin.szycik@intel.com>\n\nThere are at least two paths through which VSI promiscuous mode can be\nindependently configured via ice_fltr_set_vsi_promisc():\n- ice_vlan_rx_add_vid() (netdev op)\n- ice_service_task() -> ... -> ice_set_promisc()\n\nBoth paths may try to program promiscuous mode concurrently. One such\nscenario is:\n\n1. Add ice netdev to bond\n2. Add the bond netdev to bridge\n3. ice netdev enters allmulticast mode (IFF_ALLMULTI)\n4. Service task programs promisc mode filter\n5. Bridge -> bond calls ice_vlan_rx_add_vid()\n\nCrucially, ice_vlan_rx_add_vid() fails if ice_fltr_set_vsi_promisc()\nreturns any error, including -EEXIST. This causes VLAN filtering setup\nto fail on the bond interface. ice_set_promisc() already handles -EEXIST\ncorrectly.\n\nFix by adding the same -EEXIST check to ice_vlan_rx_add_vid(): if the\npromisc filter is already programmed, continue without returning error.\n\nFixes: 1273f89578f2 (\"ice: Fix broken IFF_ALLMULTI handling\")\nCc: stable@vger.kernel.org\nSigned-off-by: Marcin Szycik <marcin.szycik@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/ice_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 8896805..cf116bb 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3755,7 +3755,7 @@ int ice_vlan_rx_add_vid(struct net_device *netdev, __be16 proto, u16 vid)\n \t\tret = ice_fltr_set_vsi_promisc(&vsi->back->hw, vsi->idx,\n \t\t\t\t\t ICE_MCAST_VLAN_PROMISC_BITS,\n \t\t\t\t\t vid);\n-\t\tif (ret)\n+\t\tif (ret && ret != -EEXIST)\n \t\t\tgoto finish;\n \t}\n \n", "prefixes": [ "net" ] }