Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216800/?format=api
{ "id": 2216800, "url": "http://patchwork.ozlabs.org/api/patches/2216800/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-4-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-4-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:27", "name": "[net] ice: fix PTP hang for E825C devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70ad47529f5e0a7b2d63430d1bbfeb1188316936", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-4-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497709, "url": "http://patchwork.ozlabs.org/api/series/497709/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497709", "date": "2026-03-27T07:23:27", "name": "[net] ice: fix PTP hang for E825C devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497709/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216800/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=WJY8VHJ4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZT30L6z1yFr\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BAA1183C4E;\n\tFri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pB0t9abubiuD; Fri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 202AF83C33;\n\tFri, 27 Mar 2026 07:23:42 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 623F9249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 48E91415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:41 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id sMlHo1VTLYW5 for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:40 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 5711041574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:40 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:40 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:38 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 202AF83C33", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5711041574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596222;\n\tbh=FNTrwKIwOPULqYpHRBxsFBtQAsvc7EZ8TtA99b4cvWM=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=WJY8VHJ42THnZrzrt4OcR3fGvC1OHT2aukRMQi6zRpABQzH/sJK0kI1retNrzEem6\n\t eq2XNJdfKg0+TposRpWzrQKDcwFfsZ0Rigx0nsTtNFTSlOgGo31uVwIrjz8DwMVSGW\n\t nygugoHX4v/KbPwYQfuwUltswE0tGNiRv5vp/NVFJ8rf1GNeyi4us98/ZOw8WJjGtx\n\t KUtfpIBU/ZpbclR2fn54rSHyvcIORFYVB8VeYTVATQq84UvDw8KoLgmp9diGV+wUwo\n\t 44pv7EKByTcg/a5WEPyeLFdkn8Eyz1jg7XmICc8oRoDH0SlnTI3R5J/GiTUzgciNnO\n\t VEdYNEDdbk1yQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5711041574", "X-CSE-ConnectionGUID": [ "RIJNkNztTfuRQEEk/jvjNA==", "M4FA3blTQYOh29AetnDgSQ==" ], "X-CSE-MsgGUID": [ "otim56XCR9y/OVZmE2fu/Q==", "VgGcfBsoTQO8SD+/k05pRg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733972\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733972\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739093\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Date": "Fri, 27 Mar 2026 08:23:27 +0100", "Message-ID": "<20260327072332.130320-4-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "References": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596220; x=1806132220;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=9uSQCaHx5lz2p4ZhV7LAX2lFsh0FH2XjuNQNioItOcE=;\n b=aniIOOVvG7bv3+Wzfq/gO0GZudGUqSJkK3qb6Ots9UIILIZoWtwxKZIs\n 1rwwj/vVN6N8wAO0Nke7/2sjZDdRb54FXapwhDS1A4yQR3bPGOyRh8yDX\n i2AUtCl/QoKA2f2pqmsd9EFe7yOt3x+tGTAuSbnZJQkOg5LRWoVmsuh/O\n bUzJGASmnOJlehNGhOjgAJC7hoUPmh4m8GL4Not9rejh10/ujs6AVoYfF\n 3TJUNn/jVxd0NOCZ0CVNcXVr+NoBazu39OwtB4dKEh2J/mXUVDDE0XKcW\n +SqHxIuu33BPiWzkwBuJhkuCEmsvnxHJUY5+GOB0J4v4jv0kwM+MFlX53\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=aniIOOVv" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix PTP hang for E825C devices", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Grzegorz Nitka <grzegorz.nitka@intel.com>\n\nChange the order of PTP reconfiguration when port goes down or up\n(ice_down and ice_up calls) to be more graceful and consistent from\ntimestamp interrupts processing perspective.\n\nFor both calls (ice_up and ice_down), accompanying ice_ptp_link_change\nis called which starts/stops PTP timer. This patch changes the order:\n- while link goes down: disable net device Tx first (netif_carrier_off,\n netif_tx_disable), then call ice_ptp_link_change\n- while link goes up: ice_ptp_link_change called first, then re-enable\n net device Tx (netif_tx_start_all_queues)\n\nOtherwise, there is a narrow window in which PTP timestamp request has\nbeen triggered and timestamp processing occurs when PTP timer is not\nenabled yet (up case) or already disabled (down case). This may lead to\nundefined behavior and receiving invalid timestamps. This case was\nobserved on E825C devices only.\n\nFixes: 6b1ff5d39228 (\"ice: always call ice_ptp_link_change and make it void\")\nCc: stable@vger.kernel.org\nSigned-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex e7308e3..8896805 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -6797,10 +6797,10 @@ static int ice_up_complete(struct ice_vsi *vsi)\n \t (vsi->port_info->phy.link_info.link_info & ICE_AQ_LINK_UP) &&\n \t ((vsi->netdev && (vsi->type == ICE_VSI_PF ||\n \t\t\t vsi->type == ICE_VSI_SF)))) {\n+\t\tice_ptp_link_change(pf, true);\n \t\tice_print_link_msg(vsi, true);\n \t\tnetif_tx_start_all_queues(vsi->netdev);\n \t\tnetif_carrier_on(vsi->netdev);\n-\t\tice_ptp_link_change(pf, true);\n \t}\n \n \t/* Perform an initial read of the statistics registers now to\n@@ -7328,9 +7328,9 @@ int ice_down(struct ice_vsi *vsi)\n \n \tif (vsi->netdev) {\n \t\tvlan_err = ice_vsi_del_vlan_zero(vsi);\n-\t\tice_ptp_link_change(vsi->back, false);\n \t\tnetif_carrier_off(vsi->netdev);\n \t\tnetif_tx_disable(vsi->netdev);\n+\t\tice_ptp_link_change(vsi->back, false);\n \t}\n \n \tice_vsi_dis_irq(vsi);\n", "prefixes": [ "net" ] }